gerritbot added a comment.
Change 679529 **abandoned** by Silvan Heintze:
[mediawiki/extensions/Wikibase@master] Don't catch TermStoreException
Reason:
old and resolved otherwise
https://gerrit.wikimedia.org/r/679529
TASK DETAIL
https://phabricator.wikimedia.org/T279409
gerritbot added a comment.
Change 721529 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_36] Re-throw DBErrors in DataUpdateAdapter
https://gerrit.wikimedia.org/r/721529
TASK DETAIL
https://phabricator.wikimedia.org/T279409
EMAIL PREFERENCES
gerritbot added a comment.
Change 721529 had a related patch set uploaded (by Addshore; author:
Ladsgroup):
[mediawiki/extensions/Wikibase@REL1_36] Re-throw DBErrors in DataUpdateAdapter
https://gerrit.wikimedia.org/r/721529
TASK DETAIL
https://phabricator.wikimedia.org/T279409
Addshore closed this task as "Resolved".
Addshore added a comment.
Going to close.
Not seen the log in prod since the 29th.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).
TASK DETAIL
https://phabricator.wikimedia.org/T279409
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, ReleaseTaggerBot
Cc: Ladsgroup, Jakob_WMDE, Addshore,
gerritbot added a comment.
Change 679533 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Re-throw DBErrors in DataUpdateAdapter
https://gerrit.wikimedia.org/r/679533
TASK DETAIL
https://phabricator.wikimedia.org/T279409
EMAIL PREFERENCES
Ladsgroup claimed this task.
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer
Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Restricted Application added a project: User-Ladsgroup.
TASK DETAIL
https://phabricator.wikimedia.org/T279409
gerritbot added a comment.
Change 679533 had a related patch set uploaded (by Ladsgroup; author:
Ladsgroup):
[mediawiki/extensions/Wikibase@master] Re-throw DBErrors in DataUpdateAdapter
https://gerrit.wikimedia.org/r/679533
TASK DETAIL
https://phabricator.wikimedia.org/T279409
Ladsgroup added a comment.
oh my bad, we do catch db errors in `DataUpdateAdapter`, I thought it's a
core class. Making a patch now.
TASK DETAIL
https://phabricator.wikimedia.org/T279409
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup
Ladsgroup added a comment.
Oh this is another case of catching DBErrors.
See
https://www.mediawiki.org/wiki/Database_transactions#Use_of_transaction_rollback
(emphasis not mine)
> Callers might catch DBError exceptions without either re-throwing them or
throwing their own version of
gerritbot added a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T279409
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot
Cc: Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot,
maantietaja,
gerritbot added a comment.
Change 679529 had a related patch set uploaded (by Ladsgroup; author:
Ladsgroup):
[mediawiki/extensions/Wikibase@master] Don't catch TermStoreException
https://gerrit.wikimedia.org/r/679529
TASK DETAIL
https://phabricator.wikimedia.org/T279409
EMAIL
Jakob_WMDE removed Jakob_WMDE as the assignee of this task.
Jakob_WMDE moved this task from Doing to To Do (prioritised from top to bottom)
on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
TASK DETAIL
https://phabricator.wikimedia.org/T279409
WORKBOARD
Jakob_WMDE claimed this task.
Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing
on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
TASK DETAIL
https://phabricator.wikimedia.org/T279409
WORKBOARD
https://phabricator.wikimedia.org/project/board/3539/
darthmon_wmde moved this task from Prioritized Tech (prioritised from top to
bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
darthmon_wmde edited projects, added Wikidata-Campsite
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
TASK DETAIL
noarave renamed this task from "Logspam about an "ignored error" in
Wikibase\Repo\Content\DataUpdateAdapter::doUpdate" to "[8h] Logspam about an
"ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate".
TASK DETAIL
https://phabricator.wikimedia.org/T279409
EMAIL PREFERENCES
16 matches
Mail list logo