[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Mattia_Capozzi_WMDE
Mattia_Capozzi_WMDE added a comment. Hello there, Sorry for spamming twice with an irrelevant comment. Everything seems to be fine also from my side on this ticket. Great job! TASK DETAIL https://phabricator.wikimedia.org/T290151 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved". Lydia_Pintscher added a comment. \o/ TASK DETAIL https://phabricator.wikimedia.org/T290151 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, Lydia_Pintscher Cc: Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Mattia_Capozzi_WMDE
Mattia_Capozzi_WMDE added a comment. Hello there! Here is my test verification comment for this ticket: When the loading state is triggered, the Text Area turns into a different, lighter grey than the one we decided upon. Here is a screenshot of the live version, whose color is

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Mattia_Capozzi_WMDE
Mattia_Capozzi_WMDE added a comment. Hello there! Here is my test verification comment for this ticket: When the loading state is triggered, the Text Area turns into a different, lighter grey than the one we decided upon. Here is a screenshot of the live version, whose color is

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Sarai-WMDE
Sarai-WMDE added a comment. Great job!  Non-blocking, small PR to adjust the speed (aka width) of the loader here: #479 TASK DETAIL https://phabricator.wikimedia.org/T290151 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-02 Thread ItamarWMDE
ItamarWMDE added a comment. Up for review in PR #464 TASK DETAIL https://phabricator.wikimedia.org/T290151 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE
ItamarWMDE added a comment. For the mixin, use keyframes and easings from: https://codepen.io/saraisanchez/pen/abJeNrm TASK DETAIL https://phabricator.wikimedia.org/T290151 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc:

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE
ItamarWMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T290151 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE
ItamarWMDE added a project: Wikidata Design System. TASK DETAIL https://phabricator.wikimedia.org/T290151 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE
ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T290151 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE,

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE
ItamarWMDE created this task. ItamarWMDE added projects: Wikidata, Mismatch Finder (Mismatch Finder - sprint 6). TASK DESCRIPTION In order to enable WiKit component implementers to specify a loading state through a prop, two visual states should be implemented in WiKit: loading, and read