[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Mattia_Capozzi_WMDE 
Mattia_Capozzi_WMDE added a comment.


  Hello there, 
  Sorry for spamming twice with an irrelevant comment. 
  Everything seems to be fine also from my side on this ticket. 
  Great job!

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Mattia_Capozzi_WMDE
Cc: Lydia_Pintscher, Mattia_Capozzi_WMDE, Sarai-WMDE, Aklapper, karapayneWMDE, 
ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Lydia_Pintscher 
Lydia_Pintscher closed this task as "Resolved".
Lydia_Pintscher added a comment.


  \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Lydia_Pintscher
Cc: Lydia_Pintscher, Mattia_Capozzi_WMDE, Sarai-WMDE, Aklapper, karapayneWMDE, 
ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Mattia_Capozzi_WMDE 
Mattia_Capozzi_WMDE added a comment.


  Hello there!
  Here is my test verification comment for this ticket: 
  When the loading state is triggered, the Text Area turns into a different, 
lighter grey than the one we decided upon. 
  Here is a screenshot of the live version, whose color is #F8F9FA (Base 90):
  F34638058: Screenshot 2021-09-09 at 12.11.35.png 

  
  
  
  According to the design 

 and the Wikit file 
, 
instead, the color of the TextArea is a darker grey: #EAECF0 (Base 80). See 
screenshot below from the design:
  F34638066: Screenshot 2021-09-09 at 12.20.20.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Mattia_Capozzi_WMDE
Cc: Mattia_Capozzi_WMDE, Sarai-WMDE, Aklapper, karapayneWMDE, ItamarWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Mattia_Capozzi_WMDE 
Mattia_Capozzi_WMDE added a comment.


  Hello there!
  Here is my test verification comment for this ticket: 
  When the loading state is triggered, the Text Area turns into a different, 
lighter grey than the one we decided upon. 
  Here is a screenshot of the live version, whose color is #F8F9FA (Base 90):
  F34638058: Screenshot 2021-09-09 at 12.11.35.png 

  
  
  
  According to the design 

 and the Wikit file 
, 
instead, the color of the TextArea is a darker grey: #EAECF0 (Base 80). See 
screenshot below from the design:
  F34638066: Screenshot 2021-09-09 at 12.20.20.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Mattia_Capozzi_WMDE
Cc: Mattia_Capozzi_WMDE, Sarai-WMDE, Aklapper, karapayneWMDE, ItamarWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-09 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  Great job! 
  
  Non-blocking, small PR to adjust the speed (aka width) of the loader here: 
#479 

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Sarai-WMDE
Cc: Sarai-WMDE, Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-02 Thread ItamarWMDE 
ItamarWMDE added a comment.


  Up for review in PR #464 

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE 
ItamarWMDE added a comment.


  For the mixin, use keyframes and easings from:
  
  https://codepen.io/saraisanchez/pen/abJeNrm

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE 
ItamarWMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE 
ItamarWMDE added a project: Wikidata Design System.

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE 
ItamarWMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290151: WiKit: Add loading and readOnly states to TextArea

2021-09-01 Thread ItamarWMDE 
ItamarWMDE created this task.
ItamarWMDE added projects: Wikidata, Mismatch Finder (Mismatch Finder - sprint 
6).

TASK DESCRIPTION
  In order to enable WiKit component implementers to specify a loading state 
through a prop, two visual states should be implemented in WiKit: loading, and 
read only.
  
  The specifications for these states can be found on figma 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T290151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, karapayneWMDE, ItamarWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org