[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Jeff_G added a comment. See also the edits logged at https://commons.wikimedia.org/w/index.php?title=Special:AbuseLog=2605%3ABA00%3A4138%3A445%3A1974%3ACACD%3AE09D%3AA640==50 . TASK DETAIL https://phabricator.wikimedia.org/T298672 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

matej_suchanek added a comment. For the record, I had already created https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/776286, which is still waiting for review. I don't think it will solve this problem. Looking at T25 , or

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Jeff_G added a comment. See also the edits logged at https://commons.wikimedia.org/w/index.php?title=Special:AbuseLog=91.120.252.226 . TASK DETAIL https://phabricator.wikimedia.org/T298672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jeff_G

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

matej_suchanek merged a task: T334808: Edit filter variable contains wrong data for structured data edits on Commons. matej_suchanek added subscribers: Achim55, Jeff_G. TASK DETAIL https://phabricator.wikimedia.org/T298672 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Daimona added a comment. Based on my local testing, my guess was right. This was caused by r747596 -- notice how `$slotRole` is not passed to onEditFilterMergedContent. OTOH, it's really not that patch's fault, since the parameter

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Daimona added a subtask: T25: Wikibase runs the EditFilterMergedContent hook with an extra parameter. TASK DETAIL https://phabricator.wikimedia.org/T298672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Bugreporter, Base,

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Daimona added a comment. The first thing that comes to mind is that whoever is firing the EditFilterMergedContent hook is passing SLOT_MAIN instead of the actual slot being edited. I'll try to reproduce this locally and see if that's indeed the reason. TASK DETAIL

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Jdx added a comment. @Bugreporter Just look at the log entries – these three rules/filters have been triggered because something is screwed up "below", perhaps AbuseFilter extension itself. It's not a problem with the rules, they have been working for years. TASK DETAIL

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Bugreporter added a comment. Issues about specific AbuseFilter should be raised at local wiki unless it is related to the extension itself, such as a missing or broken feature. TASK DETAIL https://phabricator.wikimedia.org/T298672 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T298672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, maantietaja, Y.ssk, FRomeo_WMF,

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

Jdx created this task. Jdx added projects: SDC General, AbuseFilter, Commons. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION **List of steps to reproduce** (step by step, including full links if applicable): - On Commons please log out - Try to undo a structured