[Wikidata-bugs] [Maniphest] T300176: Make Termbox SSR and CSR match exactly

[Michael]

Michael removed a project: MediaWiki-extensions-WikibaseClient.
Michael added a comment.


  I think #mediawiki-extensions-wikibaseclient 
 
was added by mistake. If it was added intentionally, then feel free to readd it.

TASK DETAIL
  https://phabricator.wikimedia.org/T300176

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: WMDE-leszek, ItamarWMDE, Aklapper, Michael, Catrope, Tarrow, Jakob_WMDE, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, lucamauri
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300176: Make Termbox SSR and CSR match exactly

[ItamarWMDE]

ItamarWMDE edited projects, added Wikibase Product Platform Team WPP; removed 
wmde-wikidata-tech, wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T300176

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: WMDE-leszek, ItamarWMDE, Aklapper, Michael, Catrope, Tarrow, Jakob_WMDE, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300176: Make Termbox SSR and CSR match exactly

[ItamarWMDE]

ItamarWMDE added a comment.


  **Task Review Notes**:
  
  - In T318137  as part of the 
Gerrit patch, hydration was completely disabled, and the DOM is created from 
scratch in the client-side, which renders the problem presented in this task 
irrepreducible.
  - The question remains whether we want to re-enable hydration, and as a 
result we will need to solve this issue too.
  
  **Prioritization Notes**:
  
  - Does not affect end - users / production
  - Does affect development efforts (ideally we do not suppress warning and 
errors, but solve them)
  - Unclear whether affect onboarding efforts (checks and tests are a pivotal 
part of trying to understand a system, ideally they should pass, but the task 
might be outdated)
  - Does not affect additional stakeholders.

TASK DETAIL
  https://phabricator.wikimedia.org/T300176

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, Aklapper, Michael, Catrope, Tarrow, Jakob_WMDE, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300176: Make Termbox SSR and CSR match exactly

[Manuel]

Manuel edited projects, added wmde-wikidata-tech; removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T300176

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Aklapper, Michael, Catrope, Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300176: Make Termbox SSR and CSR match exactly

[Manuel]

Manuel edited projects, added Wikidata-Campsite; removed Wikidata-Campsite 
(Team A Hearth ).

TASK DETAIL
  https://phabricator.wikimedia.org/T300176

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Aklapper, Michael, Catrope, Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300176: Make Termbox SSR and CSR match exactly

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Instead of manipulating the SSR HTML in PHP, we might be able to add the 
necessary information to the wrapper element (which we need anyways, for 
mounting – see T296202#7652549 
 and the next comment 
there), and then use some CSS like `.wikibase-entitytermsview-noneditable 
.wikibase-sectionedit { display: none; }` to hide the sectionedit component 
when the wrapper element indicates the page is non-editable.

TASK DETAIL
  https://phabricator.wikimedia.org/T300176

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Michael, Catrope, Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300176: Make Termbox SSR and CSR match exactly

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: MediaWiki-extensions-WikibaseClient, 
Wikidata-Termbox, Wikidata, wdwb-tech, Wikidata-Campsite (Team A Hearth ).

TASK DESCRIPTION
  When hydrating the server-side rendered markup, Vue produces warnings and 
errors about some mismatches between the virtual DOM it’s now constructed and 
the actual DOM that was once generated by SSR. Currently, we hide these 
warnings and errors, but it would be nice to not emit them in the first place.
  
  The main error seems to be related to the use of the 
`…` tags in the `Sectionedit` component, which 
some Wikibase PHP code (`ToolbarEditSectionGenerator::enableSectionEditLinks( 
$text, $isEditable )`) either replaces with their content (editable) or removes 
including their content (not editable).

TASK DETAIL
  https://phabricator.wikimedia.org/T300176

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Michael, Catrope, Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org