[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Michael]

Michael closed subtask T312224: Remove 
LanguageFallbackLabelDescriptionLookupFactory as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Michael
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lydia_Pintscher]

Lydia_Pintscher closed this task as "Resolved".
Lydia_Pintscher moved this task from Doing to Done on the Special:NewLexeme 
revival (Special:NewLexeme revival - sprint 11) board.
Lydia_Pintscher added a comment.


  \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Manuel]

Manuel edited projects, added Wikidata-Campsite; removed Wikidata-Campsite 
(Team A Hearth ).

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T312223: Use 
FallbackLabelDescriptionLookupFactory in code as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Hellket777, 786, 
Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[gerritbot]

gerritbot added a comment.


  Change 812839 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Use 
FallbackLabelDescriptionLookupFactory in item entity types
  
  https://gerrit.wikimedia.org/r/812839

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Hellket777, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Manuel]

Manuel triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Hellket777, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[karapayneWMDE]

karapayneWMDE added a project: Wikidata Dev Team (Sprint-♾).

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, karapayneWMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Hellket777, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T31: Create 
FallbackLabelDescriptionLookupFactory as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Hellket777, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Hellket777, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[gerritbot]

gerritbot added a comment.


  Change 812839 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Use 
FallbackLabelDescriptionLookupFactory in entity types
  
  https://gerrit.wikimedia.org/r/812839

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Alright, plan for now (discussed with Itamar):
  
  - Introduce a new factory, `FallbackLabelDescriptionLookupFactory`, that only 
promises to return any `FallbackLabelDescriptionLookup` (the interface); it 
actually returns a `CachingFallbackLabelDescriptionLookup` wrapping a 
`LanguageFallbackLabelDescriptionLookup`.
  - Migrate other code to use this new factory. This should probably include 
all callers of the current `LanguageFallbackLabelDescriptionLookupFactory` 
(which, both in name and in phpdoc, promises to return specifically a 
`LanguageFallbackLabelDescriptionLookup`), but also others.
  - Remove the old, more specific factory, 
`LanguageFallbackLabelDescriptionLookupFactory`, once it has become unused.
  
  This leaves the two lookup implementations as they are: arguably flawed 
(there’s no good reason why one resolves redirects and the other doesn’t), but 
I think it’s better not to move that code around at the moment. (Though we can 
at least add this information to their phpdoc.) We just change how the lookups 
are created, so that hopefully nobody ends up with an unwrapped 
`LanguageFallbackLabelDescriptionLookupFactory` that doesn’t resolve redirects.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  Makes sense to me.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T305032#8052624 , 
@Lydia_Pintscher wrote:
  
  > 樂  I don't have a good reason to go either direction. Thoughts?
  
  In that case, I think we should try to make the code resolve redirects in 
more situations, and assume that, when this affects other places besides the 
Lexeme header, that’s acceptable. I suspect there are lots of small, obscure 
places that don’t resolve redirects at the moment, where it just hasn’t been 
noticed so far. For example, in the tooltip of a Lexeme statement value, 
showing its language and lexical category, redirects aren’t currently resolved 
either, even with my patch above that shows them in the Lexeme page header:
  F35309551: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  In T305032#8052288 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > @Lydia_Pintscher are there any places where we generally want to show item 
labels, but not for redirects? (E.g. Special:AllPages, perhaps?) Or do we 
always want to resolve redirects?
  
  Hmmm I would have said no but indeed Special:AllPages currently does not show 
the label from the redirect target. Example: 
https://www.wikidata.org/wiki/Q1117?redirect=no is shown by ID in 
Special:AllPages even though the target has a label in my interface language.
  樂  I don't have a good reason to go either direction. Thoughts?

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  This patch (in Wikibase, not WikibaseLexeme!) makes the labels show up – it’s 
certainly not an ideal implementation yet, and it remains to be investigated 
which other places are affected by it (and whether we want those other places 
to resolve redirects as well), but it’s a good starting point, I think:
  
diff --git a/repo/WikibaseRepo.entitytypes.php 
b/repo/WikibaseRepo.entitytypes.php
index 63ab398b8e..7f5d11ca23 100644
--- a/repo/WikibaseRepo.entitytypes.php
+++ b/repo/WikibaseRepo.entitytypes.php
@@ -18,6 +18,7 @@
  */
 
 use MediaWiki\MediaWikiServices;
+use ValueFormatters\FormatterOptions;
 use Wikibase\DataAccess\DatabaseEntitySource;
 use Wikibase\DataModel\Entity\EntityDocument;
 use Wikibase\DataModel\Entity\Item;
@@ -27,6 +28,7 @@
 use Wikibase\Lib\DataTypeDefinitions;
 use Wikibase\Lib\EntityTypeDefinitions as Def;
 use Wikibase\Lib\EntityTypeDefinitions;
+use Wikibase\Lib\Formatters\FormatterLabelDescriptionLookupFactory;
 use Wikibase\Lib\Formatters\LabelsProviderEntityIdHtmlLinkFormatter;
 use Wikibase\Lib\Interactors\MatchingTermsLookupSearchInteractor;
 use Wikibase\Lib\SimpleCacheWithBagOStuff;
@@ -245,8 +247,17 @@
);
},
Def::ENTITY_ID_HTML_LINK_FORMATTER_CALLBACK => function( 
Language $language ) {
-   $languageLabelLookupFactory = 
WikibaseRepo::getLanguageFallbackLabelDescriptionLookupFactory();
-   $languageLabelLookup = 
$languageLabelLookupFactory->newLabelDescriptionLookup( $language );
+   $formatterLabelDescriptionLookupFactory = new 
FormatterLabelDescriptionLookupFactory(
+   WikibaseRepo::getTermLookup(),
+   WikibaseRepo::getTermFallbackCache(),
+   new RedirectResolvingLatestRevisionLookup( 
WikibaseRepo::getEntityRevisionLookup() )
+   );
+   $languageFallbackChainFactory = 
WikibaseRepo::getLanguageFallbackChainFactory();
+   $languageFallbackChain = 
$languageFallbackChainFactory->newFromLanguage( $language );
+   $options = new FormatterOptions( [
+   
FormatterLabelDescriptionLookupFactory::OPT_LANGUAGE_FALLBACK_CHAIN => 
$languageFallbackChain,
+   ] );
+   $languageLabelLookup = 
$formatterLabelDescriptionLookupFactory->getLabelDescriptionLookup( $options );
return new LabelsProviderEntityIdHtmlLinkFormatter(
$languageLabelLookup,
WikibaseRepo::getLanguageNameLookup(),

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Slight correction to the above: `FormatterLabelDescriptionLookupFactory` only 
returns a `CachingFallbackLabelDescriptionLookup` wrapping a 
`LanguageFallbackLabelDescriptionLookup` when it’s been given a language 
fallback chain in its formatter options. If it’s only been given a single 
language, then it returns a `LanguageLabelDescriptionLookup`, which doesn’t do 
language fallbacks (sensible) and also doesn’t resolve redirects (probably not 
intentional).
  
  What a mess.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  @Lydia_Pintscher are there any places where we generally want to show item 
labels, but not for redirects? (E.g. Special:AllPages, perhaps?)

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE edited projects, added Special:NewLexeme revival 
(Special:NewLexeme revival - sprint 11); removed Special:NewLexeme revival.
Lucas_Werkmeister_WMDE added a comment.


  I looked into this a bit, and I think it’s an unfortunate effect of some 
confusing class functionality in Wikibase. There are two relevant 
`FallbackLabelDescriptionLookup` implementations: 
`LanguageFallbackLabelDescriptionLookup`, which looks up labels and 
descriptions using an inner `TermLookup` while applying language fallbacks, and 
`CachingFallbackLabelDescriptionLookup`, which wraps another 
`FallbackLabelDescriptionLookup` and adds caching to it.
  
  One thing `CachingFallbackLabelDescriptionLookup` does that isn’t exactly 
obvious from its name is that it also resolves redirects. The code to do this 
(based on `EntityRevisionLookup`) used to be directly in the class, until it 
was extracted into a separate RedirectResolvingLatestRevisionLookup class 
 for 
T196882 .
  
  Both of these `FallbackLabelDescriptionLookup` implementations are 
instantiated in various places. Some places wrap a 
`CachingFallbackLabelDescriptionLookup` around a 
`LanguageFallbackLabelDescriptionLookup`, others return a 
`LanguageFallbackLabelDescriptionLookup` directly. Because only 
`CachingFallbackLabelDescriptionLookup` resolves redirects, this means that 
only the former places will show the labels of redirect targets – more or less 
arbitrarily, I think.
  
  Places that create a wrapping `CachingFallbackLabelDescriptionLookup` (good):
  
  - `FormatterLabelDescriptionLookupFactory`, used to format entity ID values 
(I think)
  - `WikibaseValueFormatterBuilders` likewise(?)
  
  Places that directly return a `LanguageFallbackLabelDescriptionLookup` (bad):
  
  - `LanguageFallbackLabelDescriptionLookupFactory` (I suppose that’s to be 
expected), which in turn is used in //many// places
  - `WikibaseLexeme.datatypes.php` `PT:wikibase-lexeme` 
`formatter-factory-callback` (has a TODO to use 
`LanguageFallbackLabelDescriptionLookupFactory` which wouldn’t really help at 
the moment, per above), used to format the language and lexical category in the 
tooltip (`title`) of Lexeme values (I think)
- (the `PT:wikibase-form` `formatter-factory-callback` uses 
`LanguageFallbackLabelDescriptionLookupFactory`, though)
  - `WikibaseRepo.entitytypes.php` `item` 
`ENTITY_ID_HTML_LINK_FORMATTER_CALLBACK` – I **think** this is the one that’s 
actually used by `LexemeView` to render the language and lexical category
  - `WikibaseLexeme.entitytypes.repo.php` `lexeme` (and `form`) 
`ENTITY_ID_HTML_LINK_FORMATTER_CALLBACK`
  - `WikibaseClient.ServiceWiring` `SidebarLinkBadgeDisplay`, probably unrelated
  
  I don’t know if there’s actually any good reason why these shouldn’t use 
`CachingFallbackLabelDescriptionLookup` as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[karapayneWMDE]

karapayneWMDE set the point value for this task to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Manuel]

Manuel added a project: Special:NewLexeme revival.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[ItamarWMDE]

ItamarWMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE renamed this task from "Lexeme pages do not show lables 
of redirected Items (unlike Item pages)" to "Lexeme pages do not show labels of 
redirected Items (unlike Item pages)".

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org