Re: [Wikidata-tech] Adding reference re-adds claim

2016-04-07 Thread Magnus Manske
On Thu, Apr 7, 2016 at 12:27 AM Lydia Pintscher < lydia.pintsc...@wikimedia.de> wrote: > On Tue, Apr 5, 2016 at 10:29 PM Denny Vrandečić > wrote: > >> The primary sources tool can add references to existing claims. For some >> reason, it started re-adding the claim yesterday instead. >> >> Did an

Re: [Wikidata-tech] Adding reference re-adds claim

2016-04-06 Thread Magnus Manske
Removed from the instructions. They were removed before adding statements anyway. On Wed, Apr 6, 2016 at 5:49 PM Thiemo Mättig wrote: > Hi, > > the "definition" at Magnus' > http://tools.wmflabs.org/wikidata-todo/quick_statements.php is outdated. > Magnus, can you please remove the leading zeros

Re: [Wikidata-tech] Adding reference re-adds claim

2016-04-06 Thread Thiemo Mättig
Hi, the "definition" at Magnus' http://tools.wmflabs.org/wikidata-todo/quick_statements.php is outdated. Magnus, can you please remove the leading zeros from the year? Padding years to 11 digits is not done any more. For a while there was no padding at all in the backend, while some documentation

Re: [Wikidata-tech] Adding reference re-adds claim

2016-04-06 Thread Thomas Steiner
Is this answer from TPT related? https://github.com/google/primarysources/issues/90#issuecomment-206256966. Sorry, I am at a multi-day event this week and am a bit behind on emails. If it is, I am happy to quickly merge a pull request if anyone creates it :-) -- Dr. Thomas Steiner, Employee (http

Re: [Wikidata-tech] Adding reference re-adds claim

2016-04-06 Thread Sebastian Schaffert
Hi Lydia, I think the problem is that instead of a semantic comparison, Wikibase does a pure string comparison to check if two timestamps are equal. I changed the primary sources tool on the weekend because there was a bug in the serialization according to the TSV format specification (it failed a

Re: [Wikidata-tech] Adding reference re-adds claim

2016-04-06 Thread Lydia Pintscher
On Wed, Apr 6, 2016 at 1:32 PM Sebastian Schaffert wrote: > Hi Lydia, > > I think the problem is that instead of a semantic comparison, Wikibase > does a pure string comparison to check if two timestamps are equal. I > changed the primary sources tool on the weekend because there was a bug in > t

Re: [Wikidata-tech] Adding reference re-adds claim

2016-04-06 Thread Lydia Pintscher
On Tue, Apr 5, 2016 at 10:29 PM Denny Vrandečić wrote: > The primary sources tool can add references to existing claims. For some > reason, it started re-adding the claim yesterday instead. > > Did anything change on the Wikidata-side in the last few days that could > be causing this change in be

[Wikidata-tech] Adding reference re-adds claim

2016-04-05 Thread Denny Vrandečić
The primary sources tool can add references to existing claims. For some reason, it started re-adding the claim yesterday instead. Did anything change on the Wikidata-side in the last few days that could be causing this change in behavior? Or should we look harder on the Primary sources side? Bug