[Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-08 Thread Niklas Laxström
I'm resurrecting this thread, because I really want to start using this new class. There are still open questions, like do we want to have a shortcut and how to name it. One reason for it is that name Message for a class might conflict and thus we might want to rename it to something else. My

Re: [Wikitech-l] Proposed hooks for Vector

2010-07-08 Thread Roan Kattouw
2010/7/7 Ævar Arnfjörð Bjarmason ava...@gmail.com: But I thought I'd ask if someone (particularly Trevor) has suggestions on how to do it better. I can't see a quick and sane way to do it for the general case, since Vector uses a diffrent $footerlinks structure than MonoBook. That's fine for

Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-08 Thread Max Semenik
On 08.07.2010, 13:02 Niklas wrote: i18n( 'welcometo' $wgSitename)-text(); or if we don't have a wrapper, use this whatever the class name might be: Message::key( 'welcometo', $wgSitename )-text(); I don't like the function name 'key', it's unclear. Message::get() would be better imho. Other

Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-08 Thread Chad
On Thu, Jul 8, 2010 at 6:14 AM, Max Semenik maxsem.w...@gmail.com wrote: Chaining could be surprizingly clear, albeit verbose. Much better anyway than the insanity we currently use: * wfMsg - mostly clear what it does Usually ;-) * wfMsgNoTrans - ehm... All of the *NoTrans mean don't parse

Re: [Wikitech-l] Proposed hooks for Vector

2010-07-08 Thread Ævar Arnfjörð Bjarmason
On Thu, Jul 8, 2010 at 09:13, Roan Kattouw roan.katt...@gmail.com wrote: Although I agree that having hooks for these things would be nice, wouldn't it suffice for your purposes to just hide these things with CSS? I could probably get away with it. But I'd rather munge the output than count on

Re: [Wikitech-l] Proposed hooks for Vector

2010-07-08 Thread Ilmari Karonen
On 07/08/2010 12:13 PM, Roan Kattouw wrote: 2010/7/7 Ævar Arnfjörð Bjarmasonava...@gmail.com: But I thought I'd ask if someone (particularly Trevor) has suggestions on how to do it better. I can't see a quick and sane way to do it for the general case, since Vector uses a diffrent $footerlinks

[Wikitech-l] Possible fix for bug 24124: Diffs are taking 10 to 20 seconds to load

2010-07-08 Thread Rob Lanphier
Hi folks, I wanted to highlight bug 24124, because there's a possible fix for it, and I'm hoping we can get a lot of eyes on this one and then hopefully fast-track it into production if that's possible. Here's the link: https://bugzilla.wikimedia.org/show_bug.cgi?id=24124 The problem: diffs are

Re: [Wikitech-l] Possible fix for bug 24124: Diffs are taking 10 to 20 seconds to load

2010-07-08 Thread Tim Starling
On 09/07/10 03:21, Rob Lanphier wrote: Hi folks, I wanted to highlight bug 24124, because there's a possible fix for it, and I'm hoping we can get a lot of eyes on this one and then hopefully fast-track it into production if that's possible. If you want it to be deployed, you should tag the