[MediaWiki-CodeReview] [MediaWiki r88113]: New comment added

2011-05-15 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r88113. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88113#c16896 Commit summary: Rewrote the article counting code and related: * (bug 26033, bug 24754) Added $wgArticleCountMethod to have a more flexible way to define which

[MediaWiki-CodeReview] [MediaWiki r88134]: New comment added

2011-05-15 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r88134. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88134#c16898 Commit summary: Fixed a bug in transformation where previous language could leak into later transformations in UI language. Not sure what do with userlang. Comment:

[MediaWiki-CodeReview] [MediaWiki r88109]: New comment added

2011-05-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r88109. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88109#c16899 Commit summary: discussion with hashar * moved getInfoBox into Xml.php as infoBox static method * moved config-infobox* css classes from config to mw-infobox* in shared

[MediaWiki-CodeReview] [MediaWiki r88125]: New comment added

2011-05-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r88125. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88125#c16900 Commit summary: Removed the go() call, and the suspended until go() is called behavior. Comment: pre +

[MediaWiki-CodeReview] [MediaWiki r88053]: New comment added

2011-05-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r88053. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88053#c16901 Commit summary: Added direct file loading functionality to debug mode for both scripts and styles, with callbacks for module state changes (changing to ready) and

[MediaWiki-CodeReview] [MediaWiki r88012]: New comment added

2011-05-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r88012. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88012#c16902 Commit summary: Adding qunit tests for isIPv4Address and isIPv6Address in mw.util Comment: I'm not sure we can or should. They don't test the same code. PHPUnit

[MediaWiki-CodeReview] [MediaWiki r88129]: New comment added

2011-05-15 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r88129. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88129#c16903 Commit summary: (bug 28940) When making a thumb of an SVG, and only specifying the height make the width be the max SVG size, not the natrual

[MediaWiki-CodeReview] [MediaWiki r88124]: New comment added

2011-05-15 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r88124. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88124#c16904 Commit summary: Add Rotem Liss and Platonides to author list. Comment: I fully agree with Platonides being added to the author list, but I do

[MediaWiki-CodeReview] [MediaWiki r88109]: New comment added

2011-05-15 Thread MediaWiki Mail
User Freakolowsky posted a comment on MediaWiki.r88109. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88109#c16905 Commit summary: discussion with hashar * moved getInfoBox into Xml.php as infoBox static method * moved config-infobox* css classes from config to mw-infobox* in

[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added

2011-05-15 Thread MediaWiki Mail
User Freakolowsky posted a comment on MediaWiki.r88111. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16906 Commit summary: * added an option to toggle the display of diff size with a warning message. * in misermode this option is disabled Comment: Nike some database

[MediaWiki-CodeReview] [MediaWiki r88109]: New comment added

2011-05-15 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r88109. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88109#c16907 Commit summary: discussion with hashar * moved getInfoBox into Xml.php as infoBox static method * moved config-infobox* css classes from config to mw-infobox* in

[MediaWiki-CodeReview] [MediaWiki r87940]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r87940. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87940#c0 Commit summary: ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87900]: New comment added

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal posted a comment on MediaWiki.r87900. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87900#c16908 Commit summary: Add unit test for jquery.colorUtil module Comment: Is this still needed since you switched to using visibility as a CSS check?

[MediaWiki-CodeReview] [MediaWiki r87856]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r87856. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87856#c0 Commit summary: Creating a way to toggle mw.config LEGACY_GLOBALS from LocalSettings (bug 28916). * I thought a while for a

[MediaWiki-CodeReview] [MediaWiki r87857]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r87857. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87857#c0 Commit summary: RELEASE-NOTES for r87856 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87856]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r87856. Old Status: resolved New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87856#c0 Commit summary: Creating a way to toggle mw.config LEGACY_GLOBALS from LocalSettings (bug 28916). * I thought a while for a

[MediaWiki-CodeReview] [MediaWiki r88130]: New comment added

2011-05-15 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r88130. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88130#c16909 Commit summary: Kill diff.js with fire. It only applies to versions of Gecko that were released before Nov 2002, which is wy beyond what we

[MediaWiki-CodeReview] [MediaWiki r78156]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r78156. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78156#c0 Commit summary: Ported jsMsg to mw.util; Fixing bugs and modernising mediawiki.action.watch.ajax.js a little more * Using the raw

[MediaWiki-CodeReview] [MediaWiki r78157]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r78157. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78157#c0 Commit summary: Added a way to hide the jsMessage by calling with empty string, null or no arguments

[MediaWiki-CodeReview] [MediaWiki r78282]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r78282. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78282#c0 Commit summary: (mw.util.test) Escape the 'does return, the same way as the 'should return' (mw.html.escape() and spaces to

[MediaWiki-CodeReview] [MediaWiki r86218]: New comment added

2011-05-15 Thread MediaWiki Mail
User Raylton P. Sousa posted a comment on MediaWiki.r86218. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86218#c16910 Commit summary: Add ParserTest Comment: Solve in r87682. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r78345]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r78345. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78345#c0 Commit summary: added compareObject function to mediaWiki core jQuery prototyping utilities

[MediaWiki-CodeReview] [MediaWiki r82498]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r82498. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/82498#c0 Commit summary: bug 27146 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r78150]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r78150. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/78150#c0 Commit summary: Fixing bugs and modernising mediawiki.action.watch.ajax.js a little bit * add() takes the

[MediaWiki-CodeReview] [MediaWiki r87900]: New comment added

2011-05-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r87900. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87900#c16911 Commit summary: Add unit test for jquery.colorUtil module Comment: This plugin wasn't written in this commit. colorUtil is used to convert colors and easily

[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added

2011-05-15 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r88111. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16912 Commit summary: * added an option to toggle the display of diff size with a warning message. * in misermode this option is disabled Comment: If nothing else the

[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added

2011-05-15 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r88111. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16913 Commit summary: * added an option to toggle the display of diff size with a warning message. * in misermode this option is disabled Comment: Besides, this is

[MediaWiki-CodeReview] [MediaWiki r87899]: New comment added

2011-05-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r87899. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87899#c16914 Commit summary: Follow-up r87898: Using real path Comment: There's no way of knowing where the TestSwarm is (or of there's a test swarm at

[MediaWiki-CodeReview] [MediaWiki r87899]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r87899. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87899#c0 Commit summary: Follow-up r87898: Using real path ___

[MediaWiki-CodeReview] [MediaWiki r88142]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r88142. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88142#c0 Commit summary: Convert SemanticData to SqlStubSemanticData when keeping it in the internal cache after an

[MediaWiki-CodeReview] [MediaWiki r88144]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r88144. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88144#c0 Commit summary: Goodbye mediawiki.util.test. In no particular order: * Uses ugly eval() * Initially meant to cross-browser test

[MediaWiki-CodeReview] [MediaWiki r88144]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r88144. Old Status: ok New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88144#c0 Commit summary: Goodbye mediawiki.util.test. In no particular order: * Uses ugly eval() * Initially meant to cross-browser test

[MediaWiki-CodeReview] [MediaWiki r88144]: New comment added

2011-05-15 Thread MediaWiki Mail
User Trevor Parscal posted a comment on MediaWiki.r88144. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88144#c16915 Commit summary: Goodbye mediawiki.util.test. In no particular order: * Uses ugly eval() * Initially meant to cross-browser test mediawiki.util.test, (re|ab|)used

[MediaWiki-CodeReview] [MediaWiki r88146]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88146. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r88146. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88146#c16916 Commit summary: Suppress article feedback tool on redirects. (Bug reported

[MediaWiki-CodeReview] [MediaWiki r88147]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88147. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88147#c0 Commit summary: Revert r88144, deleted the wrong file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88144]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88144. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88144#c0 Commit summary: Goodbye mediawiki.util.test. In no particular order: * Uses ugly eval() * Initially meant to cross-browser test

[MediaWiki-CodeReview] [MediaWiki r88124]: New comment added

2011-05-15 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r88124. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88124#c16917 Commit summary: Add Rotem Liss and Platonides to author list. Comment: This is what he said his name was, so that's the name I added.

[MediaWiki-CodeReview] [MediaWiki r88146]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88146. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88146#c0 Commit summary: Suppress article feedback tool on redirects. (Bug reported on English Wikipedia Village Pump).

[MediaWiki-CodeReview] [MediaWiki r88151]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88151. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88151#c0 Commit summary: Move to startup per r88146 code review comment ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added

2011-05-15 Thread MediaWiki Mail
User Freakolowsky posted a comment on MediaWiki.r88111. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16918 Commit summary: * added an option to toggle the display of diff size with a warning message. * in misermode this option is disabled Comment: ok, true for the

[MediaWiki-CodeReview] [MediaWiki r88141]: New comment added

2011-05-15 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r88141. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88141#c16919 Commit summary: bug fixes 18635,27581,27419; new README.OpenID-mediawiki-extension to be distinct from README of php-openid library Comment: This looks hacky: +

[MediaWiki-CodeReview] [MediaWiki r88141]: New comment added

2011-05-15 Thread MediaWiki Mail
User Wikinaut posted a comment on MediaWiki.r88141. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88141#c16920 Commit summary: bug fixes 18635,27581,27419; new README.OpenID-mediawiki-extension to be distinct from README of php-openid library Comment: Oh yes, it is hackish to

[MediaWiki-CodeReview] [MediaWiki r88150]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88150. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r88150. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88150#c16921 Commit summary: Remove debugging code introduced in

[MediaWiki-CodeReview] [MediaWiki r86519]: New comment added

2011-05-15 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r86519. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86519#c16922 Commit summary: FIx inconsistent messages in r86482. Comment: You removed the tabs from passwordreset-emailelement; was that intentional?

[MediaWiki-CodeReview] [MediaWiki r87200]: New comment added

2011-05-15 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r87200. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87200#c16923 Commit summary: Making output of Special:SiteMatrix?action=raw much more similar to api.php?action=sitematrix * (bug 14955) Illogical XML in

Re: [Wikitech-l] Hackathon parser session initial notes

2011-05-15 Thread Brion Vibber
On Sat, May 14, 2011 at 7:09 PM, Brion Vibber br...@wikimedia.org wrote: In the meantime, if you're brave you can peek at the raw session notes: http://etherpad.wikimedia.org/mwhack11Sat-Parser We're reviving the wikitext-l mailing list for people interested in the project; it's gotten some

[MediaWiki-CodeReview] [MediaWiki r87200]: New comment added

2011-05-15 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r87200. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87200#c16924 Commit summary: Making output of Special:SiteMatrix?action=raw much more similar to api.php?action=sitematrix * (bug 14955) Illogical XML in sitematrix API output

[MediaWiki-CodeReview] [MediaWiki r87200]: New comment added

2011-05-15 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r87200. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87200#c16925 Commit summary: Making output of Special:SiteMatrix?action=raw much more similar to api.php?action=sitematrix * (bug 14955) Illogical XML in sitematrix API output

[MediaWiki-CodeReview] [MediaWiki r87200]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r87200. Old Status: new New Status: old Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87200#c0 Commit summary: Making output of Special:SiteMatrix?action=raw much more similar to api.php?action=sitematrix * (bug 14955) Illogical XML

[MediaWiki-CodeReview] [MediaWiki r88153]: New comment added

2011-05-15 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r88153. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88153#c16926 Commit summary: initialize Profiler instance singleton with ProfilerStub if 'bogus' is detected, rather than failing. CBA to debug. Reviewed by Tim eating his lunch.

[MediaWiki-CodeReview] [MediaWiki r88163]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r88163. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88163#c0 Commit summary: updated to be compatible with SMW 1.6 data model

[MediaWiki-CodeReview] [MediaWiki r88162]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r88162. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88162#c0 Commit summary: use methods of SMWDIWikiPage where possible

[MediaWiki-CodeReview] [MediaWiki r88159]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r88159. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88159#c0 Commit summary: move support for Title generation to the WikiPage data item

[MediaWiki-CodeReview] [MediaWiki r88141]: New comment added

2011-05-15 Thread MediaWiki Mail
User Wikinaut posted a comment on MediaWiki.r88141. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88141#c16927 Commit summary: bug fixes 18635,27581,27419; new README.OpenID-mediawiki-extension to be distinct from README of php-openid library Comment: fixed in r88172

[MediaWiki-CodeReview] [MediaWiki r87635]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r87635. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c0 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been

[MediaWiki-CodeReview] [MediaWiki r87637]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r87637. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87637#c0 Commit summary: Centralise the minimum-required-php-version in a MW_MIN_PHP_VERSION constant in Defines.php. This requires loading

[MediaWiki-CodeReview] [MediaWiki r87639]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r87639. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87639#c0 Commit summary: Move minimum database versions to Defines.php ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r87643]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r87643. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87643#c0 Commit summary: Follow-up r87637: the terrors of copy-and-paste. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88176]: New comment added

2011-05-15 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r88176. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88176#c16928 Commit summary: Revert r87635, r87637, r87639, r87643 (MW_MIN_PHP_VERSION etc.): breaks HipHop support. Comment: I don't believe r87635 or r87639 should have

[MediaWiki-CodeReview] [MediaWiki r88179]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88179. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r88179. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88179#c16929 Commit summary: Changing !isset to is_null (thanks

[MediaWiki-CodeReview] [MediaWiki r88178]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88178. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r88178. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88178#c16930 Commit summary: Setting $wgLocalTZoffset based on

[MediaWiki-CodeReview] [MediaWiki r88177]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88177. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88177#c0 Commit summary: Fix for HipHop breakage in r87748 etc. Please do not use require_once(dirname(__FILE__)...) to

[MediaWiki-CodeReview] [MediaWiki r87652]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r87652. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87652#c0 Commit summary: (follow-up r87651) whoops, forgot release notes. ___

[MediaWiki-CodeReview] [MediaWiki r87651]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r87651. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87651#c0 Commit summary: (bug 28868) Include the number of pages in the default getLongDesc for multipaged documents This

[MediaWiki-CodeReview] [MediaWiki r88167]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r88167. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88167#c0 Commit summary: Move $wgContLang out of the switch ___

[MediaWiki-CodeReview] [MediaWiki r86212]: New comment added

2011-05-15 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r86212. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86212#c16931 Commit summary: (Follow-up r86169) Needed supress warnings around iconv Also make it try to detect if a jpeg file comment has textual data, or is

[MediaWiki-CodeReview] [MediaWiki r86221]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r86221. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86221#c0 Commit summary: (follow-up r86169) per Reedy, the $val = $val thing is weird. Most of these were actually here

[MediaWiki-CodeReview] [MediaWiki r75906]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r75906. Old Status: fixme New Status: resolved User Bryan also posted a comment on MediaWiki.r75906. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/75906#c16932 Commit summary: core changes for UploadWizard

[MediaWiki-CodeReview] [MediaWiki r88087]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r88087. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88087#c0 Commit summary: Fix line removedfor no explicit reason from r85771 ___

[MediaWiki-CodeReview] [MediaWiki r88184]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r88184. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88184#c0 Commit summary: w/s and typo fix ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] search=steven+tyler gets Steven_tyler

2011-05-15 Thread Aryeh Gregor
On Fri, May 13, 2011 at 7:57 PM, Daniel Friesen li...@nadir-seen-fire.com wrote: Doesn't look that bad... - Some arcane maintenance scripts. - Some .js that can't interact with Title working with urls. - The expected User, Title, Parser, file related, etc... core api stuff that's easy to

[MediaWiki-CodeReview] [MediaWiki r88185]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r88185. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88185#c0 Commit summary: Fix Bug #28995: “public interface for getting state of a module” from Bergi Sometimes

[MediaWiki-CodeReview] [MediaWiki r88016]: New comment added

2011-05-15 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r88016. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88016#c16933 Commit summary: Rewrite importUseModWiki to subclass maintenance, general cleanup, etc. Also fixing bug 22287, change default field separator Comment: Deferred? This

[MediaWiki-CodeReview] [MediaWiki r88143]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r88143. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88143#c0 Commit summary: (bug 27073) Lazy init the style marker and insert if not available (ie. when using resourceloader

[MediaWiki-CodeReview] [MediaWiki r88143]: New comment added

2011-05-15 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r88143. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88143#c16934 Commit summary: (bug 27073) Lazy init the style marker and insert if not available (ie. when using resourceloader js on a non-mediawiki

[MediaWiki-CodeReview] [MediaWiki r87951]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r87951. Old Status: fixme New Status: resolved User Jeroen De Dauw also posted a comment on MediaWiki.r87951. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87951#c16935 Commit summary: moved stubbing

[MediaWiki-CodeReview] [MediaWiki r88187]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88187. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88187#c0 Commit summary: Add check for evil, EVIL @ ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-15 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r88187. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88187#c16936 Commit summary: Add check for evil, EVIL @ Comment: Well it would be useful to have an hint at the function / token using the @ operator.

[MediaWiki-CodeReview] [MediaWiki r88182]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88182. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88182#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r88181]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88181. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88181#c0 Commit summary: Fix directory name, mw-config, not config ___

[MediaWiki-CodeReview] [MediaWiki r88137]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88137. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88137#c0 Commit summary: * fixed typo ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88109]: New comment added

2011-05-15 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r88109. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88109#c16937 Commit summary: discussion with hashar * moved getInfoBox into Xml.php as infoBox static method * moved config-infobox* css classes from config

[Wikitech-l] RTL triage at Berlin Hackathon

2011-05-15 Thread Mark A. Hershberger
Yesterday, since Amir E. Aharoni, an RTL developer who has been actively helping out by testing and filing RTL bugs, was at the Berlin Hackathon along with Siebrand from TranslateWiki, it was the perfect time to hold an RTL triage. During the triage a developer made the point that screenshots

[Wikitech-l] Shell requests backlog

2011-05-15 Thread Luiz Augusto
Hi all, Firstly, thank you very much for enabling DPL on all Wikisources! [1] It is IMO a pity that this request was fulfilled based only in a direct request, but at least it is now enabled. I'm no longer involved on Wikimedia projects like in the past years, but I'm still looking their

[MediaWiki-CodeReview] [MediaWiki r88193]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88193. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88193#c0 Commit summary: (bug 26742) Add @noflip to RTL-specific rules in jquery.ui.datepicker.css ___

[MediaWiki-CodeReview] [MediaWiki r88200]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88200. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88200#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-15 19:50:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r87842]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r87842. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87842#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-10 20:14:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r88018]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88018. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88018#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-13 21:00:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-15 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c16938 Commit summary: Add check for evil, EVIL @ Comment: Line number would be hard, since the tokenizer doesn't keep track of those. I disagree that it's useless, it makes

Re: [Wikitech-l] Shell requests backlog

2011-05-15 Thread Strainu
I totally aggree that site requests take waaay to long to be closed. I therefore support Luiz Augusto's request. Strainu 2011/5/15 Luiz Augusto lugu...@gmail.com: Hi all, Firstly, thank you very much for enabling DPL on all Wikisources! [1] It is IMO a pity that this request was fulfilled

[Wikitech-l] Autocreated accounts are now logged again

2011-05-15 Thread Chad
Hi everyone, Just dropping a note to let people know that I've merged and deployed r85128-- reverting hiding logs of all autocreated accounts. As pointed out on bug 19161 (specifically, comment #46), this solution was overkill and failed to actually address the underlying concern. Fixes for the

[MediaWiki-CodeReview] [MediaWiki r88053]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88053. Old Status: ok New Status: fixme User Krinkle also posted a comment on MediaWiki.r88053. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88053#c16939 Commit summary: Added direct file loading functionality to debug mode for

[MediaWiki-CodeReview] [MediaWiki r86519]: New comment added

2011-05-15 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r86519. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86519#c16940 Commit summary: FIx inconsistent messages in r86482. Comment: Yes. ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] search=steven+tyler gets Steven_tyler

2011-05-15 Thread Marco Schuster
On Sun, May 15, 2011 at 5:02 PM, Aryeh Gregor simetrical+wikil...@gmail.com wrote: You cannot fix the problem by doing accent/diacritic normalization. i and I are the same letter in English but different letters in Turkish.  You cannot get around that.  We'd need to have a separate

[Wikitech-l] Stepping down as maintainer for OpenID extension

2011-05-15 Thread Sergey Chernyshev
Guys, I'd like to step down as maintainer for OpenID extension. Please remove me as maintainer from Bugzilla. Sorry - don't have time and energy to apply patches and fix bugs, hope somebody else can pick it up. Thank you, Sergey -- Sergey Chernyshev http://www.sergeychernyshev.com/

[MediaWiki-CodeReview] [MediaWiki r88210]: Revision status changed

2011-05-15 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r88210. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88210#c0 Commit summary: updated my userinfo (+jQuery) ___ MediaWiki-CodeReview mailing list

[Wikitech-l] Bugzilla Weekly Report

2011-05-15 Thread reporter
MediaWiki Bugzilla Report for May 09, 2011 - May 16, 2011 Status changes this week Bugs NEW : 199 Bugs ASSIGNED : 20 Bugs REOPENED : 37 Bugs RESOLVED :

[MediaWiki-CodeReview] [MediaWiki r87404]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User VasilievVV changed the status of MediaWiki.r87404. Old Status: new New Status: fixme User VasilievVV also posted a comment on MediaWiki.r87404. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87404#c16942 Commit summary: Commit live hack for bug 28678 Comment: That is

[MediaWiki-CodeReview] [MediaWiki r87405]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail
User VasilievVV changed the status of MediaWiki.r87405. Old Status: new New Status: resolved User VasilievVV also posted a comment on MediaWiki.r87405. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87405#c16943 Commit summary: Same as r87404, in trunk. Fixes bug 28678:

[MediaWiki-CodeReview] [MediaWiki r87404]: New comment added

2011-05-15 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r87404. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87404#c16944 Commit summary: Commit live hack for bug 28678 Comment: why is /0 a link to add a new entry... seems illogical? ___

  1   2   >