[MediaWiki-CodeReview] [MediaWiki r89144]: New comment added

2011-05-30 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89144. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89144#c17315 Commit summary: Misc. exception handling cleanup--moved it out of global function namespace Also removed htmlHeader() and htmlFooter() since it has zero callers

[MediaWiki-CodeReview] [MediaWiki r89141]: New comment added

2011-05-30 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89141. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89141#c17316 Commit summary: followup r89140: enabled utf8 Comment: var_export ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89147]: New comment added

2011-05-30 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89147. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89147#c17317 Commit summary: hook parameters pass by reference Comment: Unless he wants to substitute the user object with a new one? + 'author' = 'Tim Laqua,

[MediaWiki-CodeReview] [MediaWiki r89147]: New comment added

2011-05-30 Thread MediaWiki Mail
User Wikinaut posted a comment on MediaWiki.r89147. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89147#c17318 Commit summary: hook parameters pass by reference Comment: ad i) yes, this was what I want to make possible. ad ii) correction will follow soon - thank you for

[MediaWiki-CodeReview] [MediaWiki r88502]: New comment added

2011-05-30 Thread MediaWiki Mail
User Fomafix posted a comment on MediaWiki.r88502. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88502#c17319 Commit summary: Trial commit to fix bug #29043: “The 'Contents box' in the Printable version rendering is stupid” Other people should try my patch and see if they

[MediaWiki-CodeReview] [MediaWiki r89141]: New comment added

2011-05-30 Thread MediaWiki Mail
User F.trott posted a comment on MediaWiki.r89141. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89141#c17320 Commit summary: followup r89140: enabled utf8 Comment: Fixed in r89142 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89149]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r89149. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89149#c0 Commit summary: whitespace ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89154]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r89154. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89154#c0 Commit summary: * delete of tmp file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89156]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89156. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89156#c0 Commit summary: * removed old code that was commented out ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89160]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89160. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89160#c0 Commit summary: Fix syntax error. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89161]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r89161. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89161#c0 Commit summary: Followup r89153, remove ? from i18n file ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89151]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r89151. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89151#c0 Commit summary: array( author1, author2 ) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89142]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r89142. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89142#c0 Commit summary: followup r89140: removed disabled code and debug printouts ___

[MediaWiki-CodeReview] [MediaWiki r89062]: New comment added

2011-05-30 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89062. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89062#c17321 Commit summary: And even more documentation Comment: I think I've probably fixed most/some/all of the missing @ during my other traversals through files

[MediaWiki-CodeReview] [MediaWiki r89145]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89145. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89145#c0 Commit summary: @ingroup things ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86304]: New comment added, and revision status changed

2011-05-30 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r86304. Old Status: fixme New Status: new User Reedy also posted a comment on MediaWiki.r86304. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86304#c17322 Commit summary: * (bug 28532) wfMsgExt() and wfMsgWikiHtml() use $wgOut-parse()

Re: [Wikitech-l] Tag extension problem

2011-05-30 Thread Jeroen De Dauw
Hey, Saving into a token and restoring at the end? Thanks, that pointed me in the right direction. The docs are not very clear though. I ended up with this: return array( $parser-insertStripItem( $html, $parser-mStripState ), 'noparse' = true, 'isHTML' = true ); The tag extension docs mention

[MediaWiki-CodeReview] [MediaWiki r89168]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r89168. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89168#c0 Commit summary: Stopped polluting the global namespace with utility functions. ___

[MediaWiki-CodeReview] [MediaWiki r88502]: New comment added

2011-05-30 Thread MediaWiki Mail
User MarkAHershberger posted a comment on MediaWiki.r88502. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88502#c17323 Commit summary: Trial commit to fix bug #29043: “The 'Contents box' in the Printable version rendering is stupid” Other people should try my patch and see if

[MediaWiki-CodeReview] [MediaWiki r89128]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r89128. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89128#c0 Commit summary: Broke long line ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89137]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89137. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89137#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-29 21:21:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r88827]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88827. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88827#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-25 19:52:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r88674]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88674. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88674#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-23 19:45:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r88428]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88428. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88428#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-19 20:44:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r88264]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88264. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88264#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-16 20:22:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r89165]: New comment added

2011-05-30 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r89165. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89165#c17324 Commit summary: Added entry for alias file Comment: btw, I seem to be getting codeNotice: Did not find alias for special page 'ShortUrl'. Perhaps no aliases are

[MediaWiki-CodeReview] [MediaWiki r89181]: New comment added

2011-05-30 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r89181. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89181#c17325 Commit summary: rvv:P r89179: it doesn't work on Windows Which should have been clear from comment a few lines above Comment: Guess I need to patch PHPUnit ...

[MediaWiki-CodeReview] [MediaWiki r89181]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89181. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89181#c0 Commit summary: rvv:P r89179: it doesn't work on Windows Which should have been clear from comment a few lines above

[MediaWiki-CodeReview] [MediaWiki r89179]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89179. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89179#c0 Commit summary: enable colors in PHPUnit Since PHPUnit support color output, we might as well use it :)

[MediaWiki-CodeReview] [MediaWiki r89179]: New comment added

2011-05-30 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r89179. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89179#c17326 Commit summary: enable colors in PHPUnit Since PHPUnit support color output, we might as well use it :) Comment: who read comments anyway ... -- reverted!

[MediaWiki-CodeReview] [MediaWiki r88151]: New comment added

2011-05-30 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r88151. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88151#c17327 Commit summary: Move to startup per r88146 code review comment Comment: Will this fix be deployed together with the

[MediaWiki-CodeReview] [MediaWiki r89088]: New comment added, and revision status changed

2011-05-30 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89088. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r89088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89088#c17328 Commit summary: Rv r84022 for now: crashes PHP on large url strings

[MediaWiki-CodeReview] [MediaWiki r89088]: New comment added

2011-05-30 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r89088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89088#c17329 Commit summary: Rv r84022 for now: crashes PHP on large url strings (bug29197), which is a nasty DOS vector. Leaving the parser tests in because this should

Re: [Wikitech-l] Nuking deleted pages and their revisions

2011-05-30 Thread Aran Dunkley
Hello, I have a lot of deleted pages in my wiki and was wondering how to free up the database by getting rid of them completely. I don't want to loose the history of the pages that aren't deleted though, is there an extension for this? Thanks, Aran

Re: [Wikitech-l] Nuking deleted pages and their revisions

2011-05-30 Thread Platonides
Aran Dunkley wrote: Hello, I have a lot of deleted pages in my wiki and was wondering how to free up the database by getting rid of them completely. I don't want to loose the history of the pages that aren't deleted though, is there an extension for this? Thanks, Aran There's a script

[MediaWiki-CodeReview] [MediaWiki r89188]: New comment added, and revision status changed

2011-05-30 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r89188. Old Status: new New Status: fixme User Jack Phoenix also posted a comment on MediaWiki.r89188. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89188#c17330 Commit summary: refactoring, bugfixes (only uses 50 entries; not

[MediaWiki-CodeReview] [MediaWiki r88771]: New comment added

2011-05-30 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r88771. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88771#c17331 Commit summary: Added $wgArticleFeedbackBlacklistCategories, a way to disable ArticleFeedback on pages in a certain category (such as All disambiguation pages on

[MediaWiki-CodeReview] [MediaWiki r89013]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r89013. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89013#c0 Commit summary: follow up r88997 with a rough attempt at a parser test, though, really, we can't test signature expansion

[MediaWiki-CodeReview] [MediaWiki r89192]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89192. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89192#c0 Commit summary: don't load AFT on printable version ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89188]: New comment added

2011-05-30 Thread MediaWiki Mail
User Reach Out to the Truth posted a comment on MediaWiki.r89188. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89188#c17332 Commit summary: refactoring, bugfixes (only uses 50 entries; not sorted) Comment: You shouldn't expect the mw prefix to be present in the interwiki

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added

2011-05-30 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c17333 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form.

[MediaWiki-CodeReview] [MediaWiki r88883]: New comment added

2011-05-30 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r3. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/3#c17334 Commit summary: (bug 28840) URLs with dots break because of IE6 security check * Replace the overly paranoid regex with a function that simulates IE6's behavior *

[MediaWiki-CodeReview] [MediaWiki r88883]: Revision status changed

2011-05-30 Thread MediaWiki Mail
User Tim Starling changed the status of MediaWiki.r3. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/3#c0 Commit summary: (bug 28840) URLs with dots break because of IE6 security check * Replace the overly paranoid regex with a function

Re: [Wikitech-l] Status of more regular code deployments

2011-05-30 Thread Rob Lanphier
On Sun, May 29, 2011 at 9:15 AM, MZMcBride z...@mzmcbride.com wrote: MZMcBride wrote: Is there a status update about more regular code deployments to Wikimedia wikis? I know it's been discussed endlessly, but I was under the impression that it was a real goal going forward. Is that still the

[MediaWiki-CodeReview] [MediaWiki r89204]: New comment added

2011-05-30 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r89204. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89204#c17335 Commit summary: * Fix hphpi mode in run-server, it wasn't quite working properly Comment: Commit message was truncated. Also: * In the HipHop rewrite rule, allow