[MediaWiki-CodeReview] [MediaWiki r91728]: New comment added

2011-07-15 Thread MediaWiki Mail
User Schnark posted a comment on MediaWiki.r91728. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91728#c19623 Commit summary: Rewrite mwsuggest.js using j.ui.autocomplete. This gets rid of a lot of the little kinks of the previously implemenation: The suggestion list now

[MediaWiki-CodeReview] [MediaWiki r80786]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r80786. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80786#c0 Commit summary: Updating mw.util.test.js + fixing minor bugs that were discovered through it Updating mw.util.test.js * Adding tests for

[MediaWiki-CodeReview] [MediaWiki r81585]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r81585. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81585#c0 Commit summary: Three small fixes to mediawiki.specials.preferences.js * Moving class-adder from mousedown() to click(). Mousedown also

[MediaWiki-CodeReview] [MediaWiki r82310]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r82310. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82310#c0 Commit summary: Adding function to check if the current page is the main space or (optionally) related to the main page (eg. talk page).

[MediaWiki-CodeReview] [MediaWiki r92153]: New comment added

2011-07-15 Thread MediaWiki Mail
User Fomafix posted a comment on MediaWiki.r92153. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92153#c19624 Commit summary: r92054 : Remove leftover space Comment: Now a line break for word wrapping between the categories is not possible any more. The line can only wrapped

[MediaWiki-CodeReview] [MediaWiki r92153]: New comment added

2011-07-15 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r92153. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92153#c19625 Commit summary: r92054 : Remove leftover space Comment: Which browser? Works for me in Chrome, Firefox and Opera ___

[MediaWiki-CodeReview] [MediaWiki r82577]: New comment added

2011-07-15 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r82577. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82577#c19626 Commit summary: improve namespace related methods MWNamespace::getTalk() could give erroneus results when using it on specials namespaces (NS_MEDIA, NS_SPECIAL). It now

[MediaWiki-CodeReview] [MediaWiki r91925]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r91925. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91925#c0 Commit summary: CodeReview: Add a dropdown to revision list to specify status filter. Bug 29810

[MediaWiki-CodeReview] [MediaWiki r91549]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r91549. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c0 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout

[MediaWiki-CodeReview] [MediaWiki r92211]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r92211. Old Status: deferred New Status: ok User Hashar also posted a comment on MediaWiki.r92211. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92211#c19627 Commit summary: Fixed variable redeclaration Comment: Looks like I have

[MediaWiki-CodeReview] [MediaWiki r92217]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r92217. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92217#c0 Commit summary: Added documentation to classes about extends ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r83965]: New comment added

2011-07-15 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r83965. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83965#c19628 Commit summary: Fix overestimation of max-width when using perrow mode. Also use const variables to make this more readable. Fixes bug 27577 Follow up to r77411

[MediaWiki-CodeReview] [MediaWiki r92236]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r92236. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92236#c0 Commit summary: Revert r91549 per CR ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92153]: New comment added

2011-07-15 Thread MediaWiki Mail
User Fomafix posted a comment on MediaWiki.r92153. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92153#c19629 Commit summary: r92054 : Remove leftover space Comment: The following actual category list wraps only between Lorem and ipsum, but not between ipsum and Lorem on

[MediaWiki-CodeReview] [MediaWiki r92231]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r92231. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r92231. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92231#c19630 Commit summary: * Use local context instead of global variables *

[MediaWiki-CodeReview] [MediaWiki r92232]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r92232. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92232#c0 Commit summary: Use OutputPage::addWikiMsg() instead of OutputPage::addWikiMsgArray()

[MediaWiki-CodeReview] [MediaWiki r92234]: New comment added

2011-07-15 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r92234. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92234#c19631 Commit summary: NS_MAIN can locally have subpages enabled This workaround test if any local change has been made, if so the test will be skipped. fu r82577

[MediaWiki-CodeReview] [MediaWiki r92235]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92235. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92235#c0 Commit summary: r91925 : Compare with mStatus per CR ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91925]: New comment added

2011-07-15 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91925#c19632 Commit summary: CodeReview: Add a dropdown to revision list to specify status filter. Bug 29810 Comment: I also don't like relying on implicit __toString() conversion

[Wikitech-l] REL1_18 is broken!

2011-07-15 Thread Ashar Voultoiz
Hello, Back in June, I have added REL1_18 to the continuous integration test suite. To make it works, I had to disable the 'Database' test group which was severely broken at the time. Demon fixed the Database group slowness with r88755. I have backported it in REL1_18 together with other

[MediaWiki-CodeReview] [MediaWiki r92234]: New comment added

2011-07-15 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r92234. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92234#c19633 Commit summary: NS_MAIN can locally have subpages enabled This workaround test if any local change has been made, if so the test will be skipped. fu r82577 Comment:

[MediaWiki-CodeReview] [MediaWiki r92024]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92024. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92024#c0 Commit summary: Extend wfParseUrl() to handle protocol-relative URLs. parse_url() doesn't handle these either so it needs more workaround

[MediaWiki-CodeReview] [MediaWiki r91663]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91663. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91663#c0 Commit summary: (bug 29497) To support protocol-relative URLs in external links, add '//' to $wgUrlProtocols and remove a useless \b

[MediaWiki-CodeReview] [MediaWiki r92028]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92028. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92028#c0 Commit summary: Now that wfParseUrl() can handle protocol-relative URLs, make wfExpandUrl() work in cases where it's fed a

[MediaWiki-CodeReview] [MediaWiki r92036]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92036. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92036#c0 Commit summary: Use wfUrlProtocols() in ApiFormatBase instead of simply imploding $wgUrlProtocols and expecting that to work

[MediaWiki-CodeReview] [MediaWiki r92172]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92172. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92172#c0 Commit summary: 1.17wmf1: MFT protocol-relative URL fixes: r91663, r92024, r92028, r92036, r92044. Also kill $wgProto in wfExpandUrl() as

[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added

2011-07-15 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19634 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside

Re: [Wikitech-l] REL1_18 is broken!

2011-07-15 Thread Chad
On Fri, Jul 15, 2011 at 8:42 AM, Ashar Voultoiz hashar+...@free.fr wrote:  From a quick look, broken tests are related to the Block rewrite, some weird Api breakages and parser tests fix that need backports. For more on the weird API breakage, see r91215 for an incomplete fix that shuts up the

[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added

2011-07-15 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19635 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside

[MediaWiki-CodeReview] [MediaWiki r92239]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92239. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92239#c0 Commit summary: MFT PHPUnit testing related revisions: r87839 : PHPPunit 3.5 at least r88769 : Tests use MediaWikiTestCase r88755 : stop

[MediaWiki-CodeReview] [MediaWiki r92234]: New comment added

2011-07-15 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r92234. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92234#c19636 Commit summary: NS_MAIN can locally have subpages enabled This workaround test if any local change has been made, if so the test will be skipped. fu r82577 Comment:

[MediaWiki-CodeReview] [MediaWiki r92226]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92226. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92226#c0 Commit summary: Followup r91672: remove commented-out reference to removed file (rtl.css) ___

[MediaWiki-CodeReview] [MediaWiki r91779]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91779. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91779#c0 Commit summary: Fix whitespace, documentation ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92187]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92187. Old Status: fixme New Status: new User ^demon also posted a comment on MediaWiki.r92187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92187#c19637 Commit summary: Various cleanups to ExternalEdit. Documentation, code style,

[MediaWiki-CodeReview] [MediaWiki r91803]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91803. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91803#c0 Commit summary: Allow the 'other' parameter for HTMLForm selectorother: it is used in SpecialBlock.php::getFormFields() (and maybe in more

Re: [Wikitech-l] [Selenium] IDE test for regressing bughttps://bugzilla.wikimedia.org/show_bug.cgi?id=29310

2011-07-15 Thread Benedikt Kämpgen
Hi Michelle, Sorry for answering late, but I only occasionally look into Wikitech-l. Currently, I am working on integrating Selenium system tests into Semantic MediaWiki. We have created around 20 tests that I want to add to SMW to be run with the WMF Selenium framework. While doing this, I

Re: [Wikitech-l] [Selenium] IDE test for regressing bughttps://bugzilla.wikimedia.org/show_bug.cgi?id=29310

2011-07-15 Thread Chad
On Fri, Jul 15, 2011 at 9:25 AM, Benedikt Kämpgen benedikt.kaemp...@kit.edu wrote: Currently, I am working on integrating Selenium system tests into Semantic MediaWiki. We have created around 20 tests that I want to add to SMW to be run with the WMF Selenium framework. The WMF Selenium grid

Re: [Wikitech-l] REL1_18 is broken!

2011-07-15 Thread Ashar Voultoiz
On 15/07/11 14:56, Chad wrote: snip For more on the weird API breakage, see r91215 for an incomplete fix that shuts up the error (but as Bryan points out isn't strictly correct). That one would need to be merged so :-) The block tests are all running fine in trunk, so we probably need to

[MediaWiki-CodeReview] [MediaWiki r92234]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r92234. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92234#c0 Commit summary: NS_MAIN can locally have subpages enabled This workaround test if any local change has been made, if so the test will be

[MediaWiki-CodeReview] [MediaWiki r92239]: New comment added

2011-07-15 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r92239. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92239#c19638 Commit summary: MFT PHPUnit testing related revisions: r87839 : PHPPunit 3.5 at least r88769 : Tests use MediaWikiTestCase r88755 : stop drop/create tables on every

[MediaWiki-CodeReview] [MediaWiki r92044]: New comment added

2011-07-15 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r92044. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92044#c19639 Commit summary: Per wikitech-l, run a bunch of URLs in the API output through wfExpandUrl(), so they become fully-qualified even if they were originally protocol-relative

[MediaWiki-CodeReview] [MediaWiki r85305]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r85305. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85305#c0 Commit summary: Follow-up changes to r84610: * Cleaned up mImageTimeKeys format * ImageMap: Removed redundant addImage call (makeImage

[MediaWiki-CodeReview] [MediaWiki r84309]: New comment added

2011-07-15 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r84309. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84309#c19640 Commit summary: Fix for Bug# 17463: New pages log doesn't remove/update item after suppression redirect Except for some whitespace changes, this is Baowolff's patch

[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added

2011-07-15 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19641 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside

[MediaWiki-CodeReview] [MediaWiki r92231]: New comment added

2011-07-15 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r92231. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92231#c19642 Commit summary: * Use local context instead of global variables * Removed parameters that could be replaced by context * Call Linker methods

[MediaWiki-CodeReview] [MediaWiki r79892]: New comment added

2011-07-15 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r79892. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79892#c19643 Commit summary: * (bug 25506) Exception is thrown if OutputPage::parse is called inside a tag hook, which would reset parser state Comment: Ping

[MediaWiki-CodeReview] [MediaWiki r92081]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92081. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r92081. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92081#c19644 Commit summary: Added us_status column for future expansion re Bryan's

[MediaWiki-CodeReview] [MediaWiki r92081]: New comment added

2011-07-15 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r92081. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92081#c19645 Commit summary: Added us_status column for future expansion re Bryan's suggestion Implemented changes suggested in code review on r92009: constructor bug handling passed

[MediaWiki-CodeReview] [MediaWiki r79845]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r79845. Old Status: fixme New Status: new User Bryan also posted a comment on MediaWiki.r79845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79845#c19646 Commit summary: $wgMaxUploadSize may now be set to an array to specify the

[MediaWiki-CodeReview] [MediaWiki r92238]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r92238. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r92238. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92238#c19647 Commit summary: AjaxCategories: move self init to mw.util.init;

[MediaWiki-CodeReview] [MediaWiki r91728]: New comment added

2011-07-15 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r91728. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91728#c19648 Commit summary: Rewrite mwsuggest.js using j.ui.autocomplete. This gets rid of a lot of the little kinks of the previously implemenation: The

[MediaWiki-CodeReview] [MediaWiki r92238]: New comment added

2011-07-15 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r92238. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92238#c19649 Commit summary: AjaxCategories: move self init to mw.util.init; start with qunit Comment: Looks like the test isn't being loaded (but is somehow getting

[MediaWiki-CodeReview] [MediaWiki r83302]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r83302. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83302#c0 Commit summary: (bug 27018) Added action=filerevert to revert files to an old version. Copied procedure from FileRevertForm, as most

[MediaWiki-CodeReview] [MediaWiki r91618]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91618. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91618#c0 Commit summary: Replace bullet-icon.png with an 8-bit version (became 24-bit due to r78011 which removed the color palette) * Fixes (bug

[MediaWiki-CodeReview] [MediaWiki r91719]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91719. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91719#c0 Commit summary: * DatabaseOracle.php binds variables, so using $val = 'NULL' breaks certain maint. scripts

[MediaWiki-CodeReview] [MediaWiki r91762]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91762. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91762#c0 Commit summary: Undo browser defaults (underline/strike) for the del and ins DairikiDiff inserts. Fixes bug 29779

[MediaWiki-CodeReview] [MediaWiki r92238]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r92238. Old Status: fixme New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r92238. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92238#c19650 Commit summary: AjaxCategories: move self init to

[MediaWiki-CodeReview] [MediaWiki r91762]: New comment added

2011-07-15 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r91762. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91762#c19651 Commit summary: Undo browser defaults (underline/strike) for the del and ins DairikiDiff inserts. Fixes bug 29779 Comment: Any idea where this is supposed to go in

[MediaWiki-CodeReview] [MediaWiki r85994]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Werdna changed the status of MediaWiki.r85994. Old Status: new New Status: fixme User Werdna also posted a comment on MediaWiki.r85994. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85994#c19652 Commit summary: Unbundle OutputPage::showErrorPage() in Exception.php to

[MediaWiki-CodeReview] [MediaWiki r85994]: New comment added

2011-07-15 Thread MediaWiki Mail
User Werdna posted a comment on MediaWiki.r85994. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85994#c19653 Commit summary: Unbundle OutputPage::showErrorPage() in Exception.php to allow ErrorPageError objects to be passed a Message object for a more complicated display.

[MediaWiki-CodeReview] [MediaWiki r85025]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Werdna changed the status of MediaWiki.r85025. Old Status: new New Status: fixme User Werdna also posted a comment on MediaWiki.r85025. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85025#c19654 Commit summary: (bug 23408) give admins a warning before letting them block

[MediaWiki-CodeReview] [MediaWiki r85166]: New comment added

2011-07-15 Thread MediaWiki Mail
User Werdna posted a comment on MediaWiki.r85166. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85166#c19655 Commit summary: Follow-up r85025: fix the you're-trying-to-block-yourself-you-twit warning, and make it an actual checkbox confirmation. Also use said confirmation for

[MediaWiki-CodeReview] [MediaWiki r92238]: New comment added

2011-07-15 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r92238. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92238#c19656 Commit summary: AjaxCategories: move self init to mw.util.init; start with qunit Comment: That testswarm parses uncommented files, which qunit standalone ignores is

[MediaWiki-CodeReview] [MediaWiki r82181]: New comment added

2011-07-15 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r82181. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82181#c19657 Commit summary: * (bug 27338) Gallery in 1.17 breaks for audio/video + ogghandler Patch by DieBuche, who explains the CSS: If the image height is lower than the

[Wikitech-l] find deleted pages

2011-07-15 Thread priyank bagrecha
is there a way to find using the api whether a certain page is deleted or not? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r92253]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r92253. Old Status: new New Status: fixme User DieBuche also posted a comment on MediaWiki.r92253. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92253#c19658 Commit summary: Revert r92238: partial addition of broken test cases to

[MediaWiki-CodeReview] [MediaWiki r92256]: New comment added

2011-07-15 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r92256. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92256#c19659 Commit summary: MoodBar front-end: * Init/show triger in init-module (position: top) * Bind and load the rest from the bottom in the core-module * Implement overlay div

[MediaWiki-CodeReview] [MediaWiki r91154]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91154. Old Status: ok New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91154#c0 Commit summary: Minor tweaks for r83833 per CR ___

[MediaWiki-CodeReview] [MediaWiki r92268]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r92268. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92268#c0 Commit summary: Fix typo in r91154 ___ MediaWiki-CodeReview mailing list

[Wikitech-l] New SVN commiter

2011-07-15 Thread Ryan Lane
Gave Aaron Parecki access to extensions. He's been working on extensions such as: * MediaWiki-SEO-Title-Tag * MediaWiki-Changelog-Graphs * MediaWiki-Glossary-Extension - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r92272]: New comment added

2011-07-15 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r92272. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92272#c19660 Commit summary: Merged in live CommonSettings.php changes...sigh Comment: pre - $wgExtensionAssetsPath =

[MediaWiki-CodeReview] [MediaWiki r84874]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r84874. Old Status: ok New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r84874. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84874#c19661 Commit summary: Clean up extra needless preg_match() calls done on

[MediaWiki-CodeReview] [MediaWiki r92272]: New comment added

2011-07-15 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r92272. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92272#c19662 Commit summary: Merged in live CommonSettings.php changes...sigh Comment: Yeah, that got lost in the crap. Added back.

[MediaWiki-CodeReview] [MediaWiki r92262]: New comment added

2011-07-15 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r92262. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92262#c19663 Commit summary: Move old projects to the new ATTIC directory. Projects moved: CommonsBrowser librdcp logwood loreley lucene-search mwblocker mwsearch rpms scavenger

[MediaWiki-CodeReview] [MediaWiki r90278]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r90278. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90278#c0 Commit summary: * (bug 25133) allow redirects also for action=parsepageid

Re: [Wikitech-l] New SVN commiter

2011-07-15 Thread Sumana Harihareswara
On 07/15/2011 02:33 PM, Ryan Lane wrote: Gave Aaron Parecki access to extensions. He's been working on extensions such as: * MediaWiki-SEO-Title-Tag * MediaWiki-Changelog-Graphs * MediaWiki-Glossary-Extension - Ryan Pretty screenshot from the changelog graphs extension:

[MediaWiki-CodeReview] [MediaWiki r90186]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r90186. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90186#c0 Commit summary: Minor fixed in ext.vector.simpleSearch * Aliasing jQuery to $ locally instead of implying global *

[MediaWiki-CodeReview] [MediaWiki r89878]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89878. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89878#c0 Commit summary: Fix jquery.tabIndex even more. * Discovered through TestSwarm. Aside from IE6/IE7, which already

Re: [Wikitech-l] New SVN commiter

2011-07-15 Thread Chad
On Fri, Jul 15, 2011 at 2:33 PM, Ryan Lane rlan...@gmail.com wrote: Gave Aaron Parecki access to extensions. He's been working on extensions such as: * MediaWiki-SEO-Title-Tag * MediaWiki-Changelog-Graphs * MediaWiki-Glossary-Extension Got a bunch of new ones created this week: * Matthew

[MediaWiki-CodeReview] [MediaWiki r91618]: New comment added

2011-07-15 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r91618. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91618#c19664 Commit summary: Replace bullet-icon.png with an 8-bit version (became 24-bit due to r78011 which removed the color palette) * Fixes (bug 19514) Unordered list

[MediaWiki-CodeReview] [MediaWiki r92287]: New comment added

2011-07-15 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r92287. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92287#c19665 Commit summary: 1.17wmf1 MFT r89003, r89005, r90217 Comment: Screw you SVN. It seems only r90217 was merged out. FFS ___

[MediaWiki-CodeReview] [MediaWiki r92264]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92264. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r92264. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92264#c19666 Commit summary: r92253 : readd useful changes Comment: pre +

[MediaWiki-CodeReview] [MediaWiki r92264]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92264. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r92264. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92264#c19667 Commit summary: r92253 : readd useful changes Comment: Reverted and

[MediaWiki-CodeReview] [MediaWiki r92256]: New comment added

2011-07-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r92256. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92256#c19668 Commit summary: MoodBar front-end: * Init/show triger in init-module (position: top) * Bind and load the rest from the bottom in the core-module * Implement overlay div

[MediaWiki-CodeReview] [MediaWiki r92267]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92267. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92267#c0 Commit summary: Followup r92256: Make message with an URL only ignore for Translatewiki, see CR

[MediaWiki-CodeReview] [MediaWiki r89616]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89616. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89616#c0 Commit summary: Extension:WikiEditor Code quality, JSHint validation and JSPERF - Leaked globals - Strict

[MediaWiki-CodeReview] [MediaWiki r89581]: New comment added

2011-07-15 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r89581. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89581#c19669 Commit summary: * (bug 27716) Make a method to do checking of 0 or 1 of the parameters existence (like requireOnlyOneParameter), but without

[MediaWiki-CodeReview] [MediaWiki r89581]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89581. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89581#c0 Commit summary: * (bug 27716) Make a method to do checking of 0 or 1 of the parameters existence (like

[MediaWiki-CodeReview] [MediaWiki r89605]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89605. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89605#c0 Commit summary: Fix bug that brakes the 'jquery.tabIndex firstTabIndex' test in IE6/IE7 (Thanks

[MediaWiki-CodeReview] [MediaWiki r89614]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89614. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89614#c0 Commit summary: Alright, IE7 is fixed by r89613. IE6 stays problematic, for some reason it contains non-nodes as

[MediaWiki-CodeReview] [MediaWiki r89613]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89613. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89613#c0 Commit summary: Redo r89605 in a better way. ___

[MediaWiki-CodeReview] [MediaWiki r88513]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r88513. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88513#c0 Commit summary: Adding mw.util.wikiScript + small fix in mediawiki.action.watch.ajax.js * Moving wiki* functions

[MediaWiki-CodeReview] [MediaWiki r92277]: New comment added, and revision status changed

2011-07-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r92277. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r92277. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92277#c19670 Commit summary: MoodBar: store edit count at time of feedback in the database.

[MediaWiki-CodeReview] [MediaWiki r89605]: New comment added

2011-07-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r89605. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89605#c19671 Commit summary: Fix bug that brakes the 'jquery.tabIndex firstTabIndex' test in IE6/IE7 (Thanks TestSwarm). Comment: Before Roan tells me, I

[MediaWiki-CodeReview] [MediaWiki r91557]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91557. Old Status: reverted New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91557#c0 Commit summary: Revert r91426 and followups r91427, r91430: Breaks Gallery-related parser tests

[MediaWiki-CodeReview] [MediaWiki r91762]: New comment added

2011-07-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91762. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91762#c19672 Commit summary: Undo browser defaults (underline/strike) for the del and ins DairikiDiff inserts. Fixes bug 29779 Comment: In 1.17 this would go in

[MediaWiki-CodeReview] [MediaWiki r91762]: New comment added

2011-07-15 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91762. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91762#c19673 Commit summary: Undo browser defaults (underline/strike) for the del and ins DairikiDiff inserts. Fixes bug 29779 Comment: Untagging 1.17 per the above

[MediaWiki-CodeReview] [MediaWiki r92295]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92295. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92295#c0 Commit summary: Testing ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92296]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92296. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92296#c0 Commit summary: Rm testing ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92295]: Revision status changed

2011-07-15 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92295. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92295#c0 Commit summary: Testing ___ MediaWiki-CodeReview mailing list

  1   2   >