Re: [Wikitech-l] On refactorings and huge changes

2011-07-27 Thread Platonides
Chad wrote: I disagree here. Silence should not be taken for assent. Perhaps we should formalize the approval process for RfCs. I agree with the rest of your message in that we absolutely need to get more eyes on RfCs...and I'm open to suggestions on how to do so. -Chad They are core

[MediaWiki-CodeReview] [MediaWiki r93258]: New comment added

2011-07-27 Thread MediaWiki Mail
User MZMcBride posted a comment on MediaWiki.r93258. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93258#c20176 Commit summary: (bug N) Rewrite most of wfExpandUrl() to handle protocol-relative URLs properly and more flexibly * Fix a bug in rN where URLs like

[MediaWiki-CodeReview] [MediaWiki r93258]: New comment added

2011-07-27 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r93258. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93258#c20177 Commit summary: (bug N) Rewrite most of wfExpandUrl() to handle protocol-relative URLs properly and more flexibly * Fix a bug in rN

[MediaWiki-CodeReview] [MediaWiki r93257]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93257. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93257#c0 Commit summary: adding +1 to pl.planet ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91651]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r91651. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91651#c0 Commit summary: (bug 27410) The tag filter on a history page should be within a label element. Patch by The Evil IP Address. Also remove

[Wikitech-l] SQL: Stored Procedures and MediaWiki update.php

2011-07-27 Thread Robert Vogel
Hello everybody! At my company we develop extensions for MediaWiki. We use the LoadExtensionSchemaUpdates hook to create tables with the maintenance/update.php script. Recently we faced the question whether it is possible to have stored procedures/functions in an extensions SQL-File, or not.

[MediaWiki-CodeReview] [MediaWiki r93261]: New comment added

2011-07-27 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r93261. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93261#c20178 Commit summary: Save css optimizations for modern css ( margin: 0 0 0 0 to margin: 0 etc.) Comment: I'm not a CSS expert, but reading modern in your commit message,

[MediaWiki-CodeReview] [MediaWiki r90743]: New comment added, and revision status changed

2011-07-27 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r90743. Old Status: new New Status: fixme User DieBuche also posted a comment on MediaWiki.r90743. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90743#c20179 Commit summary: Directionality improvements as part of bug 6100 (under

[Wikitech-l] SMWCon Fall 2011 in Berlin: call for presentations

2011-07-27 Thread Yaron Koren
Hello, Wikimania is just next week, but two months from now will be another conference that may be of interest to MediaWiki users and developers: SMWCon, or the Semantic MediaWiki Conference, which will be happening in Berlin on September 21-23:

[MediaWiki-CodeReview] [MediaWiki r93261]: New comment added

2011-07-27 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r93261. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93261#c20180 Commit summary: Save css optimizations for modern css ( margin: 0 0 0 0 to margin: 0 etc.) Comment: Stuff like margin: 0; has been valid since CSS 1 ( Quote from

[Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Leo Koppelkamm
Hi folks please have a look at Bug 11374https://bugzilla.wikimedia.org/show_bug.cgi?id=11374: Red .diffchange text in the green 'added' area may be hard to read for color blinded users. Since it's a rather prominent place, I wouldn't mind some comments on the proposed patch by Krinkle, slightly

[MediaWiki-CodeReview] [MediaWiki r93265]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r93265. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93265#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Thomas Morton
Those are much nicer colours, anyway, in my opinion. Tom On 27 July 2011 14:42, Leo Koppelkamm diebu...@gmail.com wrote: Hi folks please have a look at Bug 11374https://bugzilla.wikimedia.org/show_bug.cgi?id=11374: Red .diffchange text in the green 'added' area may be hard to read for

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread K. Peachey
The proposed change is worse for me, they don't stand out in the diffs I suggest we stick to a Yellow and Blue combo, that colour combo has the least and is the most uncommon type of colour blindness compared to the other types which encompass most other colours, thus having the least

Re: [Wikitech-l] On refactorings and huge changes

2011-07-27 Thread Jeroen De Dauw
Hey, Otherwise, projects [not sponsored by WMF] will end up delayed until After Wikimania/After fundraising/After next scap... So people would probably continue committing to trunk because it's the only way to know it will eventually be reviewed. After being a non-core, non-WMF community

[MediaWiki-CodeReview] [MediaWiki r93261]: New comment added

2011-07-27 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r93261. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93261#c20181 Commit summary: Save css optimizations for modern css ( margin: 0 0 0 0 to margin: 0 etc.) Comment: What's the point of this change? You save 472 bytes on the

[MediaWiki-CodeReview] [MediaWiki r93264]: New comment added

2011-07-27 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r93264. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93264#c20182 Commit summary: Remove semantically incorrect wrapper table from toc and replace it with an inline-blocked diff. Update some skin css, since we don't have the implicit

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Helder
On Portuguese Wikibooks we use the same formatting which is used on French Wikipedia: http://fr.wikipedia.org/wiki/MediaWiki:Common.css Here is an example: http://fr.wikipedia.org/w/index.php?title=MediaWiki:Common.cssdiff=prevoldid=67735346 Helder On Wed, Jul 27, 2011 at 10:42, Leo Koppelkamm

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Leo Koppelkamm
Do you mean yellow left and blue right? Just to make sure the bug is not mainly about left vs. right color, but about the red highlight on a green or yellow background. That red highlight is hard to discriminate for red-green colorblind users ( see http://imgur.com/9AldW for a simulation ). On

[MediaWiki-CodeReview] [MediaWiki r90743]: New comment added, and revision status changed

2011-07-27 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r90743. Old Status: fixme New Status: new User SPQRobin also posted a comment on MediaWiki.r90743. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90743#c20183 Commit summary: Directionality improvements as part of bug 6100 (under

[MediaWiki-CodeReview] [MediaWiki r93261]: New comment added

2011-07-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r93261. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93261#c20184 Commit summary: Save css optimizations for modern css ( margin: 0 0 0 0 to margin: 0 etc.) Comment: I agree. ___

[MediaWiki-CodeReview] [MediaWiki r93253]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r93253. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93253#c0 Commit summary: Mark 2 tests as requiring a DB...since they do :) ___

[MediaWiki-CodeReview] [MediaWiki r93274]: New comment added

2011-07-27 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r93274. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93274#c20185 Commit summary: followup r93178: declared missing global Comment: Oops - sorry for that :)

[MediaWiki-CodeReview] [MediaWiki r93274]: New comment added

2011-07-27 Thread MediaWiki Mail
User F.trott posted a comment on MediaWiki.r93274. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93274#c20186 Commit summary: followup r93178: declared missing global Comment: np. :) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93273]: New comment added

2011-07-27 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r93273. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93273#c20187 Commit summary: Follow up r93253. Do not mark DatabaseSqliteTest.php as needing a db. An existing db is not needed, since it uses a memory one. Having this in

[MediaWiki-CodeReview] [MediaWiki r93266]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r93266. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93266#c0 Commit summary: Rename PROT_* constants to PROTO_* Follow up r93258 ___

[MediaWiki-CodeReview] [MediaWiki r93279]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r93279. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93279#c0 Commit summary: small style tweaks ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90743]: New comment added

2011-07-27 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r90743. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90743#c20188 Commit summary: Directionality improvements as part of bug 6100 (under $wgBetterDirectionality): * Add CSS that should fix all LTR/LTR text on both LTR/RTL wikis, for

[MediaWiki-CodeReview] [MediaWiki r93284]: New comment added, and revision status changed

2011-07-27 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r93284. Old Status: new New Status: fixme User Siebrand also posted a comment on MediaWiki.r93284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93284#c20189 Commit summary: Fix Bug 11270 Bug 11555 : Make editsection link more

[MediaWiki-CodeReview] [MediaWiki r91432]: New comment added

2011-07-27 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91432. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91432#c20190 Commit summary: (see bug 29712) Removing the defaultUserOptionOverrides in MessagesXx.php because it is broken (and has been for a long time) and secondly, it is only

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Ryan Kaldari
I always thought the French diff interface was much more pleasant than the default one. I like Krinkle's version as well. They could both stand to bump up the contrast a little, but otherwise I think they are an improvement. Ryan Kaldari On 7/27/11 7:17 AM, Leo Koppelkamm wrote: Do you mean

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Brandon Harris
Underlines and overlines. I would like to see an experimental version with those. On 7/27/11 10:38 AM, Ryan Kaldari wrote: I always thought the French diff interface was much more pleasant than the default one. I like Krinkle's version as well. They could both stand to bump up the

Re: [Wikitech-l] On refactorings and huge changes

2011-07-27 Thread Bryan Tong Minh
Hey, On Tue, Jul 26, 2011 at 10:27 PM, Chad innocentkil...@gmail.com wrote: All, While spending the past few days/weeks in CodeReview, it has become abundantly clear to me that we absolutely must get away from this idea of doing huge refactorings in our working copies and landing them in

Re: [Wikitech-l] Should MW tie user rights more closely to email?

2011-07-27 Thread Platonides
Jelle Zijlstra wrote: 2011/7/26 Platonides The requester clarified the request today: So for example if the user removes the email address, or replaces it with another but doesn't verify it, the user rights associated with their user group are automatically suspended, until

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread George Herbert
Could we get visual mockups of the various proposals, preferably stacked on one page so we can compare them fairly easily? On Wed, Jul 27, 2011 at 10:39 AM, Brandon Harris bhar...@wikimedia.org wrote:        Underlines and overlines.  I would like to see an experimental version with those.

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Brandon Harris
On a related tangent to this, actually: I have, in the past, provided users with a color blindness preference. I'm not a big fan of preferences overall (too much clutter) but a visually-impaired/color blind one is a preference I'd not fight and would even welcome.

[MediaWiki-CodeReview] [MediaWiki r93290]: New comment added

2011-07-27 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r93290. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93290#c20191 Commit summary: Using addScriptFile , addStyle. Removed Gadget-rtl.css (not used) Comment: You should use the resource loader instead of addStyle / addScriptFile :)

[MediaWiki-CodeReview] [MediaWiki r93291]: New comment added

2011-07-27 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r93291. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93291#c20192 Commit summary: Unicode space separator characters (Zs) now terminates links Fix 19052 which was only reporting the issue for U+3000 IDEOGRAPHIC SPACE. Covers both

[MediaWiki-CodeReview] [MediaWiki r93293]: New comment added

2011-07-27 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r93293. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93293#c20193 Commit summary: DPLforum: automagically register the new namespace + its talkspace Comment: Even though [[extension:Translate]] does not yet support translation of

[MediaWiki-CodeReview] [MediaWiki r93293]: New comment added

2011-07-27 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r93293. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93293#c20194 Commit summary: DPLforum: automagically register the new namespace + its talkspace Comment: The defines are (also) in the main setup file and as a matter of fact,

[MediaWiki-CodeReview] [MediaWiki r93293]: New comment added

2011-07-27 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r93293. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93293#c20195 Commit summary: DPLforum: automagically register the new namespace + its talkspace Comment: My bad. Guess we'll fix it whenever it needs fixing. Thanks for the reply.

[MediaWiki-CodeReview] [MediaWiki r93290]: New comment added

2011-07-27 Thread MediaWiki Mail
User Kipmaster posted a comment on MediaWiki.r93290. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93290#c20196 Commit summary: Using addScriptFile , addStyle. Removed Gadget-rtl.css (not used) Comment: I tried but with no success... If you say it's possible then I'll try

[Wikitech-l] Cleaning up default assignments -- No triage this week

2011-07-27 Thread Mark A. Hershberger
In order to be able to have time to clean up the default assignments in Bugzilla, I've put my weekly triage on hold this week and last week. The rationale behind this cleanup is to avoid Cookie Licking (http://communitymgt.wikia.com/wiki/Cookie_Licking) and make it easier for people to find work

[MediaWiki-CodeReview] [MediaWiki r93264]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93264. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93264#c0 Commit summary: Remove semantically incorrect wrapper table from toc and replace it with an inline-blocked diff. Update some skin

[MediaWiki-CodeReview] [MediaWiki r93285]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93285. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93285#c0 Commit summary: r93284 : Update rightClickEdit.js ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93284]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93284. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93284#c0 Commit summary: Fix Bug 11270 Bug 11555 : Make editsection link more understandable by positioning it directly left ( RTL: right )

[MediaWiki-CodeReview] [MediaWiki r93301]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93301. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93301#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-07-27 19:08:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r93303]: New comment added

2011-07-27 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r93303. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93303#c20197 Commit summary: Typo in message autoblockedtext Follow up r85951 Comment: need backport in 1.18 since it follow up r85951

[MediaWiki-CodeReview] [MediaWiki r93304]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93304. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93304#c0 Commit summary: Fix svn properties Fix some inconsistent eol ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r93284]: New comment added

2011-07-27 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r93284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93284#c20198 Commit summary: Fix Bug 11270 Bug 11555 : Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title. Patch by Aryeh Gregor,

Re: [Wikitech-l] SQL: Stored Procedures and MediaWiki update.php

2011-07-27 Thread Roan Kattouw
On Wed, Jul 27, 2011 at 12:47 PM, Robert Vogel vo...@hallowelt.biz wrote: Hello everybody! At my company we develop extensions for MediaWiki. We use the LoadExtensionSchemaUpdates hook to create tables with the maintenance/update.php script. Recently we faced the question whether it is

[MediaWiki-CodeReview] [MediaWiki r92478]: New comment added

2011-07-27 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r92478. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92478#c20199 Commit summary: Added double click to select word, tripple click to select block. Comment: Double click and triple click are wonderful!

[MediaWiki-CodeReview] [MediaWiki r93167]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r93167. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93167#c0 Commit summary: Update General-domain to use PLURAL ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93284]: New comment added

2011-07-27 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r93284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93284#c20200 Commit summary: Fix Bug 11270 Bug 11555 : Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title. Patch by Aryeh

[MediaWiki-CodeReview] [MediaWiki r93297]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r93297. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93297#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-07-27 19:00:00)

[MediaWiki-CodeReview] [MediaWiki r93284]: New comment added

2011-07-27 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r93284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93284#c20201 Commit summary: Fix Bug 11270 Bug 11555 : Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title. Patch by Aryeh Gregor,

[MediaWiki-CodeReview] [MediaWiki r93313]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r93313. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93313#c0 Commit summary: mixed up forward/backward in comments ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92113]: New comment added, and revision status changed

2011-07-27 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92113. Old Status: fixme New Status: resolved User Krinkle also posted a comment on MediaWiki.r92113. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92113#c20203 Commit summary: Unit tests for jquery.localize (Follow-up r92069)

[MediaWiki-CodeReview] [MediaWiki r92125]: New comment added, and revision status changed

2011-07-27 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92125. Old Status: fixme New Status: resolved User Krinkle also posted a comment on MediaWiki.r92125. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92125#c20204 Commit summary: Fix broken test introduced in r92113 for

[MediaWiki-CodeReview] [MediaWiki r92126]: New comment added, and revision status changed

2011-07-27 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92126. Old Status: fixme New Status: resolved User Krinkle also posted a comment on MediaWiki.r92126. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92126#c20205 Commit summary: Fixes for jquery.localize unit test IE6,IE7,IE8: -

[MediaWiki-CodeReview] [MediaWiki r92846]: New comment added

2011-07-27 Thread MediaWiki Mail
User Kaldari posted a comment on MediaWiki.r92846. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92846#c20206 Commit summary: follow-up to r91499 - set padding for the elements inside the button rather than for the button itself - this is how normal jquery.UI skins handle it,

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Leo Koppelkamm
On Wednesday, July 27, 2011 at 8:33 PM, George Herbert wrote: Could we get visual mockups of the various proposals, preferably stacked on one page so we can compare them fairly easily? Red/Green http://commons.wikimedia.org/?debug=truediff=55008419withCSS=MediaWiki:Gadget-diffRedGreen3.css

[MediaWiki-CodeReview] [MediaWiki r92846]: New comment added

2011-07-27 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r92846. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92846#c20208 Commit summary: follow-up to r91499 - set padding for the elements inside the button rather than for the button itself - this is how normal jquery.UI skins handle

[MediaWiki-CodeReview] [MediaWiki r93319]: New comment added

2011-07-27 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r93319. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93319#c20209 Commit summary: Recommit r93264 ( Remove semantically incorrect wrapper table from toc and replace it with an inline-blocked diff. Update some skin css, since we don't

[MediaWiki-CodeReview] [MediaWiki r92846]: New comment added

2011-07-27 Thread MediaWiki Mail
User Jorm (WMF) posted a comment on MediaWiki.r92846. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92846#c20210 Commit summary: follow-up to r91499 - set padding for the elements inside the button rather than for the button itself - this is how normal jquery.UI skins handle

Re: [Wikitech-l] Experimental Wikia RTE branch for MediaWiki trunk

2011-07-27 Thread Maciej Jaros
Dmitriy Sintsov (2011-07-21 09:48): Brion Vibberbr...@pobox.com [Fri, 6 May 2011 16:34:20 -0700]: This gets a little scarier-looking once it turns out that the core Parser class has a hojillion little patches on it that the extension depends on, which do much of the annotation placeholder

[MediaWiki-CodeReview] [MediaWiki r92846]: New comment added

2011-07-27 Thread MediaWiki Mail
User Kaldari posted a comment on MediaWiki.r92846. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92846#c20211 Commit summary: follow-up to r91499 - set padding for the elements inside the button rather than for the button itself - this is how normal jquery.UI skins handle it,

[MediaWiki-CodeReview] [MediaWiki r93237]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r93237. Old Status: fixme New Status: reverted Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93237#c0 Commit summary: Follow-up r93234: use User::getBlock() accessor rather than accessing $mBlock directly.

[MediaWiki-CodeReview] [MediaWiki r93284]: New comment added

2011-07-27 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r93284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93284#c20212 Commit summary: Fix Bug 11270 Bug 11555 : Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title. Patch by Aryeh

[Wikitech-l] Question about Infobox and Navbox

2011-07-27 Thread priyank bagrecha
The boxes that are on a wikipedia-page on the top right hand corner generally, as I have seen are created by using templates Infobox or Navbox. Are there any other templates which can result in such a box? Thanks Priyank ___ Wikitech-l mailing list

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Maciej Jaros
Leo Koppelkamm (2011-07-27 23:31): On Wednesday, July 27, 2011 at 8:33 PM, George Herbert wrote: Could we get visual mockups of the various proposals, preferably stacked on one page so we can compare them fairly easily? Red/Green

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Raindrift posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20213 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll

[MediaWiki-CodeReview] [MediaWiki r93287]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r93287. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93287#c0 Commit summary: removing debug statement ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20214 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20215 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll work

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20216 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Raindrift posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20217 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Raindrift posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20218 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20219 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll work

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20220 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20221 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll

Re: [Wikitech-l] RFC: Modifying diff colors due to color blindness issues

2011-07-27 Thread Brandon Harris
On 7/27/11 3:49 PM, Maciej Jaros wrote: I like the first red green (without the border), but if at it there should probably be more distinction between the grey, red and green colours. I was working on a picture on Commons some time ago after being poked by a colour blind person and found

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Raindrift posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20222 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll

[MediaWiki-CodeReview] [MediaWiki r93340]: New comment added

2011-07-27 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r93340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93340#c20223 Commit summary: Changed jop-loops to use --wiki Comment: Also made it use MWScript.php wrapper. ___

[MediaWiki-CodeReview] [MediaWiki r93340]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r93340. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93340#c0 Commit summary: Changed jop-loops to use --wiki ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93174]: New comment added

2011-07-27 Thread MediaWiki Mail
User Jlemley posted a comment on MediaWiki.r93174. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20224 Commit summary: Followup r93154: Tweak extension credits and message files for consisteny Add extension to Translatewiki Comment: Applied fixes to 1.16 release.

[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added

2011-07-27 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20225 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll work

[MediaWiki-CodeReview] [MediaWiki r91031]: New comment added

2011-07-27 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91031. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c20226 Commit summary: (bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to r68904. Yay Roan finally taught me how to use the resourceloader :D

Re: [Wikitech-l] On refactorings and huge changes

2011-07-27 Thread Rob Lanphier
On Tue, Jul 26, 2011 at 4:49 PM, Chad innocentkil...@gmail.com wrote: On Tue, Jul 26, 2011 at 4:42 PM, Platonides platoni...@gmail.com wrote: If the author considers it ready to merge and there has been no opposition in a week, then merge it. That would solve the rotting problem. I don't think

[MediaWiki-CodeReview] [MediaWiki r93336]: New comment added

2011-07-27 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r93336. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93336#c20227 Commit summary: Kill obsolete extension Comment: pre Per the upstream bug tracker http://dev.ckeditor.com/ticket/5602 and http://dev.ckeditor.com/ticket/6273 MediaWiki

[MediaWiki-CodeReview] [MediaWiki r93343]: New comment added

2011-07-27 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r93343. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93343#c20228 Commit summary: make sure sockets are enabled Comment: Won't work on HipHop. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93321]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r93321. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93321#c0 Commit summary: Revert r93237 (use User::getBlock() accessor rather than accessing $mBlock directly ...): breaks a test (specifically

[MediaWiki-CodeReview] [MediaWiki r93333]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r9. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/9#c0 Commit summary: Add OBSOLETE files to FCKeditor in 1.17/1.18 ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r93325]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93325. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93325#c0 Commit summary: Followup r93321: revert r93237 for extensions too ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r93081]: New comment added, and revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93081. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r93081. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93081#c20229 Commit summary: Fixed newFromArchiveRow to check for ar_page_id Comment: does

[MediaWiki-CodeReview] [MediaWiki r93004]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93004. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93004#c0 Commit summary: Follow-up r92924, set special page group for ChangeEmail ___

[MediaWiki-CodeReview] [MediaWiki r92960]: New comment added, and revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r92960. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r92960. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92960#c20230 Commit summary: Make wfUrlEncode(null) reset the static. Two skipped tests work

[MediaWiki-CodeReview] [MediaWiki r92955]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r92955. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92955#c0 Commit summary: Localization update for he. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92832]: New comment added

2011-07-27 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r92832. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92832#c20231 Commit summary: Remove $rtl = true; from translation file in Latin script. Comment: Do we need this one deployed on live site? Should we get it backported to 1.17

[MediaWiki-CodeReview] [MediaWiki r93348]: Revision status changed

2011-07-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93348. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93348#c0 Commit summary: Fix syntax error from r93343 ___ MediaWiki-CodeReview mailing list

  1   2   >