[MediaWiki-CodeReview] [MediaWiki r101320]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101320. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101320 Commit summary: Add namespace gender aliases for 'stq'

[MediaWiki-CodeReview] [MediaWiki r101329]: New comment added

2011-10-31 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101329. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101329#c25172 Commit summary: Fixing and improvement code of CheckUser API module Comment: I wouldn't call using extract() as an improvement.

[MediaWiki-CodeReview] [MediaWiki r101330]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101330. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101330 Commit summary: fixed obvious misprint ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92109]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Dantman changed the status of MediaWiki.r92109. Old Status: ok New Status: fixme User Dantman also posted a comment on MediaWiki.r92109. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92109#c25173 Commit summary: (bug 29558) Add config var to disable update.php. Did this

[MediaWiki-CodeReview] [MediaWiki r100393]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100393. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100393 Commit summary: [JSTesting] mediawiki.special.javaScriptTest: position top ___

[MediaWiki-CodeReview] [MediaWiki r100385]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100385. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100385 Commit summary: [JSTesting] Don't rely on the timeout argument of start/stop. This behavior is removed in the latest QUnit version. --

[MediaWiki-CodeReview] [MediaWiki r100387]: New comment added

2011-10-31 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r100387. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100387#c25175 Commit summary: Updating jquery.qunit from upstream * Source: https://github.com/jquery/qunit/tree/ee156923cdb01820e35e6bb579d5cf6bf55736d4 -- Several bug fixes --

[MediaWiki-CodeReview] [MediaWiki r101322]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101322. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101322 Commit summary: add 'embed' per the advice of Roan, who is a tiny god among mortals. ___

[MediaWiki-CodeReview] [MediaWiki r100677]: New comment added

2011-10-31 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100677. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100677#c25176 Commit summary: Refactor the setup code with seperate mathods for loading fonts for lang attr and style definition. Use addFont method to avoid duplication of css.

[MediaWiki-CodeReview] [MediaWiki r100677]: New comment added

2011-10-31 Thread MediaWiki Mail
User Santhosh.thottingal posted a comment on MediaWiki.r100677. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100677#c25178 Commit summary: Refactor the setup code with seperate mathods for loading fonts for lang attr and style definition. Use addFont method to avoid

[MediaWiki-CodeReview] [MediaWiki r98699]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98699. Old Status: deferred New Status: fixme User Catrope also posted a comment on MediaWiki.r98699. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98699#c25180 Commit summary: add CreateAPage to SVN. Mostly compatible with 1.16,

[MediaWiki-CodeReview] [MediaWiki r98699]: New comment added

2011-10-31 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r98699. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98699#c25181 Commit summary: add CreateAPage to SVN. Mostly compatible with 1.16, except that the upload form has *not* been rewritten to be comptible with 1.16's new upload system.

[MediaWiki-CodeReview] [MediaWiki r92109]: New comment added

2011-10-31 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r92109. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92109#c25182 Commit summary: (bug 29558) Add config var to disable update.php. Did this by checking $wgMiserMode and bailing unless --iknowwhatimdoing Comment: I was going to

[MediaWiki-CodeReview] [pywikipedia r9684]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Valhallasw changed the status of pywikipedia.r9684. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9684 Commit summary: use xmlcharrefreplace replacement and forceInterwiki for Page.__str__()from rewrite branch

[MediaWiki-CodeReview] [pywikipedia r9684]: New comment added

2011-10-31 Thread MediaWiki Mail
User Valhallasw posted a comment on pywikipedia.r9684. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9684#c25183 Commit summary: use xmlcharrefreplace replacement and forceInterwiki for Page.__str__()from rewrite branch Comment: However, why is there logic about encoding in

[MediaWiki-CodeReview] [MediaWiki r101351]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101351. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101351 Commit summary: Folloup r100677 Missed semicolon ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [pywikipedia r9684]: New comment added

2011-10-31 Thread MediaWiki Mail
User Xqt posted a comment on pywikipedia.r9684. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9684#c25184 Commit summary: use xmlcharrefreplace replacement and forceInterwiki for Page.__str__()from rewrite branch Comment: I just actualized it from rewrite branch. I guess

[MediaWiki-CodeReview] [MediaWiki r101365]: New comment added

2011-10-31 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r101365. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101365#c25185 Commit summary: Fixed annoying intermittent BlockTest failures. No surprise we had 'em since blocks set to expire RIGHT NOW tend to expire at that very time:)

[MediaWiki-CodeReview] [MediaWiki r101331]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r101331. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101331 Commit summary: small fixes according to ashley's review ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r99444]: New comment added

2011-10-31 Thread MediaWiki Mail
User Raindrift posted a comment on MediaWiki.r99444. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99444#c25186 Commit summary: protocol-relative URLs for javascript. Could also be extended to relative urls of any kind -- now mw.Uri is just relative to the current URL Comment:

[MediaWiki-CodeReview] [MediaWiki r99444]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Raindrift changed the status of MediaWiki.r99444. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99444 Commit summary: protocol-relative URLs for javascript. Could also be extended to relative urls of any kind -- now mw.Uri is just relative

[MediaWiki-CodeReview] [MediaWiki r100971]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100971. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100971 Commit summary: Allow filtering by property values. Converted recently added reviewers to a property Internationalization/#145

[MediaWiki-CodeReview] [MediaWiki r99446]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Raindrift changed the status of MediaWiki.r99446. Old Status: new New Status: ok User Raindrift also posted a comment on MediaWiki.r99446. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99446#c25187 Commit summary: ensure tests for mw.Uri work in non-browser environments

[MediaWiki-CodeReview] [MediaWiki r101122]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101122. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101122 Commit summary: Added a reviewer filter, true = is_in and false = is_not_in (but reversed, because these filters remove messages that match

[MediaWiki-CodeReview] [MediaWiki r101124]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101124. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101124 Commit summary: Allow filtering by properties in the API. Had to drop preconstructed list of allowed filters, because with values the can

[MediaWiki-CodeReview] [MediaWiki r101130]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101130. Old Status: new New Status: ok User Amire80 also posted a comment on MediaWiki.r101130. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101130#c25188 Commit summary: Implemented last-translator property filter

[MediaWiki-CodeReview] [MediaWiki r101131]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101131. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101131 Commit summary: Small cleanup, the verbosity is making my head hurt ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100177]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Raindrift changed the status of MediaWiki.r100177. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100177 Commit summary: more correct fix for the multi-file scrolling -- the problem was that it called the moveToStep function just for a side

[MediaWiki-CodeReview] [MediaWiki r101132]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101132. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101132 Commit summary: New accept queue message task, when you just want to click, click and click Also disabled the review task which is not

[MediaWiki-CodeReview] [MediaWiki r101134]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101134. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101134 Commit summary: Do not show accept queue tasks for users who cannot accept translations ___

[MediaWiki-CodeReview] [MediaWiki r100387]: New comment added

2011-10-31 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r100387. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100387#c25189 Commit summary: Updating jquery.qunit from upstream * Source: https://github.com/jquery/qunit/tree/ee156923cdb01820e35e6bb579d5cf6bf55736d4 -- Several bug fixes --

[MediaWiki-CodeReview] [MediaWiki r101363]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101363. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101363 Commit summary: * (bug 31818) 'usercreated' message now supports GENDER ___

[MediaWiki-CodeReview] [MediaWiki r99912]: New comment added

2011-10-31 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r99912. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99912#c25190 Commit summary: Per bug 28135: * Set JPEG comment * Add comment about the options array * Automatically set $wgEnableAutoRotation to true Comment: r101375

[MediaWiki-CodeReview] [MediaWiki r101344]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101344. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101344 Commit summary: [RL2] Revert r101305, broken. Warning: Illegal offset type in

[MediaWiki-CodeReview] [MediaWiki r101305]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101305. Old Status: new New Status: reverted User Krinkle also posted a comment on MediaWiki.r101305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101305#c25191 Commit summary: [RL2] Use Strangs instead of booleans for

[MediaWiki-CodeReview] [MediaWiki r100244]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100244. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100244 Commit summary: Fixed a possble typo that ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101352]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101352. Old Status: new New Status: resolved User Krinkle also posted a comment on MediaWiki.r101352. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101352#c25192 Commit summary: unconditionally register the test modules Somehow,

[MediaWiki-CodeReview] [MediaWiki r101346]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101346. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101346 Commit summary: now explicitly need to register test modules. Previously, the javascript test modules were always registered even

[MediaWiki-CodeReview] [MediaWiki r101353]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101353. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101353 Commit summary: remove exception added by r101346 That would break every sites not having $wgEnableJavaScriptTest set since r101352

[MediaWiki-CodeReview] [MediaWiki r101356]: New comment added

2011-10-31 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r101356. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101356#c25193 Commit summary: fix mediawiki.test wrong URL mw.loader.bug30825 test verify we AJAX calls support protocols relative URLS. The way we forged the target URL was fine

[MediaWiki-CodeReview] [MediaWiki r101356]: New comment added

2011-10-31 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r101356. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101356#c25194 Commit summary: fix mediawiki.test wrong URL mw.loader.bug30825 test verify we AJAX calls support protocols relative URLS. The way we forged the target URL was fine

[MediaWiki-CodeReview] [MediaWiki r101356]: New comment added

2011-10-31 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r101356. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101356#c25195 Commit summary: fix mediawiki.test wrong URL mw.loader.bug30825 test verify we AJAX calls support protocols relative URLS. The way we forged the target URL was fine

[MediaWiki-CodeReview] [MediaWiki r101357]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101357. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101357 Commit summary: minor typo in comment ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100244]: New comment added

2011-10-31 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100244. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100244#c25196 Commit summary: Fixed a possble typo that Comment: ... that annoyed me. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r53369]: New comment added

2011-10-31 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r53369. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/53369#c25197 Commit summary: * Added FSRepo configuration properties thumbUrl and thumbDir, to allow the thumbnails to be stored in a separate location to the source images.

[MediaWiki-CodeReview] [MediaWiki r101388]: New comment added

2011-10-31 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r101388. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101388#c25198 Commit summary: fix main page interwiki links Comment: Stop using empty() please. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101389]: New comment added

2011-10-31 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r101389. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101389#c25199 Commit summary: mft r101388 Comment: Please make note of the target branch in the commit message for easier follow-up reading

[MediaWiki-CodeReview] [MediaWiki r101388]: New comment added

2011-10-31 Thread MediaWiki Mail
User Preilly posted a comment on MediaWiki.r101388. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101388#c25200 Commit summary: fix main page interwiki links Comment: This should now be fixed in r101392. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101390]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Preilly changed the status of MediaWiki.r101390. Old Status: new New Status: old Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101390 Commit summary: fix use of empty ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101389]: New comment added

2011-10-31 Thread MediaWiki Mail
User Preilly posted a comment on MediaWiki.r101389. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101389#c25201 Commit summary: mft r101388 Comment: So, will something like this work, mft r101388 to the 1.18wmf1 branch? ___

[MediaWiki-CodeReview] [MediaWiki r100387]: New comment added

2011-10-31 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r100387. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100387#c25202 Commit summary: Updating jquery.qunit from upstream * Source: https://github.com/jquery/qunit/tree/ee156923cdb01820e35e6bb579d5cf6bf55736d4 -- Several bug fixes -- New

[MediaWiki-CodeReview] [MediaWiki r101395]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101395. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r101395. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101395#c25203 Commit summary: [JSTesting] javascripttest-backlink: * Match the character as

[MediaWiki-CodeReview] [MediaWiki r100564]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r100564. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100564 Commit summary: Poor FundraiserLandingPage had no messages ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r101383]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101383. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r101383. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101383#c25205 Commit summary: [JSTesting] Restore loading principle. * Follows-up r101346,

[MediaWiki-CodeReview] [MediaWiki r101399]: New comment added

2011-10-31 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r101399. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101399#c25204 Commit summary: Redefines the Gateway's idea of what it means to be posted, so we can display the correct stage of the form on the outside (and not do things like

[MediaWiki-CodeReview] [MediaWiki r101384]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101384. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101384 Commit summary: [JSTesting] Match the other wgEnableJavaScriptTest checks (just in case). * Follows-up r101346, r101352, r101353

[MediaWiki-CodeReview] [MediaWiki r101399]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101399. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101399 Commit summary: Redefines the Gateway's idea of what it means to be posted, so we can display the correct stage of the form on the

[MediaWiki-CodeReview] [MediaWiki r101352]: New comment added

2011-10-31 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101352. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101352#c25207 Commit summary: unconditionally register the test modules Somehow, you really need to have the modules registered globally. Need to sort it out with Roan :-D follow

[MediaWiki-CodeReview] [MediaWiki r101399]: New comment added

2011-10-31 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r101399. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101399#c25209 Commit summary: Redefines the Gateway's idea of what it means to be posted, so we can display the correct stage of the form on the outside (and not do things like

[MediaWiki-CodeReview] [MediaWiki r101133]: New comment added

2011-10-31 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r101133. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101133#c25210 Commit summary: Give optional messages a bit more visibility Comment: It's not very important, but $hasOptional needed?

[MediaWiki-CodeReview] [MediaWiki r101133]: New comment added

2011-10-31 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101133. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101133#c25211 Commit summary: Give optional messages a bit more visibility Comment: Needed for what? Why show the message if there isn't any optional messages.

[MediaWiki-CodeReview] [MediaWiki r101133]: New comment added

2011-10-31 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r101133. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101133#c25212 Commit summary: Give optional messages a bit more visibility Comment: It's only used once, so maybe it can be written as if ( count( $this-group-getTags( 'optional'

[MediaWiki-CodeReview] [MediaWiki r101400]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101400. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101400 Commit summary: fix typos of r101361 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99802]: New comment added

2011-10-31 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on MediaWiki.r99802. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99802#c25213 Commit summary: Intial commit of Extension:FundraiserLandingPage Comment: How secure it is depends mostly on how you use it in templates. With $wgRawHtml

[MediaWiki-CodeReview] [MediaWiki r99802]: New comment added

2011-10-31 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on MediaWiki.r99802. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99802#c25214 Commit summary: Intial commit of Extension:FundraiserLandingPage Comment: In re performance, my understanding is that we planned to cache it. Clearly I missed

[MediaWiki-CodeReview] [MediaWiki r99802]: New comment added

2011-10-31 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on MediaWiki.r99802. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99802#c25215 Commit summary: Intial commit of Extension:FundraiserLandingPage Comment: Special pages are uncached by default. Normally, only people with user accounts can

[MediaWiki-CodeReview] [MediaWiki r99802]: New comment added

2011-10-31 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on MediaWiki.r99802. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99802#c25216 Commit summary: Intial commit of Extension:FundraiserLandingPage Comment: I definitely agree that there is a potential for XSS with this. We had previously

[MediaWiki-CodeReview] [MediaWiki r101135]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101135. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101135 Commit summary: Removed $wgTranslateMessageReview global - it will stay hidden from the ui unless the user has right to use it Updated

[MediaWiki-CodeReview] [MediaWiki r99802]: New comment added

2011-10-31 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on MediaWiki.r99802. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99802#c25218 Commit summary: Intial commit of Extension:FundraiserLandingPage Comment: From #wikimedia-dev, 2011/10/20 [01:12am] pgehres: TimStarling: if you'd like to chat

[MediaWiki-CodeReview] [MediaWiki r101395]: New comment added

2011-10-31 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r101395. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101395#c25219 Commit summary: [JSTesting] javascripttest-backlink: * Match the character as used in Skin::subPageSubtitle for regular subpages. * Instead injecting the message raw,

[MediaWiki-CodeReview] [MediaWiki r101356]: New comment added

2011-10-31 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r101356. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101356#c25220 Commit summary: fix mediawiki.test wrong URL mw.loader.bug30825 test verify we AJAX calls support protocols relative URLS. The way we forged the target URL was fine

[MediaWiki-CodeReview] [MediaWiki r101356]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101356. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r101356. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101356#c25221 Commit summary: fix mediawiki.test wrong URL mw.loader.bug30825 test

[Wikitech-l] Brighton Mumbai meetups this month

2011-10-31 Thread Sumana Harihareswara
Just to remind you: * India hackathon (18–20 November, Mumbai, India) — Alolita Sharma, Siebrand Mazeland, Sumana Harihareswara and the local India team are preparing for this event, which will focus on language, mobile and offline support for MediaWiki content. You can register to request a free

[Wikitech-l] other conferences in November - grow the MediaWiki dev community

2011-10-31 Thread Sumana Harihareswara
Next month: Museum Computer Network http://www.mcn.edu/mcn-2011-atlanta 16-19 Nov, Atlanta. Wikimedians there will present about mobile, OpenStreetMap, Commons, uploading, and other museum-related issues. Wikimedian Lori Phillips will attend and would love for Wikimedia developers to come too,

[MediaWiki-CodeReview] [MediaWiki r101228]: New comment added

2011-10-31 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r101228. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101228#c25222 Commit summary: Fix title case. Comment: It wasn't in 1.18wmf1 or in 1.18, so I guess we just missed it when the feature was added.

[MediaWiki-CodeReview] [MediaWiki r100628]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r100628. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100628 Commit summary: Fixing potential security issue by passing all querystring elements through a very restrictive regex

[MediaWiki-CodeReview] [MediaWiki r101105]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r101105. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101105 Commit summary: somehow missed the hooks in r100925 also, added message documentation for new msgs

[MediaWiki-CodeReview] [MediaWiki r100925]: New comment added

2011-10-31 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r100925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100925#c25223 Commit summary: new thumbnail behavior for thumbnailing with multi-file uploads. Multi-file uploads don't get thumbnails, but have a control for enabling them per-file

[MediaWiki-CodeReview] [MediaWiki r100925]: New comment added

2011-10-31 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r100925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100925#c25224 Commit summary: new thumbnail behavior for thumbnailing with multi-file uploads. Multi-file uploads don't get thumbnails, but have a control for enabling them

[MediaWiki-CodeReview] [MediaWiki r97150]: New comment added

2011-10-31 Thread MediaWiki Mail
User Fomafix posted a comment on MediaWiki.r97150. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97150#c25225 Commit summary: Update jquery.tablesorter for r97145: emulate thead if there is no thead in the HTML, by walking down the table starting at the first row and moving

[MediaWiki-CodeReview] [MediaWiki r100925]: New comment added

2011-10-31 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r100925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100925#c25226 Commit summary: new thumbnail behavior for thumbnailing with multi-file uploads. Multi-file uploads don't get thumbnails, but have a control for enabling them per-file

[MediaWiki-CodeReview] [MediaWiki r100925]: New comment added

2011-10-31 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r100925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100925#c25227 Commit summary: new thumbnail behavior for thumbnailing with multi-file uploads. Multi-file uploads don't get thumbnails, but have a control for enabling them per-file

[MediaWiki-CodeReview] [MediaWiki r99092]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r99092. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r99092. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99092#c25228 Commit summary: (bug 31420) Fix weird tablesorter bug where headers spanning

[MediaWiki-CodeReview] [MediaWiki r101418]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101418. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101418 Commit summary: follow-up to r101334, fixing minor issues ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r101419]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101419. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101419 Commit summary: follow-up to r101418, fixing typo ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101334]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r101334. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101334 Commit summary: Changes for LandingCheck 2.0 which adds the ability to have multiple servers running LandingCheck where one might be

[MediaWiki-CodeReview] [MediaWiki r99099]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r99099. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99099 Commit summary: Documentation and type hinting. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99100]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r99100. Old Status: new New Status: reverted User Aaron Schulz also posted a comment on MediaWiki.r99100. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99100#c25229 Commit summary: FU r83909: restore preprocessing stage to

[MediaWiki-CodeReview] [MediaWiki r99109]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r99109. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r99109. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99109#c25230 Commit summary: Massive amount of type hinting so we can actually

[MediaWiki-CodeReview] [MediaWiki r84814]: New comment added, and revision status changed

2011-10-31 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r84814. Old Status: ok New Status: fixme User Hashar also posted a comment on MediaWiki.r84814. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84814#c25231 Commit summary: Topple the last bastion of global-function-based special

[MediaWiki-CodeReview] [MediaWiki r100925]: New comment added

2011-10-31 Thread MediaWiki Mail
User Raindrift posted a comment on MediaWiki.r100925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100925#c25232 Commit summary: new thumbnail behavior for thumbnailing with multi-file uploads. Multi-file uploads don't get thumbnails, but have a control for enabling them

[MediaWiki-CodeReview] [MediaWiki r100925]: New comment added

2011-10-31 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r100925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100925#c25233 Commit summary: new thumbnail behavior for thumbnailing with multi-file uploads. Multi-file uploads don't get thumbnails, but have a control for enabling them

[MediaWiki-CodeReview] [MediaWiki r101425]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r101425. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101425 Commit summary: removed unused variable, added informative comments, changed thumbnail icon. followup to r100925

[MediaWiki-CodeReview] [MediaWiki r101423]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r101423. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101423 Commit summary: Fixed a bug where some versions of Chrome on Linux and FF seemed to be accessing the filename property of a File object using

Re: [Wikitech-l] For your enjoyment: Localisation team development showcase

2011-10-31 Thread Brion Vibber
On Mon, Oct 31, 2011 at 11:47 AM, Siebrand Mazeland (WMF) smazel...@wikimedia.org wrote: Today the localisation team has had its first development showcase, something we hope to repeat every two weeks. Outside of three of our team members, one invitee was present (Robin Pepermans). A

Re: [Wikitech-l] ALAC is open source

2011-10-31 Thread Brion Vibber
On Fri, Oct 28, 2011 at 9:42 AM, Brion Vibber br...@pobox.com wrote: On Fri, Oct 28, 2011 at 2:33 AM, Magnus Manske magnusman...@googlemail.com wrote: The Apple Lossless Audio Codec has been released under Apache license 2.0: http://alac.macosforge.org/trac/wiki Something to add to the

Re: [Wikitech-l] For your enjoyment: Localisation team development showcase

2011-10-31 Thread Sam Reed
http://commons.wikimedia.org/wiki/File:Localisation-team-showcase-20111031.ogv Needs a license, description etc ;) From: brion.vib...@gmail.com [mailto:brion.vib...@gmail.com] On Behalf Of Brion Vibber Sent: 31 October 2011 23:43 To: Siebrand Mazeland (WMF) Cc: wikitech-l

Re: [Wikitech-l] For your enjoyment: Localisation team development showcase

2011-10-31 Thread Brion Vibber
On Mon, Oct 31, 2011 at 4:56 PM, Sam Reed re...@wikimedia.org wrote: http://commons.wikimedia.org/wiki/File:Localisation-team-showcase-20111031.ogv ** ** Needs a license, description etc ;) Awesome, thanks! I've redirected the original file link to the commons page so my server

[MediaWiki-CodeReview] [MediaWiki r101426]: Revision status changed

2011-10-31 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101426. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101426 Commit summary: adding uselang to LandingCheck ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99100]: New comment added

2011-10-31 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r99100. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99100#c25234 Commit summary: FU r83909: restore preprocessing stage to cache link existence using LinkBatch; otherwise a separate DB query is done on every link. Since the

  1   2   >