[Wikitech-l] Cascading HTMLForms

2011-11-14 Thread Robert Vogel
Hello everybody, I am trying to write a SpecialPage with some kind of wizard functionality. On normal access a HTMLForm with a HTMLSelectField is presented. In the submit callback method of this HTMLForm object I create another HTMLForm with more HTMLFields. So far everything works fine. But

[MediaWiki-CodeReview] [MediaWiki r102945]: New comment added

2011-11-14 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r102945. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102945#c25966 Commit summary: (bug 32380) Make get powered by link target protocol-relative Comment: $wgFooterIcons in DefaultSettings.php needs to be updated too.

[MediaWiki-CodeReview] [MediaWiki r102625]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Freakolowsky changed the status of MediaWiki.r102625. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102625 Commit summary: * Added getInfinity to DatabaseOracle * Block - replaced 'infinity' strings with DB-getInfinity calls * UploadStash

[MediaWiki-CodeReview] [pywikipedia r9744]: New comment added, and revision status changed

2011-11-14 Thread MediaWiki Mail
User Valhallasw changed the status of pywikipedia.r9744. Old Status: new New Status: fixme User Valhallasw also posted a comment on pywikipedia.r9744. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9744#c25967 Commit summary: doi known_family error, bug #3436114 Comment:

[MediaWiki-CodeReview] [MediaWiki r101149]: New comment added

2011-11-14 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r101149. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101149#c25968 Commit summary: fixed bug 31613 (API UsageException when saving a collection to a page) Comment: Did #3 in r102949. ___

[MediaWiki-CodeReview] [MediaWiki r102949]: New comment added

2011-11-14 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r102949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102949#c25969 Commit summary: Followup r101149: make FauxRequest::__construct() use $_SESSION if the session parameter isn't given Comment: Is there a chance of current

[MediaWiki-CodeReview] [MediaWiki r102891]: New comment added, and revision status changed

2011-11-14 Thread MediaWiki Mail
User Santhosh.thottingal changed the status of MediaWiki.r102891. Old Status: fixme New Status: new User Santhosh.thottingal also posted a comment on MediaWiki.r102891. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102891#c25970 Commit summary: Oops, missed to notice the

[MediaWiki-CodeReview] [MediaWiki r102954]: New comment added

2011-11-14 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r102954. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102954#c25971 Commit summary: Fix for r102949: don't delete too much Comment: I meant r102951 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r102949]: New comment added

2011-11-14 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r102949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102949#c25972 Commit summary: Followup r101149: make FauxRequest::__construct() use $_SESSION if the session parameter isn't given Comment: I don't believe so, since such bugs

[MediaWiki-CodeReview] [MediaWiki r102952]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102952. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102952 Commit summary: Remove the kok-* codes got added unintentionally in r102891. ___

[MediaWiki-CodeReview] [MediaWiki r102949]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102949. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102949 Commit summary: Followup r101149: make FauxRequest::__construct() use $_SESSION if the session parameter isn't given

[MediaWiki-CodeReview] [MediaWiki r101149]: New comment added

2011-11-14 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r101149. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101149#c25973 Commit summary: fixed bug 31613 (API UsageException when saving a collection to a page) Comment: ...and reverted. But none of that is needed now that we have

Re: [Wikitech-l] Overzealous Commons deletionists

2011-11-14 Thread Andre Engels
On Mon, Nov 14, 2011 at 3:44 AM, John Erling Blad jeb...@gmail.com wrote: If someone reports something (s)he thinks is an error, even if the wording seems insulting, there are usually something important in the report. Don't attack what you think is wrong about the report, try to figure out

[MediaWiki-CodeReview] [MediaWiki r102772]: New comment added, and revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102772. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r102772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102772#c25974 Commit summary: Backport compatible updates from trunk. Mostly protocol

[MediaWiki-CodeReview] [MediaWiki r102951]: New comment added

2011-11-14 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r102951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102951#c25975 Commit summary: (bug 29854) Store protocol-relative links twice in the externallinks table, one with http: in el_index and once with https: . Modified patch by Brad

[MediaWiki-CodeReview] [MediaWiki r102951]: New comment added

2011-11-14 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r102951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102951#c25976 Commit summary: (bug 29854) Store protocol-relative links twice in the externallinks table, one with http: in el_index and once with https: . Modified patch by Brad

[MediaWiki-CodeReview] [MediaWiki r102772]: New comment added, and revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102772. Old Status: fixme New Status: new User Catrope also posted a comment on MediaWiki.r102772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102772#c25977 Commit summary: Backport compatible updates from trunk. Mostly protocol

[MediaWiki-CodeReview] [MediaWiki r102891]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102891. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102891 Commit summary: Oops, missed to notice the missed ?php. Reverting. ___

[MediaWiki-CodeReview] [MediaWiki r102893]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102893. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102893 Commit summary: Correct the name of Sanskrit. Follow-up 102889. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r102891]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102891. Old Status: resolved New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102891 Commit summary: Oops, missed to notice the missed ?php. Reverting. ___

[MediaWiki-CodeReview] [MediaWiki r102891]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102891. Old Status: reverted New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102891 Commit summary: Oops, missed to notice the missed ?php. Reverting. ___

[MediaWiki-CodeReview] [MediaWiki r102802]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102802. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102802 Commit summary: Make commafy support negative numbers too, Add test cases. Ref Bug 32359 and Followup r97793

[MediaWiki-CodeReview] [MediaWiki r100506]: New comment added

2011-11-14 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100506. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100506#c25978 Commit summary: Moved CheckUser log stuff into a separate special page Comment: It moved to preparent::__construct( 'CheckUser', 'checkuser' );/pre But some of

[MediaWiki-CodeReview] [MediaWiki r102957]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102957. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102957 Commit summary: kill light setup file; broken beyond use anyway ___

[MediaWiki-CodeReview] [MediaWiki r102959]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102959. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102959 Commit summary: up rel notes ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Search completion

2011-11-14 Thread Roan Kattouw
On Wed, Nov 9, 2011 at 12:26 PM, Roan Kattouw roan.katt...@gmail.com wrote: Yes, that's what causing it. Although, really, MediaWiki code should always be aliasing $ to the global jQuery object, which BannerController and collapsibleTabs clearly aren't doing. These should be fixed in r102962

[MediaWiki-CodeReview] [MediaWiki r102910]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102910. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102910 Commit summary: Bug 32379 - DatabaseError.php is hardcoding http Also tidy up a couple of returns (per others in method, and/or parents)

[MediaWiki-CodeReview] [MediaWiki r102965]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102965. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102965 Commit summary: Followup r102910 Make the link to the MW page https only ___

[MediaWiki-CodeReview] [MediaWiki r102910]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102910. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102910 Commit summary: Bug 32379 - DatabaseError.php is hardcoding http Also tidy up a couple of returns (per others in method, and/or parents)

[MediaWiki-CodeReview] [MediaWiki r102910]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102910. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102910 Commit summary: Bug 32379 - DatabaseError.php is hardcoding http Also tidy up a couple of returns (per others in method, and/or

[MediaWiki-CodeReview] [MediaWiki r102962]: New comment added, and revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102962. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r102962. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102962#c25979 Commit summary: Properly alias $ to jQuery in collapsibleTabs

[MediaWiki-CodeReview] [MediaWiki r102963]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r102963. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102963 Commit summary: More $ aliasing in obsolete code ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r102913]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102913. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102913 Commit summary: [RL2] Add missing function argument to startGadgetManager - Fixes bug where opening the editor would show the wrong form in

[MediaWiki-CodeReview] [MediaWiki r100506]: New comment added

2011-11-14 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r100506. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100506#c25980 Commit summary: Moved CheckUser log stuff into a separate special page Comment: Yeah I assumed at some point it would check that but I was mistaken. So what is

[MediaWiki-CodeReview] [MediaWiki r100506]: New comment added

2011-11-14 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100506. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100506#c25981 Commit summary: Moved CheckUser log stuff into a separate special page Comment: I haven't tried myself, but it should work. Is there evidence that it doesn't?

[MediaWiki-CodeReview] [MediaWiki r100506]: New comment added

2011-11-14 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r100506. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100506#c25982 Commit summary: Moved CheckUser log stuff into a separate special page Comment: Bug 32400 ___ MediaWiki-CodeReview

Re: [Wikitech-l] en-CA in MediaWiki? Rethinking our method of handling translation bugs?

2011-11-14 Thread Sumana Harihareswara
On 11/12/2011 06:41 AM, Niklas Laxström wrote: I'm very surprised to hear that there are a communication problems (leaving Daniel's case out for now, which has different origins). The administrators (and even translators) of translatewiki.net are almost 100% also part of the MediaWiki

[MediaWiki-CodeReview] [MediaWiki r102527]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102527. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102527 Commit summary: split getHooksFromDoc() function if() { LOT OF CODE } else { LOT OF CODE } structures are hard to read move the LOT OF CODE

[MediaWiki-CodeReview] [MediaWiki r100931]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r100931. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100931 Commit summary: Minor code style cleanups ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100791]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r100791. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100791 Commit summary: Fixed 'Fatal error: Cannot access protected property Revision::$mDeleted in

[MediaWiki-CodeReview] [MediaWiki r100362]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r100362. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100362 Commit summary: More whitespace tweaks...and fixed doc typo ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100280]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r100280. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100280 Commit summary: Code cleanups fixed strange comma ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95641]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r95641. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95641 Commit summary: Add html5 microdata's itemscope to the list of boolean attributes. ___

[MediaWiki-CodeReview] [MediaWiki r97783]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97783. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97783 Commit summary: Added array type hinting too getGroupPermissions() ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r98487]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r98487. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98487 Commit summary: Revision::newFromTitle() returns null sometimes. Protect against the errors. ___

[MediaWiki-CodeReview] [MediaWiki r98458]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r98458. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98458 Commit summary: FU r98405: various document cleanup ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98745]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r98745. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98745 Commit summary: (bug 31320) CentralAuth uses http URLs for autologin images when logging in over https. Renamed WikiReference::getUrl() to

[MediaWiki-CodeReview] [MediaWiki r99463]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r99463. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99463 Commit summary: moar w/s changes! ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99484]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r99484. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99484 Commit summary: list=allusers was throwing fatals when invalid user names occurred in the database. Address this scenario gracefully

[MediaWiki-CodeReview] [MediaWiki r94180]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r94180. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94180 Commit summary: Made moveToInternal() check result of Article::insertOn (related to bug 26223) ___

[MediaWiki-CodeReview] [MediaWiki r96281]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96281. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96281 Commit summary: Pass the key for the skin being created to the constructor of a skin. This is just something that's been bothering me for

[MediaWiki-CodeReview] [MediaWiki r97633]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97633. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97633 Commit summary: Added LinkCache::addGoodLinkObjFromRow, since addGoodLinkObj is not going to work much longer when new parameters are

[MediaWiki-CodeReview] [MediaWiki r97641]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97641. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97641 Commit summary: I broke few parser tests in r97633 by overlooking the return value. This fixes them.

[MediaWiki-CodeReview] [MediaWiki r102970]: New comment added, and revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102970. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r102970. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102970#c25983 Commit summary: (bug 20050) References containing numbered lists cause Tidy

[MediaWiki-CodeReview] [MediaWiki r102849]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102849. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102849 Commit summary: Allow extensions to add post-update maintenance scripts ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r102862]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102862. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102862 Commit summary: Moved methods around to group them by functionnality ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r102798]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102798. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102798 Commit summary: Followup r102785, fix wrong index order in tables.sql. The patches are fine ___

Re: [Wikitech-l] Overzealous Commons deletionists

2011-11-14 Thread Sumana Harihareswara
On 11/13/2011 06:46 PM, Platonides wrote: On 13/11/11 01:44, William Allen Simpson wrote: On 11/12/11 6:45 PM, Platonides wrote: When users get a message on their commons talk page, they will receive an email informing of that. In my personal experience, that's only true for the *first*

[MediaWiki-CodeReview] [MediaWiki r102906]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102906. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102906 Commit summary: Fixup for r102875 parse error. The post-commit hook is *again* not working... ___

[MediaWiki-CodeReview] [MediaWiki r102725]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102725. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102725 Commit summary: [Resources.php] Must. Have. Order. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r102628]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102628. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102628 Commit summary: Follow-up r102612: Use protocol relative URLs for translatewiki.net also ___

[MediaWiki-CodeReview] [MediaWiki r102630]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102630. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102630 Commit summary: Follow-up r102628, r102612: More protocol relative URLs. Also contains localisation updates from //translatewiki.net :)

[MediaWiki-CodeReview] [MediaWiki r102955]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102955. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102955 Commit summary: Revert r102949. Broke tests (undefined variable $_SESSION because session_start() hadn't been called) and is unnecessary

[MediaWiki-CodeReview] [MediaWiki r102953]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102953. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102953 Commit summary: Localisation updates for core and extension messages from translatewiki.net ___

[MediaWiki-CodeReview] [MediaWiki r99562]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r99562. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99562 Commit summary: Avoid warnings from PG about improper escaping. See http://www.postgresql.org/docs/8.1/static/release-8-1.html

[MediaWiki-CodeReview] [MediaWiki r101511]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r101511. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101511 Commit summary: follow up r101496 — ^demon's comments re style ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r101543]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r101543. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101543 Commit summary: Localisation updates from http://translatewiki.net. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r99765]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r99765. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99765 Commit summary: In WantedQueryPage: * Call Linker methods statically * Use $this-msg() to simplify parameter formatting and escaping * Link to

[MediaWiki-CodeReview] [MediaWiki r99106]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r99106. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99106 Commit summary: Per Domas, reinstate 1e9 check that was dropped in r94199. Also document what these checks are all about in more detail.

[MediaWiki-CodeReview] [MediaWiki r99143]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r99143. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99143 Commit summary: FU r98405: ObjectFileCache doesn't need to be abstract ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r102565]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102565. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102565 Commit summary: Release notes for r93061 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93061]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r93061. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93061 Commit summary: Updated hooks docs per r91123. The UI methods are not part of the object anymore.

[MediaWiki-CodeReview] [MediaWiki r100761]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r100761. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100761 Commit summary: Followup to r97033 - removed wgWhatlinksherelimit and started the conversion to wgQueryPageDefaultLimit, but didn't see too

[MediaWiki-CodeReview] [MediaWiki r97033]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97033. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97033 Commit summary: Merged wgWhatlinkshereLimit from Wikia. It defaults to the same value it was hardcoded to before.

[MediaWiki-CodeReview] [MediaWiki r97526]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97526. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97526 Commit summary: Merged in a change which causes update.php to be gentler (tests slave-lag). Part of the many Wikia diffs:

[MediaWiki-CodeReview] [MediaWiki r97767]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97767. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97767 Commit summary: Clear findFile() process cache of file moves (issue came up with bug bug 31056) ___

[MediaWiki-CodeReview] [MediaWiki r96652]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96652. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96652 Commit summary: * Don't list sp:ChangeEmail/sp:ChangePassword at SpecialPages. These were clutter, and useless for anons, as there are links on

[MediaWiki-CodeReview] [MediaWiki r98852]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r98852. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98852 Commit summary: * Added a script to prune old file cache entries. * Use default .cache extension for ResourceFileCache. No need for js/css

[MediaWiki-CodeReview] [MediaWiki r97348]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97348. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97348 Commit summary: Followup to r97342 to add docs for new hook. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98459]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r98459. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98459 Commit summary: Refactored HistoryPage to use RequestContext ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r102970]: New comment added, and revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102970. Old Status: fixme New Status: new User Catrope also posted a comment on MediaWiki.r102970. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102970#c25984 Commit summary: (bug 20050) References containing numbered lists cause

[MediaWiki-CodeReview] [MediaWiki r100906]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100906. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100906 Commit summary: Followup 100905, fixing usages of getContext() ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101273]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101273. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101273 Commit summary: Followup r100927 and r100905, when setting a FauxRequest use the NEW context

[MediaWiki-CodeReview] [MediaWiki r100927]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100927. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100927 Commit summary: Followup r100905, cleanup per CR and fixes the overriding of the main RequestContext

[MediaWiki-CodeReview] [MediaWiki r101024]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101024. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101024 Commit summary: Fix for r100905: * Make tests work again * Added ApiTestCase::doApiRequest() and related to pass it to the context and

[MediaWiki-CodeReview] [MediaWiki r101240]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101240. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101240 Commit summary: Kill various unused variables Comment some out also Add some bits of documentation

[MediaWiki-CodeReview] [MediaWiki r97745]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97745. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97745 Commit summary: Return documentation ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99224]: New comment added

2011-11-14 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r99224. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99224#c25985 Commit summary: Follow-up r98430, use dedicated error message for filename too long error. Adds 'filename-toolong' message. Comment: It's a hardcoded unconfigurable

[MediaWiki-CodeReview] [MediaWiki r99225]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r99225. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99225 Commit summary: Follow-up r99224, fix unit tests. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99224]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r99224. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99224 Commit summary: Follow-up r98430, use dedicated error message for filename too long error. Adds 'filename-toolong' message.

[MediaWiki-CodeReview] [MediaWiki r100140]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100140. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100140 Commit summary: Fix for r100114: make API and tests work again ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r100114]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100114. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100114 Commit summary: * Use local context instead of global variables * Pass the context between Special:Userlogin and Special:ChangePassword when

[MediaWiki-CodeReview] [MediaWiki r100197]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100197. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100197 Commit summary: more accurate documentation for addValue() method ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100926]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100926. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100926 Commit summary: Followup r100905, fixed the ApiTests ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r102301]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102301. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102301 Commit summary: Fix Bug #32047: in table with class=sortable, thead is before caption Apply fomafix's patch for jquery.tablesorter.js (also

[MediaWiki-CodeReview] [MediaWiki r102710]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102710. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102710 Commit summary: on tablesort, verify caption is the first child in the table r102303 tried to compare the whole table when bug 32047 only

[MediaWiki-CodeReview] [MediaWiki r102303]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r102303. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102303 Commit summary: tests for bug 32047 / r102301 In table with class=sortable, thead is before caption

[MediaWiki-CodeReview] [MediaWiki r102988]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102988. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102988 Commit summary: Followup r99224: add message to ApiBase::$messageMap too ___

[MediaWiki-CodeReview] [MediaWiki r102945]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102945. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102945 Commit summary: (bug 32380) Make get powered by link target protocol-relative ___

[MediaWiki-CodeReview] [MediaWiki r102983]: Revision status changed

2011-11-14 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102983. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102983 Commit summary: Followup r102945: $wgFooterIcons too ___ MediaWiki-CodeReview mailing list

  1   2   3   >