[MediaWiki-CodeReview] [MediaWiki r107830]: New comment added

2012-01-03 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r107830. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107830#c28817 Commit summary for MediaWiki.r107830: Preferences update script for Bug 31917. Siebrand's comment: Feedback by TimStarling on IRC: You should commit the transaction after the

[MediaWiki-CodeReview] [MediaWiki r107830]: New comment added

2012-01-03 Thread MediaWiki Mail
Amire80 posted a comment on MediaWiki.r107830. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107830#c28818 Commit summary for MediaWiki.r107830: Preferences update script for Bug 31917. Amire80's comment: Addressed in r107866 and r107867.

Re: [Wikitech-l] [Mediawiki-i18n] Report on WebFonts deployment

2012-01-03 Thread Håkon Wium Lie
Also sprach Glanthor: It would be awesome if we could support some historical writing systems with web fonts, for example runes. There is a great free (GPL) font for this: junicode (http://junicode.sourceforge.net/). It is possible to use it in the future? It's certainly technically

[MediaWiki-CodeReview] [MediaWiki r107773]: New comment added

2012-01-03 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107773. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107773#c28819 Commit summary for MediaWiki.r107773: * (bug 32686) Tooltip on links to non-existing pages are now always in user's language Fixed this by abusing of the $options parameter of

[MediaWiki-CodeReview] [MediaWiki r107869]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r107869 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107869 Old status: new New status: ok Commit summary for MediaWiki.r107869: Fix class name conflict ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r107867]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r107867 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107867 Old status: new New status: ok Commit summary for MediaWiki.r107867: Follow up to r107866 - removing unneeded commit. ___

[MediaWiki-CodeReview] [MediaWiki r107866]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r107866 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107866 Old status: new New status: ok Commit summary for MediaWiki.r107866: Follow up to r107830 - adding commit after update. ___

[MediaWiki-CodeReview] [MediaWiki r107636]: New comment added

2012-01-03 Thread MediaWiki Mail
Bawolff posted a comment on MediaWiki.r107636. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107636#c28820 Commit summary for MediaWiki.r107636: * Moved post-deletion code from WikiPage::doDeleteArticle() to WikiPage::doDeleteUpdates() so that it can be shared with page move * Use

[MediaWiki-CodeReview] [MediaWiki r107830]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r107830 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107830 Old status: fixme New status: resolved Commit summary for MediaWiki.r107830: Preferences update script for Bug 31917. ___

[MediaWiki-CodeReview] [MediaWiki r103711]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r103711 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103711#c28821 Old Status: fixme New Status: new Commit summary for MediaWiki.r103711: (bug 1697) Special:Log make Title an User object when the log type expect it

[MediaWiki-CodeReview] [MediaWiki r107635]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r107635 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107635 Old status: new New status: ok Commit summary for MediaWiki.r107635: Cleanup and comments. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r107787]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r107787 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107787 Old status: new New status: ok Commit summary for MediaWiki.r107787: [WebFonts] fix #pt-webfonts icon position * Core uses padding-left 15px for a 13px-wide icon * So this

[MediaWiki-CodeReview] [MediaWiki r107862]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107862 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107862#c28822 Old Status: new New Status: fixme Commit summary for MediaWiki.r107862: Implemented console panel in debug toolbar Hashar's comment:

[MediaWiki-CodeReview] [MediaWiki r107391]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107391 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107391 Old status: new New status: ok Commit summary for MediaWiki.r107391: And while I'm at it: don't call DatabaseBase::commit() twice per deletion

Re: [Wikitech-l] Rolling towards 1.19... scheduling a code freeze

2012-01-03 Thread Roan Kattouw
On Tue, Jan 3, 2012 at 2:05 AM, Erwin Dokter er...@darcoury.nl wrote: Can someone have a look at bug 25697, which is a very minor, easy patch? I hope to get this one in before 1.19, to go along with the new diff look. Done. Roan ___ Wikitech-l

[MediaWiki-CodeReview] [MediaWiki r107123]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r107123 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107123 Old status: new New status: ok Commit summary for MediaWiki.r107123: Fixup CA js/css per Roan on r106782 Also removed copypasta message from CR

[MediaWiki-CodeReview] [MediaWiki r107321]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107321 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107321 Old status: new New status: ok Commit summary for MediaWiki.r107321: Updating jquery.qunit from upstream * Source:

[MediaWiki-CodeReview] [MediaWiki r107321]: New comment added

2012-01-03 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107321. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107321#c28823 Commit summary for MediaWiki.r107321: Updating jquery.qunit from upstream * Source: https://github.com/jquery/qunit/tree/0aba72f723579082735782231a3503aa249618aa * 1.2.0pre

[MediaWiki-CodeReview] [MediaWiki r107861]: New comment added

2012-01-03 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r107861. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107861#c28824 Commit summary for MediaWiki.r107861: Using wfTime in place of microtime IAlex's comment: We should rather deprecate wfTime() and replace other calls to that function.

[MediaWiki-CodeReview] [MediaWiki r107137]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107137 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107137 Old status: new New status: ok Commit summary for MediaWiki.r107137: Follow-up r98698: Reduce amount of ipv6 spam in FileCacheBase::incrMissesRecent() per CR

[MediaWiki-CodeReview] [MediaWiki r107861]: New comment added

2012-01-03 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r107861. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107861#c28825 Commit summary for MediaWiki.r107861: Using wfTime in place of microtime Johnduhart's comment: And just call microtime directly?

[MediaWiki-CodeReview] [MediaWiki r106911]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r106911 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106911#c28828 Old Status: new New Status: ok Commit summary for MediaWiki.r106911: actually use the flipping cssclass arg, so its possible to set a css class

[MediaWiki-CodeReview] [MediaWiki r103984]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r103984 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103984 Old status: new New status: resolved Commit summary for MediaWiki.r103984: Followup r103814, fixed a few typos and a stray newline

[MediaWiki-CodeReview] [MediaWiki r81507]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r81507 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81507#c28829 Old Status: new New Status: resolved Commit summary for MediaWiki.r81507: Completely remove support for legacy style skins. All legacy skinning

[MediaWiki-CodeReview] [MediaWiki r101627]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r101627 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101627 Old status: fixme New status: new Commit summary for MediaWiki.r101627: [RL2] Add ForeignAPIGadgetRepo. Tested and working ___

[MediaWiki-CodeReview] [MediaWiki r95837]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r95837 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95837 Old status: new New status: ok Commit summary for MediaWiki.r95837: Remove the basic styles that vector coppied from monobook from both monobook and vector and relocate them to

Re: [Wikitech-l] VIPS test

2012-01-03 Thread Tilman Bayer
On Thu, Dec 22, 2011 at 12:32 AM, Tim Starling tstarl...@wikimedia.org wrote: On 22/12/11 10:19, Gregor Hagedorn wrote: Late addition, just tested VIPS with: https://test2.wikipedia.org/wiki/Special:VipsTest?file=Fern+Groombridge.JPGwidth=300sharpen=0.8 and found the non-bilinear VIPS

[MediaWiki-CodeReview] [MediaWiki r107826]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107826 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107826 Old status: new New status: ok Commit summary for MediaWiki.r107826: I18n #353: Using Special:MyPage/Page/ta will now try titles in this order: Page/uilang,

[MediaWiki-CodeReview] [MediaWiki r99312]: New comment added

2012-01-03 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r99312. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99312#c28830 Commit summary for MediaWiki.r99312: Part of bug 31503 - Allow gender distinction also for user groups Hashar's comment: With r107881 I have moved that documentation to QQQ and

[MediaWiki-CodeReview] [MediaWiki r107880]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107880 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107880 Old status: new New status: ok Commit summary for MediaWiki.r107880: Fix regression in Special:MyLanguage - don't bork on invalid titles

[MediaWiki-CodeReview] [MediaWiki r107881]: New comment added

2012-01-03 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107881#c28831 Commit summary for MediaWiki.r107881: remove useless gender for english group name Follow r99312 Nikerabbit's comment: Those comments in MessagesEn are not useful, and

[MediaWiki-CodeReview] [MediaWiki r107881]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107881 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107881 Old status: new New status: fixme Commit summary for MediaWiki.r107881: remove useless gender for english group name Follow r99312

[MediaWiki-CodeReview] [MediaWiki r107881]: New comment added

2012-01-03 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107881#c28832 Commit summary for MediaWiki.r107881: remove useless gender for english group name Follow r99312 Nikerabbit's comment: What was the reason for this change?

[MediaWiki-CodeReview] [MediaWiki r99312]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r99312 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99312#c28833 Old Status: new New Status: resolved Commit summary for MediaWiki.r99312: Part of bug 31503 - Allow gender distinction also for user groups

[MediaWiki-CodeReview] [MediaWiki r104410]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r104410 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104410 Old status: new New status: ok Commit summary for MediaWiki.r104410: Restored r98710 but with a 'forRefresh' option (not used yet)

[MediaWiki-CodeReview] [MediaWiki r100162]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100162 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100162 Old status: new New status: ok Commit summary for MediaWiki.r100162: revert r99562 and set standard_conforming_strings “on” by default

[MediaWiki-CodeReview] [MediaWiki r100512]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100512 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100512 Old status: new New status: resolved Commit summary for MediaWiki.r100512: Adding functions to HTMLForm for setting the submitText and WrapperLegend to messages instead

[MediaWiki-CodeReview] [MediaWiki r107318]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107318 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107318 Old status: new New status: ok Commit summary for MediaWiki.r107318: Follow-up r106567: pass the User object to LogPage::addEntry(); was breaking protect.php maintenance

Re: [Wikitech-l] Bugzilla: Minor enhancements should not be tagged highest priority.

2012-01-03 Thread Strainu
2011/12/30 Dan Collins en.wp.s...@gmail.com: There are also numerous highest priority extension installations. Site request should be treated with the highest priority. Strainu ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r107861]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107861 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107861 Old status: new New status: ok Commit summary for MediaWiki.r107861: Using wfTime in place of microtime ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r107178]: New comment added

2012-01-03 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107178. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107178#c28834 Commit summary for MediaWiki.r107178: Moving the flatlist option to HTMLFormField to prevent code duplication per hashar on r100551 Hashar's comment: Thanks John!

[MediaWiki-CodeReview] [MediaWiki r107882]: New comment added

2012-01-03 Thread MediaWiki Mail
Duplicatebug posted a comment on MediaWiki.r107882. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107882#c28835 Commit summary for MediaWiki.r107882: Fix gender on Special:Userrights r99312 added gender supports to group message. On Special:Userrights, messages were not passed the

[Wikitech-l] Fixing bugs before deployment (was Re: Rolling towards 1.19... scheduling a code freeze)

2012-01-03 Thread bawolff
Message: 4 Date: Mon, 02 Jan 2012 18:07:17 -0500 From: mhershber...@wikimedia.org (Mark A. Hershberger) Subject: [Wikitech-l] Fixing bugs before deployment (was Re: Rolling       towards 1.19... scheduling a code freeze) To: Wikimedia developers wikitech-l@lists.wikimedia.org Message-ID:

Re: [Wikitech-l] Mediawiki 2.0

2012-01-03 Thread Antoine Musso
Le Fri, 30 Dec 2011 18:31:30 +0100, Krinkle krinklem...@gmail.com a écrit: Since virtually any value other than null and undefined is an object, including numbers, strings and functions. Much like ruby! http://ruby-doc.org/core/Integer.html $ irb 5.upto( 10 ) { |num| print

Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki

2012-01-03 Thread Antoine Musso
Le Sat, 31 Dec 2011 11:25:23 +0100, K. Peachey p858sn...@gmail.com a écrit: We currently have a large number of file uploads with no licensing data on MW wiki! And we should really start doing something about it, As some people may have noticed last week(ish) I went though and tag most (if

[MediaWiki-CodeReview] [MediaWiki r98080]: New comment added

2012-01-03 Thread MediaWiki Mail
Catrope posted a comment on MediaWiki.r98080. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98080#c28836 Commit summary for MediaWiki.r98080: MoodBar: Write the filter state to a cookie and read it on page load. This still needs AJAX filtering to be implemented and the on-page-load

[MediaWiki-CodeReview] [MediaWiki r107862]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Johnduhart changed the status of MediaWiki.r107862 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107862#c28837 Old Status: fixme New Status: new Commit summary for MediaWiki.r107862: Implemented console panel in debug toolbar Johnduhart's comment:

Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki

2012-01-03 Thread Platonides
On 03/01/12 15:26, Antoine Musso wrote: Hello, Just consider that those files have been created by their uploader and that they granted a license for use on mediawiki.org Whatever you do, please do not migrate to commons, or we will surely loose materials in the process due to their

[MediaWiki-CodeReview] [MediaWiki r107881]: New comment added

2012-01-03 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107881#c28838 Commit summary for MediaWiki.r107881: remove useless gender for english group name Follow r99312 Hashar's comment: The GENDER is useless in those english messages. Removing

Re: [Wikitech-l] Bugzilla: Minor enhancements should not be tagged highest priority.

2012-01-03 Thread John Du Hart
So instead of bug fixes or security patches operations should spend time deploying an extension so you know who has the most edits? Not a great idea. On Jan 3, 2012 8:06 AM, Strainu strain...@gmail.com wrote: 2011/12/30 Dan Collins en.wp.s...@gmail.com: There are also numerous highest

[MediaWiki-CodeReview] [MediaWiki r107325]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107325 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107325 Old status: new New status: ok Commit summary for MediaWiki.r107325: In EditPage::showDiff(): * Group global declarations * Only get 'currentrev' and 'yourtext' messages if

[MediaWiki-CodeReview] [MediaWiki r101136]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r101136 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101136 Old status: new New status: ok Commit summary for MediaWiki.r101136: Follow-up r99909. If there is a preprocessToXml method, use that. Some preprocessor could have

Re: [Wikitech-l] Email notification sender

2012-01-03 Thread Strainu
2012/1/2 K. Peachey p858sn...@gmail.com: On Mon, Jan 2, 2012 at 5:13 PM, M. Williamson node...@gmail.com wrote: Correction: Wikipedia is the largest part of the projects. Why do people always want to pretend otherwise, or lament that fact? Never said otherwise, Huib just said Wikipedia was one

[MediaWiki-CodeReview] [MediaWiki r107886]: New comment added

2012-01-03 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r107886. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107886#c28839 Commit summary for MediaWiki.r107886: * (bug 27724) Add timestamp to job queue. Designed for administration purposes, not to be exposed to front end users Useful for

[MediaWiki-CodeReview] [MediaWiki r107886]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r107886 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107886#c28840 Old Status: new New Status: fixme Commit summary for MediaWiki.r107886: * (bug 27724) Add timestamp to job queue. Designed for administration

[MediaWiki-CodeReview] [MediaWiki r101030]: New comment added

2012-01-03 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r101030. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101030#c28841 Commit summary for MediaWiki.r101030: * Added pageJoinCond() and userJoinCond() to Revision and exposed them publicly * Removed commented-out code Hashar's comment:

[MediaWiki-CodeReview] [MediaWiki r105154]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r105154 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105154 Old status: new New status: ok Commit summary for MediaWiki.r105154: * Made resetDB() actually clear out the tables rather than leave the contents * Removed destroyDB();

Re: [Wikitech-l] Bugzilla: Minor enhancements should not be tagged highest priority.

2012-01-03 Thread Strainu
2012/1/3 John Du Hart compwhi...@gmail.com: So instead of bug fixes or security patches operations should spend time deploying an extension so you know who has the most edits? Not a great idea. I disagree. If a community decided that they need an extension to know who has the most edits, there

[MediaWiki-CodeReview] [MediaWiki r105752]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r105752 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105752 Old status: new New status: ok Commit summary for MediaWiki.r105752: FU r105154: only clear tables that tests specify as written to. This reduces the obnoxious slowness that

[MediaWiki-CodeReview] [MediaWiki r105154]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r105154 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105154 Old status: ok New status: resolved Commit summary for MediaWiki.r105154: * Made resetDB() actually clear out the tables rather than leave the contents * Removed

[MediaWiki-CodeReview] [MediaWiki r107886]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r107886 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107886 Old status: fixme New status: new Commit summary for MediaWiki.r107886: * (bug 27724) Add timestamp to job queue. Designed for administration purposes, not to be exposed to

[MediaWiki-CodeReview] [MediaWiki r107889]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107889 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107889#c28842 Old Status: new New Status: ok Commit summary for MediaWiki.r107889: Fixup some returns/return documentation Hashar's comment: I would keep the

[MediaWiki-CodeReview] [MediaWiki r107846]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107846 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107846 Old status: new New status: ok Commit summary for MediaWiki.r107846: Revert r107835 - breaks my wiki unknown function' ___

[MediaWiki-CodeReview] [MediaWiki r107845]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107845 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107845 Old status: new New status: ok Commit summary for MediaWiki.r107845: Typofix r107842 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r107778]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107778 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107778 Old status: new New status: ok Commit summary for MediaWiki.r107778: [mediawiki.api] Fix typo that was made consistently. * Follows-up r107011

[MediaWiki-CodeReview] [MediaWiki r107893]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r107893 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107893 Old status: new New status: ok Commit summary for MediaWiki.r107893: svn:eol-style native ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r107895]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107895 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107895 Old status: new New status: ok Commit summary for MediaWiki.r107895: Update method signatures in FakeTitle to avoid E_STRICTs ___

[MediaWiki-CodeReview] [MediaWiki r107777]: New comment added

2012-01-03 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r10. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/10#c28843 Commit summary for MediaWiki.r10: Always set 'jsvarurl' to false (only affect skins not using OutputPage::headElement()) since action=rawgen=js always return an empty page,

[MediaWiki-CodeReview] [MediaWiki r107777]: New comment added

2012-01-03 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r10. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/10#c28844 Commit summary for MediaWiki.r10: Always set 'jsvarurl' to false (only affect skins not using OutputPage::headElement()) since action=rawgen=js always return an empty page,

[MediaWiki-CodeReview] [MediaWiki r107286]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107286 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107286 Old status: new New status: ok Commit summary for MediaWiki.r107286: Use 'newsectionheaderdefaultlevel' message when previewing a new section so that it renders the same as

[MediaWiki-CodeReview] [MediaWiki r107419]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107419 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107419 Old status: new New status: ok Commit summary for MediaWiki.r107419: Need to set mDataLoaded so that this works without a db ___

Re: [Wikitech-l] Fixing bugs before deployment (was Re: Rolling towards 1.19... scheduling a code freeze)

2012-01-03 Thread Mark A. Hershberger
bawolff bawolff...@gmail.com writes: I disagree having all visible changes listed would be useful. The majority of all changes result in some visible change (however minor). Sure. I don't want to be dogmatic. I really just want to make sure stuff is seen sooner rather than later. People who

[MediaWiki-CodeReview] [MediaWiki r107879]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Johnduhart changed the status of MediaWiki.r107879 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107879 Old status: new New status: ok Commit summary for MediaWiki.r107879: Fix typo in r101627 ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Email notification sender

2012-01-03 Thread Nickanc Wikipedia
I totally agree with Strainu. 2012/1/3 Strainu strain...@gmail.com: 2012/1/2 K. Peachey p858sn...@gmail.com: On Mon, Jan 2, 2012 at 5:13 PM, M. Williamson node...@gmail.com wrote: Correction: Wikipedia is the largest part of the projects. Why do people always want to pretend otherwise, or

[MediaWiki-CodeReview] [MediaWiki r107853]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107853 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107853 Old status: new New status: ok Commit summary for MediaWiki.r107853: [JSTesting] fix comment ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Email notification sender

2012-01-03 Thread Erik Moeller
On Sat, Dec 31, 2011 at 10:09 AM, Thomas Dalton thomas.dal...@gmail.com wrote: Why do email notifications from Wikipedia have the sender as MediaWiki Mail? Most Wikipedia users probably don't know what MediaWiki is. I suggest it be changed to Wikipedia or Wikipedia notifications or something

[MediaWiki-CodeReview] [MediaWiki r107127]: New comment added

2012-01-03 Thread MediaWiki Mail
Edokter posted a comment on MediaWiki.r107127. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107127#c28845 Commit summary for MediaWiki.r107127: Applying patch from bug 5 (from Erwin Dokter). Followup to r105280 and r106884. * td.diff-deletedline gets a softer yellow background

[MediaWiki-CodeReview] [Wikimedia r1007]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Kaldari changed the status of Wikimedia.r1007 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1007 Old status: resolved New status: ok Commit summary for Wikimedia.r1007: Updated delete(), update() and insert() with debugging and documenation.

Re: [Wikitech-l] Email notification sender

2012-01-03 Thread Thomas Gries
Am 03.01.2012 18:40, schrieb Erik Moeller: On Sat, Dec 31, 2011 at 10:09 AM, Thomas Dalton thomas.dal...@gmail.com wrote: Why do email notifications from Wikipedia have the sender as MediaWiki Mail? Most Wikipedia users probably don't know what MediaWiki is. I suggest it be changed to

[MediaWiki-CodeReview] [Wikimedia r1119]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Khorn (WMF) changed the status of Wikimedia.r1119 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1119 Old status: new New status: reverted Commit summary for Wikimedia.r1119: followup r107609 Accidentally stranded a local copy of the $form_errors variable in the

[MediaWiki-CodeReview] [Wikimedia r1119]: New comment added

2012-01-03 Thread MediaWiki Mail
Khorn (WMF) posted a comment on Wikimedia.r1119. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1119#c28846 Commit summary for Wikimedia.r1119: followup r107609 Accidentally stranded a local copy of the $form_errors variable in the RapidHTML class. Khorn (WMF)'s comment: Comment is

[MediaWiki-CodeReview] [MediaWiki r107896]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107896 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107896 Old status: new New status: ok Commit summary for MediaWiki.r107896: Removed useless call to Title::getArticleID(); let WikiPage::doDeleteArticle() do this itself

[MediaWiki-CodeReview] [MediaWiki r107848]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107848 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107848 Old status: new New status: deferred Commit summary for MediaWiki.r107848: * Use accessor to get the latest revision of a page * Load page data before calling

[MediaWiki-CodeReview] [MediaWiki r107838]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107838 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107838 Old status: new New status: ok Commit summary for MediaWiki.r107838: Use $wgUser instead of the User from the context in Article::view() and Article::showDiffPage() for

[MediaWiki-CodeReview] [MediaWiki r107894]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107894 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107894 Old status: new New status: deferred Commit summary for MediaWiki.r107894: * Use InitializeArticleMaybeRedirect hook to make the redirect instead of

Re: [Wikitech-l] Email notification sender

2012-01-03 Thread Brion Vibber
On Tue, Jan 3, 2012 at 10:16 AM, Thomas Gries m...@tgries.de wrote: See also http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/UserMailer.php?revision=104208view=markup and change line 195 $headers['X-Mailer']='MediaWiki mailer'; to something else I don't see any reason to

Re: [Wikitech-l] Email notification sender

2012-01-03 Thread Brandon Harris
Agree++; X-Mailer is not intended to be user-visible. It is most often used for readers to adjust for display quirks these days, but also to inform MTAs of behavior quirks. This should be the same across all instances. In fact, it probably shouldn't be user-configurable.

Re: [Wikitech-l] Plural, Gender parsing support for interface messages at client side

2012-01-03 Thread Brion Vibber
On Mon, Jan 2, 2012 at 11:01 AM, Roan Kattouw roan.katt...@gmail.comwrote: On Mon, Jan 2, 2012 at 3:56 PM, Santhosh Thottingal santhosh.thottin...@gmail.com wrote: [1] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107556 In that CR thread, Neil suggested moving message parsing to

[MediaWiki-CodeReview] [Wikimedia r1019]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1019 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1019#c28847 Old Status: new New Status: ok Commit summary for Wikimedia.r1019: Added resetSettings(). Added $this-settings. Added ability to dequeue from

[MediaWiki-CodeReview] [MediaWiki r107881]: New comment added

2012-01-03 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107881#c28848 Commit summary for MediaWiki.r107881: remove useless gender for english group name Follow r99312 Nikerabbit's comment: It's also less obvious translators and wiki

[MediaWiki-CodeReview] [MediaWiki r107043]: New comment added

2012-01-03 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r107043. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107043#c28849 Commit summary for MediaWiki.r107043: Use mw.util.addCSS for adding css. Based on bug 33305, and fixed in r106992. Reedy's comment: Untagging 1.18, path conflict, and code

Re: [Wikitech-l] Plural, Gender parsing support for interface messages at client side

2012-01-03 Thread Roan Kattouw
On Tue, Jan 3, 2012 at 8:24 PM, Brion Vibber br...@pobox.com wrote: I would rather have real, working client-side processing support; Me too, but I don't like the idea of Yet Another Miniparser that parses a narrow subset of wikitext. I'm in a meeting now and we've decided to just go ahead with

Re: [Wikitech-l] Plural, Gender parsing support for interface messages at client side

2012-01-03 Thread Brion Vibber
On Tue, Jan 3, 2012 at 11:36 AM, Roan Kattouw roan.katt...@gmail.comwrote: On Tue, Jan 3, 2012 at 8:24 PM, Brion Vibber br...@pobox.com wrote: I would rather have real, working client-side processing support; Me too, but I don't like the idea of Yet Another Miniparser that parses a narrow

[MediaWiki-CodeReview] [MediaWiki r107931]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107931 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107931 Old status: new New status: ok Commit summary for MediaWiki.r107931: Followup r107882: explicitly say text() or parse() on wfMessage() calls!

[MediaWiki-CodeReview] [MediaWiki r107882]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Brion VIBBER changed the status of MediaWiki.r107882 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107882#c28850 Old Status: new New Status: resolved Commit summary for MediaWiki.r107882: Fix gender on Special:Userrights r99312 added gender supports

[MediaWiki-CodeReview] [MediaWiki r107887]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Brion VIBBER changed the status of MediaWiki.r107887 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107887 Old status: new New status: ok Commit summary for MediaWiki.r107887: Fix non reverted job_insert_timestamp Fixup timestamp addition per Roan Ping r107886

[MediaWiki-CodeReview] [MediaWiki r107769]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107769 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107769 Old status: new New status: ok Commit summary for MediaWiki.r107769: Turn Title::isNewPage() into something useful by caching its result and preload it from

[MediaWiki-CodeReview] [MediaWiki r107771]: New comment added

2012-01-03 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r107771. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107771#c28851 Commit summary for MediaWiki.r107771: Follow-up r107769: * do the same with getTouched(); removed its $db param since it's pretty useless now (and nothing is using it

[MediaWiki-CodeReview] [MediaWiki r107806]: Revision status changed

2012-01-03 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107806 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107806 Old status: new New status: ok Commit summary for MediaWiki.r107806: (Half of bug 33454) The week based year number (format char 'o') was being calculated based on server

[MediaWiki-CodeReview] [MediaWiki r107376]: New comment added, and revision status changed

2012-01-03 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107376 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107376#c28852 Old Status: new New Status: fixme Commit summary for MediaWiki.r107376: Added support for stored procedures/functions to MySQL: * Refactored

  1   2   3   >