Sorry, I've replied to Sumana directly instead of the mailing list. So
now duplicating into the mailing list.
Sumana Harihareswara писал 2012-12-19 22:30:
Try these tips:
https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews
Sumana, it's all very good but:
1) I think it's not so comfortable to push other developers personally
when adding them as the reviewers... And I don't know whom to add as the
reviewer, so I just choose randomly. But what if that guy doesn't want
to do review for that extension? For example what if he is already very
busy in working on mediawiki _core_, and I ask him to review a trivial
extension?
2) Who can verify changes in extensions? There is no CI. So, people who
can verify changes and people who can put +2 - are they the same people?
But it again leads to short-circuiting all the work to the "core"
people, and aren't they already busy? (I assume they are as they don't
review all the changes)
3) As a solution, I think it would be good if - at least in
not-so-important-as-the-core extensions - the changes merged
automatically after getting, for example, 2x "+1"... Or will you end up
with changes reviewed by not merged by anyone? And also, maybe it would
also be good if the system automatically added some reviewers - randomly
or based on some "ownership" rules...
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
