Re: [Wikitech-l] Finding and fixing cyclic dependencies

2019-05-13 Thread Daniel Kinzler
Hey Antoine! Am 13.05.19 um 20:59 schrieb Antoine Musso: > Hello, > > A few months ago, the code health group enquired about the Php metrics static > analysis tool [1] and it has been rather straightforward to run it > automatically > and publish its report: > >

Re: [Wikitech-l] Finding and fixing cyclic dependencies

2019-05-13 Thread Antoine Musso
On 10/05/2019 18:39, Daniel Kinzler wrote: Hi all! I invite you to try out "Project Ruprecht"[1][2], a tool that measures the "tangledness" of PHP code, and provides you with a "naughty list" of things to fix. [1] https://phabricator.wikimedia.org/diffusion/MTDA/repository/master/ [2]

[Wikitech-l] 1.34.0-wmf5 train schedule

2019-05-13 Thread Antoine Musso
Hello, I will be the train conductor toward 1.34.0-wmf5. The planned schedule for this week is: Tuesday: branch cut pairing with Lars "liw" Wirzenius. Should be around noon UTC. Wednesday: deploy during the American morning window: 19:00–21:00 UTC 12:00–14:00 PDT 21:00–23:00 UTC+2

Re: [Wikitech-l] Finding and fixing cyclic dependencies

2019-05-13 Thread Daniel Kinzler
Am 13.05.19 um 12:48 schrieb Amir Sarabadani: > I wonder how many points you get for nerd snipping a software engineer :) One, as it's rather easy ;) > Wonderful work Daniel, kudos! Thank you for your help! > In the given list of bad dependencies, I find User class depending on Skin > class >

Re: [Wikitech-l] Finding and fixing cyclic dependencies

2019-05-13 Thread Amir Sarabadani
I wonder how many points you get for nerd snipping a software engineer :) Wonderful work Daniel, kudos! In the given list of bad dependencies, I find User class depending on Skin class one of the most problematic ones. Also, ApiQuery class depending on all of its subclasses is one of the biggest