Re: [Wikitech-l] Declaring methods final in classes

2019-09-01 Thread Krinkle
On Sun, Sep 1, 2019 at 12:40 PM Aryeh Gregor wrote: > On Fri, Aug 30, 2019 at 10:09 PM Krinkle wrote: > > For anything else, it doesn't really work in my experience because > PHPUnit > > won't actually provide a valid implementation of the interface. It > returns > > null for anything, which is

Re: [Wikitech-l] Phabricator monthly statistics - 2019-08

2019-09-01 Thread יגאל חיטרון
‫בתאריך יום א׳, 1 בספט׳ 2019 ב-15:22 מאת ‪Andre Klapper‬‏ <‪ aklap...@wikimedia.org‬‏>:‬ > Hi, > > On Sun, 2019-09-01 at 14:09 +0300, יגאל חיטרון wrote: > > About " Unbreak now: 0": Can we get a better approximation, as 0.1 or > > 0.45? > > Igal (User: IKhitron) > > Which specific underlying

Re: [Wikitech-l] Phabricator monthly statistics - 2019-08

2019-09-01 Thread Andre Klapper
Hi, On Sun, 2019-09-01 at 14:09 +0300, יגאל חיטרון wrote: > About " Unbreak now: 0": Can we get a better approximation, as 0.1 or > 0.45? > Igal (User: IKhitron) Which specific underlying problem would get solved for you by having even more precision? Also note the corresponding warning: > >

Re: [Wikitech-l] Phabricator monthly statistics - 2019-08

2019-09-01 Thread יגאל חיטרון
Hi. Thank you for the statistics. About " Unbreak now: 0": Can we get a better approximation, as 0.1 or 0.45? Igal (User: IKhitron) ‫בתאריך יום א׳, 1 בספט׳ 2019 ב-3:00 מאת <‪communitymetr...@wikimedia.org ‬‏>:‬ > > Hi Community Metrics team, > > This is your automatic monthly Phabricator

Re: [Wikitech-l] Declaring methods final in classes

2019-09-01 Thread Aryeh Gregor
On Fri, Aug 30, 2019 at 10:09 PM Krinkle wrote: > For anything else, it doesn't really work in my experience because PHPUnit > won't actually provide a valid implementation of the interface. It returns > null for anything, which is usually not a valid implementation of the > contract the class