[Wikitech-l] [BREAKING CHANGE] Remove AlphabeticPager::getOrderTypeMessages()

2022-10-28 Thread Krinkle
This was introduced in March 2008 with r32228 (ad178edb80) for use in the CategoryPager of Special:Categories, but almost immediately removed again from there, on the same day, in r32259

[Wikitech-l] Re: Feedback wanted: PHPCS in a static types world

2022-10-28 Thread Lucas Werkmeister
> > We have already disabled some of these rules for new code in the Translate > extension (ref > > ) > Interesting – we do something similar in some Wikibase codebases (ref

[Wikitech-l] Re: Feedback wanted: PHPCS in a static types world

2022-10-28 Thread Bartosz Dziewoński
I agree, a lot of the doc comments become redundant when types are specified in type hints. Note that doc comments for properties are actually not required, as far as I can tell – you could replace: /** @var LinkRenderer */ private $linkRenderer; …with: private LinkRenderer

[Wikitech-l] Re: [Small wiki toolkits] Final feedback session on Friday, October 28th, at 16:00 UTC

2022-10-28 Thread Seyram Komla Sapaty
Hello! Reminder that this workshop starts in an hour (16:00 UTC). See you there! On Thu, Oct 20, 2022 at 8:18 PM Srishti Sethi wrote: > Hello everyone, > > > The last & final feedback session on the "Small wiki toolkits" (SWT) > workshop series is coming up - it will take place on Friday,

[Wikitech-l] Re: Feedback wanted: PHPCS in a static types world

2022-10-28 Thread Thiemo Kreuz
100% agree. Comments that do nothing but repeat what the code already says serve no purpose¹. I regularly remove these but can't when it means PHPCS starts complaining. Typical example: /** * @param User $user * @param array $rights * @return bool */ public function isAllowed( User $user,

[Wikitech-l] Re: Feedback wanted: PHPCS in a static types world

2022-10-28 Thread Niklas Laxström
pe 28. lokak. 2022 klo 17.04 Lucas Werkmeister ( lucas.werkmeis...@wikimedia.de) kirjoitti: > In my opinion, MediaWiki’s PHPCS ruleset feels largely rooted in an older > version of PHP, where static type declarations (formerly known as “type > hints”) did not exist. As we move towards more modern

[Wikitech-l] Feedback wanted: PHPCS in a static types world

2022-10-28 Thread Lucas Werkmeister
Hi all! In my opinion, MediaWiki’s PHPCS ruleset feels largely rooted in an older version of PHP, where static type declarations (formerly known as “type hints”) did not exist. As we move towards more modern code, I think some rules should be relaxed, and others adjusted. More specifically, I’d

[Wikitech-l] Thank you

2022-10-28 Thread Jacoba Jacqueline Hartnick
Hi there, I know this must be frustrating for you guys, but keep in mind I've just figured out all this a few weeks ago so please have patience with me. JHartnick ___ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe send an email

[Wikitech-l] MediaWiki Language Extension Bundle 2022.10

2022-10-28 Thread Kartik Mistry
We would like to announce the release of MediaWiki Language Extension Bundle 2022.10. This bundle is compatible with '''MediaWiki >= 1.37.2''' and requires '''PHP 7.3.19''' or above. The next MLEB is expected to be released in 3 months. If there are very important bug fixes, we will do an