User "Nikerabbit" changed the status of MediaWiki.r100023. Old Status: new New Status: ok
User "Nikerabbit" also posted a comment on MediaWiki.r100023. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100023#c24403 Commit summary: Bug 29357: CategoryTree should have built-in localizable support for pretty Categorytree-member-num. Added the messages: * categorytree-num-categories * categorytree-num-pages * categorytree-num-files * categorytree-num-empty Added documentation for all of them and for categorytree-member-num and also localized them for Hebrew. Rewrote the part that uses categorytree-member-num to automatically create a comma-separated list of relevant member counts. categorytree-member-num will still be used the same way if it is customized on wiki. Comment: Looks good. It is possible to shorten the code a bit more by doing: <pre> -wfMessage( 'categorytree-num-pages', $wgLang->formatNum( $pageCount ) )->text(); +wfMessage( 'categorytree-num-pages' )->numParams( $pageCount )->text(); </pre> Is there risk breaking customisations of this message that expect $5 to be a number? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
