User "Aaron Schulz" changed the status of MediaWiki.r90219. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90219#c0 Commit summary: * (bug 29426) Fix wrong use of Block::load's second parameter in BlockTest It was accidentally passing a username where it should have passed a user ID, causing PostgreSQL's stricter comparisons to fail, while MySQL's allowed it to run without complaint but returned bad results. Of course that bug got hidden by the test.... testing the wrong thing... :) Now correctly loads using the user id instead of name, checks the proper return values, and actually compares the right object. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
