Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-08-26 Thread Matthew Flaschen
On 06/06/2013 11:16 AM, Alex Monk wrote: Also, +1 to a "Fixes-Bug: 123" annotation or somesuch, as Timo proposed a couple of months ago in the rather more cryptic "Bug 123" vs. "Bug: 123". +1 from me as well. Filed as https://bugzilla.wikimedia.org/show_bug.cgi?id=53387 Matt Flaschen _

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-11 Thread Andre Klapper
On Thu, 2013-06-06 at 16:05 +0100, James Forrester wrote: > As I understand it, the bug states we might want to capture are: Yes, I couldn't have come up with a better summary. Thanks! > * In production in all of the WMF cluster - "RELEASED", replacing the > unused "VERIFIED" state?​ I wouldn't

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-07 Thread Željko Filipin
On Fri, Jun 7, 2013 at 6:24 AM, Matthew Flaschen wrote: > > Also I'm not sure 'Verified' is completely unused... > > I don't generally use it, but I've seen the QA/browser testing team do so. That would probably be only me. :) I can live without "verified". Željko __

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Matthew Flaschen
On 06/06/2013 11:16 AM, Alex Monk wrote: > This should definitely not be used for WMF cluster deployment, only for > tarball releases to third parties (if at all). > Also I'm not sure 'Verified' is completely unused... I don't generally use it, but I've seen the QA/browser testing team do so. Mat

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread James Forrester
On 6 June 2013 16:58, Christian Aistleitner wrote: > However, adding that functionality is totally doable, if we settle for > staying with keywords. (Which I hope we do not) > I agree; keywords are meant to be time-invariant, not statuses; they're the wrong conceptual item to apply for temporary

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Christian Aistleitner
Hi, On Thu, Jun 06, 2013 at 04:39:41PM +0200, Andre Klapper wrote: > assuming that the hooks-bugzilla plugin can do both status > and keyword changes That assumption does not hold true: hooks-bugzilla can set the status, but it currently cannot set keywords, as j2bugzilla (underlying java<->bugzi

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Alex Monk
On Thu, Jun 6, 2013 at 4:05 PM, James Forrester wrote: > * In gerrit but not merged - "PATCH IN REVIEW" (eww) or "COMMITTED" or > whatever. > Committed would've been appropriate in Subversion, but 'committed' in Git does not guarantee it is available in Gerrit. On Thu, Jun 6, 2013 at 4:05 PM, Jam

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread James Forrester
On 6 June 2013 15:40, Andre Klapper wrote: > Salut, > > On Thu, 2013-06-06 at 11:25 +0200, Antoine Musso wrote: > > Launchpad.net has instead of RESOLVED and VERIFIED: > > > > Fix Committed (fixed but not available until next release) > > Fix Released (fix released). > > ---8<---8<---

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Andre Klapper
On Thu, 2013-06-06 at 10:47 +1000, K. Peachey wrote: > How does a Status change work better than a Keyword change in this case? It does not (assuming that the hooks-bugzilla plugin can do both status and keyword changes), I'm just combining two aspects in one go. :) A keyword (that I consider ide

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Andre Klapper
Salut, On Thu, 2013-06-06 at 11:25 +0200, Antoine Musso wrote: > Launchpad.net has instead of RESOLVED and VERIFIED: > > Fix Committed (fixed but not available until next release) > Fix Released (fix released). > ---8<---8<---8<---8<---8<---8<--- > Which is essenti

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Andre Klapper
On Wed, 2013-06-05 at 15:29 -0700, Jon Robson wrote: > I've been using ASSIGNED and assignee name to mean this... to me if > someone is assigned to something it is a promise to attempt to fix it. Ideally I'd use ASSIGNED when seriously(TM) planning to work on a patch. I mean, seriously. But I know

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Andre Klapper
On Wed, 2013-06-05 at 21:54 -0400, Matthew Flaschen wrote: > On 06/05/2013 08:18 PM, Daniel Friesen wrote: > > What is the workflow when: > > # Someone mentions the bug in a commit. > > # "Gerrit Notification Bot" changes the report status to PATHCH_TO_REVIEW > > # The patch is only related or only

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Tim Landscheidt
Antoine Musso wrote: >> in December I mentioned the idea of having a "PATCH_AVAILABLE" or >> "PATCH_TO_REVIEW" status in Bugzilla [1] and that we should re-evaluate >> the idea once we have automatic notifications from Gerrit into Bugzilla >> in place [2]. This is now the case [3]. > > Lamely c

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Christian Aistleitner
Hi, On Thu, Jun 06, 2013 at 12:15:47AM +0200, Andre Klapper wrote: > Hence I propose > * [ drop "patch-in-gerrit" keyword ] > * [ Add "PATCH_AVAILABLE"/"PATCH_TO_REVIEW" status ] I'd love to see that happening. :-) Best regards, Christian -- quelltextlich e.U. \\ C

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-06 Thread Antoine Musso
Le 06/06/13 00:15, Andre Klapper a écrit : > in December I mentioned the idea of having a "PATCH_AVAILABLE" or > "PATCH_TO_REVIEW" status in Bugzilla [1] and that we should re-evaluate > the idea once we have automatic notifications from Gerrit into Bugzilla > in place [2]. This is now the case [3

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Matthew Flaschen
On 06/05/2013 08:18 PM, Daniel Friesen wrote: > On Wed, 05 Jun 2013 15:15:47 -0700, Andre Klapper > wrote: > >> Hi everybody, >> >> * to make the "Gerrit Notification Bot" automatically change the >> bug report status to "PATCH_AVAILABLE"/"PATCH_TO_REVIEW" in >> Bugzilla whe

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Brian Wolff
On 6/5/13, Andre Klapper wrote: > Hi everybody, > > in December I mentioned the idea of having a "PATCH_AVAILABLE" or > "PATCH_TO_REVIEW" status in Bugzilla [1] and that we should re-evaluate > the idea once we have automatic notifications from Gerrit into Bugzilla > in place [2]. This is now the

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread K. Peachey
How does a Status change work better than a Keyword change in this case? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Daniel Friesen
On Wed, 05 Jun 2013 15:15:47 -0700, Andre Klapper wrote: Hi everybody, * to make the "Gerrit Notification Bot" automatically change the bug report status to "PATCH_AVAILABLE"/"PATCH_TO_REVIEW" in Bugzilla when a patch for that bug report has been committed (not:

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Bartosz Dziewoński
Yesplz. The sooner we do this, the better. I've sometimes ASSIGNED bugs to myself to indicate that there's a patch, too, but assigning means different things for different people (e.g. the VE team assigns pretty much all bugs to someone and this means something to them internally I couldn't qu

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Jon Robson
I've been using ASSIGNED and assignee name to mean this... to me if someone is assigned to something it is a promise to attempt to fix it. I'm not sure how patch to review would be useful... Gerrit should be the place to look for things to review - not bugzilla. A RELEASED would however would be u

[Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Andre Klapper
Hi everybody, in December I mentioned the idea of having a "PATCH_AVAILABLE" or "PATCH_TO_REVIEW" status in Bugzilla [1] and that we should re-evaluate the idea once we have automatic notifications from Gerrit into Bugzilla in place [2]. This is now the case [3]. From the Amsterdam Hackathon I kn