Re: [Wikitech-l] ContentHandler review?

2012-08-23 Thread Daniel Kinzler
On 22.08.2012 19:32, Chris Steipp wrote: > I think you were referring to this bug: > https://bugzilla.wikimedia.org/show_bug.cgi?id=38622 Oops. Yea, right, thanks. -- daniel ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wiki

Re: [Wikitech-l] ContentHandler review?

2012-08-22 Thread Tyler Romeo
1300 lines. D: Somebody should really split that. Maybe put the interface into one file, the abstract class into another, etc. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com On Wed, Aug 22, 2012 at 1:32 PM,

Re: [Wikitech-l] ContentHandler review?

2012-08-22 Thread Chris Steipp
On Wed, Aug 22, 2012 at 10:16 AM, Daniel Kinzler wrote: > On 22.08.2012 15:56, Daniel Friesen wrote: >> Where is the discussion and review of ContentHandler? > > There is not much discussion going on. There's a slowish conversation I'm > having > with Tim on Bugzilla: > > https://gerrit.wikimedia

Re: [Wikitech-l] ContentHandler review?

2012-08-22 Thread Daniel Kinzler
On 22.08.2012 15:56, Daniel Friesen wrote: > Where is the discussion and review of ContentHandler? There is not much discussion going on. There's a slowish conversation I'm having with Tim on Bugzilla: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=shortlog;h=refs%2Fheads%2FWikida

Re: [Wikitech-l] ContentHandler review?

2012-08-22 Thread Jeroen De Dauw
AFAIK the Wikidata branch just contains content handler stuff. Daniel K knows better what's on there though. Sent from my Android phone. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] ContentHandler review?

2012-08-22 Thread Daniel Friesen
Where is the discussion and review of ContentHandler? ContentHandler is something I'd really like to see make it into core. It's useful for far more than just Wikidata. I'd like to comment and review some part of the code. Like method naming patterns that don't match the patterns we use elsew