Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-12 Thread Tim Starling
On 10/05/13 22:05, Jeroen De Dauw wrote: > Question: Is it possible to use HipHop only for part of a codebase. For > instance, if there is some MW extension that depends on a third party > library we have no control over that makes uses of SPL, would this cause > problems? It would be possible to

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-12 Thread Tyler Romeo
On Sun, May 12, 2013 at 1:56 PM, Dmitriy Sintsov wrote: > Perhaps you should send the link to HipHop developers (or to their list, > if there's any). Once I finish it and it's working I plan on doing just that. *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Compute

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-12 Thread Dmitriy Sintsov
On 12.05.2013 1:18, Tyler Romeo wrote: FWIW, here is what I have so far: http://pastebin.com/hUQ92DfB I haven't tested it yet because my PHP environment is not behaving, and the only class I haven't implemented fully is SplHeap. Perhaps you should send the link to HipHop developers (or to thei

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-11 Thread Tyler Romeo
FWIW, here is what I have so far: http://pastebin.com/hUQ92DfB I haven't tested it yet because my PHP environment is not behaving, and the only class I haven't implemented fully is SplHeap. *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidzte

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-11 Thread Chad
On Sat, May 11, 2013 at 3:31 AM, Dmitriy Sintsov wrote: > On 10.05.2013 17:58, Chad wrote: >> >> On Fri, May 10, 2013 at 8:05 AM, Jeroen De Dauw >> wrote: >>> >>> Hey, >>> >>> I can see why SPL might require extra work in HipHop to support. At the >>> same time I find it somewhat unfortunate this

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-11 Thread Dmitriy Sintsov
On 10.05.2013 23:51, Antoine Musso wrote: Le 10/05/13 03:10, Tim Starling a écrit : There's a few other SPL features that we don't use at the moment and we should avoid introducing if possible due to lack of support in HipHop: I wish we actually used Spl :-] They are nice classes providing a

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-11 Thread Dmitriy Sintsov
On 10.05.2013 17:58, Chad wrote: On Fri, May 10, 2013 at 8:05 AM, Jeroen De Dauw wrote: Hey, I can see why SPL might require extra work in HipHop to support. At the same time I find it somewhat unfortunate this means one cannot use the Standard PHP Library. Yeah, but I think it's a workable

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-10 Thread Antoine Musso
Le 10/05/13 03:10, Tim Starling a écrit : > There's a few other SPL features that we don't use at the moment and > we should avoid introducing if possible due to lack of support in HipHop: I wish we actually used Spl :-] They are nice classes providing all kind of useful features: http://php.ne

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-10 Thread Antoine Musso
Le 10/05/13 03:10, Tim Starling a écrit : > So I'd like to suggest that we refuse new code submissions in Gerrit > that use these features, if they are targeted for WMF production, This can be done using CodeSniffer. We can write a specific style standard such as "WikimediaProduction" that will

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-10 Thread Chad
On Fri, May 10, 2013 at 8:05 AM, Jeroen De Dauw wrote: > Hey, > > I can see why SPL might require extra work in HipHop to support. At the > same time I find it somewhat unfortunate this means one cannot use the > Standard PHP Library. > Yeah, but I think it's a workable issue. And the HH team see

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-10 Thread Chad
On Fri, May 10, 2013 at 9:49 AM, Max Semenik wrote: > On 10.05.2013, 5:10 Tim wrote: > >> Several people from the HipHop team at Facebook just met with several >> people from WMF. Also, in the last couple of days, I've been doing >> some research into what it would take to make MediaWiki support H

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-10 Thread Max Semenik
On 10.05.2013, 5:10 Tim wrote: > Several people from the HipHop team at Facebook just met with several > people from WMF. Also, in the last couple of days, I've been doing > some research into what it would take to make MediaWiki support HipHop > VM. The answer is: not very much. > There's two fe

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-10 Thread Jeroen De Dauw
Hey, I can see why SPL might require extra work in HipHop to support. At the same time I find it somewhat unfortunate this means one cannot use the Standard PHP Library. Question: Is it possible to use HipHop only for part of a codebase. For instance, if there is some MW extension that depends on

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-09 Thread Tyler Romeo
On Thu, May 9, 2013 at 9:57 PM, Tim Starling wrote: > If you can write a complete and accurate compatibility class in pure > PHP, then it can be included in HipHop in the system/classes directory. > Interesting. I'll try and work on this. *-- * *Tyler Romeo* Stevens Institute of Technology, Clas

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-09 Thread Tim Starling
On 10/05/13 11:48, Tyler Romeo wrote: > On Thu, May 9, 2013 at 9:46 PM, Tim Starling wrote: > >> You can always implement the parts you need in pure PHP. > > > True. It might be worthwhile to make some sort of Spl compatibility library > that loads in PHP versions of those classes if they do not

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-09 Thread Tyler Romeo
On Thu, May 9, 2013 at 9:46 PM, Tim Starling wrote: > You can always implement the parts you need in pure PHP. True. It might be worthwhile to make some sort of Spl compatibility library that loads in PHP versions of those classes if they do not exists. That way we can use them without dropping

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-09 Thread Tim Starling
On 10/05/13 11:28, Daniel Friesen wrote: > On Thu, 09 May 2013 18:10:53 -0700, Tim Starling > wrote: > >> * SplDoublyLinkedList >> * SplFixedArray >> * SplHeap >> * SplMaxHeap >> * SplMinHeap >> * SplPriorityQueue >> * SplQueue >> * SplStack > > It would be nice if HHVM would support these. I'm

Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-09 Thread Daniel Friesen
On Thu, 09 May 2013 18:10:53 -0700, Tim Starling wrote: * SplDoublyLinkedList * SplFixedArray * SplHeap * SplMaxHeap * SplMinHeap * SplPriorityQueue * SplQueue * SplStack It would be nice if HHVM would support these. I'm not sure what is so complex about these that HHVM can implement arra

[Wikitech-l] HipHop VM support: ArrayObject and filter_var()

2013-05-09 Thread Tim Starling
Several people from the HipHop team at Facebook just met with several people from WMF. Also, in the last couple of days, I've been doing some research into what it would take to make MediaWiki support HipHop VM. The answer is: not very much. There's two features that we use, mostly in extensions,