[Wikitech-l] How to use @since annotations

2010-08-15 Thread Niklas Laxström
Hi, The issue of how to use @since annotations recently came up in the code review. Those are essential for extension developers who want to target multiple MediaWiki versions with one codebase. I think we should come up a standard way to use those. Without further talk, here are some issues we

Re: [Wikitech-l] How to use @since annotations

2010-08-15 Thread Jeroen De Dauw
Hey, I think methods should have the @since annotation, as they can be added in a later version then the one the class was added in. This makes them non-redundant, so in no case should they be removed. Cheers -- Jeroen De Dauw * http://blog.bn2vs.com * http://wiki.bn2vs.com Don't panic. Don't

Re: [Wikitech-l] How to use @since annotations

2010-08-15 Thread Happy-melon
Jeroen De Dauw jeroended...@gmail.com wrote in message news:aanlktin9bkbsq2vkjdosbgs1e9cmf9yz1w8jniyso...@mail.gmail.com... Hey, I think methods should have the @since annotation, as they can be added in a later version then the one the class was added in. This makes them non-redundant,

Re: [Wikitech-l] How to use @since annotations

2010-08-15 Thread Aryeh Gregor
On Sun, Aug 15, 2010 at 7:27 AM, Niklas Laxström niklas.laxst...@gmail.com wrote: The issue of how to use @since annotations recently came up in the code review. Those are essential for extension developers who want to target multiple MediaWiki versions with one codebase. I think we should

Re: [Wikitech-l] How to use @since annotations

2010-08-15 Thread Jeroen De Dauw
I think @since annotations are probably useless. I disagree, and know that quite some other extension developers do to. Have you actually been in the situation where you are writing an extension that needs to be compatible up to a certain previous MediaWiki release, and where forced to go look

Re: [Wikitech-l] How to use @since annotations

2010-08-15 Thread Niklas Laxström
On 15 August 2010 20:36, Aryeh Gregor simetrical+wikil...@gmail.com wrote: If you do want to find out if a method is in the version you're targeting, there's a very easy way: check out the branch in SVN and look in the file.  Or use ViewVC.  It's not really harder than looking in the source