Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-02 Thread Ilmari Karonen
Robert Rohde wrote: As I suggested yesterday, perhaps not very clearly, I think the sensible thing to do is to bypass the Parser on most calls to messages like Welcome to {{SITENAME}} by caching the post-transformed version of the message, e.g Welcome to Wikipedia, in the MessageCache

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-02 Thread Niklas Laxström
2009/9/2 Ilmari Karonen nos...@vyznev.net: (Although Roan's suggestion of also folding things like {{CURRENTYEAR}} and passing their expiration time to the cache may also be worth considering.  We could then just treat e.g. {{SITENAME}} as having an infinite expiration time, and any truly

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-02 Thread Platonides
Niklas Laxström wrote: Localisation cache caches only static content, not in-wiki customisations. On the other hand, it needs some trickery if the set of extensions differ between wikis, but should still be possible. But I'm just guessing, I don't know how they are going to set it up. How is

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-02 Thread Aryeh Gregor
On Wed, Sep 2, 2009 at 8:34 AM, Niklas Laxströmniklas.laxst...@gmail.com wrote: When using CDB, the cache is constant. You can't do incremental updates. You can, you just have to write an entirely new database every time. This will already have to be done every time the messages change. Changes

[Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Chad
-- Forwarded message -- From: Brion Vibber br...@wikimedia.org Date: Tue, Sep 1, 2009 at 11:48 AM Subject: Re: [Wikitech-l] how to chang {{SITENAME}} To: Wikimedia developers wikitech-l@lists.wikimedia.org [snip] I'd like to ask that folks leave this thread aside for the moment

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Roan Kattouw
Duplicate thread of http://lists.wikimedia.org/pipermail/wikitech-l/2009-September/044984.html ? Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Chad
On Tue, Sep 1, 2009 at 1:40 PM, Roan Kattouwroan.katt...@gmail.com wrote: Duplicate thread of http://lists.wikimedia.org/pipermail/wikitech-l/2009-September/044984.html ? Roan Kattouw (Catrope) ___ Wikitech-l mailing list

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Ilmari Karonen
Roan Kattouw wrote: Duplicate thread of http://lists.wikimedia.org/pipermail/wikitech-l/2009-September/044984.html ? Not exactly, I think. Folding constant magic words when setting up the localization cache and speeding up the parser in general would be fairly orthogonal improvements, even

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Chad
On Tue, Sep 1, 2009 at 2:34 PM, Domas Mituzasmidom.li...@gmail.com wrote: Hello!!! If anyone is interested in actually looking into the costs of Parser setup and invocation for brace replacement in messages and optimizing this code path, that would be great, but please follow up in a new

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Domas Mituzas
Chad, I personally haven't, but if you've got some good profiling data from WMF usage of this stuff it would certainly be helpful :) Well, in simple micro-benchmarking, wfMsg(pagetitle) took 0.5ms on enwiki and 5ms on frwiki (thats _without_ any initialization overhead). First call to

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Domas Mituzas
Hello, What other people have objected is your position that the only way to regain them is to manually replace {{SITENAME}} on all messages. I didn't say manually ;-) One could have an automated solution :) Parser-transformMsg() could replace many well-known {{something and only call

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Platonides
Domas Mituzas wrote: Anyone, one can see, lion's share is Parser-preprocess, which doesn't do any initialization here, pure parser magic (though it probably has some revisits to magic words and Title code that could be removed). So yes, parser init adds about 5ms, so does message cache,

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Platonides
Domas Mituzas wrote: Hello, What other people have objected is your position that the only way to regain them is to manually replace {{SITENAME}} on all messages. I didn't say manually ;-) One could have an automated solution :) An admin bot template subster Parser-transformMsg() could

Re: [Wikitech-l] How we can speed up double brace substitution, Was: how to chang {{SITENAME}}

2009-09-01 Thread Robert Rohde
On Tue, Sep 1, 2009 at 2:16 PM, Domas Mituzasmidom.li...@gmail.com wrote: Hello, What other people have objected is your position that the only way to regain them is to manually replace {{SITENAME}} on all messages. I didn't say manually ;-) One could have an automated solution :)