Ashar Voultoiz wrote:
On 24/06/11 08:33, Thomas Gries wrote:
When I think that a version committed by myself r90650 (marked as new)
is fully obsolete and
already replaced in my other commit r90684 (marked as fixed)
I would say, if it is reverted, mark it reverted :)
Or maybe resolved, if
On 28/06/11 00:28, Thomas Gries wrote:
Please do not change the flags for your own revisions,
except to change them back to new after you fix a revision that was
flagged fixme.
Just like the Holy Bible, our code review guide is subject to
interpretation :-)
--
Ashar Voultoiz
On 24/06/11 08:33, Thomas Gries wrote:
When I think that a version committed by myself r90650 (marked as new)
is fully obsolete and
already replaced in my other commit r90684 (marked as fixed)
I would say, if it is reverted, mark it reverted :)
--
Ashar Voultoiz
When I think that a version committed by myself r90650 (marked as new)
is fully obsolete and
already replaced in my other commit r90684 (marked as fixed)
in order to save code reviewers' time,
here are my questions:
1. shall I revert the 90650 from SVN ?
2. how exactly, and what would be