On 17/9/24 17:04, Tim Starling wrote:

Has anyone ever regenerated their LocalSettings.php using the installer for a reason other than testing that feature?


I am thinking about removing it. It adds a fair amount of code and complexity.

To clarify, I have in my sights two separate features: unconfigured upgrade, in which upgrade is done with no LocalSettings.php if tables are detected in the database, and LocalSettings.php regeneration, which optionally happens after that.

My idea is to have the DBConnect page simply fail validation if tables exist. The charset and engine detection code in MysqlInstaller::preUpgrade() could then be removed, along with a few other smaller chunks of code.

Unconfigured upgrade is a rare operation which is unlikely to be helpful for users.

-- Tim Starling

_______________________________________________
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

Reply via email to