Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-30 Thread Ilmari Karonen
On 01/29/2011 04:06 AM, Aaron Schulz wrote: In JavaScriptDistiller, inside of the createParser() function, we have: $parser-add( '/\\/\\*(.|[\\r\\n])*?\\*\\//' ); It took me hours to track down that this was causing Apache 2.1.11 to crash on nearly any page view on my test wiki. This

Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-30 Thread Platonides
Ilmari Karonen wrote: Hmm... I don't really know what's going on inside PHP's PCRE implementation, but you might want to try replacing that regexp with: $parser-add( '/\\/\\*.*?\\*\\//s' ); The add()s are combined into a single big regex, you can't set dot-all. Doing it with (?s) may be

Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-30 Thread Ilmari Karonen
On 01/30/2011 04:16 PM, Platonides wrote: Ilmari Karonen wrote: Hmm... I don't really know what's going on inside PHP's PCRE implementation, but you might want to try replacing that regexp with: $parser-add( '/\\/\\*.*?\\*\\//s' ); The add()s are combined into a single big regex, you

Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-30 Thread Maciej Jaros
Ilmari Karonen (2011-01-30 15:19): On 01/30/2011 04:16 PM, Platonides wrote: Ilmari Karonen wrote: Hmm... I don't really know what's going on inside PHP's PCRE implementation, but you might want to try replacing that regexp with: $parser-add( '/\\/\\*.*?\\*\\//s' ); The add()s are

Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-29 Thread Aaron Schulz
That's much better than using editbin :) I added the following: IfModule mpm_winnt_module ThreadStackSize 8388608 /IfModule The stack overflow issue is gone now. This should be in the MW.org apache config docs and elsewhere (especially for 1.17, since nothing beforehand was running into this

[Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-28 Thread Aaron Schulz
In JavaScriptDistiller, inside of the createParser() function, we have: $parser-add( '/\\/\\*(.|[\\r\\n])*?\\*\\//' ); It took me hours to track down that this was causing Apache 2.1.11 to crash on nearly any page view on my test wiki. This happened when a large JS bundle is loaded, such as: