[Wikitech-l] Removed user agent-sniffing client-* classes from html

2011-11-03 Thread Brion Vibber
Per https://bugzilla.wikimedia.org/show_bug.cgi?id=32183 ... In r101860 I've removed most of the client-* classes from the html that were added based on user-agent sniffing. Sniffing UA strings is a fragile practice which should be strongly discouraged in favor of checking for the actual features

Re: [Wikitech-l] Removed user agent-sniffing client-* classes from html

2011-11-03 Thread Brion Vibber
On Thu, Nov 3, 2011 at 12:23 PM, Brion Vibber br...@wikimedia.org wrote: In r101860 I've removed most of the client-* classes from the html that were added based on user-agent sniffing. Sniffing UA strings is a fragile practice which should be strongly discouraged in favor of checking for the

Re: [Wikitech-l] Removed user agent-sniffing client-* classes from html

2011-11-03 Thread Krinkle
On Thu, Nov 3, 2011 at 8:42 PM, Brion Vibber br...@wikimedia.org wrote: On Thu, Nov 3, 2011 at 12:23 PM, Brion Vibber br...@wikimedia.org wrote: In r101860 I've removed most of the client-* classes from the html that were added based on user-agent sniffing. Sniffing UA strings is a fragile