Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-30 Thread Ariel T. Glenn
Στις 30-07-2010, ημέρα Παρ, και ώρα 11:09 -0700, ο/η Neil Kandalgaonkar έγραψε: > On 7/30/10 8:35 AM, Aryeh Gregor wrote: > > Msg::get(). wfMsg() > > This seems like a minimum compromise. Personally I'd go all the way to > M::get() or M(), but that would be a bit too obscure and would break > e

Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-30 Thread Neil Kandalgaonkar
On 7/30/10 8:35 AM, Aryeh Gregor wrote: > Msg::get(). wfMsg() This seems like a minimum compromise. Personally I'd go all the way to M::get() or M(), but that would be a bit too obscure and would break existing conventions for Mediawiki source. It's worth favoring brevity more than usual in th

Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-30 Thread Aryeh Gregor
On Fri, Jul 30, 2010 at 12:29 AM, Max Semenik wrote: > Message::get(), which I already mentioned. Or, better yet, Msg::get(). wfMsg() is one of the most common functions in the codebase. Common functions need to be easier to write, because they're written more often; but can be harder to read,

Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-29 Thread Max Semenik
On 30.07.2010, 3:05 Niklas wrote: > * rename Message::key to Message::newFromKey Overkillishly long. > * add global function wfMessage which is a shorter way to call > Message::newFromKey Can't say I like it. > If you don't like this proposal, please suggest better names. Message::get(), which I

Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-29 Thread Niklas Laxström
On 8 July 2010 12:02, Niklas Laxström wrote: > I'm resurrecting this thread, because I really want to start using > this new class. There are still open questions, like do we want to > have a shortcut and how to name it. Hi again! I'm proposing the following changes: * rename Message::key to Mes

Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-08 Thread Chad
On Thu, Jul 8, 2010 at 6:14 AM, Max Semenik wrote: > Chaining could be surprizingly clear, albeit verbose. Much better > anyway than the insanity we currently use: > * wfMsg - mostly clear what it does Usually ;-) > * wfMsgNoTrans - ehm... All of the *NoTrans mean "don't parse it." > * wfMsgFo

Re: [Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-08 Thread Max Semenik
On 08.07.2010, 13:02 Niklas wrote: > i18n( 'welcometo' $wgSitename)->text(); > or if we don't have a wrapper, use this whatever the class name might be: > Message::key( 'welcometo', $wgSitename )->text(); I don't like the function name 'key', it's unclear. Message::get() would be better imho. >

[Wikitech-l] Request for comments: New Message class (2nd round)

2010-07-08 Thread Niklas Laxström
I'm resurrecting this thread, because I really want to start using this new class. There are still open questions, like do we want to have a shortcut and how to name it. One reason for it is that name Message for a class might conflict and thus we might want to rename it to something else. My curre