Re: [Wikitech-l] The mw.ext construct in lua modules

2019-02-05 Thread John Erling Blad
Those that break the naming scheme *somehow* is 7 extensions (ArticlePlaceholder (mixed case), DynamicPageListEngine (not extension name), JsonConfig (not extension name), LinkedWiki (not ext structure), SemanticScribunto (not extension name), Wikibase Client (not ext structure), ZeroPortal (not

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-02-05 Thread Brad Jorsch (Anomie)
On Mon, Feb 4, 2019 at 5:26 PM Eran Rosenthal wrote: > > What is the problem with the ".ext" part? > 1. It adds unnecessary complexity both in the extension (need to init > mw.ext if it doesn't exist) It's one line in the boilerplate. That's not much complexity. > and more important - in its

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-02-04 Thread Eran Rosenthal
> What is the problem with the ".ext" part? 1. It adds unnecessary complexity both in the extension (need to init mw.ext if it doesn't exist) and more important - in its usage when the Lua extension is invoked (longer names) (there is very small risk of name collision - mw.ModuleA and

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-02-04 Thread Thiemo Kreuz
> […] I think mw.ext.EXTNAME should be avoided […] Can I ask to provide arguments that help others understand this opinion better? What is the problem with the ".ext" part? > […] or we should reject this proposal and open phab ticket to wikibase to > change mw.wikibase to mw.ext.wikibase

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-02-02 Thread Greg Rundlett (freephile)
Sound proposal in my opinion. Greg Rundlett https://eQuality-Tech.com https://freephile.org On Sat, Feb 2, 2019 at 8:32 AM Eran Rosenthal wrote: > I agree with John, and I think mw.ext.EXTNAME should be avoided and we > should prefer mw.EXTNAME which is clear and simple and fills very native.

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-02-02 Thread Eran Rosenthal
I agree with John, and I think mw.ext.EXTNAME should be avoided and we should prefer mw.EXTNAME which is clear and simple and fills very native. This is already the way it is used in wikibase (mw.wikibase.FUNCNAME) which I believe is the most heavily used extension exposing Lua interface. To

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-01-25 Thread John Erling Blad
There are several extensions that diverge on the naming scheme. Some of them even being referenced as using the scheme, while not providing lua libs at all. It is a bit weird. On Fri, Jan 25, 2019 at 7:09 PM Kunal Mehta wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi, > > On

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-01-25 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/24/19 11:33 PM, Thiemo Kreuz wrote: > Is there a question assigned with this long email? Is this a call > for feedback? I think this is probably related to/coming from . - -- Legoktm

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-01-25 Thread Thiemo Kreuz
I meant half a decade. Thanks for assuming good faith. > You use naming schemes to avoid name clashes […] This is by far not the only reason to have a naming scheme. Probably the least interesting one. I don't think it makes sense for me to continue contributing to this conversation, since the

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-01-25 Thread John Erling Blad
Half a century? 50 years? You have been working for WMDE since 2014. Perhaps it would be an idea to discuss the naming scheme instead of doing questionable call to authority? The interesting point is _what_ to gain by adding unrelated character sequences to names. If some character sequence don't

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-01-25 Thread Thiemo Kreuz
"How it should be done" according to whom? This might be a dumb question, but I had the impression you are speaking for a larger group of people in your initial post. I would like to understand the context better in which the proposed standard came to be. Personally, I don't support the idea of

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-01-25 Thread John Erling Blad
It is a description of how it should be done, which is not according to the current page. Yes it is a call for feedback if I must spell it out. On Fri, Jan 25, 2019 at 8:33 AM Thiemo Kreuz wrote: > > Is there a question assigned with this long email? Is this a call for > feedback? > > Kind

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-01-24 Thread Thiemo Kreuz
Is there a question assigned with this long email? Is this a call for feedback? Kind regards Thiemo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] The mw.ext construct in lua modules

2019-01-24 Thread John Erling Blad
At the Extension:Scribunto/Lua reference manual, at several places,[1] it is pointed out that the lua-libs should use the form 'mw.ext.NAME'. This creates visual noise in the code. Any lib included should have a extension page, thus it has already been given an unique name. In addition, only the