http://wikitech.wikimedia.org/view/How_to_deploy_code mentions a couple 
of pitfalls. Given that it is not in svn, I'm providing here a couple of 
simpñle snippets to fix them. Can someone apply?


PITFALL #1: The path argument has to be relative to the php-1.17 
directory, not to the current directory.
It's interesting to note, as it's not intuitive, but the script can 
easily remind you that:

SCAPROOT="/home/wikipedia/common/php"
if [ ! -e "$SCAPROOT/$1" ]; then
  echo "$SCAPROOT/$1" does not exist
  exit 1
fi


PITFALL #2: The comment is only the second argument, so normal shell 
parameter rules apply.

if [ $# -lt 2 ]; then
  echo "Provide a comment for syncing $1"
  exit 1
fi

if [ $# -gt 2 ]; then
  echo sync-file only takes 2 arguments, you passed $#
  echo Did you forgot to quote the comment?
  exit 1
fi


_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to