Re: [Wikitech-l] "must be of type int, int given"

2017-04-18 Thread Denny Vrandečić
That would be neat! On Mon, Apr 17, 2017 at 7:51 PM Chad wrote: > On Mon, Apr 17, 2017 at 2:07 PM Gergo Tisza wrote: > > > On Mon, Apr 17, 2017 at 8:35 PM, Denny Vrandečić > > wrote: > > > > > Value returned from function

Re: [Wikitech-l] "must be of type int, int given"

2017-04-18 Thread Denny Vrandečić
Indeed, it seems your right - if I namespace the thing, the compiler actually tells me that namespace/int is not the same as int. So yeah, it probably assumes a type int here, which has no relation to the built-in scalar int. D'oh. I didn't realize until know that one wasn't allowed to use type

Re: [Wikitech-l] Issue loading JS with ResourceLoader but not with addScript

2017-04-18 Thread Legoktm
Hi, On 04/17/2017 02:17 PM, James Montalvo wrote: > Uncaught Error: Module "jquery" is not loaded. Does your module definition have a dependency on 'jquery'? You should remove that as it will cause errors like this. jQuery is always loaded before any other RL modules are. -- Legoktm

Re: [Wikitech-l] "must be of type int, int given"

2017-04-18 Thread Denny Vrandečić
I tried to change the int to a float, easy enough, and the error went away. Just to be replaced with Exception handler threw an object exception: TypeError: Argument 2 passed to stream_set_blocking() must be an instance of int, bool given in

Re: [Wikitech-l] CREDIT next week, and a survey

2017-04-18 Thread Adam Baso
Hi all - just wanted to let you know the outcomes of the survey. Based on the feedback, we're now: * Going forward, after meetings and some post-processing, copying meeting notes and linking to specific videos in a per-event page. * Setting the channel topic consistently in #wikimedia-office

Re: [Wikitech-l] "must be of type int, int given"

2017-04-18 Thread Stas Malyshev
Hi! > Exception handler threw an object exception: TypeError: Argument 2 passed > to stream_set_blocking() must be an instance of int, bool given in > /vagrant/mediawiki/includes/libs/redis/RedisConnectionPool.php:233 This one is weird - second arg of stream_set_blocking should be boolean, e.g.:

Re: [Wikitech-l] Issue loading JS with ResourceLoader but not with addScript

2017-04-18 Thread Krinkle
The error string "Module "jquery" is not loaded" actually comes from mw.loader.require, unlike the "Unknown dependency: jquery" error which can come from mw.loader.load. It looks like the "masonry.pkgd.js" script is detecting a CommonJS-compatible environment and therefore assumes jQuery must

Re: [Wikitech-l] Issue loading JS with ResourceLoader but not with addScript

2017-04-18 Thread James Montalvo
No jquery dependency specified. I put together a minimal extension to demonstrate the issue. Below is a link to the comparison of the first commit (using ResourceLoader) and the second (using OutputPage::addScript). https://github.com/jamesmontalvo3/JustMasonry/compare/ResourceLoader...addScript