Re: [Wikitech-l] Second round of the MediaWiki Release Management RFP

2014-06-13 Thread Greg Grossmeier

> On 5/27/14, 11:13 AM, Greg Grossmeier wrote:
> > The deadline for proposals is June 13.
> 
> I only noticed this now, but [2] says there will be a "!vote" that ends
> on June 15th. Is there a reason why there's only 2 days between the
> proposal deadline and the voting closing?
> 
> > [2] 
> > https://commons.wikimedia.org/wiki/File:MediaWiki_Release_Request_For_Proposals_2014.pdf

bah! bad copy-editing on my part. That's the date from last year (I
re-used the old pdf, thought I edited everything correctly).

The right dates are on the wiki page:
https://www.mediawiki.org/wiki/Release_Management_RFP


 May 27th - RFP Official Public Announcement / Start of submissions
 June 13th - Deadline for proposals / community feedback period officially 
begins
 Week of June 16th - IRC Office Hours with the applicants
 June 27th - End of Community Feedback period
 June 27th - Announce winner of RFP


Thanks!

-- 
| Greg GrossmeierGPG: B2FA 27B1 F7EB D327 6B8E |
| identi.ca: @gregA18D 1138 8E47 FAC8 1C7D |


signature.asc
Description: Digital signature
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Announcement: Elliot Eggleston joins Wikimedia as Features Engineer

2014-06-13 Thread Erik Moeller
On Fri, Jun 13, 2014 at 6:06 PM, Pine W  wrote:

> Voodoo? Secret account in the Caymans set up by Fundraising Tech?
> Wikishares?

If you want in on the Wikishares, it would be a nice test case for
Matt Walker's new PDF generator. :)

-- 
Erik Möller
VP of Engineering and Product Development, Wikimedia Foundation

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Release management proposal from a consortium of developers and sysadmins

2014-06-13 Thread Isarra Yos

Hey all,

We've posted our proposal for the release management RFP. You can find 
it at https://www.mediawiki.org/wiki/Release_Management_RFP/2014/Consortium


Our team includes me (Kim Schoonover), Ryan Schmidt (Skizzerz), Benjamin 
Lees (Emufarmers), Jack Phoenix, and Bartosz Dziewoński (Matma Rex). We 
are a consortium of developers and system administrators who maintain, 
support and develop for large MediaWiki installations serving thousands 
of users. We think we know a thing or two about what MediaWiki releases 
need.


Please comment; your feedback is welcome and needed to make this a success.

-Isarra

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Announcement: Elliot Eggleston joins Wikimedia as Features Engineer

2014-06-13 Thread Pine W
Welcome Elliot, but...

/antennae twitch

Voodoo? Secret account in the Caymans set up by Fundraising Tech?
Wikishares?

/ping Csteipp
/ping Gbyrd

Pine


On Fri, Jun 13, 2014 at 2:25 PM, Terry Chay  wrote:

> Hello everyone,
>
> It’s with great pleasure that I’m announcing that Elliott Eggleston will
> be joining the Wikimedia Foundation as a Features Engineer in
> Fundraising-Tech.
>
> Before joining us, Eliott was a senior software engineer at SAI Global[1],
> and before that at Integrity Interactive (which was bought by SAI Global),
> which means he’s been working diligently for seven years in enterprise
> software development. Surprisingly, we didn’t hold this too much against
> him.[2] ;-)
>
> His first official day is Monday June 16th where he will be in the office.
> He is going to work with the Fundraising Tech team under Katie Horn and
> along with Adam Wight and Sherah Smith on whatever voodoo there manages to
> pay our salaries (and adds to secret account in the Caymans I had them set
> up[3]), as Matthew Walker transitions to Services[4] this year.
>
> He received his Bachelor’s in Computer Science from Columbia in 2004 and
> spends his down time writing an Android application[5], making a website to
> map his music listening-bike route, playing Scrabble, and taking 3-d
> pictures. He lives in Somerville, Massachusetts.
>
> Oh yeah, he’s also a childhood friend of Adam Wight. (Ask them to serenade
> you with the pi song they invented as kids.) I don’t know whether I should
> be excited to have a person whose disciplined work and even temper can talk
> Adam back from the ledge, or to be worried that they might tag team another
> thread on WMF-all demanding the Foundation to be a co-op.
>
> Please join me in a welcoming Elliott to the Wikimedia Foundation. :-)
>
> Take care,
> Terry
>
> P.S. In keeping with Jared’s demand of a picture to accompany every new
> hire announcement, here is one:
> https://abs.twimg.com/sticky/default_profile_images/default_profile_3_200x200.png[5]
>
> [1] http://www.saiglobal.com
>
> [2] We only made him do four coding tests during the hiring process.
>
> [3] As a hedge if all my wikishares don't vest.
>
> [4]
> https://www.mediawiki.org/wiki/Wikimedia_Engineering/Service_and_REST_API_team
>
> [5] Erik Möller is of the opinion working a Java Android app for
> manipulating 3D fractals with a web export that works in latest versions of
> Firefox on mobile devices with WebGL is not the kind of thing you do for
> fun if you don’t enjoy complex challenges. I am of the opinion that Java
> PERIOD itself is not the kind of thing you do for fun PERIOD.
>
> [6] Not sure this is any better: https://github.com/ejegg
>
> terry chay  최태리
> Director of Features Engineering
> Wikimedia Foundation
> “Imagine a world in which every single human being can freely share in the
> sum of all knowledge. That's our commitment.”
>
> p: +1 (415) 839-6885 x6832
> m: +1 (408) 480-8902
> e: tc...@wikimedia.org
> i: http://terrychay.com/
> w: http://meta.wikimedia.org/wiki/User:Tychay
> aim: terrychay
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] MW-Vagrant improvements at the Zürich Hackathon

2014-06-13 Thread Bryan Davis
Adam,

I wanted to avoid the complexity of a full multi version setup if we could,
but if there are more than a couple of roles that would benefit from such
features it would be possible. The easiest thing for your payment wiki may
be to follow the pattern of the wikimania_scholarships role and add your
own apache vhost and git checkout management. I'd be glad to help you work
on this if you'd like some assistance. We might be able to add a bit more
configurability to some of the existing puppet classes and defines to make
working with multiple checkouts of mw-core easier.

Bryan

On Friday, June 13, 2014, Adam Wight  wrote:

> Bryan and Chris,
> The multiwiki work is fantastic, a big thank you for pursuing this!  I
> tried to use your new module to provide a vagrant development environment
> for Fundraising's "payments" wiki [1], and I ran up against a large and
> very solid-looking wall that I think is worth mentioning.  We maintain a
> special release branch of MediaWiki for payments, with a bit of security
> hardening.  We cannot follow trunk development without carefully reading
> over the new features, and we need to develop against this target so that
> we catch version incompatibilities before deployment.
>
> I see that multiwiki encapsulates the various wikis by configuration only,
> and they all share the main codebase.  Do you have multiple checkouts of
> MediaWiki-core on your roadmap, or are we a fringe case?  I'd like to help
> support our development under vagrant, but this issue is a bit of a
> blocker.  Any advice would be appreciated.
>
> Thanks,
> Adam
>
> [1] https://gerrit.wikimedia.org/r/135326, production is
> https://payments.wikimedia.org
>
>
> On Wed, May 21, 2014 at 9:55 AM, Bryan Davis  > wrote:
>
> > On Fri, May 16, 2014 at 2:40 PM, Arthur Richards
> > > wrote:
> > >
> > > CentralAuth/Multiwiki:
> > > Bryan Davis, Chris Steipp, and Reedy spent a lot of time hacking on
> this,
> > > and we now have support for multiwiki/CentralAuth in Vagrant! There is
> > > still some cleanup work being done for the role to remove
> > kludge/hacks/etc
> > > (see https://gerrit.wikimedia.org/r/#/c/132691/).
> >
> > The CentralAuth role and the associated puppet config that allows
> > creation of multiple wikis as Apache virtual hosts on a single
> > MediaWiki-Vagrant virtual machine have been merged! Go forth and
> > debug/extend CentralAuth. :)
> >
> > I'd love to see additional roles created that use the multwiki::wiki
> > Puppet define to add interesting things for testing/debugging like RTL
> > wikis or other complex features such as WikiData that use a
> > collaboration between multiple wikis in the WMF production cluster.
> > If you're interested in working on something like this and get stuck
> > with the Puppet code needed or find shortcomings in the setup that
> > Chris and I developed I'd be glad to try and help work through the
> > issues.
> >
> > Bryan
> > --
> > Bryan Davis  Wikimedia Foundation >
> > [[m:User:BDavis_(WMF)]]  Sr Software EngineerBoise, ID USA
> > irc: bd808v:415.839.6885 x6855
> >
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org 
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org 
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l



-- 
Bryan Davis  Wikimedia Foundation
[[m:User:BDavis_(WMF)]]  Sr Software EngineerBoise, ID USA
irc: bd808v:415.839.6885 x6855
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] MW-Vagrant improvements at the Zürich Hackathon

2014-06-13 Thread Chris Steipp
Thanks Adam!

I'd like to hear more about your exact use case. Getting all of the
wikis to run out of a single codebase was a major part of the
challenge getting things setup. If you want a repo per wiki, that
should be a straightforward case of setting up another apache
virtualhost, or using a different subdirectory for each wiki. If you
want CentralAuth across them, that's pretty trivial too. Controlling
all that with puppet, I defer to bd808 on :)

But it sounds like you may have something else in your use case, let me know.

On Fri, Jun 13, 2014 at 4:09 PM, Adam Wight  wrote:
> Bryan and Chris,
> The multiwiki work is fantastic, a big thank you for pursuing this!  I
> tried to use your new module to provide a vagrant development environment
> for Fundraising's "payments" wiki [1], and I ran up against a large and
> very solid-looking wall that I think is worth mentioning.  We maintain a
> special release branch of MediaWiki for payments, with a bit of security
> hardening.  We cannot follow trunk development without carefully reading
> over the new features, and we need to develop against this target so that
> we catch version incompatibilities before deployment.
>
> I see that multiwiki encapsulates the various wikis by configuration only,
> and they all share the main codebase.  Do you have multiple checkouts of
> MediaWiki-core on your roadmap, or are we a fringe case?  I'd like to help
> support our development under vagrant, but this issue is a bit of a
> blocker.  Any advice would be appreciated.
>
> Thanks,
> Adam
>
> [1] https://gerrit.wikimedia.org/r/135326, production is
> https://payments.wikimedia.org
>
>
> On Wed, May 21, 2014 at 9:55 AM, Bryan Davis  wrote:
>
>> On Fri, May 16, 2014 at 2:40 PM, Arthur Richards
>>  wrote:
>> >
>> > CentralAuth/Multiwiki:
>> > Bryan Davis, Chris Steipp, and Reedy spent a lot of time hacking on this,
>> > and we now have support for multiwiki/CentralAuth in Vagrant! There is
>> > still some cleanup work being done for the role to remove
>> kludge/hacks/etc
>> > (see https://gerrit.wikimedia.org/r/#/c/132691/).
>>
>> The CentralAuth role and the associated puppet config that allows
>> creation of multiple wikis as Apache virtual hosts on a single
>> MediaWiki-Vagrant virtual machine have been merged! Go forth and
>> debug/extend CentralAuth. :)
>>
>> I'd love to see additional roles created that use the multwiki::wiki
>> Puppet define to add interesting things for testing/debugging like RTL
>> wikis or other complex features such as WikiData that use a
>> collaboration between multiple wikis in the WMF production cluster.
>> If you're interested in working on something like this and get stuck
>> with the Puppet code needed or find shortcomings in the setup that
>> Chris and I developed I'd be glad to try and help work through the
>> issues.
>>
>> Bryan
>> --
>> Bryan Davis  Wikimedia Foundation
>> [[m:User:BDavis_(WMF)]]  Sr Software EngineerBoise, ID USA
>> irc: bd808v:415.839.6885 x6855
>>
>> ___
>> Wikitech-l mailing list
>> Wikitech-l@lists.wikimedia.org
>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Dan Duvall
> would also work, but on my system just `vagrant status` takes >1s which is
> not horrible,
> but is noticeable when run  so often. For that reason i went for a check
> that could operate
> without booting ruby and loading all the vagrant code.

Great point.

We've been discussing further improvements we might make to
mediawiki-vagrant, with the primary focus being easier TDD workflows. I'd
love any other feedback on how to make things more efficient/less painful.
I'm hoping to fix `vagrant run-tests [extension]` and implement a new
`vagrant run-browser-tests` in the near future, so if anyone has special
use cases, let me know.


On Fri, Jun 13, 2014 at 3:27 PM, Erik Bernhardson <
ebernhard...@wikimedia.org> wrote:

> On Fri, Jun 13, 2014 at 3:04 PM, Dan Duvall  wrote:
>
> > >
> > > I use a horrible hack, essentially we run the tests from a pre-commit
> > hook
> > > with `make phpunit`, but we redefine make as:
> > >
> >
> > This might be naive of me, given I don't know specifically how you
> maintain
> > your hooks, but why not modify the pre-commit hook to conditionally
> execute
> > over the vagrant ssh tunnel instead of hijacking make?
> >
> > would probably work as well.  When i wrote this script i already had the
> make() stuff
> in my .bashrc so i could also use make from the command line. The
> pre-commit script[1]
> was written based off that, just looks at the commit to figure out which
> make commands to
> run, then calls make.
>
>  [1]
>
> https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/scripts/pre-review
>
> Also, instead of crawling parent directories for the Vagrantfile, you could
> > use `if (which vagrant && vagrant status) &> /dev/null; then ...`.
> >
> >
> would also work, but on my system just `vagrant status` takes >1s which is
> not horrible,
> but is noticeable when run  so often. For that reason i went for a check
> that could operate
> without booting ruby and loading all the vagrant code.
>
> Cheers,
> > Dan
> >
> > On Fri, Jun 13, 2014 at 2:35 PM, Erik Bernhardson <
> > ebernhard...@wikimedia.org> wrote:
> >
> > > On Fri, Jun 13, 2014 at 12:49 PM, Jon Robson 
> > wrote:
> > > >
> > > > I would like to run the phpunit tests from inside my host OS
> though...
> > > > I have pre-commit hook I rely on to run phpunit tests before
> > > > submitting... how can I do that now?
> > > >
> > > >
> > > I use a horrible hack, essentially we run the tests from a pre-commit
> > hook
> > > with `make phpunit`, but we redefine make as:
> > >
> > > make() {
> > > if is_vagrant; then
> > > vagrant ssh -- cd /vagrant/mediawiki/extensions/Flow '&&' sudo
> su
> > > www-data -c "'make $*'" || exit 1
> > > else
> > > /usr/bin/env make $* || exit 1
> > > fi
> > > }
> > >
> > > where the is_vagrant function duplicates the vagrant functionality of
> > > looking at all parent directories for a Vagrantfile
> > >
> > >
> > >
> > > > On Fri, Jun 13, 2014 at 11:45 AM, Dan Duvall 
> > > > wrote:
> > > > > Jon,
> > > > >
> > > > > From the looks of it, you may be invoking the tests from your host
> > OS,
> > > > not
> > > > > the Vagrant-managed VM. Trying logging in to the VM using `vagrant
> > ssh`
> > > > and
> > > > > executing the tests from there.
> > > > >
> > > > >   master x ~/git/vagrant $ vagrant ssh
> > > > >   ...
> > > > >   vagrant@mediawiki-vagrant:~$ cd /vagrant/mediawiki/tests/phpunit
> > > > >   vagrant@mediawiki-vagrant:/vagrant/mediawiki/tests/phpunit$ php
> > > > > phpunit.php
> > > > >
> > > > > If you still have problems with it, feel free to come grab me and
> we
> > > can
> > > > > troubleshoot it further.
> > > > >
> > > > > On a related note, I'll be working on improving the
> mediawiki-vagrant
> > > > > browser tests setup for MobileFrontend in the coming weeks. It'd be
> > > great
> > > > > to have you, or someone else on the mobile team, vet the
> > improvements.
> > > > >
> > > > > Cheers,
> > > > > Dan
> > > > >
> > > > > --
> > > > > Dan Duvall
> > > > > Automation Engineer
> > > > > Wikimedia Foundation 
> > > > > ___
> > > > > Wikitech-l mailing list
> > > > > Wikitech-l@lists.wikimedia.org
> > > > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > > >
> > > >
> > > >
> > > > --
> > > > Jon Robson
> > > > * http://jonrobson.me.uk
> > > > * https://www.facebook.com/jonrobson
> > > > * @rakugojon
> > > >
> > > > ___
> > > > Wikitech-l mailing list
> > > > Wikitech-l@lists.wikimedia.org
> > > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > > >
> > > ___
> > > Wikitech-l mailing list
> > > Wikitech-l@lists.wikimedia.org
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > >
> >
> >
> >
> > --
> > Dan Duvall
> > Automation Engineer
> > Wikimedia Foundation 
> > _

Re: [Wikitech-l] MW-Vagrant improvements at the Zürich Hackathon

2014-06-13 Thread Adam Wight
Bryan and Chris,
The multiwiki work is fantastic, a big thank you for pursuing this!  I
tried to use your new module to provide a vagrant development environment
for Fundraising's "payments" wiki [1], and I ran up against a large and
very solid-looking wall that I think is worth mentioning.  We maintain a
special release branch of MediaWiki for payments, with a bit of security
hardening.  We cannot follow trunk development without carefully reading
over the new features, and we need to develop against this target so that
we catch version incompatibilities before deployment.

I see that multiwiki encapsulates the various wikis by configuration only,
and they all share the main codebase.  Do you have multiple checkouts of
MediaWiki-core on your roadmap, or are we a fringe case?  I'd like to help
support our development under vagrant, but this issue is a bit of a
blocker.  Any advice would be appreciated.

Thanks,
Adam

[1] https://gerrit.wikimedia.org/r/135326, production is
https://payments.wikimedia.org


On Wed, May 21, 2014 at 9:55 AM, Bryan Davis  wrote:

> On Fri, May 16, 2014 at 2:40 PM, Arthur Richards
>  wrote:
> >
> > CentralAuth/Multiwiki:
> > Bryan Davis, Chris Steipp, and Reedy spent a lot of time hacking on this,
> > and we now have support for multiwiki/CentralAuth in Vagrant! There is
> > still some cleanup work being done for the role to remove
> kludge/hacks/etc
> > (see https://gerrit.wikimedia.org/r/#/c/132691/).
>
> The CentralAuth role and the associated puppet config that allows
> creation of multiple wikis as Apache virtual hosts on a single
> MediaWiki-Vagrant virtual machine have been merged! Go forth and
> debug/extend CentralAuth. :)
>
> I'd love to see additional roles created that use the multwiki::wiki
> Puppet define to add interesting things for testing/debugging like RTL
> wikis or other complex features such as WikiData that use a
> collaboration between multiple wikis in the WMF production cluster.
> If you're interested in working on something like this and get stuck
> with the Puppet code needed or find shortcomings in the setup that
> Chris and I developed I'd be glad to try and help work through the
> issues.
>
> Bryan
> --
> Bryan Davis  Wikimedia Foundation
> [[m:User:BDavis_(WMF)]]  Sr Software EngineerBoise, ID USA
> irc: bd808v:415.839.6885 x6855
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Proposal for release management

2014-06-13 Thread Markus Glaser
Hello everyone,

Mark Hershberger and I submitted a proposal for the next year of release 
management:
https://www.mediawiki.org/wiki/Release_Management_RFP/2014/Mark_y_Markus_LLC

In the upcoming year, we want to focus on creating a user group as a central 
hub for all third party related issues with MediaWiki.

We are happy to hear your comments, feedback and ideas.

Best,
Markus
(mglaser)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Roadmap and deployment highlights - week of June 16th

2014-06-13 Thread Greg Grossmeier
Hello and welcome to the latest edition of the WMF Engineering Roadmap
and Deployment update.

The full log of planned deployments next week can be found at:


A quick list of notable items...


== Tuesday ==

* MediaWiki deploy
** group1 to 1.24wmf9: All non-Wikipedia sites (Wiktionary, Wikisource,
   Wikinews, Wikibooks, Wikiquote, Wikiversity, and a few other sites)
   ** 

* Mobile view
** Tablets will be sent to the mobile version of the project
   websites. Previously they were sent to the desktop version. There is
   a blog post and central notice drafted and ready to go out day of.


* CentralAuth Global Rename Tool
** CentralAuth will now provide an interface to rename global users.
** More info at: 



== Thursday ==

* MediaWiki deploy
** group2 to 1.24wmf9 (all Wikipedias)
** group0 to 1.24wmf10 (test/test2/testwikidata/mediawiki)

* MediaViewer
** Will be enabled on *all* wikis
** 




Thanks and as always, questions and comments welcome,

Greg

-- 
| Greg GrossmeierGPG: B2FA 27B1 F7EB D327 6B8E |
| identi.ca: @gregA18D 1138 8E47 FAC8 1C7D |


signature.asc
Description: Digital signature
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Erik Bernhardson
On Fri, Jun 13, 2014 at 3:27 PM, Erik Bernhardson <
ebernhard...@wikimedia.org> wrote:

>  [1]
> https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/scripts/pre-review
>
should have been
https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/scripts/pre-commit
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Erik Bernhardson
On Fri, Jun 13, 2014 at 3:04 PM, Dan Duvall  wrote:

> >
> > I use a horrible hack, essentially we run the tests from a pre-commit
> hook
> > with `make phpunit`, but we redefine make as:
> >
>
> This might be naive of me, given I don't know specifically how you maintain
> your hooks, but why not modify the pre-commit hook to conditionally execute
> over the vagrant ssh tunnel instead of hijacking make?
>
> would probably work as well.  When i wrote this script i already had the
make() stuff
in my .bashrc so i could also use make from the command line. The
pre-commit script[1]
was written based off that, just looks at the commit to figure out which
make commands to
run, then calls make.

 [1]
https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/scripts/pre-review

Also, instead of crawling parent directories for the Vagrantfile, you could
> use `if (which vagrant && vagrant status) &> /dev/null; then ...`.
>
>
would also work, but on my system just `vagrant status` takes >1s which is
not horrible,
but is noticeable when run  so often. For that reason i went for a check
that could operate
without booting ruby and loading all the vagrant code.

Cheers,
> Dan
>
> On Fri, Jun 13, 2014 at 2:35 PM, Erik Bernhardson <
> ebernhard...@wikimedia.org> wrote:
>
> > On Fri, Jun 13, 2014 at 12:49 PM, Jon Robson 
> wrote:
> > >
> > > I would like to run the phpunit tests from inside my host OS though...
> > > I have pre-commit hook I rely on to run phpunit tests before
> > > submitting... how can I do that now?
> > >
> > >
> > I use a horrible hack, essentially we run the tests from a pre-commit
> hook
> > with `make phpunit`, but we redefine make as:
> >
> > make() {
> > if is_vagrant; then
> > vagrant ssh -- cd /vagrant/mediawiki/extensions/Flow '&&' sudo su
> > www-data -c "'make $*'" || exit 1
> > else
> > /usr/bin/env make $* || exit 1
> > fi
> > }
> >
> > where the is_vagrant function duplicates the vagrant functionality of
> > looking at all parent directories for a Vagrantfile
> >
> >
> >
> > > On Fri, Jun 13, 2014 at 11:45 AM, Dan Duvall 
> > > wrote:
> > > > Jon,
> > > >
> > > > From the looks of it, you may be invoking the tests from your host
> OS,
> > > not
> > > > the Vagrant-managed VM. Trying logging in to the VM using `vagrant
> ssh`
> > > and
> > > > executing the tests from there.
> > > >
> > > >   master x ~/git/vagrant $ vagrant ssh
> > > >   ...
> > > >   vagrant@mediawiki-vagrant:~$ cd /vagrant/mediawiki/tests/phpunit
> > > >   vagrant@mediawiki-vagrant:/vagrant/mediawiki/tests/phpunit$ php
> > > > phpunit.php
> > > >
> > > > If you still have problems with it, feel free to come grab me and we
> > can
> > > > troubleshoot it further.
> > > >
> > > > On a related note, I'll be working on improving the mediawiki-vagrant
> > > > browser tests setup for MobileFrontend in the coming weeks. It'd be
> > great
> > > > to have you, or someone else on the mobile team, vet the
> improvements.
> > > >
> > > > Cheers,
> > > > Dan
> > > >
> > > > --
> > > > Dan Duvall
> > > > Automation Engineer
> > > > Wikimedia Foundation 
> > > > ___
> > > > Wikitech-l mailing list
> > > > Wikitech-l@lists.wikimedia.org
> > > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > >
> > >
> > >
> > > --
> > > Jon Robson
> > > * http://jonrobson.me.uk
> > > * https://www.facebook.com/jonrobson
> > > * @rakugojon
> > >
> > > ___
> > > Wikitech-l mailing list
> > > Wikitech-l@lists.wikimedia.org
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > >
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >
>
>
>
> --
> Dan Duvall
> Automation Engineer
> Wikimedia Foundation 
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Dan Duvall
>
> I use a horrible hack, essentially we run the tests from a pre-commit hook
> with `make phpunit`, but we redefine make as:
>

This might be naive of me, given I don't know specifically how you maintain
your hooks, but why not modify the pre-commit hook to conditionally execute
over the vagrant ssh tunnel instead of hijacking make?

Also, instead of crawling parent directories for the Vagrantfile, you could
use `if (which vagrant && vagrant status) &> /dev/null; then ...`.

Cheers,
Dan

On Fri, Jun 13, 2014 at 2:35 PM, Erik Bernhardson <
ebernhard...@wikimedia.org> wrote:

> On Fri, Jun 13, 2014 at 12:49 PM, Jon Robson  wrote:
> >
> > I would like to run the phpunit tests from inside my host OS though...
> > I have pre-commit hook I rely on to run phpunit tests before
> > submitting... how can I do that now?
> >
> >
> I use a horrible hack, essentially we run the tests from a pre-commit hook
> with `make phpunit`, but we redefine make as:
>
> make() {
> if is_vagrant; then
> vagrant ssh -- cd /vagrant/mediawiki/extensions/Flow '&&' sudo su
> www-data -c "'make $*'" || exit 1
> else
> /usr/bin/env make $* || exit 1
> fi
> }
>
> where the is_vagrant function duplicates the vagrant functionality of
> looking at all parent directories for a Vagrantfile
>
>
>
> > On Fri, Jun 13, 2014 at 11:45 AM, Dan Duvall 
> > wrote:
> > > Jon,
> > >
> > > From the looks of it, you may be invoking the tests from your host OS,
> > not
> > > the Vagrant-managed VM. Trying logging in to the VM using `vagrant ssh`
> > and
> > > executing the tests from there.
> > >
> > >   master x ~/git/vagrant $ vagrant ssh
> > >   ...
> > >   vagrant@mediawiki-vagrant:~$ cd /vagrant/mediawiki/tests/phpunit
> > >   vagrant@mediawiki-vagrant:/vagrant/mediawiki/tests/phpunit$ php
> > > phpunit.php
> > >
> > > If you still have problems with it, feel free to come grab me and we
> can
> > > troubleshoot it further.
> > >
> > > On a related note, I'll be working on improving the mediawiki-vagrant
> > > browser tests setup for MobileFrontend in the coming weeks. It'd be
> great
> > > to have you, or someone else on the mobile team, vet the improvements.
> > >
> > > Cheers,
> > > Dan
> > >
> > > --
> > > Dan Duvall
> > > Automation Engineer
> > > Wikimedia Foundation 
> > > ___
> > > Wikitech-l mailing list
> > > Wikitech-l@lists.wikimedia.org
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >
> >
> >
> > --
> > Jon Robson
> > * http://jonrobson.me.uk
> > * https://www.facebook.com/jonrobson
> > * @rakugojon
> >
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>



-- 
Dan Duvall
Automation Engineer
Wikimedia Foundation 
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] How to Keep Track of Template Values Across a Wikipedia?

2014-06-13 Thread Maximilian Klein
Hello All,

I'm working on the Open-Access Signalling Project[1], which aims to signal
and badge when a reference in Wikipedia is Open Access source. I'm writing
the bot at the moment to do this, and I'm encountering a question - how do
I keep track of the values of the template {{Cite doi | doi=value}}, in as
close to real-time as possible?

The most efficient approach I can come up with is to query the SQL servers
on Labs in constant loop, returning the results of "What transcludes {{Cite
doi}}" and seeing if the last_edited timestamp is newer than previous? If
the last_edit is newer, then get the content of the page and see if the
{{Cite_doi}} value has changed, checking against a local database.

This seems horribly inefficient still. Is there a hook to know when a
template on a page has been edited, rather than having to check every time
the page has been edited?

Thanks in advance,

Max Klein
‽ http://notconfusing.com/

[1]
https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Open_Access/Signalling_OA-ness
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Erik Bernhardson
On Fri, Jun 13, 2014 at 12:49 PM, Jon Robson  wrote:
>
> I would like to run the phpunit tests from inside my host OS though...
> I have pre-commit hook I rely on to run phpunit tests before
> submitting... how can I do that now?
>
>
I use a horrible hack, essentially we run the tests from a pre-commit hook
with `make phpunit`, but we redefine make as:

make() {
if is_vagrant; then
vagrant ssh -- cd /vagrant/mediawiki/extensions/Flow '&&' sudo su
www-data -c "'make $*'" || exit 1
else
/usr/bin/env make $* || exit 1
fi
}

where the is_vagrant function duplicates the vagrant functionality of
looking at all parent directories for a Vagrantfile



> On Fri, Jun 13, 2014 at 11:45 AM, Dan Duvall 
> wrote:
> > Jon,
> >
> > From the looks of it, you may be invoking the tests from your host OS,
> not
> > the Vagrant-managed VM. Trying logging in to the VM using `vagrant ssh`
> and
> > executing the tests from there.
> >
> >   master x ~/git/vagrant $ vagrant ssh
> >   ...
> >   vagrant@mediawiki-vagrant:~$ cd /vagrant/mediawiki/tests/phpunit
> >   vagrant@mediawiki-vagrant:/vagrant/mediawiki/tests/phpunit$ php
> > phpunit.php
> >
> > If you still have problems with it, feel free to come grab me and we can
> > troubleshoot it further.
> >
> > On a related note, I'll be working on improving the mediawiki-vagrant
> > browser tests setup for MobileFrontend in the coming weeks. It'd be great
> > to have you, or someone else on the mobile team, vet the improvements.
> >
> > Cheers,
> > Dan
> >
> > --
> > Dan Duvall
> > Automation Engineer
> > Wikimedia Foundation 
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
>
>
> --
> Jon Robson
> * http://jonrobson.me.uk
> * https://www.facebook.com/jonrobson
> * @rakugojon
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Announcement: Elliot Eggleston joins Wikimedia as Features Engineer

2014-06-13 Thread Terry Chay
Hello everyone,

It’s with great pleasure that I’m announcing that Elliott Eggleston will be 
joining the Wikimedia Foundation as a Features Engineer in Fundraising-Tech.

Before joining us, Eliott was a senior software engineer at SAI Global[1], and 
before that at Integrity Interactive (which was bought by SAI Global), which 
means he’s been working diligently for seven years in enterprise software 
development. Surprisingly, we didn’t hold this too much against him.[2] ;-)

His first official day is Monday June 16th where he will be in the office. He 
is going to work with the Fundraising Tech team under Katie Horn and along with 
Adam Wight and Sherah Smith on whatever voodoo there manages to pay our 
salaries (and adds to secret account in the Caymans I had them set up[3]), as 
Matthew Walker transitions to Services[4] this year.

He received his Bachelor’s in Computer Science from Columbia in 2004 and spends 
his down time writing an Android application[5], making a website to map his 
music listening-bike route, playing Scrabble, and taking 3-d pictures. He lives 
in Somerville, Massachusetts.

Oh yeah, he’s also a childhood friend of Adam Wight. (Ask them to serenade you 
with the pi song they invented as kids.) I don’t know whether I should be 
excited to have a person whose disciplined work and even temper can talk Adam 
back from the ledge, or to be worried that they might tag team another thread 
on WMF-all demanding the Foundation to be a co-op. 

Please join me in a welcoming Elliott to the Wikimedia Foundation. :-)

Take care,
Terry

P.S. In keeping with Jared’s demand of a picture to accompany every new hire 
announcement, here is one: 
https://abs.twimg.com/sticky/default_profile_images/default_profile_3_200x200.png[5]

[1] http://www.saiglobal.com

[2] We only made him do four coding tests during the hiring process.

[3] As a hedge if all my wikishares don't vest.

[4] 
https://www.mediawiki.org/wiki/Wikimedia_Engineering/Service_and_REST_API_team

[5] Erik Möller is of the opinion working a Java Android app for manipulating 
3D fractals with a web export that works in latest versions of Firefox on 
mobile devices with WebGL is not the kind of thing you do for fun if you don’t 
enjoy complex challenges. I am of the opinion that Java PERIOD itself is not 
the kind of thing you do for fun PERIOD.

[6] Not sure this is any better: https://github.com/ejegg

terry chay  최태리
Director of Features Engineering
Wikimedia Foundation
“Imagine a world in which every single human being can freely share in the sum 
of all knowledge. That's our commitment.”

p: +1 (415) 839-6885 x6832
m: +1 (408) 480-8902
e: tc...@wikimedia.org
i: http://terrychay.com/
w: http://meta.wikimedia.org/wiki/User:Tychay
aim: terrychay

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Gergo Tisza
On Fri, Jun 13, 2014 at 1:13 PM, Dan Duvall  wrote:

> I would like to run the phpunit tests from inside my host OS though...
> > I have pre-commit hook I rely on to run phpunit tests before
> > submitting... how can I do that now?
> >
>
> We might be able to get that working by ensuring the includes added by
> mediawiki-vagrant use relative paths—in fact, after a second look, this
> should be considered a bug in mediawiki-vagrant. With that usage, however,
> you won't benefit from any of the automatic provisioning that Vagrant
> provides; you'll have to ensure you have all the right dependencies set up
> in your host OS.
>
> A workaround that I might suggest trying first would be to make your
> commits from within the VM, the big downside here being that you'll have to
> duplicate your user-level git configuration from your host. Another
> workaround (albeit more complicated) might be to configure your pre-commit
> hook to execute the tests on the VM over ssh.
>

The super-easy workaround is to just create a /vagrant symlink on the host
OS, pointing to the directory hosting the virtual machine.
Running the tests in a different environment than the one where the system
itself is running seems like a bad idea, though.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Dan Duvall
Hey Jon,

I would like to run the phpunit tests from inside my host OS though...
> I have pre-commit hook I rely on to run phpunit tests before
> submitting... how can I do that now?
>

We might be able to get that working by ensuring the includes added by
mediawiki-vagrant use relative paths—in fact, after a second look, this
should be considered a bug in mediawiki-vagrant. With that usage, however,
you won't benefit from any of the automatic provisioning that Vagrant
provides; you'll have to ensure you have all the right dependencies set up
in your host OS.

A workaround that I might suggest trying first would be to make your
commits from within the VM, the big downside here being that you'll have to
duplicate your user-level git configuration from your host. Another
workaround (albeit more complicated) might be to configure your pre-commit
hook to execute the tests on the VM over ssh.

Let me know if you'd like to try either of the two suggestions, and I can
help you out. Meanwhile, I'll see about fixing the include issue.

Cheers,
Dan



On Fri, Jun 13, 2014 at 12:49 PM, Jon Robson  wrote:

> Hey Dan,
> Yeh that was the problem.
>
> I would like to run the phpunit tests from inside my host OS though...
> I have pre-commit hook I rely on to run phpunit tests before
> submitting... how can I do that now?
>
> On Fri, Jun 13, 2014 at 11:45 AM, Dan Duvall 
> wrote:
> > Jon,
> >
> > From the looks of it, you may be invoking the tests from your host OS,
> not
> > the Vagrant-managed VM. Trying logging in to the VM using `vagrant ssh`
> and
> > executing the tests from there.
> >
> >   master x ~/git/vagrant $ vagrant ssh
> >   ...
> >   vagrant@mediawiki-vagrant:~$ cd /vagrant/mediawiki/tests/phpunit
> >   vagrant@mediawiki-vagrant:/vagrant/mediawiki/tests/phpunit$ php
> > phpunit.php
> >
> > If you still have problems with it, feel free to come grab me and we can
> > troubleshoot it further.
> >
> > On a related note, I'll be working on improving the mediawiki-vagrant
> > browser tests setup for MobileFrontend in the coming weeks. It'd be great
> > to have you, or someone else on the mobile team, vet the improvements.
> >
> > Cheers,
> > Dan
> >
> > --
> > Dan Duvall
> > Automation Engineer
> > Wikimedia Foundation 
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
>
>
> --
> Jon Robson
> * http://jonrobson.me.uk
> * https://www.facebook.com/jonrobson
> * @rakugojon
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>



-- 
Dan Duvall
Automation Engineer
Wikimedia Foundation 
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Jon Robson
Hey Dan,
Yeh that was the problem.

I would like to run the phpunit tests from inside my host OS though...
I have pre-commit hook I rely on to run phpunit tests before
submitting... how can I do that now?

On Fri, Jun 13, 2014 at 11:45 AM, Dan Duvall  wrote:
> Jon,
>
> From the looks of it, you may be invoking the tests from your host OS, not
> the Vagrant-managed VM. Trying logging in to the VM using `vagrant ssh` and
> executing the tests from there.
>
>   master x ~/git/vagrant $ vagrant ssh
>   ...
>   vagrant@mediawiki-vagrant:~$ cd /vagrant/mediawiki/tests/phpunit
>   vagrant@mediawiki-vagrant:/vagrant/mediawiki/tests/phpunit$ php
> phpunit.php
>
> If you still have problems with it, feel free to come grab me and we can
> troubleshoot it further.
>
> On a related note, I'll be working on improving the mediawiki-vagrant
> browser tests setup for MobileFrontend in the coming weeks. It'd be great
> to have you, or someone else on the mobile team, vet the improvements.
>
> Cheers,
> Dan
>
> --
> Dan Duvall
> Automation Engineer
> Wikimedia Foundation 
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l



-- 
Jon Robson
* http://jonrobson.me.uk
* https://www.facebook.com/jonrobson
* @rakugojon

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Dan Duvall
Yes, sorry Chris. Emphasis on my absent 'we'.

To clarify further: Chris is doing most of the browser-test work. I'm
working on improving the mediawiki-vagrant environment. Teamwork makes
dream work, as they say.

Cheers,
Dan


On Fri, Jun 13, 2014 at 11:55 AM, Chris McMahon 
wrote:

> On Fri, Jun 13, 2014 at 11:45 AM, Dan Duvall 
> wrote:
>
> >
> > On a related note, I'll be working on improving the mediawiki-vagrant
> > browser tests setup for MobileFrontend in the coming weeks. It'd be great
> > to have you, or someone else on the mobile team, vet the improvements.
>
>
> Dan and I (mostly Dan!) have all the browser tests for VisualEditor now
> running green for Firefox on a Vagrant instance under the visualeditor
> role.  The mobilefrontend role is next for browser test support.
>
> Other suggestions for improvements to vagrant are welcome...
>
> -Chris
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l




-- 
Dan Duvall
Automation Engineer
Wikimedia Foundation 
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Chris McMahon
On Fri, Jun 13, 2014 at 11:45 AM, Dan Duvall  wrote:

>
> On a related note, I'll be working on improving the mediawiki-vagrant
> browser tests setup for MobileFrontend in the coming weeks. It'd be great
> to have you, or someone else on the mobile team, vet the improvements.


Dan and I (mostly Dan!) have all the browser tests for VisualEditor now
running green for Firefox on a Vagrant instance under the visualeditor
role.  The mobilefrontend role is next for browser test support.

Other suggestions for improvements to vagrant are welcome...

-Chris
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Dan Duvall
Jon,

From the looks of it, you may be invoking the tests from your host OS, not
the Vagrant-managed VM. Trying logging in to the VM using `vagrant ssh` and
executing the tests from there.

  master x ~/git/vagrant $ vagrant ssh
  ...
  vagrant@mediawiki-vagrant:~$ cd /vagrant/mediawiki/tests/phpunit
  vagrant@mediawiki-vagrant:/vagrant/mediawiki/tests/phpunit$ php
phpunit.php

If you still have problems with it, feel free to come grab me and we can
troubleshoot it further.

On a related note, I'll be working on improving the mediawiki-vagrant
browser tests setup for MobileFrontend in the coming weeks. It'd be great
to have you, or someone else on the mobile team, vet the improvements.

Cheers,
Dan

-- 
Dan Duvall
Automation Engineer
Wikimedia Foundation 
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Structured logging changesets that need review

2014-06-13 Thread Sumana Harihareswara
Changesets that could still use your attention:
* Add a PSR-3 based logging interface
https://gerrit.wikimedia.org/r/#/c/119940/
* Enable MWLogger logging for wfLogProfilingData
https://gerrit.wikimedia.org/r/#/c/119942/

Sumana Harihareswara
Senior Technical Writer
Wikimedia Foundation


On Fri, Apr 11, 2014 at 11:38 AM, Bryan Davis  wrote:

> On Fri, Mar 14, 2014 at 4:07 PM, Bryan Davis  wrote:
> > The structured logging RFC [0] will be up for discussion again next
> > Wednesday [1]. There is a strawman implementation in gerrit [2] that
> > is likely to be the focus of discussion unless there are other issues
> > that the reviewers find more pressing.
> >
> > At this point the most controversial aspect of my proposed
> > implementation seems to be importing third-party libraries into
> > mw-core and/or the use of composer to manage that activity. I would
> > welcome discussion of alternatives or consensus that this is a
> > reasonable approach for the immediate future that should be revisited
> > if and when a better idea is found for the general problem.
> >
> > [0]:
> https://www.mediawiki.org/wiki/Requests_for_comment/Structured_logging
> > [1]:
> https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-03-19
> > [2]: https://gerrit.wikimedia.org/r/#/c/112699/
>
> The outcome of the discussion on this was approval by Tim of the
> general concept of using Composer to manage importing libraries into
> MediaWiki-Core. I took that as incentive to split the monolithic
> proof-of-concept patch into four smaller logical for review and
> approval:
>
> * Gerrit change 119939 Add Composer managed libraries [3]
>
> Import Psr\Log and Monolog libraries to MW-Core in a new "libs"
> directory which is managed using Composer. The includes/AutoLoader.php
> script has been modified to require the lib/autoload.php class
> autoloader script generated by Composer.
>
> * Gerrit change 119940 Add a PSR-3 based logging interface [4]
>
> The MWLogger class is actually a thin wrapper around any PSR-3
> LoggerInterface implementation. Named MWLogger instances can be
> obtained from the MWLogger::getInstance() static method. MWLogger
> expects a class implementing the MWLoggerSpi interface to act as a
> factory for new MWLogger instances. A concrete MWLoggerSpi
> implementation using the Monolog library is also provided.
>
> * Gerrit change 119941 Enable MWLogger logging for legacy logging methods
> [5]
>
> Introduces the $wgUseMWLoggerForLegacyFunctions that enables the use
> of the MWLogger PSR-3 logger for legacy global logging functions. When
> enabled wfDebug, wfDebugLog and wfLogDBError will route their log
> messages to MWLogger instances.
>
> * Gerrit change 119942 Enable MWLogger logging for wfLogProfilingData [6]
>
> Output structured profiling report data from wfLogProfilingData when
> $wgUseMWLoggerForLegacyFunctions is enabled.
>
> I got some great review feedback from Jeroen on the first patch [3].
> We were able to iterate to get to a point where he was satisfied with
> the technical implementation of the composer.json and gave it a +1.
> The second patch [4] got some comments from Tyler and Timo which I
> have tried to respond to. Tyler caught a small formatting problem in
> the third patch [5] that has been corrected. I have gotten no feedback
> at all on the final patch [6].
>
> I'd really like to see this work merged so that I can continue to
> build on it to improve the error and debug logging capabilities of
> MediaWiki. The net result if this was all merged today would be some
> classes that could be used if a deployment modified it's
> LocalSettings.php configuration to enable them. Nothing should break
> anywhere in the default case. I know that most people don't find
> logging to be sexy stuff to think about and that I'm weird for being
> obsessed with this sort of thing. I'm looking for advice from the
> people on this mailing list on how to find someone to work with me to
> finish the review of at least the first 3 patches and give +2 to get
> this initiative moving again.
>
> [3]: https://gerrit.wikimedia.org/r/119939
> [4]: https://gerrit.wikimedia.org/r/119940
> [5]: https://gerrit.wikimedia.org/r/119941
> [6]: https://gerrit.wikimedia.org/r/119942
>
> Bryan
> --
> Bryan Davis  Wikimedia Foundation
> [[m:User:BDavis_(WMF)]]  Sr Software EngineerBoise, ID USA
> irc: bd808v:415.839.6885 x6855
>
> 
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Chris Steipp
On Fri, Jun 13, 2014 at 10:44 AM, Jon Robson  wrote:
> Has anyone had success with this...?
>
> This is what happens when I try to run:
>
> master x ~/git/vagrant/mediawiki/tests/phpunit $ php phpunit.php
>
> Warning: require_once(/vagrant/LocalSettings.php): failed to open
> stream: No such file or directory in
> /Users/jrobson/git/vagrant/mediawiki/LocalSettings.php on line 130
>
> Fatal error: require_once(): Failed opening required
> '/vagrant/LocalSettings.php' (include_path='.:') in
> /Users/jrobson/git/vagrant/mediawiki/LocalSettings.php on line 130

I use it frequently, and iirc the setup was nearly exactly what the
instruction on mediawiki said.

One other issue I did hit was that running even the databaseless tests
on a default vagrant setup ran out of memory. I upped my vagrant
config to use 2GB, and things work fine.


csteipp@herou:~/tmp/vagrant2> cat Vagrantfile-extra.rb
#Vagrant.configure('2') do |config|
#config.vm.synced_folder './browsertests', '/srv/browsertests',
#id: 'vagrant-browsertests',
#owner: 'vagrant',
#group: 'vagrant'
#end

Vagrant.configure('2') do |config|
config.vm.provider :virtualbox do |vb|
# See http://www.virtualbox.org/manual/ch08.html for additional options.
vb.customize ['modifyvm', :id, '--memory', '2048']
vb.customize ['modifyvm', :id, '--cpus', '2']
vb.customize ['modifyvm', :id, "--cpuexecutioncap", "90"]
end
end



> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Nikolas Everett
I _thought_ someone was working on getting it to just work.  For now,
though, if you start with a clean machine you can run the commands here:
https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Installing_PHPUnit#Using_PEAR
to get it installed.  Make sure the use the pear commands because it'll get
you phpunit 3.7.X.  phpunit 4.0 doesn't work for us mediawiki.  Anyway,
after following the pear commands inside your vagrant VM phpunit should
work.

Nik


On Fri, Jun 13, 2014 at 1:44 PM, Jon Robson  wrote:

> Has anyone had success with this...?
>
> This is what happens when I try to run:
>
> master x ~/git/vagrant/mediawiki/tests/phpunit $ php phpunit.php
>
> Warning: require_once(/vagrant/LocalSettings.php): failed to open
> stream: No such file or directory in
> /Users/jrobson/git/vagrant/mediawiki/LocalSettings.php on line 130
>
> Fatal error: require_once(): Failed opening required
> '/vagrant/LocalSettings.php' (include_path='.:') in
> /Users/jrobson/git/vagrant/mediawiki/LocalSettings.php on line 130
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Getting phpunit working with Vagrant

2014-06-13 Thread Jon Robson
Has anyone had success with this...?

This is what happens when I try to run:

master x ~/git/vagrant/mediawiki/tests/phpunit $ php phpunit.php

Warning: require_once(/vagrant/LocalSettings.php): failed to open
stream: No such file or directory in
/Users/jrobson/git/vagrant/mediawiki/LocalSettings.php on line 130

Fatal error: require_once(): Failed opening required
'/vagrant/LocalSettings.php' (include_path='.:') in
/Users/jrobson/git/vagrant/mediawiki/LocalSettings.php on line 130

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Security guidelines: need specific examples

2014-06-13 Thread Sumana Harihareswara
Thanks for the chat just now
https://www.mediawiki.org/wiki/Architecture_meetings/Security_guidelines_discussion_2014-06-13
- summary and full logs are up. Chris now has several TODOs to improve
the draft, including maybe splitting out some details onto other pages.

For each of the security principles, we need good and bad past examples
of what Wikimedia/MediaWiki has done. Where we've succeeded, where we've
fallen down. Chris has assembled several, but:

* we still need a past example of how Wikimedia (doesn't HAVE to be
MediaWiki specifically) screwed up on "Secure (fail-safe) defaults" --
hopefully we've since fixed it!
* we still need a positive example of where we've created a simple
design, implementation, or interface whose simplicity guards against
future errors or attacks. Suggestion: "HTMLForm, while incredibly
complex, has a relatively simple interface for security, i.e., built-in
CSRF tokens and validation."

If you can, comment on the talkpage:
https://www.mediawiki.org/wiki/Talk:Security_for_developers/Architecture
-- 
Sumana Harihareswara
Senior Technical Writer
Wikimedia Foundation

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Tell my favorite conference about your Wikimedia tech

2014-06-13 Thread Luis Villa
On Fri, Jun 13, 2014 at 7:07 AM, Tyler Romeo  wrote:

> I’ve always wanted to submit a cool MediaWiki talk to these conferences,
> but I have no idea what I’d talk about (or whether I’m even experienced
> enough to talk about anything at a conference).
>

The answer to that second part is "yes" :) LCA is not TED :) Background on
their speaker selection process and what makes for a good submission
(useful for any conference, not just LCA):
http://opensource.com/life/14/1/get-your-conference-talk-submission-accepted


> Are there any guidelines on what would make a good talk?
>

http://speaking.io/plan/an-idea/ ?

[All of speaking.io is useful.]

HTH-
Luis
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Security guidelines Q&A in 10 min

2014-06-13 Thread Sumana Harihareswara
In 10 minutes we'll be discussing the security guidelines
https://www.mediawiki.org/wiki/Security_for_developers/Architecture that
Chris Steipp is working on. Feel free to bring your questions ("what is
a data flow diagram?" "wait, why are we protecting that?").

https://www.mediawiki.org/wiki/Architecture_meetings/Security_guidelines_discussion_2014-06-13

See you in #wikimedia-office on Freenode IRC.
-- 
Sumana Harihareswara
Senior Technical Writer
Wikimedia Foundation

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Tell my favorite conference about your Wikimedia tech

2014-06-13 Thread Tyler Romeo
I’ve always wanted to submit a cool MediaWiki talk to these conferences, but I 
have no idea what I’d talk about (or whether I’m even experienced enough to 
talk about anything at a conference). Are there any guidelines on what would 
make a good talk?
-- 
Tyler Romeo
0xC86B42DF

From: Luis Villa lvi...@wikimedia.org
Reply: Wikimedia developers wikitech-l@lists.wikimedia.org
Date: June 13, 2014 at 10:05:14
To: Wikimedia developers wikitech-l@lists.wikimedia.org
Subject:  Re: [Wikitech-l] Tell my favorite conference about your Wikimedia 
tech  

On Thu, Jun 12, 2014 at 9:56 PM, Roan Kattouw 
wrote:

> On Jun 12, 2014 4:08 PM, "Luis Villa"  wrote:
> > I got a balloon ride the year I spoke. It was trumped the next year by a
> > helicopter ride. Definitely an amazing trip.
> >
> Wow, when was that?! I got no such thing :)
>
> In 2012 they did take all the speakers a show (and dinner) at a staged Gold
> Rush town (which is the *the* tourist attraction in Ballarat), in 2014 it
> was just a dinner at the local marina.
>

'05 for balloons over lovely Canberra, '06 for helicopters over Sydney
harbor. (I only went in '05, heard about '06 later.) Maybe they've toned it
down a little, but still a great conference!

Luis
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

signature.asc
Description: Message signed with OpenPGP using AMPGpg
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Tell my favorite conference about your Wikimedia tech

2014-06-13 Thread Luis Villa
On Thu, Jun 12, 2014 at 9:56 PM, Roan Kattouw 
wrote:

> On Jun 12, 2014 4:08 PM, "Luis Villa"  wrote:
> > I got a balloon ride the year I spoke. It was trumped the next year by a
> > helicopter ride. Definitely an amazing trip.
> >
> Wow, when was that?! I got no such thing :)
>
> In 2012 they did take all the speakers a show (and dinner) at a staged Gold
> Rush town (which is the *the* tourist attraction in Ballarat), in 2014 it
> was just a dinner at the local marina.
>

'05 for balloons over lovely Canberra, '06 for helicopters over Sydney
harbor. (I only went in '05, heard about '06 later.) Maybe they've toned it
down a little, but still a great conference!

Luis
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Second round of the MediaWiki Release Management RFP

2014-06-13 Thread Legoktm
On 5/27/14, 11:13 AM, Greg Grossmeier wrote:
> The deadline for proposals is June 13.

I only noticed this now, but [2] says there will be a "!vote" that ends
on June 15th. Is there a reason why there's only 2 days between the
proposal deadline and the voting closing?

> [2] 
> https://commons.wikimedia.org/wiki/File:MediaWiki_Release_Request_For_Proposals_2014.pdf

-- Legoktm

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l