Re: [Wikitech-l] MediaWiki Security and Maintenance Releases: 1.19.19, 1.22.11 and 1.23.4
On 24 September 2014 23:28, Markus Glaser gla...@hallowelt.biz wrote: Patch to previous version (1.19.18): https://releases.wikimedia.org/mediawiki/1.19/mediawiki-1.19.19.patch.gz So I downloaded and applied this. gunzipped it, got this: -rw-r--r-- 1 root root 13663 Sep 24 21:35 mediawiki-1.19.19.patch Applied it, and got this (on two different wikis): # patch -p1 --dry-run mediawiki-1.19.19.patch patching file includes/DefaultSettings.php patching file includes/Sanitizer.php patching file includes/upload/UploadBase.php patching file includes/XmlTypeCheck.php Hunk #1 FAILED at 20. 1 out of 4 hunks FAILED -- saving rejects to file includes/XmlTypeCheck.php.rej patching file RELEASE-NOTES-1.19 patching file tests/phpunit/includes/upload/UploadTest.php The wikis are 1.19.18; I forget what I installed them as, but I've been applying the differential patches as they came out. This is the first one I've had the slightest hiccup with. So is it just me? - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MediaWiki Security and Maintenance Releases: 1.19.19, 1.22.11 and 1.23.4
On 9/26/14, David Gerard dger...@gmail.com wrote: On 24 September 2014 23:28, Markus Glaser gla...@hallowelt.biz wrote: Patch to previous version (1.19.18): https://releases.wikimedia.org/mediawiki/1.19/mediawiki-1.19.19.patch.gz So I downloaded and applied this. gunzipped it, got this: -rw-r--r-- 1 root root 13663 Sep 24 21:35 mediawiki-1.19.19.patch Applied it, and got this (on two different wikis): # patch -p1 --dry-run mediawiki-1.19.19.patch patching file includes/DefaultSettings.php patching file includes/Sanitizer.php patching file includes/upload/UploadBase.php patching file includes/XmlTypeCheck.php Hunk #1 FAILED at 20. 1 out of 4 hunks FAILED -- saving rejects to file includes/XmlTypeCheck.php.rej patching file RELEASE-NOTES-1.19 patching file tests/phpunit/includes/upload/UploadTest.php The wikis are 1.19.18; I forget what I installed them as, but I've been applying the differential patches as they came out. This is the first one I've had the slightest hiccup with. So is it just me? - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l I just tried the following: bawolff@Bawolff-L:/var/www/w/git/includes$ git checkout 1.19.18 Checking out files: 100% (4472/4472), done. Note: checking out '1.19.18'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example: git checkout -b new_branch_name HEAD is now at a107915... Updated release notes and version number to MediaWiki 1.19.18 bawolff@Bawolff-L:/var/www/w/git/includes$ cd ../ bawolff@Bawolff-L:/var/www/w/git$ patch -p1 ~/mediawiki-1.19.19.patch patching file includes/DefaultSettings.php patching file includes/Sanitizer.php patching file includes/upload/UploadBase.php patching file includes/XmlTypeCheck.php patching file RELEASE-NOTES-1.19 patching file tests/phpunit/includes/upload/UploadTest.php - So provided that the 1.19.18 tarball/patch gets thing up to precisely where git has 1.19.18 tagged (a107915), then the patch seems to work fine. --bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] REL1_24 branched in core
Mark/Markus: I'll second the request for merging pages (in general, and those 2 specifically), and encourage Updating existing pages rather than just starting afresh. Aging documentation isn't usually improved by abandoning/forking it! Updating is often preferred. Ideally, please merge *into* the older pages, which have: * more watchlisters, * and more history, * and more incoming links (from onwiki, and email archives, and bookmarks). All of which assists in widespread awareness of changes (and thereby collaboration). It's perfectly fine to have a per-release checklist that is updated, but it shouldn't be different than the main pages people look to for information. Also, burying the work under the WikiReleaseTeam page doesn't help findability. Possibly merge update some of these, too? https://www.mediawiki.org/wiki/Version_lifecycle https://www.mediawiki.org/wiki/Branch_points https://www.mediawiki.org/wiki/Release_notes https://www.mediawiki.org/wiki/WikiReleaseTeam/Release_timeline https://www.mediawiki.org/wiki/WikiReleaseTeam/Release_log Thanks! -quiddity On Thu, Sep 25, 2014 at 8:27 AM, Markus Glaser gla...@hallowelt.biz wrote: Hi Greg, actually, the WikiReleaseTeam/Release process [1] is my attempt to rewrite the release checklist [2], with more specific information about responsibilites and timeframes. I will take this opportunity to continue working on this. [1] https://www.mediawiki.org/wiki/WikiReleaseTeam/Release_process [2] https://www.mediawiki.org/wiki/Release_checklist -Ursprüngliche Nachricht- Von: wikitech-l-boun...@lists.wikimedia.org [mailto: wikitech-l-boun...@lists.wikimedia.org] Im Auftrag von Greg Grossmeier Gesendet: Mittwoch, 24. September 2014 02:35 An: Wikimedia developers Betreff: Re: [Wikitech-l] REL1_24 branched in core That's it! Thanks, Sumana! :) Mark/Markus/Kunal: This seems redundant (in some ways) to https://www.mediawiki.org/wiki/WikiReleaseTeam/Release_process . And they don't crosslink. Mark/Markus: Can you merge the two pages effectively? Thanks! On Tue, Sep 23, 2014 at 5:19 PM, Sumana Harihareswara suma...@wikimedia.org wrote: https://www.mediawiki.org/wiki/Release_checklist ? Sumana Harihareswara Senior Technical Writer Wikimedia Foundation On Tue, Sep 23, 2014 at 8:17 PM, Greg Grossmeier g...@wikimedia.org wrote: On Sat, Sep 20, 2014 at 5:24 AM, Antoine Musso hashar+...@free.fr wrote: I have adjusted CI to take in account REL1_24 https://gerrit.wikimedia.org/r/#/q/I515b5e21779120ca143a0ed8ec2c99948a dec607,n,z Is there a page documenting all the little things (like what Antoine did there ^) that need to happen with each release? -- Greg Grossmeier Release Team Manager ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Greg Grossmeier Release Team Manager ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MediaWiki Security and Maintenance Releases: 1.19.19, 1.22.11 and 1.23.4
It's because there's a leading space before the tab in front of the comment here: https://git.wikimedia.org/blob/mediawiki%2Fcore.git/REL1_19/includes%2FXmlTypeCheck.php#L22 That leading space exists in the patch for 1.19.19, so applies fine when you're applying it to a fresh copy of the 1.19.18 branch. But, as it was introduced in the 1.19.10 release ( https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/926b9e6) and the patch for the 1.19.10 release didn't include the space, if you used the patches for all releases since, it won't be there and the new 1.19.19 patch will fail to apply the first changes to that file without fixing that space first. Cheers, grunny ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Today's outages: Wikitech (brief) and Gerrit (interminable)
Executive summary: I messed with ldap today. Gerrit handles ldap differently from all other services, so it broke and it took several ops several hours to sort out what was happening. Everything is working again now. Details: As part of an elaborate post-tampa ballet[1] I moved the ldap servers from virt1000 and virt0 to ldap-eqiad (aka neptunium for the time being) and ldap-codfw (aka labcontrol2001). This change was made this morning via puppet[2]. Much to my delight, labs handled the change gracefully and without any service interruptions. Wikitech suffered a brief outage because I neglected to note that it depends on an ldap server name in the mediawiki config. I hotfixed that on virt1000 and also submitted a proper patch[3] for review. With that change wikitech returned to normal, although (as usual) caches are broken and many users will have to log out and in again to get all the labs features they're used to. With the change in ldap server, Gerrit logins went down and stayed down. At various times Marc, Rob, Brandon and I were all involved in troubleshooting. Several changes were made to the ldap setup cluster-wide[4][5] -- these changes are probably correct, but did Gerrit no good (and getting them applied w/out gerrit was no walk in the park.) After a great many more blind alleys, Marc noted that we typically handle ldap certificate validation by specifying a root cert in ldap.conf, and that is not the Proper Debian Way. Apparently we've just been lucky so far that most of our ldap services use ldap.conf rather than the systemwide ca-certificate system. The right solution is to drop trusted certs into /usr/local/share/ca-certificates and then regenerate /etc/ssl/ca-certificates.crt by running update-ca-certificates. Marc did this on ytterbium (the Gerrit host) and Gerrit immediately started working again. Remaining tasks are: 1) Puppetize Marc's hotfix[6] 2) (Maybe) totally refactor how we use ldap everywhere so that it conforms to Debian standards. 3) Document all the services that rely on ldap so the next time someone (me, probably) messes with it, they know what to watch for[7] Many thanks to Marc, Rob and Brandon for joining in when I called out for help with this problem. [1] https://wikitech.wikimedia.org/wiki/Ldap_rename [2] https://gerrit.wikimedia.org/r/#/c/162689/ [3] https://gerrit.wikimedia.org/r/#/c/163189/ [4] https://gerrit.wikimedia.org/r/#/c/163183/ [5] https://gerrit.wikimedia.org/r/#/c/163194/ [6] https://gerrit.wikimedia.org/r/163222 [7] https://wikitech.wikimedia.org/wiki/LDAP ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Roadmap and deployment highlights - week of September 29th
Hello and welcome to the latest edition of the WMF Engineering Roadmap and Deployment update. The full log of planned deployments next week can be found at: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_September_29th A quick list of notable items... == Monday == * PDF Service conversion, see the announcement to wikitech-ambassadors ** https://lists.wikimedia.org/pipermail/wikitech-ambassadors/2014-September/000955.html == Tuesday == * MediaWiki deploy ** group1 to 1.25wmf1: All non-Wikipedia sites (Wiktionary, Wikisource, Wikinews, Wikibooks, Wikiquote, Wikiversity, and a few other sites) ** https://www.mediawiki.org/wiki/MediaWiki_1.25/wmf1 == Thursday == * MediaWiki deploy ** group2 to 1.25wmf1 (all Wikipedias) ** group0 to 1.25wmf2 (test/test2/testwikidata/mediawiki) Thanks and as always, questions and comments welcome, Greg -- Greg Grossmeier Release Team Manager ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Invitation to beta-test HHVM
On Fri, Sep 19, 2014 at 12:57 AM, This, that and the other at.li...@live.com.au wrote: Only once that issue is fixed, and the API is running via HHVM, will I be able to get excited... You may be able to get excited now. :) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Backing out REL1_24
On 9/22/14 1:10 PM, Mark A. Hershberger wrote: In deference to the concerns raised by James Forrester, Markus and I have decided not to back out the REL1_24 branch. Will you be creating the REL1_24 branches for extensions and skins, or would you like me to do that? -- Legoktm ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
