Re: [Wikitech-l] [Engineering] Gerrit 2.12.2 test instance - PLEASE TEST

So I'll start by ignoring horrible UI/UX which, IMO, hasn't improved very much over the old version. I've used the test install for various routine activities and so far I've only found one bug: When I click the change-id link in commit messages, it takes me to a 404 page. On Tue, Jul 12, 2016

Re: [Wikitech-l] [Ops] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

On Wed, Jul 13, 2016 at 2:15 AM, aude wrote: > On Tue, Jul 12, 2016 at 7:56 PM, Ori Livneh wrote: >> Our failure to react to this swiftly and comprehensively is appalling and >> embarrassing. It represents failure of process at multiple levels and a lack

Re: [Wikitech-l] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

On 07/12/2016 09:25 PM, Matthew Flaschen wrote: I am already writing an incident report, and I welcome a discussion. Incident report for the Echo part of this: https://wikitech.wikimedia.org/wiki/Incident_documentation/20160712-EchoCentralAuth . Please edit and improve. Thanks, Matt

Re: [Wikitech-l] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

Hi, On 07/12/2016 04:56 PM, Ori Livneh wrote: > Is it actually fixed? It doesn't look like it, from the logs. > > Since midnight UTC on July 7, 3,195 distinct users have tried and failed to > log in a combined total of 25,047 times, or an average of approximately > eight times per user. The six

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

Great! I especially like how scrolling works when comparing old and new versions of files. Thanks for upgrading. On Wed, 13 Jul 2016 06:17:58 +0500, Chad Horohoe wrote: Hi, Daniel and I have been spending a lot of time in the last week preparing a smooth

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

On Tue, Jul 12, 2016 at 7:39 PM Danny B. wrote: > First of all - thanks for putting the effort to upgrade! > > Unfortunately that is the last positive sentence I'll have here. However, > it > is not your fault at all. It is all about expectations. And my expectations

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

I have tested it and I love it. It is all I was hoping it would be and more. The inline commit editing is quite nice, the lists of related commits are useful, but the warnings about merge conflicts are the best thing ever. The sooner it's live, the better! -- Bartosz Dziewoński

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

First of all - thanks for putting the effort to upgrade! Unfortunately that is the last positive sentence I'll have here. However, it is not your fault at all. It is all about expectations. And my expectations were that the UI/UX will be much more mature than the current version we use.

Re: [Wikitech-l] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

On 07/12/2016 07:07 PM, Greg Grossmeier wrote: Thanks to Matt Flaschen and Brad Jorsch (and others like Ori Livneh and Bryan Davis) for their help. Also Roan Kattouw, Kunal Mehta, and Stephane Bisson. Matt ___ Wikitech-l mailing list

Re: [Wikitech-l] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

On 07/12/2016 07:56 PM, Ori Livneh wrote: Is it actually fixed? It doesn't look like it, from the logs. It's beyond unhelpful that you would send this email without pointing to the logs you are referring to. With a statement like that, a paste is called for. If you mean the existing

[Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

Hi, Daniel and I have been spending a lot of time in the last week preparing a smooth upgrade path for Gerrit to a new (and supported version). The migration will be coming soon but I could use your help testing things in the meantime. https://gerrit-new.wikimedia.org/r/ The database is a

Re: [Wikitech-l] [Ops] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

On 07/12/2016 08:15 PM, aude wrote: This (unbreak now) bug has been open since November. I wonder how this has been allowed to remain open and not addressed for this long? This has not all been caused by Echo, and it really isn't one bug, just one symptom. There are clearly multiple

Re: [Wikitech-l] [Ops] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

On Tue, Jul 12, 2016 at 7:56 PM, Ori Livneh wrote: > On Tue, Jul 12, 2016 at 4:07 PM, Greg Grossmeier > wrote: > >> >> > https://phabricator.wikimedia.org/T119736 - "Could not find local user >> data for {Username}@{wiki}" >> > >> > There was an order of

Re: [Wikitech-l] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

> On Tue, Jul 12, 2016 at 4:07 PM, Greg Grossmeier wrote: > > > > > > https://phabricator.wikimedia.org/T119736 - "Could not find local user > > data for {Username}@{wiki}" > > > > > > There was an order of magnitude increase in the rate of those errors > > > that started

Re: [Wikitech-l] [Engineering] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

On Tue, Jul 12, 2016 at 4:07 PM, Greg Grossmeier wrote: > > > https://phabricator.wikimedia.org/T119736 - "Could not find local user > data for {Username}@{wiki}" > > > > There was an order of magnitude increase in the rate of those errors > > that started on July 7th. > > >

[Wikitech-l] Change to SWAT deploy (aka "let's not break things")

Hello! For a while we've had the ability to test changes in production on a single host (mw1017) using a special HTTP header (X-Wikimedia-Debug). This has proved useful for many when deploying changes in production and we are adding it to the SWAT deploy process. See the steps at:

[Wikitech-l] The train will resume tomorrow (was Re: All wikis reverted to wmf.8 last night due to T119736)

> https://phabricator.wikimedia.org/T119736 - "Could not find local user data > for {Username}@{wiki}" > > There was an order of magnitude increase in the rate of those errors > that started on July 7th. > > Investigation and remediation is on-going. Investigation and remediation is mostly

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

On Tuesday, July 12, 2016, Daniel Kinzler wrote: > Am 12.07.2016 um 18:00 schrieb Rob Lanphier: > > On Tue, Jul 12, 2016 at 1:40 AM, Daniel Kinzler < > daniel.kinz...@wikimedia.de > >> The original design of ContentHandler used integer IDs for content

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

Am 12.07.2016 um 21:02 schrieb Rob Lanphier: > On Tue, Jul 12, 2016 at 8:02 AM, Brad Jorsch (Anomie) > wrote: >> One simple method: assign the numeric IDs by making the numeric ID column >> auto-increment, and insert the model strings into the table as needed. >>

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

On Tue, Jul 12, 2016 at 8:02 AM, Brad Jorsch (Anomie) wrote: > One simple method: assign the numeric IDs by making the numeric ID column > auto-increment, and insert the model strings into the table as needed. > PageAssessments uses this model for tracking its project

Re: [Wikitech-l] How to fake a login with AuthManager?

>On Tue, Jul 12, 2016 at 11:01 AM, Daniel Barrett >wrote: >> What is the proper incantation for faking a successful login (for a given >> user) as part of a unit test? My old code was: >> >> $context = RequestContext::getMain(); >> $specialPage = new LoginForm(

[Wikitech-l] All wikis reverted to wmf.8 last night due to T119736

https://phabricator.wikimedia.org/T119736 - "Could not find local user data for {Username}@{wiki}" There was an order of magnitude increase in the rate of those errors that started on July 7th. Investigation and remediation is on-going. Greg -- | Greg GrossmeierGPG: B2FA 27B1

[Wikitech-l] Revert to 1.28.0-wmf.8

All wikis were rolled back to 1.28.0-wmf.8 last night due to an increase in https://phabricator.wikimedia.org/T119736 . We're working on it, and will either go back to 1.28.0-wmf.9, or to 1.28.0-wmf.10 (at normal train pace) when it's resolved. Matt

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

Am 12.07.2016 um 18:00 schrieb Rob Lanphier: > On Tue, Jul 12, 2016 at 1:40 AM, Daniel Kinzler > The original design of ContentHandler used integer IDs for content models >> and formats in the DB. A mapping to human readable names is only needed >> for logging and

Re: [Wikitech-l] How to fake a login with AuthManager?

On Tue, Jul 12, 2016 at 11:01 AM, Daniel Barrett wrote: > What is the proper incantation for faking a successful login (for a given > user) as part of a unit test? My old code was: > > $context = RequestContext::getMain(); > $specialPage = new LoginForm( $context->getRequest()

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

On Tue, Jul 12, 2016 at 11:47 AM, Daniel Kinzler < daniel.kinz...@wikimedia.de> wrote: > Am 12.07.2016 um 17:02 schrieb Brad Jorsch (Anomie): > > On Tue, Jul 12, 2016 at 4:40 AM, Daniel Kinzler < > daniel.kinz...@wikimedia.de > > > > One simple method: assign the numeric IDs by making the numeric

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

On Tue, Jul 12, 2016 at 1:40 AM, Daniel Kinzler wrote: > Do we really want to manage something that is essentially configuration, > namely > the set of available content models and formats, in a database table? How > is it > maintained? > > For context: > * As per

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

Am 12.07.2016 um 17:02 schrieb Brad Jorsch (Anomie): > On Tue, Jul 12, 2016 at 4:40 AM, Daniel Kinzler > One simple method: assign the numeric IDs by making the numeric ID column > auto-increment, and insert the model strings into the table as needed. When exactly?

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

On Tue, Jul 12, 2016 at 4:40 AM, Daniel Kinzler wrote: > Do we really want to manage something that is essentially configuration, > namely the set of available content models and formats, in a database > table? How is it maintained? > One simple method: assign the

[Wikitech-l] How to fake a login with AuthManager?

What is the proper incantation for faking a successful login (for a given user) as part of a unit test? My old code was: $context = RequestContext::getMain(); $specialPage = new LoginForm( $context->getRequest() ); $user->logout(); $specialPage->showReturnToPage('successredirect');

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

Am 12.07.2016 um 13:23 schrieb Jaime Crespo: > On Tue, Jul 12, 2016 at 12:40 PM, Daniel Kinzler > wrote: >> Yea, still something we need to figure out :) > >> That was, if I remember correctly, one of the arguments for using readable >> strings there, instead of int

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

On Tue, Jul 12, 2016 at 12:40 PM, Daniel Kinzler wrote: > Yea, still something we need to figure out :) > That was, if I remember correctly, one of the arguments for using readable > strings there, instead of int values and a config variable, as I originally >

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

Am 12.07.2016 um 12:25 schrieb Jaime Crespo: > Your last question is a non issue for me- I do not care if things are > on the database or on configuration- that is not the issue I have been > complaining about. Yea, still something we need to figure out :) I'm fine with the DB based solution, if

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

Your last question is a non issue for me- I do not care if things are on the database or on configuration- that is not the issue I have been complaining about. What I blocked is having 6000 million rows (x40 due to redundancy) with the same column value "gzip; version 3 (1-2-3-testing-testing. It

Re: [Wikitech-l] What's the "correct" content model when rev_content_model is NULL?

Addendum, after sleeping over this: Do we really want to manage something that is essentially configuration, namely the set of available content models and formats, in a database table? How is it maintained? For context: * As per T113034, we are movign away from managing interwiki prefixes in