Re: [Wikitech-l] [Train] 1.33.0-wmf.24 status update

[Dan Duvall]

The 1.33.0-wmf.24 version of MediaWiki remains blocked[0], holding at
group0 pending resolution of the following issue:

* RefreshLinksJob::runForTitle: transaction round 'RefreshLinksJob::run'
already started on commons - https://phabricator.wikimedia.org/T220037

Errors related to the issue were mitigated somewhat by a backported patch
to the EventBus extension. However, the 90% drop in DBTransactionError
rates still left us at a hefty ~ 800 errors per minute and the root cause
is yet unknown.

Thanks to everyone who is helping to resolve this week's issues!

Just a note that since we are well outside today's train deployment window
and we refrain from Friday deploys, any fixes for the outstanding issue can
be deployed for group0 but promotion of 1.33.0-wmf.24 will be held until
Monday.

Kindly,
Dan


On Wed, Apr 3, 2019 at 2:29 PM Dan Duvall  wrote:

> The 1.33.0-wmf.24 version of MediaWiki is blocked[0].
>
> The new version is deployed to group0[1], but can proceed no further until
> these issues are resolved:
>
> * Citoid should only usurp " configured - https://phabricator.wikimedia.org/T219510
> * RefreshLinksJob::runForTitle: transaction round 'RefreshLinksJob::run'
> already started on commons - https://phabricator.wikimedia.org/T220037
>
> The first issue was deemed noncritical for group1 but the second caused a
> large spike in DBTransactionError rates. The second issue already has a
> proposed fix but had not yet merged at the closing of the train deployment
> window.
>
> If both issues are resolved by tomorrow's train window, group1 and group2
> will be promoted in succession at that time (barring further issues).
>
> Thank you for your help resolving these issues!
>
> Your humble train toiler,
> Dan
>
> [0]. https://phabricator.wikimedia.org/T206678
> [1]. 
>
> --
> Dan Duvall
> Software Engineer, Release Engineering
> Wikimedia Foundation 
>


-- 
Dan Duvall
Software Engineer, Release Engineering
Wikimedia Foundation 
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Easy list whitelist

[RhinosF1 Wikipedia]

Based on -tech IRC discussion, I'm summing this up @
https://meta.wikimedia.org/wiki/Tech/20190404-Adblock-issue given WikiTech
is currently Account creation locked.

On Thu, 4 Apr 2019 at 21:17, RhinosF1 Wikipedia  wrote:

> Hi Nick,
>
> Thanks for the Clarification, From what I know, the issue was present for
> about 10 hours. I'm not sure how widespread the impact was page wise. Is it
> worth summarising what happened anywhere else?
>
> Thanks,
> RhinosF1
>
> On Thu, 4 Apr 2019 at 21:15, Nick Wilson (Quiddity) 
> wrote:
>
>> Hi RhinosF1,
>> It was only a single webpage that was reported as being blocked by the
>> browser extension (although there were presumably other pages and wikis
>> affected that went unreported in the past), thus it is probably not of
>> great concern to our thousands of contributors who read the short Tech News
>> newsletter. We try to keep the newsletter short and focused on important
>> items of widespread interest, both for ease of translation and so that
>> people read it in full each week. You can read details about what normally
>> gets included at
>> https://meta.wikimedia.org/wiki/Tech/News/For_contributors
>> Cheers,
>>
>>
>> On Thu, Apr 4, 2019 at 12:38 PM RhinosF1 Wikipedia 
>> wrote:
>>
>>> Hi,
>>> Thanks to Nick for the PR.
>>>
>>> As far as I understand, Easy list is some sort of ad blocking system
>>> that multiple ad blockers use.
>>>
>>> From what I can see, Wiktionary got caught up in a block on URLs ending
>>> in /ads and /advert making some pages blank. It's best to read the Tech IRC
>>> log from 4pm onwards to get the idea.
>>>
>>> I'll have a look at Tech News. I'm happy to write a proper report on
>>> what happened if necessary. Where you would suggest posting it? I can't use
>>> Wikitech due to Account Creation block.
>>>
>>> Thanks,
>>> RhinosF1
>>>
>>> On Thu, 4 Apr 2019 at 19:02, Nick Wilson (Quiddity) <
>>> nwil...@wikimedia.org> wrote:
>>>
>>>> Easy List seems to be one of the component in various adblocker tools
>>>> (possibly enabled by default in some or all of them?).
>>>> https://easylist.to/
>>>> E.g. the "uBlock Origin" extension's settings panel which lists it,
>>>> apparently enabled by default:
>>>> https://i.postimg.cc/yN217Tg5/Selection-001.jpg
>>>> I've submitted a pull-request at
>>>> https://github.com/easylist/easylist/pull/3190
>>>> (and +1 to the "please include sufficient context" note :)
>>>>
>>>> On Thu, Apr 4, 2019 at 9:58 AM Andre Klapper 
>>>> wrote:
>>>>
>>>> > On Thu, 2019-04-04 at 16:08 +0100, RhinosF1 Wikipedia wrote:
>>>> > > Could someone please see if WMF wikis could be whitelisted as a
>>>> follow up
>>>> > > to
>>>> > > https://github.com/easylist/easylist/issues/3188?
>>>> >
>>>> > What does that mean? Whitelisting what exactly? Where? Please include
>>>> > sufficient context to allow folks on this list to understand
>>>> relevance.
>>>> >
>>>> > > Despite the short term distruption, Could it be placed on Tech News
>>>> as
>>>> > > users were noticing that some pages were blocked?
>>>> >
>>>> > See https://meta.wikimedia.org/wiki/Tech/News for "Inclusion
>>>> criteria"
>>>> > under "Get started". Obviously I have no idea what "Easy List" is.
>>>> >
>>>> > Cheers,
>>>> > andre
>>>> > --
>>>> > Andre Klapper | Bugwrangler / Developer Advocate
>>>> > https://blogs.gnome.org/aklapper/
>>>> >
>>>> >
>>>> >
>>>> > ___
>>>> > Wikitech-l mailing list
>>>> > Wikitech-l@lists.wikimedia.org
>>>> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>>>
>>>>
>>>>
>>>> --
>>>> Nick "Quiddity" Wilson (he/him)
>>>> Community Engagement - Documentation
>>>> Wikimedia Foundation
>>>> ___
>>>> Wikitech-l mailing list
>>>> Wikitech-l@lists.wikimedia.org
>>>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>>
>>>
>>
>> --
>> Nick "Quiddity" Wilson (he/him)
>> Community Engagement - Documentation
>> Wikimedia Foundation
>>
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Easy list whitelist

[RhinosF1 Wikipedia]

Hi Nick,

Thanks for the Clarification, From what I know, the issue was present for
about 10 hours. I'm not sure how widespread the impact was page wise. Is it
worth summarising what happened anywhere else?

Thanks,
RhinosF1

On Thu, 4 Apr 2019 at 21:15, Nick Wilson (Quiddity) 
wrote:

> Hi RhinosF1,
> It was only a single webpage that was reported as being blocked by the
> browser extension (although there were presumably other pages and wikis
> affected that went unreported in the past), thus it is probably not of
> great concern to our thousands of contributors who read the short Tech News
> newsletter. We try to keep the newsletter short and focused on important
> items of widespread interest, both for ease of translation and so that
> people read it in full each week. You can read details about what normally
> gets included at
> https://meta.wikimedia.org/wiki/Tech/News/For_contributors
> Cheers,
>
>
> On Thu, Apr 4, 2019 at 12:38 PM RhinosF1 Wikipedia 
> wrote:
>
>> Hi,
>> Thanks to Nick for the PR.
>>
>> As far as I understand, Easy list is some sort of ad blocking system that
>> multiple ad blockers use.
>>
>> From what I can see, Wiktionary got caught up in a block on URLs ending
>> in /ads and /advert making some pages blank. It's best to read the Tech IRC
>> log from 4pm onwards to get the idea.
>>
>> I'll have a look at Tech News. I'm happy to write a proper report on what
>> happened if necessary. Where you would suggest posting it? I can't use
>> Wikitech due to Account Creation block.
>>
>> Thanks,
>> RhinosF1
>>
>> On Thu, 4 Apr 2019 at 19:02, Nick Wilson (Quiddity) <
>> nwil...@wikimedia.org> wrote:
>>
>>> Easy List seems to be one of the component in various adblocker tools
>>> (possibly enabled by default in some or all of them?).
>>> https://easylist.to/
>>> E.g. the "uBlock Origin" extension's settings panel which lists it,
>>> apparently enabled by default:
>>> https://i.postimg.cc/yN217Tg5/Selection-001.jpg
>>> I've submitted a pull-request at
>>> https://github.com/easylist/easylist/pull/3190
>>> (and +1 to the "please include sufficient context" note :)
>>>
>>> On Thu, Apr 4, 2019 at 9:58 AM Andre Klapper 
>>> wrote:
>>>
>>> > On Thu, 2019-04-04 at 16:08 +0100, RhinosF1 Wikipedia wrote:
>>> > > Could someone please see if WMF wikis could be whitelisted as a
>>> follow up
>>> > > to
>>> > > https://github.com/easylist/easylist/issues/3188?
>>> >
>>> > What does that mean? Whitelisting what exactly? Where? Please include
>>> > sufficient context to allow folks on this list to understand relevance.
>>> >
>>> > > Despite the short term distruption, Could it be placed on Tech News
>>> as
>>> > > users were noticing that some pages were blocked?
>>> >
>>> > See https://meta.wikimedia.org/wiki/Tech/News for "Inclusion criteria"
>>> > under "Get started". Obviously I have no idea what "Easy List" is.
>>> >
>>> > Cheers,
>>> > andre
>>> > --
>>> > Andre Klapper | Bugwrangler / Developer Advocate
>>> > https://blogs.gnome.org/aklapper/
>>> >
>>> >
>>> >
>>> > ___
>>> > Wikitech-l mailing list
>>> > Wikitech-l@lists.wikimedia.org
>>> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>>
>>>
>>>
>>> --
>>> Nick "Quiddity" Wilson (he/him)
>>> Community Engagement - Documentation
>>> Wikimedia Foundation
>>> ___
>>> Wikitech-l mailing list
>>> Wikitech-l@lists.wikimedia.org
>>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>
>>
>
> --
> Nick "Quiddity" Wilson (he/him)
> Community Engagement - Documentation
> Wikimedia Foundation
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Easy list whitelist

[Nick Wilson (Quiddity)]

Hi RhinosF1,
It was only a single webpage that was reported as being blocked by the
browser extension (although there were presumably other pages and wikis
affected that went unreported in the past), thus it is probably not of
great concern to our thousands of contributors who read the short Tech News
newsletter. We try to keep the newsletter short and focused on important
items of widespread interest, both for ease of translation and so that
people read it in full each week. You can read details about what normally
gets included at https://meta.wikimedia.org/wiki/Tech/News/For_contributors
Cheers,


On Thu, Apr 4, 2019 at 12:38 PM RhinosF1 Wikipedia 
wrote:

> Hi,
> Thanks to Nick for the PR.
>
> As far as I understand, Easy list is some sort of ad blocking system that
> multiple ad blockers use.
>
> From what I can see, Wiktionary got caught up in a block on URLs ending in
> /ads and /advert making some pages blank. It's best to read the Tech IRC
> log from 4pm onwards to get the idea.
>
> I'll have a look at Tech News. I'm happy to write a proper report on what
> happened if necessary. Where you would suggest posting it? I can't use
> Wikitech due to Account Creation block.
>
> Thanks,
> RhinosF1
>
> On Thu, 4 Apr 2019 at 19:02, Nick Wilson (Quiddity) 
> wrote:
>
>> Easy List seems to be one of the component in various adblocker tools
>> (possibly enabled by default in some or all of them?).
>> https://easylist.to/
>> E.g. the "uBlock Origin" extension's settings panel which lists it,
>> apparently enabled by default:
>> https://i.postimg.cc/yN217Tg5/Selection-001.jpg
>> I've submitted a pull-request at
>> https://github.com/easylist/easylist/pull/3190
>> (and +1 to the "please include sufficient context" note :)
>>
>> On Thu, Apr 4, 2019 at 9:58 AM Andre Klapper 
>> wrote:
>>
>> > On Thu, 2019-04-04 at 16:08 +0100, RhinosF1 Wikipedia wrote:
>> > > Could someone please see if WMF wikis could be whitelisted as a
>> follow up
>> > > to
>> > > https://github.com/easylist/easylist/issues/3188?
>> >
>> > What does that mean? Whitelisting what exactly? Where? Please include
>> > sufficient context to allow folks on this list to understand relevance.
>> >
>> > > Despite the short term distruption, Could it be placed on Tech News as
>> > > users were noticing that some pages were blocked?
>> >
>> > See https://meta.wikimedia.org/wiki/Tech/News for "Inclusion criteria"
>> > under "Get started". Obviously I have no idea what "Easy List" is.
>> >
>> > Cheers,
>> > andre
>> > --
>> > Andre Klapper | Bugwrangler / Developer Advocate
>> > https://blogs.gnome.org/aklapper/
>> >
>> >
>> >
>> > ___
>> > Wikitech-l mailing list
>> > Wikitech-l@lists.wikimedia.org
>> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>
>>
>>
>> --
>> Nick "Quiddity" Wilson (he/him)
>> Community Engagement - Documentation
>> Wikimedia Foundation
>> ___
>> Wikitech-l mailing list
>> Wikitech-l@lists.wikimedia.org
>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
>

-- 
Nick "Quiddity" Wilson (he/him)
Community Engagement - Documentation
Wikimedia Foundation
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Easy list whitelist

[RhinosF1 Wikipedia]

Hi,
Thanks to Nick for the PR.

As far as I understand, Easy list is some sort of ad blocking system that
multiple ad blockers use.

From what I can see, Wiktionary got caught up in a block on URLs ending in
/ads and /advert making some pages blank. It's best to read the Tech IRC
log from 4pm onwards to get the idea.

I'll have a look at Tech News. I'm happy to write a proper report on what
happened if necessary. Where you would suggest posting it? I can't use
Wikitech due to Account Creation block.

Thanks,
RhinosF1

On Thu, 4 Apr 2019 at 19:02, Nick Wilson (Quiddity) 
wrote:

> Easy List seems to be one of the component in various adblocker tools
> (possibly enabled by default in some or all of them?).
> https://easylist.to/
> E.g. the "uBlock Origin" extension's settings panel which lists it,
> apparently enabled by default:
> https://i.postimg.cc/yN217Tg5/Selection-001.jpg
> I've submitted a pull-request at
> https://github.com/easylist/easylist/pull/3190
> (and +1 to the "please include sufficient context" note :)
>
> On Thu, Apr 4, 2019 at 9:58 AM Andre Klapper 
> wrote:
>
> > On Thu, 2019-04-04 at 16:08 +0100, RhinosF1 Wikipedia wrote:
> > > Could someone please see if WMF wikis could be whitelisted as a follow
> up
> > > to
> > > https://github.com/easylist/easylist/issues/3188?
> >
> > What does that mean? Whitelisting what exactly? Where? Please include
> > sufficient context to allow folks on this list to understand relevance.
> >
> > > Despite the short term distruption, Could it be placed on Tech News as
> > > users were noticing that some pages were blocked?
> >
> > See https://meta.wikimedia.org/wiki/Tech/News for "Inclusion criteria"
> > under "Get started". Obviously I have no idea what "Easy List" is.
> >
> > Cheers,
> > andre
> > --
> > Andre Klapper | Bugwrangler / Developer Advocate
> > https://blogs.gnome.org/aklapper/
> >
> >
> >
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
>
>
> --
> Nick "Quiddity" Wilson (he/him)
> Community Engagement - Documentation
> Wikimedia Foundation
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Easy list whitelist

[Nick Wilson (Quiddity)]

Easy List seems to be one of the component in various adblocker tools
(possibly enabled by default in some or all of them?). https://easylist.to/
E.g. the "uBlock Origin" extension's settings panel which lists it,
apparently enabled by default:
https://i.postimg.cc/yN217Tg5/Selection-001.jpg
I've submitted a pull-request at
https://github.com/easylist/easylist/pull/3190
(and +1 to the "please include sufficient context" note :)

On Thu, Apr 4, 2019 at 9:58 AM Andre Klapper  wrote:

> On Thu, 2019-04-04 at 16:08 +0100, RhinosF1 Wikipedia wrote:
> > Could someone please see if WMF wikis could be whitelisted as a follow up
> > to
> > https://github.com/easylist/easylist/issues/3188?
>
> What does that mean? Whitelisting what exactly? Where? Please include
> sufficient context to allow folks on this list to understand relevance.
>
> > Despite the short term distruption, Could it be placed on Tech News as
> > users were noticing that some pages were blocked?
>
> See https://meta.wikimedia.org/wiki/Tech/News for "Inclusion criteria"
> under "Get started". Obviously I have no idea what "Easy List" is.
>
> Cheers,
> andre
> --
> Andre Klapper | Bugwrangler / Developer Advocate
> https://blogs.gnome.org/aklapper/
>
>
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l



-- 
Nick "Quiddity" Wilson (he/him)
Community Engagement - Documentation
Wikimedia Foundation
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] TechCom Radar 2019-04-03

[Kate Chapman]

Hi All,

Here are the minutes from this week's TechCom meeting:

* Hosted IRC meeting on: RFC: Skin templating

 * minutes:

 * log: 


* No IRC meeting next week

* Updates to the draft Architecture Principles have been made based on
feedback: 


You can also find our meeting minutes at


See also the TechCom RFC board
.

If you prefer you can subscribe to our newsletter here


Thanks,
Kate

--
Kate Chapman
Senior Program Manager, Core Platform
Wikimedia Foundation
kchap...@wikimedia.org

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] 2019-04-03 Scrum of scrums meeting notes

[Željko Filipin]

For HTML version see
https://www.mediawiki.org/wiki/Scrum_of_scrums/2019-04-03

= 2019-04-03 =

== Callouts ==

* Fundraising campaigns
https://meta.wikimedia.org/wiki/CentralNotice/Calendar
* SRE service operations would like input/help from Core Platform
Team/Performance on https://phabricator.wikimedia.org/T219279 (Some pages
will become completely unreachable after PHP7 update due to Unicode changes)
* Performance is blocked on input from Core Platform Team/Tim on sampling
profiler for PHP 7: https://phabricator.wikimedia.org/T176916#5064425
* UI Standardization: New sans-serif font stack for improved mobile reading
(MinervaNeue) has been rolled-out: https://phabricator.wikimedia.org/T175877
* Wikimetrics is deprecated, requests redirect now to
https://eventmetrics.wmflabs.org/ We have worked with community Tech team
to add couple features to event-metrics that were needed

== Audiences ==

=== Contributors ===

 Community Tech 
* Blocked by:
* Blocking:
* Updates:
** EventMetrics has been demoed to users and is officially available. We
are cleaning up some bugs now.

 Anti-Harassment Tools 
* Blocked by:
* Blocking:
* Updates:
** More details about our refactor of Blocks here:
https://phabricator.wikimedia.org/T219441

 Editing 
* Blocked by:
* Blocking:
* Updates:
** Mobile section editing A/B test running on most wikis

 Growth 
* Blocked by: Security Concept and Design Review of our Newcomer Homepage
* Blocking:
* Updates:
** The team is currently coding the start module for the newcomer homepage,
and designing the mobile version of the homepage

 Language 
* Blocked by:
* Blocking:
* Updates:
** ContentTranslation version 2 is default from now unless user has draft
already in version 1.
** Cron script to purge old unpublished drafts deployed and running at
every 15 days to purge drafts older than 455 days.

=== Readers ===

 iOS native app 
* Blocked by:
* Blocking:
* Updates:
** 6.2.1 release coming up
https://phabricator.wikimedia.org/tag/ios-app-v6.2.1-beluga-on-stilts/
*** Find & Replace
*** Editing onboarding
*** Other bug fixes & editing enhancements
** 6.3 planning begins (
https://phabricator.wikimedia.org/tag/ios-app-v6.3-lobster-on-a-motorcycle/)
*** Talk pages
*** Link wizard
*** Citation wizard
*** "Open here to edit" analytics

 Android native app 
* Blocked by:
* Blocking:
* Updates:

 Readers Web 
* Blocked by:
* Blocking:
* Updates:
** Summary: technical planning for next year, continuing advanced mobile
contributions features and the MobileFrontend architecture investment
project.
** Responsive website (MinervaNeue / MobileFrontend):
*** Advanced mobile contributions
https://www.mediawiki.org/wiki/Reading/Web/Advanced_mobile_contributions
 Allow easier access to user modes T218625
 Upgrade MobileWebMainMenuClickTracking to have an AMC field T218627
 Skin Contributions and History pages in Minerva for consistency with
their mobile replacements T219349
 Jon working with Volker to improve special pages
*** Invest in the MobileFrontend & MinervaNeue frontend architecture
https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture
 Refactoring Nearby: Remove messageBox template partial inside Nearby
T218813
 Refactor NotificationsOverlay T219036
 Refactor BetaOptinPanel T217298
*** ExternalGuidance extension review and support
*** Miscellaneous bug fixes and maintenance T214549 T198534 T218731 T219920
** Quick Surveys
*** Allow quicksurveys to target based on registration date T218304
** Desktop website (Popups)
*** Popups https://www.mediawiki.org/wiki/Page_Previews
 Bugfix for double pokey on some page previews T204627
** Planning
*** MobileFrontend & MinervaNeue frontend architecture planning for next
fiscal year

 Readers Infrastructure 
* Blocked by:
* Blocking:
* Updates:
** Suggested Edits APIs are launched in production (Wikidata)
** PCS/MCS/Maps: Nothing particularly interesting

 Multimedia 
* Updates
** Still working towards 2nd release of SDoC (depicts statements), pretty
much code complete but many speedbumps along the way
*** Turned on wikidata federation on live commons, and it broke various
things. All since patched, working on some integration tests before we try
it again (just in case)
** Work continues for subsequent releases

 Parsing 
* Blocked by:
* Blocking:
* Updates: Porting continues, about 33% done

 UI Standardization 
* Blocked by:
* Blocking:
* Updates:
** Collaboration with Jon Robson last full week on AMC work, bringing
*** HistoryAction to OOUI and
*** preparing Special:Contributions for the same
https://phabricator.wikimedia.org/T117736, including
*** a dozen merged patches for full skinnability on mobile, improved UX and
using DateInputWidget for type=>date HTMLForm elements
** New sans-serif font stack for improved mobile reading (MinervaNeue) has
been rolled-out: 

Re: [Wikitech-l] resource loader; 1.32 alpha; 1.32 stable breaking change loading scripts in widgets

[bawolff]

I don't know if its best practise to do this, but core seems to do:

(window.RLQ=window.RLQ||[]).push(function () {
mw.loader.using('ext.myextension').then(function(){
console.log('library loaded');}); });

You probably don't have many other options if you are using the Widgets
extension.

--
Brian

On Thu, Apr 4, 2019 at 4:08 PM Bartosz Dziewoński 
wrote:

> Best practice is to use the PHP methods which generate the required
> wrappers. Have a look at ResourceLoader::makeLoaderConditionalScript()
> and ResourceLoader::makeInlineCodeWithModule().
>
> Alternatively, if it's possible, it is ideal to put the initialization
> code into another module and load it with addMobules() etc. as usual,
> instead of inlining the code in the HTML source.
>
> --
> Bartosz Dziewoński
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Easy list whitelist

[Andre Klapper]

On Thu, 2019-04-04 at 16:08 +0100, RhinosF1 Wikipedia wrote:
> Could someone please see if WMF wikis could be whitelisted as a follow up
> to
> https://github.com/easylist/easylist/issues/3188?

What does that mean? Whitelisting what exactly? Where? Please include
sufficient context to allow folks on this list to understand relevance.

> Despite the short term distruption, Could it be placed on Tech News as
> users were noticing that some pages were blocked?

See https://meta.wikimedia.org/wiki/Tech/News for "Inclusion criteria"
under "Get started". Obviously I have no idea what "Easy List" is.

Cheers,
andre
-- 
Andre Klapper | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] resource loader; 1.32 alpha; 1.32 stable breaking change loading scripts in widgets

[Bartosz Dziewoński]

Best practice is to use the PHP methods which generate the required 
wrappers. Have a look at ResourceLoader::makeLoaderConditionalScript() 
and ResourceLoader::makeInlineCodeWithModule().


Alternatively, if it's possible, it is ideal to put the initialization 
code into another module and load it with addMobules() etc. as usual, 
instead of inlining the code in the HTML source.


--
Bartosz Dziewoński

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] resource loader; 1.32 alpha; 1.32 stable breaking change loading scripts in widgets

[Tom Schulze]

dear all,

i experienced breaking changes when loading scripts in the widgets
extension through the resource loader. please check the gitlab snippet
[1] i created. i did not find any documentation and checked the
migration guide [2].

is the code presented in the gitlab snippet good practice? could anyone
point me to existing documentation?

thank you!

tom

[1] https://gitlab.com/snippets/1843172

[2]
https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users)#MediaWiki_1.32_(TBA)



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Easy list whitelist

[RhinosF1 Wikipedia]

Hi,
Could someone please see if WMF wikis could be whitelisted as a follow up
to
https://github.com/easylist/easylist/issues/3188?

Despite the short term distruption, Could it be placed on Tech News as
users were noticing that some pages were blocked?

Thanks,
RhinosF1
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Patchsets by new Gerrit contributors waiting for code review and/or merge

[Jaime Crespo]

For the couple I am slightly familiar with (apologies if I am mistaken):

On Thu, Apr 4, 2019 at 11:11 AM Andre Klapper  wrote:
> * https://gerrit.wikimedia.org/r/#/c/operations/software/cumin/+/497312/
> ** allow running cumin as a regular user
> ** 2019-March-18
> ** Maintainers/Stewards: WMF SRE?

Cumin is maintained by the software automation subteam of SRE.

> * https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/498773/
> ** db::views: Bring back abuse_filter_history table
> ** 2019-March-25
> ** Maintainers/Stewards: WMF SRE?

Wikireplica views are maintained by the WMCS team (not SRE), although
they may or may not need assistance by SREs/security, depending on the
proposed changes.

I will bring these 2 to their attention.

Thanks for the heads up, Andre

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Phabricator Login Error

[RhinosF1 Wikipedia]

Thanks!

On Thu, 4 Apr 2019 at 10:03, RhinosF1 Wikipedia  wrote:

> Ok, thanks for the clarification.
>
> User is still in -tech channel. I've looked through the Phab Admin list
> and it looks like most are US/Canda based so they might be best waiting
> until later.
>
> Thanks for the help
>
> On Thu, 4 Apr 2019 at 09:59, K. Peachey  wrote:
>
>> It's been used on and off as required for the past few years.
>>
>> On Thu, 4 Apr 2019 at 18:55, RhinosF1 Wikipedia 
>> wrote:
>> >
>> > Do we know when it was implemented and why? Is it part of the response
>> to earlier security issues?
>> >
>> > On Thu, 4 Apr 2019 at 09:51, K. Peachey  wrote:
>> >>
>> >> It's a anti-spam measure, One of the Phab administrators will approve
>> >> when available.
>> >>
>> >> On Thu, 4 Apr 2019 at 18:28, RhinosF1 Wikipedia 
>> wrote:
>> >> >
>> >> > Hi all,
>> >> > Is there any reason Phabricator accounts would be marked not
>> approved?
>> >> > I've not noticed this happening before but there's been a report on
>> IRC
>> >> > (see
>> >> > https://wm-bot.wmflabs.org/logs/%23wikimedia-tech/20190404.txt) by
>> >> > https://phabricator.wikimedia.org/p/Dusti/ saying they are getting
>> the
>> >> > error:  'Your account has been created, but needs to be approved by
>> an
>> >> > administrator. You'll receive an email once your account is
>> approved.' (see
>> >> > https://snag.gy/InXbLz.jpg)
>> >> >
>> >> >
>> >> > Can someone approve and clarify what's happened?
>> >> > ___
>> >> > Wikitech-l mailing list
>> >> > Wikitech-l@lists.wikimedia.org
>> >> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>> >>
>> >> ___
>> >> Wikitech-l mailing list
>> >> Wikitech-l@lists.wikimedia.org
>> >> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Phabricator Login Error

[Andre Klapper]

On Thu, 2019-04-04 at 09:55 +0100, RhinosF1 Wikipedia wrote:
> Do we know when it was implemented and why? Is it part of the
> response to earlier security issues?

Yes.

Best place to bring up Phabricator questions is
https://www.mediawiki.org/wiki/Talk:Phabricator/Help
which is linked from the Phabricator front page.

Cheers,
andre
-- 
Andre Klapper | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Patchsets by new Gerrit contributors waiting for code review and/or merge

[Andre Klapper]

CR0: Please review and provide guidance if you are familiar with the code, and 
decide (CR±1 or CR±2):

* https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Material/+/471766/
** Add scrollbar:: to view more content on sidebar
** 2018-November-06
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/472184/
** Avoid hitting DB in Category getters when they have the required info
** 2018-November-23 (rebased on 2019-March-10)
** Maintainers/Stewards: MediaWiki Platform team?

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/480039/
** Added new feature: order virtual fields by the order they inserted to list 
on cargo store
** 2018-December-17
** Maintainers/Stewards: ???

* 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GoogleAnalyticsMetrics/+/485488/
** fix: non-ascii page title bug
** 2019-January-20
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PipeEscape/+/486043/
** Convert PipeEscape to use extension registration
** 2019-January-23
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OdbcDatabase/+/487568/
** Fix OdbcDatabase to work under 1.32 and with current ExternalData
** 2019-February-02
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Push/+/492443/
** Use addJsConfigVars instead of addInlineScript
** 2019-February-23
** Maintainers/Stewards: ??? (mw.org says Unmaintained)

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SearchStats/+/492455/
** Add i18n key searchstats
** 2019-February-23
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FirstSteps/+/492460/
** Convert FirstSteps to use extension registration
** 2019-February-27
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OATHAuth/+/492436/
** Added missing disableoathforuser message
** 2019-March-03
** Maintainers/Stewards: ??? ("Unassigned")

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/495439/
** Add PHPDocs to CargoViewData functions
** 2019-March-09
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MultiMaps/+/494860/
** Extension MultiMaps: Adding support for multiple URL in Leaflet
** 2019-March-07
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/492485/
** [bugfix] Remove link to /edithistory from page's edithistory summary.
** 2019-March-17
** Maintainers/Stewards: ??? (not sure where Pywikibot lists that)

* https://gerrit.wikimedia.org/r/#/c/operations/software/cumin/+/497312/
** allow running cumin as a regular user
** 2019-March-18
** Maintainers/Stewards: WMF SRE?

* https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/498773/
** db::views: Bring back abuse_filter_history table
** 2019-March-25
** Maintainers/Stewards: WMF SRE?

* https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/497646/
** pywikibot: Add support for property creation
** 2019-March-25 (but with a "WIP" flag)
** Maintainers/Stewards: ??? (not sure where Pywikibot lists that)


CR+1: Please help make a decision (CR±1, CR±2) on these CR+1 patches:

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WhiteSpace/+/493168/
** Convert WhiteSpace to use extension registration
** 2019-February-27
** Maintainers/Stewards: ???

* 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalContributions/+/492444/
** Use plaintextParams directly instead of using rawParams()
** 2019-February-27 (but blocked on non-removed "WIP" flag)
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CloseWikis/+/492449/
** SpecialCloseWiki: Replace the usage of global variables
** 2019-March-21
** Maintainers/Stewards: ???

* 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/LastUserLogin/+/492441/
** LastUserLogin: Replace the usage of global variables
** 2019-March-21
** Maintainers/Stewards: ???


Read https://www.mediawiki.org/wiki/Gerrit/Code_review#By_project how
you can get notified of new patches in your code areas of interest.

Thanks in advance for your reviews!


Of last time's 11 listed patches, 
2 got -1ed by anomie and Tgr;
2 got +2ed by by Daniel Kinzler and MatmaRex;
1 got rebased and is back to CR0.


Maintainers/Stewards data taken from 
https://www.mediawiki.org/wiki/Developers/Maintainers
CR0 source: 
https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D0+label:Code-Review%253D0
CR+1 source: 
https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D1+label:Code-Review%253E%253D%252B1+-label:Code-Review%253C%253D0

-- 
Andre Klapper | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Phabricator Login Error

[RhinosF1 Wikipedia]

Ok, thanks for the clarification.

User is still in -tech channel. I've looked through the Phab Admin list and
it looks like most are US/Canda based so they might be best waiting until
later.

Thanks for the help

On Thu, 4 Apr 2019 at 09:59, K. Peachey  wrote:

> It's been used on and off as required for the past few years.
>
> On Thu, 4 Apr 2019 at 18:55, RhinosF1 Wikipedia 
> wrote:
> >
> > Do we know when it was implemented and why? Is it part of the response
> to earlier security issues?
> >
> > On Thu, 4 Apr 2019 at 09:51, K. Peachey  wrote:
> >>
> >> It's a anti-spam measure, One of the Phab administrators will approve
> >> when available.
> >>
> >> On Thu, 4 Apr 2019 at 18:28, RhinosF1 Wikipedia 
> wrote:
> >> >
> >> > Hi all,
> >> > Is there any reason Phabricator accounts would be marked not approved?
> >> > I've not noticed this happening before but there's been a report on
> IRC
> >> > (see
> >> > https://wm-bot.wmflabs.org/logs/%23wikimedia-tech/20190404.txt) by
> >> > https://phabricator.wikimedia.org/p/Dusti/ saying they are getting
> the
> >> > error:  'Your account has been created, but needs to be approved by an
> >> > administrator. You'll receive an email once your account is
> approved.' (see
> >> > https://snag.gy/InXbLz.jpg)
> >> >
> >> >
> >> > Can someone approve and clarify what's happened?
> >> > ___
> >> > Wikitech-l mailing list
> >> > Wikitech-l@lists.wikimedia.org
> >> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >>
> >> ___
> >> Wikitech-l mailing list
> >> Wikitech-l@lists.wikimedia.org
> >> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Phabricator Login Error

[K. Peachey]

It's been used on and off as required for the past few years.

On Thu, 4 Apr 2019 at 18:55, RhinosF1 Wikipedia  wrote:
>
> Do we know when it was implemented and why? Is it part of the response to 
> earlier security issues?
>
> On Thu, 4 Apr 2019 at 09:51, K. Peachey  wrote:
>>
>> It's a anti-spam measure, One of the Phab administrators will approve
>> when available.
>>
>> On Thu, 4 Apr 2019 at 18:28, RhinosF1 Wikipedia  wrote:
>> >
>> > Hi all,
>> > Is there any reason Phabricator accounts would be marked not approved?
>> > I've not noticed this happening before but there's been a report on IRC
>> > (see
>> > https://wm-bot.wmflabs.org/logs/%23wikimedia-tech/20190404.txt) by
>> > https://phabricator.wikimedia.org/p/Dusti/ saying they are getting the
>> > error:  'Your account has been created, but needs to be approved by an
>> > administrator. You'll receive an email once your account is approved.' (see
>> > https://snag.gy/InXbLz.jpg)
>> >
>> >
>> > Can someone approve and clarify what's happened?
>> > ___
>> > Wikitech-l mailing list
>> > Wikitech-l@lists.wikimedia.org
>> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>
>> ___
>> Wikitech-l mailing list
>> Wikitech-l@lists.wikimedia.org
>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Phabricator Login Error

[RhinosF1 Wikipedia]

Do we know when it was implemented and why? Is it part of the response to
earlier security issues?

On Thu, 4 Apr 2019 at 09:51, K. Peachey  wrote:

> It's a anti-spam measure, One of the Phab administrators will approve
> when available.
>
> On Thu, 4 Apr 2019 at 18:28, RhinosF1 Wikipedia 
> wrote:
> >
> > Hi all,
> > Is there any reason Phabricator accounts would be marked not approved?
> > I've not noticed this happening before but there's been a report on IRC
> > (see
> > https://wm-bot.wmflabs.org/logs/%23wikimedia-tech/20190404.txt) by
> > https://phabricator.wikimedia.org/p/Dusti/ saying they are getting the
> > error:  'Your account has been created, but needs to be approved by an
> > administrator. You'll receive an email once your account is approved.'
> (see
> > https://snag.gy/InXbLz.jpg)
> >
> >
> > Can someone approve and clarify what's happened?
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Phabricator Login Error

[K. Peachey]

It's a anti-spam measure, One of the Phab administrators will approve
when available.

On Thu, 4 Apr 2019 at 18:28, RhinosF1 Wikipedia  wrote:
>
> Hi all,
> Is there any reason Phabricator accounts would be marked not approved?
> I've not noticed this happening before but there's been a report on IRC
> (see
> https://wm-bot.wmflabs.org/logs/%23wikimedia-tech/20190404.txt) by
> https://phabricator.wikimedia.org/p/Dusti/ saying they are getting the
> error:  'Your account has been created, but needs to be approved by an
> administrator. You'll receive an email once your account is approved.' (see
> https://snag.gy/InXbLz.jpg)
>
>
> Can someone approve and clarify what's happened?
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Phabricator Login Error

[RhinosF1 Wikipedia]

Hi all,
Is there any reason Phabricator accounts would be marked not approved?
I've not noticed this happening before but there's been a report on IRC
(see
https://wm-bot.wmflabs.org/logs/%23wikimedia-tech/20190404.txt) by
https://phabricator.wikimedia.org/p/Dusti/ saying they are getting the
error:  'Your account has been created, but needs to be approved by an
administrator. You'll receive an email once your account is approved.' (see
https://snag.gy/InXbLz.jpg)


Can someone approve and clarify what's happened?
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] SQL strict mode in development

[Antoine Musso]

Hello,

As of today, MediaWiki development settings now ask MySQL/MariaDB to 
report error for a wide range of issues that just emitted a warning 
previously.  That is done in includes/DevelopmentSettings.php by setting:


 $wgSQLMode = 'TRADITIONAL';

As such, you might see database errors occurring on CI runs. We 
definitely need them to be tracked and fixed to later enable a stricter 
mode on the Wikimedia cluster.



Why does it matter?

In short, without the stricter mode, the server might just truncate some 
rows, fallback to some default or just truncate the value!


We had a RFC written back in 2015 about the subject which gives the 
rationale and examples:

https://phabricator.wikimedia.org/T112637


Thus if you encounter an error, please do fill a sub task for T108255.


Ref:
mediawiki/core change https://gerrit.wikimedia.org/r/429386/
For CI/dev: https://phabricator.wikimedia.org/T119371
For production: https://phabricator.wikimedia.org/T108255

--
Antoine "hashar" Musso


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l