Re: [Wikitech-l] The end of Hooks::run(): what you need to know

2020-06-01 Thread Tim Starling
On 2/6/20 4:27 am, Physikerwelt wrote: >> Hook runner classes give hooks machine-readable parameter names and types. > > This sounds really cool. Does this mean can read the parameter names > and types without deep learning;-) Yes. A large number of hook call sites initially failed Phan static an

Re: [Wikitech-l] CI build of empty patch fails in Vector repo in 'mediawiki/phan-taint-check-plugin'

2020-06-01 Thread Aron Demian
Thank you! And thanks to Daimona Eaytoy and DannyS712 for the temporary patch, it is working now! On Mon, 1 Jun 2020 at 21:40, Kunal Mehta wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 2020-06-01 07:21, Aron Demian wrote: > > This has been happening since Saturday. Looking f

Re: [Wikitech-l] CI build of empty patch fails in Vector repo in 'mediawiki/phan-taint-check-plugin'

2020-06-01 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2020-06-01 07:21, Aron Demian wrote: > This has been happening since Saturday. Looking for resolution. See . It's currently being fixed by rolling out a new version of the phan-taint-check plugin. - --

Re: [Wikitech-l] The end of Hooks::run(): what you need to know

2020-06-01 Thread Physikerwelt
On Mon, Jun 1, 2020 at 1:44 AM Tim Starling wrote: > > Hooks::run() was soft-deprecated in Nikki Nikkhoui's HookContainer > patch, merged on April 17. [1] And my patch to remove almost all > instances of it in MediaWiki Core was finally merged over the weekend. > [2] That means that everyone writi

Re: [Wikitech-l] Hotfix for high-visibility regression waiting for review and SWAT

2020-06-01 Thread Aron Demian
Thank you Olga for the answer! Have you considered merging the fix that's already ready and fixes exactly what was missed in the similar hotfix for CSS ? > Patch Se

Re: [Wikitech-l] Hotfix for high-visibility regression waiting for review and SWAT

2020-06-01 Thread Olga Vasileva
The readers web team at the WMF is currently looking at this bug and will be providing a fix soon. Thank you, - Olga On Mon, Jun 1, 2020 at 5:15 PM Aron Demian wrote: > The third bug in the recent wave of regressions (T253819 > : Dancing Search Bar in

[Wikitech-l] TechCom Radar 2020-05-27

2020-06-01 Thread Kate Chapman
Hi All, Here are the minutes from this week's TechCom meeting: * Office hours 2020-06-03 16:00 UTC (9am PDT, 18:00 CEST) in #wikimedia-office RFC: Hybrid extension management * RFC: Wikimedia Push Notification Service

[Wikitech-l] Hotfix for high-visibility regression waiting for review and SWAT

2020-06-01 Thread Aron Demian
The third bug in the recent wave of regressions (T253819 : Dancing Search Bar in MediaWiki) is a high visibility bug, it happens at a range of screen widths on all wikis for any kind of users (readers too). A reddit video of it

[Wikitech-l] CI build of empty patch fails in Vector repo in 'mediawiki/phan-taint-check-plugin'

2020-06-01 Thread Aron Demian
This has been happening since Saturday. Looking for resolution. Empty patch to demonstrate: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/600431 Last merged patch (passed test, insignificant change to php): https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/596512 Failure: htt