[Wikitech-l] Re: Goto for microoptimisation

Just to play the devils advocate. I want to point out some example risks (which were of course included in the discussion in the earlier linked literature): a) someone will introduce if ($x==1.5) in the middle or b) someone will make action1 modifying on $x which might result in $x==2 the

[Wikitech-l] Re: reviewer for extension

Hi, On 8/13/21 6:21 AM, Andre Klapper wrote: Is this about https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043 as that is the only open changeset listed under https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ? I wonder if it makes sense to change the

[Wikitech-l] Re: Goto for microoptimisation

For the record, I merged Tim's patch last week and was unaware of this email thread. My thinking was as follows: 1. The implementation does not depend on the goto statement. That is, it is not used to write overly-clever or complicated

[Wikitech-l] Re: Help in my tasks in Gerrit

Hello? Could someone help me with something related to gerrit.wikimedia.org? ___ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org

[Wikitech-l] Re: reviewer for extension

Hi, you can +2 it, I guess. But I would like to point you to read some docs. :) https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP for coding convention and https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for how-to format a commit message. If you have any questions,

[Wikitech-l] Re: reviewer for extension

Hi, On Fri, 2021-08-13 at 09:14 +0200, td...@mail.com wrote: > Hello, I have just updated this extension >   > https://www.mediawiki.org/wiki/Extension:CIForms >   > and the related github repository. > However, to update the code on gerrit here >   >

[Wikitech-l] Re: Help in my tasks in Gerrit

The link is displayed wrongly, correcting: https://gerrit.wikimedia.org/r/dashboard/8867 ___ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org

[Wikitech-l] Help in my tasks in Gerrit

Could someone help me with something related to gerrit.wikimedia.org? My https://gerrit.wikimedia.org/r/dashboard/self;>dashboard has 6 changes that need code review, which is important because they are requests from Phabricator . So could someone experienced review the code for my requested

[Wikitech-l] reviewer for extension

Hello, I have just updated this extension   https://www.mediawiki.org/wiki/Extension:CIForms   and the related github repository. However, to update the code on gerrit here   https://gerrit.wikimedia.org/g/mediawiki/extensions/CIForms   I would need a code-reviewer. Anyone willing to help