[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

[Inductiveload]

On the theme of code search, I have submitted a MediaWiki docset to
the Dash user contributions repo, so you can also use it with Zeal[1],
which looks like this [2, 3]. It includes collaboration diagrams and
references/referenced by listings.

Obviously, as it's only from the core doxygen it doesn't include
extensions, but I find it goes a long way to demystifying things.
Because it's only built[4] manually and submitted manually, it's not
bang up-to-date, but I have found it handy. Really it just provides a
less clunky interface to doxygen's HTML

You can download the docset via the XML feed here (just paste this
into Zeal's "Add Feed" button):
https://zealusercontributions.vercel.app/api/docsets/Mediawiki.xml

You can also see a lot more user contributed docsets here:
https://zealusercontributions.vercel.app

Cheers,

-- IL

[1] https://zealdocs.org/
[1] https://phabricator.wikimedia.org/F34943176
[2] https://phabricator.wikimedia.org/F34943177
[4] https://github.com/inductiveload/mediawiki_docset
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

[Daniel Kinzler]

Am 05.02.22 um 21:38 schrieb Amir Sarabadani:
Codesearch has been working fine in the past couple of years. There is a new 
frontend being built and I hope we can deploy it soon to provide a better user 
experience and I personally don't see a value in re-implementing codesearch. 
Especially using non-open source software.


While I agree with several points that have been raised, in particular about 
licensing and building on top of existing tools, I'd like to point out that the 
idea is not to re-implement codesearch, but to overcome some of its limitations. 
What we use codesearch for most is finding usages of methods (and sometimes 
classes). This works fine if the method name is fairly unique. But if the method 
name is generic, or you are moving a method from one class to another an you 
want to find callers of the old method, but not the new method, then regular 
experssions just don't cut it.


Basically, I'd want codesearch to allow me to do the kind of "find callers" 
search that IDEs like phpstorm support. Sure, I could do it in the ID, but I 
can't link to that from a ticket, and I'd have to make sure I have exactky the 
right set of extensions installed (and updated).


A tool very much like codesearch, but based not on regular expressions but 
rather on symbols and their relationships, would be very valuable to me. The 
question how exactly it should be build is of course open.


--
Daniel Kinzler
Principal Software Engineer, Core Platform
Wikimedia Foundation

___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Is there still a maximum page size in effect?

[Strainu]

În sâm., 5 feb. 2022 la 19:53, Andre Klapper  a scris:
>
> On Sat, 2022-02-05 at 18:43 +0200, Strainu wrote:
> > I am aware of the various limits in the NewPP report. I'm trying to
> > determine if we currently we have some max page size (before or after
> > processing).
> >
> > The documentation on mw.org and en.wp is a bit confusing on the
> > subject and personal experimentation shows that substituting
> > templates allows be to go past the 2MiB page size.
>
> What does "personal experimentation" mean exactly? There might be
> exceptions like https://phabricator.wikimedia.org/T188852 but generally
> speaking, as neither
> https://noc.wikimedia.org/conf/InitialiseSettings.php.txt nor
> https://noc.wikimedia.org/conf/CommonSettings.php.txt seem to change
> the MediaWiki software default setting defined in
> https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/DefaultSettings.php$2673
> I'd assume that we're at 2MiB.

Hey Andre,

Thanks for taking the time to respond to my curiosity during the weekend.

Here is what I experimented with:
* for post-parser size (which would have been my first guess given
that for templates we count the *Post‐expand include size*) I just
measured the size of the .mw-parser-output div. For this, I took the
output of [1] (which is a mix of included and substituded templates
and is displayed just fine) and it was well over 8MiB.
* for pre-parser size, I took the same page [1], added some more
templates and started saving while substituting them (e.g. I have 1.5
MiB of text and a few thousand templates which I sustitute in one go).
One version which goes over the 2MiB limit is [2].

Now, because of the way those templates are written (pretty verbose
and with a lot of whitespace) the difference between the template and
the result of the substitution is small, so the page size is just over
the limit, but one can imagine a template expanding near 2MiB the
limit a couple of times could take a page to ~4MiB without much
effort.

I understand from your message that these are bugs and the limit is
still enforced. However, I still don't understand the logic in having
a limit for wikitext in pages, but a limit for post-expand (if I
understand correctly, that is after they go through the parser) in
templates. Why not have a single limit set to something like 8-12-16
MiB and counted after all the processing is done?

Thanks again,
   Strainu

[1] 
https://ro.wikipedia.org/w/index.php?title=Bunuri_mobile_din_domeniul_%C8%99tiin%C8%9Bele_naturii_clasate_%C3%AEn_patrimoniul_cultural_na%C8%9Bional_al_Rom%C3%A2niei_aflate_%C3%AEn_municipiul_Bucure%C8%99ti_(tezaur)=14712585
[2] 
https://ro.wikipedia.org/w/index.php?title=Utilizator:Strainu/2=14784282


>
> See also https://phabricator.wikimedia.org/T189108 about requesting an
> increase, and https://phabricator.wikimedia.org/T181907#3835654
> for some more background.
>
> Cheers,
> andre
> --
> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
> https://blogs.gnome.org/aklapper/
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

[Amir Sarabadani]

I co maintain codesearch with Kunal and I have similar notes. I hope
instead of duplicating the work, we could join forces to improve the
development productivity infrastructure.

Codesearch has been working fine in the past couple of years. There is a
new frontend being built and I hope we can deploy it soon to provide a
better user experience and I personally don't see a value in
re-implementing codesearch. Especially using non-open source software.

In a rather long-term solution, I hope/dream we could implement what Google
has in automating refactoring. It's called LSC [1] (Large Scale Changes)
and we can even piggy back to the library upgrader tool to automate easy
depreciation fixes so developers could focus on complex cases. It's
disheartening to me to see the valuable time of our volunteer developers
being spent on something that could be automated. (For example see the
sheer number of patches made for this deprecation:
https://gerrit.wikimedia.org/r/q/bug:T286694). It doesn't have to be able
to parse php code and do complex magic at first. We can start with simple
regex replacements and then add using rector (a really nice library for
doing refactors in php) and its equivalent in other languages.

[1] For more information see "Software Engineering at Google: Lessons
Learned from Programming Over Time" book:
https://www.goodreads.com/book/show/48816586-software-engineering-at-google

Best

On Sat, Feb 5, 2022 at 2:41 AM Kunal Mehta  wrote:

>
> Hi,
>
> On 2/4/22 08:58, Adam Baso wrote:
> > Thanks for sharing this. I was wondering, might it be possible to help
> > bring this sort of functionality into Code Search (
> > https://codesearch.wmflabs.org  ) ? I
> > noticed the presentation of the search UI looked similar, but I see how
> > the symbol resolution might be something useful for Code Search and
> > upstream Hound.
>
> Indeed, we've been discussing and exploring symbol-based search for a
> while now: . There are some
> pretty neat upstream projects that do this like 
> and zoekt, which is designed for Gerrit integration. I would also note
> that things are likely to change whenever we migrate to GitLab, which
> has its own search functionality built-in
> (). My assumption is that
> GitLab will add symbol-based search eventually to compete with GitHub,
> hopefully that ends up in the CE version someday...
>
> While I very much disagree with the opening proposition that "Working
> with Wikimedia code is time-consuming and risky", I think symbol search
> of the MediaWiki codebase would be incredibly powerful and unlock a new
> level of tooling, just like Codesearch did when it was first introduced,
> so I'm glad to see people looking into it! For example we could do stuff
> like  with it.
>
> There were two main principles in building MediaWiki Codesearch, first
> that everything be licensed as free software[1] (which Bryan covered as
> well) and that we try to use upstream as much as possible. Our
> modifications are injected by a proxy rather than patch the upstream
> code...which has turned out to be incredibly stable over the years.
>
> If you want to collaborate, all the code and setup is in Git and can add
> you to the project, but I see little to no value in building proprietary
> tools or reinventing what other projects have done pretty well rather
> than building on top of them.
>
> [1] https://mako.cc/writing/hill-free_tools.html
>
> -- Legoktm
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>


-- 
Amir (he/him)
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Is there still a maximum page size in effect?

[Andre Klapper]

On Sat, 2022-02-05 at 18:43 +0200, Strainu wrote:
> I am aware of the various limits in the NewPP report. I'm trying to
> determine if we currently we have some max page size (before or after
> processing). 
> 
> The documentation on mw.org and en.wp is a bit confusing on the
> subject and personal experimentation shows that substituting
> templates allows be to go past the 2MiB page size.

What does "personal experimentation" mean exactly? There might be
exceptions like https://phabricator.wikimedia.org/T188852 but generally
speaking, as neither
https://noc.wikimedia.org/conf/InitialiseSettings.php.txt nor
https://noc.wikimedia.org/conf/CommonSettings.php.txt seem to change
the MediaWiki software default setting defined in 
https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/DefaultSettings.php$2673
I'd assume that we're at 2MiB.

See also https://phabricator.wikimedia.org/T189108 about requesting an
increase, and https://phabricator.wikimedia.org/T181907#3835654
for some more background.

Cheers,
andre
-- 
Andre Klapper (he/him) | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing error in pushing the patch

[Shreyaans Jain]

Thanks a lot Siddhart for your reply


On Sat, Feb 5, 2022 at 9:16 PM Siddharth VP  wrote:

> In that case, the problem is as I mentioned above. Only
> Trusted-Contributors can edit others' patches.
>
> Here's something you can try but I'm not sure if it will work or not –
> instead of amending that commit, create a new commit on top of it. (Get a
> fresh copy of the patch by running "git review -d 716255", and then apply
> your changes and commit them separately – basically don't use --amend)
>
> On Sat, 5 Feb 2022 at 19:20, Shreyaans Jain 
> wrote:
>
>> No I am shreyaansjain06 on gerrit I only added the fix docker compose
>> file in git commit -- amend
>> which you can see on git log
>>
>> Also I forgot to mention one thing maybe that will help you find what
>> mistake I am doing ,like the latest code is not in repo
>> So after cloning the repo i ran this command
>>
>> git fetch
>> https://shreyaansjai...@gerrit.wikimedia.org/r/a/labs/tools/VideoCutTool
>> refs/changes/55/716255/10 && git checkout FETCH_HEAD
>>
>> This brings the latest code and i had done changes in this code
>>
>> On Sat, Feb 5, 2022 at 6:55 PM Siddharth VP 
>> wrote:
>>
>>> Ok, so you're actually Khr2003 on Gerrit? Ignore my comment about
>>> editing others' patches then.
>>>
>>> The patch says there's a merge conflict. Try rebasing the branch with
>>> master branch ("git rebase master") before using "git review".
>>>
>>>
>>> On Sat, 5 Feb 2022 at 18:31, Shreyaans Jain 
>>> wrote:
>>>
 Sure

 On Sat, Feb 5, 2022 at 6:25 PM Siddharth VP 
 wrote:

> It looks like you're trying to edit
> https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/716255/
> but you can't do that as only members of Trusted-Contributors group are
> allowed to edit others' patches.
>
> Can you show the output of "git log -1" ?
>
> On Sat, 5 Feb 2022 at 18:00, Shreyaans Jain 
> wrote:
>
>> Thanks Siddharth for your help
>> Tried all steps you suggested but still facing the remote rejected
>> issue
>>
>> On Sat, Feb 5, 2022 at 5:16 PM Siddharth VP 
>> wrote:
>>
>>> I did not say to use "git push". For Gerrit, only "git review"
>>> should be used.
>>>
>>> The error in that screenshot is that you're in a detached HEAD state
>>> (9b6fe4f). You should switch to a branch, "git checkout -b branchname",
>>> then "git review" from there.
>>>
>>> On Sat, 5 Feb 2022 at 17:08, Shreyaans Jain <
>>> shreyaansjai...@gmail.com> wrote:
>>>
 I used git push also that was also giving me error

 Can you suggest me what should I do?

 On Sat, Feb 5, 2022, 17:01 Siddharth VP 
 wrote:

> You need to be on a branch to use git review. You cannot use it
> while in a detached HEAD state.
>
> On Sat, 5 Feb 2022 at 16:53, Shreyaans Jain <
> shreyaansjai...@gmail.com> wrote:
>
>> Thanks for your reply
>>
>> I followed the steps given in that article but i am still facing
>> this issue
>> Can you help me in it?
>>
>> On Sat, Feb 5, 2022, 12:05 Andre Klapper 
>> wrote:
>>
>>> Hi,
>>>
>>> On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
>>> > Hey everyone I was working on Videocuttool
>>> > issue https://phabricator.wikimedia.org/T297992 and now the
>>> issue is
>>> > resolved but I am unable to push the patch. I have properly
>>> > set the ssh key on both my system as well as gerrit and also
>>> did the
>>> > steps many times but still facing the problem. It will be
>>> great if
>>> > anyone can help me in it .
>>>
>>> Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial
>>>
>>> Thanks,
>>> andre
>>> --
>>> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
>>> https://blogs.gnome.org/aklapper/
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to
>>> wikitech-l-le...@lists.wikimedia.org
>>>
>>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to
>> wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to
> wikitech-l-le...@lists.wikimedia.org
>
> 

[Wikitech-l] Is there still a maximum page size in effect?

[Strainu]

Hi,

I am aware of the various limits in the NewPP report. I'm trying to
determine if we currently we have some max page size (before or after
processing).

The documentation on mw.org and en.wp is a bit confusing on the subject and
personal experimentation shows that substituting templates allows be to go
past the 2MiB page size.

If we don't have such a limit, I'm not exactly sure why do we need the
Post‐expand include size limit? Why is output generated by transclusion
harder on the parser than output directly in the page?

Thanks,
 Strainu
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing error in pushing the patch

[Siddharth VP]

In that case, the problem is as I mentioned above. Only
Trusted-Contributors can edit others' patches.

Here's something you can try but I'm not sure if it will work or not –
instead of amending that commit, create a new commit on top of it. (Get a
fresh copy of the patch by running "git review -d 716255", and then apply
your changes and commit them separately – basically don't use --amend)

On Sat, 5 Feb 2022 at 19:20, Shreyaans Jain 
wrote:

> No I am shreyaansjain06 on gerrit I only added the fix docker compose file
> in git commit -- amend
> which you can see on git log
>
> Also I forgot to mention one thing maybe that will help you find what
> mistake I am doing ,like the latest code is not in repo
> So after cloning the repo i ran this command
>
> git fetch
> https://shreyaansjai...@gerrit.wikimedia.org/r/a/labs/tools/VideoCutTool
> refs/changes/55/716255/10 && git checkout FETCH_HEAD
>
> This brings the latest code and i had done changes in this code
>
> On Sat, Feb 5, 2022 at 6:55 PM Siddharth VP  wrote:
>
>> Ok, so you're actually Khr2003 on Gerrit? Ignore my comment about editing
>> others' patches then.
>>
>> The patch says there's a merge conflict. Try rebasing the branch with
>> master branch ("git rebase master") before using "git review".
>>
>>
>> On Sat, 5 Feb 2022 at 18:31, Shreyaans Jain 
>> wrote:
>>
>>> Sure
>>>
>>> On Sat, Feb 5, 2022 at 6:25 PM Siddharth VP 
>>> wrote:
>>>
 It looks like you're trying to edit
 https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/716255/ but
 you can't do that as only members of Trusted-Contributors group are allowed
 to edit others' patches.

 Can you show the output of "git log -1" ?

 On Sat, 5 Feb 2022 at 18:00, Shreyaans Jain 
 wrote:

> Thanks Siddharth for your help
> Tried all steps you suggested but still facing the remote rejected
> issue
>
> On Sat, Feb 5, 2022 at 5:16 PM Siddharth VP 
> wrote:
>
>> I did not say to use "git push". For Gerrit, only "git review" should
>> be used.
>>
>> The error in that screenshot is that you're in a detached HEAD state
>> (9b6fe4f). You should switch to a branch, "git checkout -b branchname",
>> then "git review" from there.
>>
>> On Sat, 5 Feb 2022 at 17:08, Shreyaans Jain <
>> shreyaansjai...@gmail.com> wrote:
>>
>>> I used git push also that was also giving me error
>>>
>>> Can you suggest me what should I do?
>>>
>>> On Sat, Feb 5, 2022, 17:01 Siddharth VP 
>>> wrote:
>>>
 You need to be on a branch to use git review. You cannot use it
 while in a detached HEAD state.

 On Sat, 5 Feb 2022 at 16:53, Shreyaans Jain <
 shreyaansjai...@gmail.com> wrote:

> Thanks for your reply
>
> I followed the steps given in that article but i am still facing
> this issue
> Can you help me in it?
>
> On Sat, Feb 5, 2022, 12:05 Andre Klapper 
> wrote:
>
>> Hi,
>>
>> On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
>> > Hey everyone I was working on Videocuttool
>> > issue https://phabricator.wikimedia.org/T297992 and now the
>> issue is
>> > resolved but I am unable to push the patch. I have properly
>> > set the ssh key on both my system as well as gerrit and also
>> did the
>> > steps many times but still facing the problem. It will be great
>> if
>> > anyone can help me in it .
>>
>> Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial
>>
>> Thanks,
>> andre
>> --
>> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
>> https://blogs.gnome.org/aklapper/
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to
>> wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to
> wikitech-l-le...@lists.wikimedia.org
>
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

 ___
 Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
 To unsubscribe send an email to
 wikitech-l-le...@lists.wikimedia.org

 https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>>
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to 

[Wikitech-l] Re: Facing error in pushing the patch

[Shreyaans Jain]

No I am shreyaansjain06 on gerrit I only added the fix docker compose file
in git commit -- amend
which you can see on git log

Also I forgot to mention one thing maybe that will help you find what
mistake I am doing ,like the latest code is not in repo
So after cloning the repo i ran this command

git fetch
https://shreyaansjai...@gerrit.wikimedia.org/r/a/labs/tools/VideoCutTool
refs/changes/55/716255/10 && git checkout FETCH_HEAD

This brings the latest code and i had done changes in this code

On Sat, Feb 5, 2022 at 6:55 PM Siddharth VP  wrote:

> Ok, so you're actually Khr2003 on Gerrit? Ignore my comment about editing
> others' patches then.
>
> The patch says there's a merge conflict. Try rebasing the branch with
> master branch ("git rebase master") before using "git review".
>
>
> On Sat, 5 Feb 2022 at 18:31, Shreyaans Jain 
> wrote:
>
>> Sure
>>
>> On Sat, Feb 5, 2022 at 6:25 PM Siddharth VP 
>> wrote:
>>
>>> It looks like you're trying to edit
>>> https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/716255/ but
>>> you can't do that as only members of Trusted-Contributors group are allowed
>>> to edit others' patches.
>>>
>>> Can you show the output of "git log -1" ?
>>>
>>> On Sat, 5 Feb 2022 at 18:00, Shreyaans Jain 
>>> wrote:
>>>
 Thanks Siddharth for your help
 Tried all steps you suggested but still facing the remote rejected
 issue

 On Sat, Feb 5, 2022 at 5:16 PM Siddharth VP 
 wrote:

> I did not say to use "git push". For Gerrit, only "git review" should
> be used.
>
> The error in that screenshot is that you're in a detached HEAD state
> (9b6fe4f). You should switch to a branch, "git checkout -b branchname",
> then "git review" from there.
>
> On Sat, 5 Feb 2022 at 17:08, Shreyaans Jain 
> wrote:
>
>> I used git push also that was also giving me error
>>
>> Can you suggest me what should I do?
>>
>> On Sat, Feb 5, 2022, 17:01 Siddharth VP 
>> wrote:
>>
>>> You need to be on a branch to use git review. You cannot use it
>>> while in a detached HEAD state.
>>>
>>> On Sat, 5 Feb 2022 at 16:53, Shreyaans Jain <
>>> shreyaansjai...@gmail.com> wrote:
>>>
 Thanks for your reply

 I followed the steps given in that article but i am still facing
 this issue
 Can you help me in it?

 On Sat, Feb 5, 2022, 12:05 Andre Klapper 
 wrote:

> Hi,
>
> On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
> > Hey everyone I was working on Videocuttool
> > issue https://phabricator.wikimedia.org/T297992 and now the
> issue is
> > resolved but I am unable to push the patch. I have properly
> > set the ssh key on both my system as well as gerrit and also did
> the
> > steps many times but still facing the problem. It will be great
> if
> > anyone can help me in it .
>
> Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial
>
> Thanks,
> andre
> --
> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
> https://blogs.gnome.org/aklapper/
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to
> wikitech-l-le...@lists.wikimedia.org
>
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

 ___
 Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
 To unsubscribe send an email to
 wikitech-l-le...@lists.wikimedia.org

 https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>>
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>>
>>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

 ___
 Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
 To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org

 

[Wikitech-l] Re: Facing error in pushing the patch

[Siddharth VP]

Ok, so you're actually Khr2003 on Gerrit? Ignore my comment about editing
others' patches then.

The patch says there's a merge conflict. Try rebasing the branch with
master branch ("git rebase master") before using "git review".


On Sat, 5 Feb 2022 at 18:31, Shreyaans Jain 
wrote:

> Sure
>
> On Sat, Feb 5, 2022 at 6:25 PM Siddharth VP  wrote:
>
>> It looks like you're trying to edit
>> https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/716255/ but
>> you can't do that as only members of Trusted-Contributors group are allowed
>> to edit others' patches.
>>
>> Can you show the output of "git log -1" ?
>>
>> On Sat, 5 Feb 2022 at 18:00, Shreyaans Jain 
>> wrote:
>>
>>> Thanks Siddharth for your help
>>> Tried all steps you suggested but still facing the remote rejected issue
>>>
>>> On Sat, Feb 5, 2022 at 5:16 PM Siddharth VP 
>>> wrote:
>>>
 I did not say to use "git push". For Gerrit, only "git review" should
 be used.

 The error in that screenshot is that you're in a detached HEAD state
 (9b6fe4f). You should switch to a branch, "git checkout -b branchname",
 then "git review" from there.

 On Sat, 5 Feb 2022 at 17:08, Shreyaans Jain 
 wrote:

> I used git push also that was also giving me error
>
> Can you suggest me what should I do?
>
> On Sat, Feb 5, 2022, 17:01 Siddharth VP  wrote:
>
>> You need to be on a branch to use git review. You cannot use it while
>> in a detached HEAD state.
>>
>> On Sat, 5 Feb 2022 at 16:53, Shreyaans Jain <
>> shreyaansjai...@gmail.com> wrote:
>>
>>> Thanks for your reply
>>>
>>> I followed the steps given in that article but i am still facing
>>> this issue
>>> Can you help me in it?
>>>
>>> On Sat, Feb 5, 2022, 12:05 Andre Klapper 
>>> wrote:
>>>
 Hi,

 On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
 > Hey everyone I was working on Videocuttool
 > issue https://phabricator.wikimedia.org/T297992 and now the
 issue is
 > resolved but I am unable to push the patch. I have properly
 > set the ssh key on both my system as well as gerrit and also did
 the
 > steps many times but still facing the problem. It will be great if
 > anyone can help me in it .

 Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial

 Thanks,
 andre
 --
 Andre Klapper (he/him) | Bugwrangler / Developer Advocate
 https://blogs.gnome.org/aklapper/
 ___
 Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
 To unsubscribe send an email to
 wikitech-l-le...@lists.wikimedia.org

 https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>>
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>>
>>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

 ___
 Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
 To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org

 https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>>
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>>
>>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an 

[Wikitech-l] Re: Facing error in pushing the patch

[Siddharth VP]

It looks like you're trying to edit
https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/716255/ but you
can't do that as only members of Trusted-Contributors group are allowed to
edit others' patches.

Can you show the output of "git log -1" ?

On Sat, 5 Feb 2022 at 18:00, Shreyaans Jain 
wrote:

> Thanks Siddharth for your help
> Tried all steps you suggested but still facing the remote rejected issue
>
> On Sat, Feb 5, 2022 at 5:16 PM Siddharth VP  wrote:
>
>> I did not say to use "git push". For Gerrit, only "git review" should be
>> used.
>>
>> The error in that screenshot is that you're in a detached HEAD state
>> (9b6fe4f). You should switch to a branch, "git checkout -b branchname",
>> then "git review" from there.
>>
>> On Sat, 5 Feb 2022 at 17:08, Shreyaans Jain 
>> wrote:
>>
>>> I used git push also that was also giving me error
>>>
>>> Can you suggest me what should I do?
>>>
>>> On Sat, Feb 5, 2022, 17:01 Siddharth VP  wrote:
>>>
 You need to be on a branch to use git review. You cannot use it while
 in a detached HEAD state.

 On Sat, 5 Feb 2022 at 16:53, Shreyaans Jain 
 wrote:

> Thanks for your reply
>
> I followed the steps given in that article but i am still facing this
> issue
> Can you help me in it?
>
> On Sat, Feb 5, 2022, 12:05 Andre Klapper 
> wrote:
>
>> Hi,
>>
>> On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
>> > Hey everyone I was working on Videocuttool
>> > issue https://phabricator.wikimedia.org/T297992 and now the issue
>> is
>> > resolved but I am unable to push the patch. I have properly
>> > set the ssh key on both my system as well as gerrit and also did the
>> > steps many times but still facing the problem. It will be great if
>> > anyone can help me in it .
>>
>> Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial
>>
>> Thanks,
>> andre
>> --
>> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
>> https://blogs.gnome.org/aklapper/
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

 ___
 Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
 To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org

 https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>>
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>>
>>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing a Problem in issue #105

[AMEY Gupta]

Hey I have posted the proper link and issue I am facing on zulip in general
under(help needed) topic pls check it and let me know what  I am doing
wrong.

On Sat, 5 Feb, 2022, 11:16 am Greg Grossmeier,  wrote:

> Hi,
>
> Searching for "afch-rewrite" leads me to
> https://github.com/WPAFC/afch-rewrite with the homepage of
> https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Articles_for_creation/Helper_script
>  .
> I presume that is what this is about.
>
> Their documentation says they use a Zulip for communication:
> https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Articles_for_creation/Helper_script/Contributing#Need_help?
>
>
> Might want to try there if the github issue isn't proving helpful.
>
> Best,
>
> Greg
>
> On Fri, Feb 4, 2022 at 9:08 PM AMEY Gupta  wrote:
>
>> Hey I am facing a problem in issue #105  in ( afch-rewrite). I am
>> following this approach for (avoiding empty comments) . At first I wrote a
>> function to calculate the length of the text area and if the text area's
>> length is 0 then I,ll disabled the button . but I am getting confused about
>> how to get the button disabled .
>>
>>   Screenshot (302)_LI.jpg
>> 
>>
>>   Screenshot (303)_LI.jpg
>> 
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> On Fri, 4 Feb, 2022, 10:07 pm Andre Klapper, 
>> wrote:
>>
>>> On Fri, 2022-02-04 at 20:31 +0530, Ameygupta wrote:
>>> > Hey I am facing a problem in issue #105 (Don.t enter empty comments)
>>> > can anyone help me about it ?
>>>
>>> Not without further context, I'm afraid. :) What and where is "issue
>>> #105"? Please provide sufficient context, as this is a mailing list
>>> with hundreds of members and about any kind of Wikimedia related
>>> development (which means thousands of software projects).
>>>
>>> Thanks,
>>> andre
>>> --
>>> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
>>> https://blogs.gnome.org/aklapper/
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>>
>>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>>
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing error in pushing the patch

[Siddharth VP]

I did not say to use "git push". For Gerrit, only "git review" should be
used.

The error in that screenshot is that you're in a detached HEAD state
(9b6fe4f). You should switch to a branch, "git checkout -b branchname",
then "git review" from there.

On Sat, 5 Feb 2022 at 17:08, Shreyaans Jain 
wrote:

> I used git push also that was also giving me error
>
> Can you suggest me what should I do?
>
> On Sat, Feb 5, 2022, 17:01 Siddharth VP  wrote:
>
>> You need to be on a branch to use git review. You cannot use it while in
>> a detached HEAD state.
>>
>> On Sat, 5 Feb 2022 at 16:53, Shreyaans Jain 
>> wrote:
>>
>>> Thanks for your reply
>>>
>>> I followed the steps given in that article but i am still facing this
>>> issue
>>> Can you help me in it?
>>>
>>> On Sat, Feb 5, 2022, 12:05 Andre Klapper  wrote:
>>>
 Hi,

 On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
 > Hey everyone I was working on Videocuttool
 > issue https://phabricator.wikimedia.org/T297992 and now the issue is
 > resolved but I am unable to push the patch. I have properly
 > set the ssh key on both my system as well as gerrit and also did the
 > steps many times but still facing the problem. It will be great if
 > anyone can help me in it .

 Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial

 Thanks,
 andre
 --
 Andre Klapper (he/him) | Bugwrangler / Developer Advocate
 https://blogs.gnome.org/aklapper/
 ___
 Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
 To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org

 https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>>
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>>
>>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing error in pushing the patch

[Shreyaans Jain]

I used git push also that was also giving me error

Can you suggest me what should I do?

On Sat, Feb 5, 2022, 17:01 Siddharth VP  wrote:

> You need to be on a branch to use git review. You cannot use it while in a
> detached HEAD state.
>
> On Sat, 5 Feb 2022 at 16:53, Shreyaans Jain 
> wrote:
>
>> Thanks for your reply
>>
>> I followed the steps given in that article but i am still facing this
>> issue
>> Can you help me in it?
>>
>> On Sat, Feb 5, 2022, 12:05 Andre Klapper  wrote:
>>
>>> Hi,
>>>
>>> On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
>>> > Hey everyone I was working on Videocuttool
>>> > issue https://phabricator.wikimedia.org/T297992 and now the issue is
>>> > resolved but I am unable to push the patch. I have properly
>>> > set the ssh key on both my system as well as gerrit and also did the
>>> > steps many times but still facing the problem. It will be great if
>>> > anyone can help me in it .
>>>
>>> Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial
>>>
>>> Thanks,
>>> andre
>>> --
>>> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
>>> https://blogs.gnome.org/aklapper/
>>> ___
>>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>>
>>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing error in pushing the patch

[Siddharth VP]

You need to be on a branch to use git review. You cannot use it while in a
detached HEAD state.

On Sat, 5 Feb 2022 at 16:53, Shreyaans Jain 
wrote:

> Thanks for your reply
>
> I followed the steps given in that article but i am still facing this
> issue
> Can you help me in it?
>
> On Sat, Feb 5, 2022, 12:05 Andre Klapper  wrote:
>
>> Hi,
>>
>> On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
>> > Hey everyone I was working on Videocuttool
>> > issue https://phabricator.wikimedia.org/T297992 and now the issue is
>> > resolved but I am unable to push the patch. I have properly
>> > set the ssh key on both my system as well as gerrit and also did the
>> > steps many times but still facing the problem. It will be great if
>> > anyone can help me in it .
>>
>> Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial
>>
>> Thanks,
>> andre
>> --
>> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
>> https://blogs.gnome.org/aklapper/
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing error in pushing the patch

[Shreyaans Jain]

Thanks for your reply

I followed the steps given in that article but i am still facing this issue
Can you help me in it?

On Sat, Feb 5, 2022, 12:05 Andre Klapper  wrote:

> Hi,
>
> On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
> > Hey everyone I was working on Videocuttool
> > issue https://phabricator.wikimedia.org/T297992 and now the issue is
> > resolved but I am unable to push the patch. I have properly
> > set the ssh key on both my system as well as gerrit and also did the
> > steps many times but still facing the problem. It will be great if
> > anyone can help me in it .
>
> Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial
>
> Thanks,
> andre
> --
> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
> https://blogs.gnome.org/aklapper/
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/