[Wikitech-l] Re: Removal of the mw.eventLog.Schema class without deprecation

2022-04-14 Thread Sam Smith
On Thu, Apr 14, 2022 at 5:25 PM Dan Andreescu 
wrote:

> On Thu, Apr 14, 2022 at 12:07 PM David Lynch  wrote:
>
>> This is still used in some MobileFrontend and DiscussionTools code. The
>> codesearch would be better done as
>> https://codesearch.wmcloud.org/search/?q=mw.eventLog.Schema=nope=js==
>>
>
> ah! I missed the open paren ( in the original search, good eye!
>

Seconded! Thanks, David!
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Removal of the mw.eventLog.Schema class without deprecation

2022-04-14 Thread Dan Andreescu
On Thu, Apr 14, 2022 at 12:07 PM David Lynch  wrote:

> This is still used in some MobileFrontend and DiscussionTools code. The
> codesearch would be better done as
> https://codesearch.wmcloud.org/search/?q=mw.eventLog.Schema=nope=js==
>

ah! I missed the open paren ( in the original search, good eye!
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Removal of the mw.eventLog.Schema class without deprecation

2022-04-14 Thread David Lynch
This is still used in some MobileFrontend and DiscussionTools code. The
codesearch would be better done as
https://codesearch.wmcloud.org/search/?q=mw.eventLog.Schema=nope=js==

I have no aversion to working to migrate those uses away from it, of
course. They're just blockers for actually deleting the class.

(I've commented to this effect on the ticket as well.)

On Thu, Apr 14, 2022 at 10:58 AM Sam Smith  wrote:

> Hello,
>
> I've proposed the removal of the mw.eventLog.Schema class without
> deprecation.
>
> Patch: https://gerrit.wikimedia.org/r/780882
> Phab task: https://phabricator.wikimedia.org/T305491
> Uses:
> - https://codesearch.wmcloud.org/search/?q=%5C.Schema%5C(=js
> -
> https://global-search.toolforge.org/?q=%5C.Schema%5C%28=1=2%2C4%2C8=%28Gadgets-definition%7C.*%5C.%28js%7Ccss%7Cjson%29%29
>
> The EventLogging extension provides the mw.eventLog.Schema class as part
> of its JavaScript API. The class was introduced circa 2015 and was used in
> a handful of extensions maintained by the Readers Web team around that
> time. As of writing, however, it is not used in any Wikimedia-hosted
> codebase, user script, or gadget.
>
> Thanks,
>
> -Sam
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Removal of the mw.eventLog.Schema class without deprecation

2022-04-14 Thread Sam Smith
Hello,

I've proposed the removal of the mw.eventLog.Schema class without
deprecation.

Patch: https://gerrit.wikimedia.org/r/780882
Phab task: https://phabricator.wikimedia.org/T305491
Uses:
- https://codesearch.wmcloud.org/search/?q=%5C.Schema%5C(=js
-
https://global-search.toolforge.org/?q=%5C.Schema%5C%28=1=2%2C4%2C8=%28Gadgets-definition%7C.*%5C.%28js%7Ccss%7Cjson%29%29

The EventLogging extension provides the mw.eventLog.Schema class as part of
its JavaScript API. The class was introduced circa 2015 and was used in a
handful of extensions maintained by the Readers Web team around that time.
As of writing, however, it is not used in any Wikimedia-hosted codebase,
user script, or gadget.

Thanks,

-Sam
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/