[Wikitech-l] Presenting about transparency in Wikimedia's technical spaces - July 23, 17:00 UTC

2022-07-22 Thread Kunal Mehta
Hi, Tomorrow at the HOPE 2022 conference, I'm giving a talk titled, "How to Run a Top-10 Website, Publicly and Transparently", discussing the impact of transparency in Wikimedia's technical spaces. A number of people have expressed interest in watching, including non-technical users, so I'm

[Wikitech-l] +2 nomination for Dreamy_Jazz in mediawiki/extensions/CheckUser

2022-06-25 Thread Kunal Mehta
Hi, I have nominated Dreamy_Jazz for +2 rights in the CheckUser extension, please feel free to comment at . Thanks, -- Legoktm ___ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe

[Wikitech-l] Goodbye Special:CodeReview

2022-05-20 Thread Kunal Mehta
Hi, You may have noticed recently that some links like redirect to a new static dump of code review pages (e.g. ) to preserve the comments that often provide an important

[Wikitech-l] Re: Requesting feedback about the future of the LocalisationUpdate extension

2022-05-09 Thread Kunal Mehta
Hi, On 4/27/22 07:22, Niklas Laxström wrote: Since the beginning of the year, the Wikimedia Language team has enabled translation backports for MediaWiki core, extensions and skins hosted on Gerrit. On a weekly schedule compatible translations from master branch are backpored to all the

[Wikitech-l] Re: RelEng GitLab-a-thon sprint next week; skipping 1.39.0-wmf.11 train

2022-05-06 Thread Kunal Mehta
Hi, On 5/2/22 12:55, Brennen Bearnes wrote: Goal for this sprint:***Migration of blubber / blubberoid to GitLab* This sounds great, but...that also means blubber is going to disappear from IRC notifications[1], will be disconnected from Phabricator[2], etc. The ticket for getting

[Wikitech-l] Re: Swag program for technical contributors

2022-04-08 Thread Kunal Mehta
Hi, On 4/7/22 17:08, Srishti Sethi wrote: This is a small token of appreciation for the countless efforts of our technical contributors! This is awesome, thank you everyone who worked on this! At the risk of looking a gift horse in the mouth, I hope in future years we can have more

[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

2022-02-11 Thread Kunal Mehta
Hi, On 2/5/22 13:18, Daniel Kinzler wrote: Basically, I'd want codesearch to allow me to do the kind of "find callers" search that IDEs like phpstorm support. Sure, I could do it in the ID, but I can't link to that from a ticket, and I'd have to make sure I have exactky the right set of

[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

2022-02-04 Thread Kunal Mehta
Hi, On 2/4/22 08:58, Adam Baso wrote: Thanks for sharing this. I was wondering, might it be possible to help bring this sort of functionality into Code Search ( https://codesearch.wmflabs.org ) ? I noticed the presentation of the search UI looked similar,

[Wikitech-l] Re: [Wikimedia-l] Re: Re: Uplifting the multimedia stack (was: Community Wishlist Survery)

2022-01-10 Thread Kunal Mehta
Hi, On 1/1/22 12:10, Asaf Bartov wrote: It seems to me there are *very few* people who could change status quo, not much more than a handful: the Foundation's executive leadership (in its annual planning work, coming up this first quarter of 2022), and the Board of Trustees. If the goal is

[Wikitech-l] Re: Repository ownership of the Lingo extension

2022-01-08 Thread Kunal Mehta
Hi, On 1/8/22 11:13, Zoran Dori wrote: I want to notify you that I have, on behalf of the WikiTeq company, made a task https://phabricator.wikimedia.org/T298277 for requesting repository ownership for the Lingo extension. I fulfilled the

[Wikitech-l] Looking for new maintainer for packagist-mirror.wmcloud.org

2021-12-09 Thread Kunal Mehta
Hi, is exactly what it sounds like, a mirror of the metadata on packagist.org. It's very simple, just a systemd timer and some Apache config. Since setting it up 2 or 3 years ago I've barely had to touch it. And based on access logs, some people are

[Wikitech-l] Making $wgLegalTitleChars easier to use outside PHP

2021-12-09 Thread Kunal Mehta
Hi, Myself and Erutuon are working on writing a Rust library[1] that validates and normalizes MediaWiki page titles, initially for use in bots and tools, but it has other potential use cases too. There is some prior art for this, a mediawiki-title npm package[2] is used by various nodejs

[Wikitech-l] Re: Nomination for Zabe to have +2 in mediawiki/

2021-12-02 Thread Kunal Mehta
I have closed the request as unanimously successful. Congrats Zabe! -- Legoktm On 11/21/21 10:08 PM, Kunal Mehta wrote: Hi, I've nominated Zabe for +2 rights in all mediawiki/* repositories: <https://phabricator.wikimedia.org/T296165>. -- L

[Wikitech-l] Nomination for Zabe to have +2 in mediawiki/

2021-11-21 Thread Kunal Mehta
Hi, I've nominated Zabe for +2 rights in all mediawiki/* repositories: . -- Legoktm ___ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe send an email to

[Wikitech-l] Removing the "fonts" submodule from operations/mediawiki-config

2021-10-26 Thread Kunal Mehta
Hi, tl;dr: The "fonts" submodule in operations/mediawiki-config will go away For a very long time, we've had a Git repository, operations/mediawiki-config/fonts, that contains a random assortment of font files copied out of an Ubuntu appserver back in 2008. My understanding is that these

[Wikitech-l] Re: Wikimedia Enterprise HTML dumps available for public download

2021-10-19 Thread Kunal Mehta
Hi, On 10/19/21 7:57 AM, Ariel Glenn WMF wrote: I am pleased to announce that Wikimedia Enterprise's HTML dumps [1] for October 17-18th are available for public download; see https://dumps.wikimedia.org/other/enterprise_html/ for more

[Wikitech-l] Score, Kubernetes and switching to Shellbox

2021-10-05 Thread Kunal Mehta
Hi everyone, tl;dr: External shell outs are now run via Shellbox. Any deployed code needs to use Shellbox/BoxedCommand, and documentation is available to help migrate. To safely re-enable Score (LilyPond) on Wikimedia wikis, we developed Shellbox, a way to run shell commands in a remote,

[Wikitech-l] Datacenter switchover recap

2021-09-14 Thread Kunal Mehta
Hi, This week's datacenter switchovers went very smoothly overall, in total we had 2 minutes and 42 seconds of read-only time when switching MediaWiki from the codfw to eqiad datacenter, which is pretty close to the 2 minutes we were aiming for. The main follow-up task from today is that

[Wikitech-l] Re: Next datacenter switchover: week of Sept. 13

2021-09-09 Thread Kunal Mehta
Hi, Just a reminder that this is happening next week. On 8/4/21 1:27 PM, Kunal Mehta wrote: Services: Monday, Sept 13th 14:00 UTC Traffic: Monday, Sept 13th 15:00 UTC MediaWiki: Tuesday, Sept 14th 14:00 UTC The services/traffic switchovers should be invisible to users, while we expect

[Wikitech-l] Have CI perform basic checks on package-lock.json

2021-09-05 Thread Kunal Mehta
Hi, package-lock.json is basically impossible to manually review but we still have to do some form of basic checking on its contents. I'd like to introduce a small, conservative tool that does *some* of these checks for of us. package-lock-lint[1] currently checks that: * package-lock.json

[Wikitech-l] Re: WVUI v0.3.0 released – last minor version incl. new components

2021-08-27 Thread Kunal Mehta
Hi, On 8/26/21 11:48 PM, Volker E. wrote: We've released version 0.3.0 of WVUI earlier today. One of the agreements from Vue.js developer summit [0] organized by the Design System team has been to start a new library and repository next with all other technical decisions made, a.o. being based

[Wikitech-l] Re: Nomination for Majavah to get +2 rights in mediawiki/

2021-08-27 Thread Kunal Mehta
With a unanimous consensus, I have granted Majavah +2 rights. Congrats! -- Legoktm ___ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org

[Wikitech-l] Nomination for Majavah to get +2 rights in mediawiki/

2021-08-19 Thread Kunal Mehta
Hi everyone, I have filed to nominate Majavah for +2 rights in all mediawiki/* Gerrit repositories. Thanks, -- Legoktm ___ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe send an

[Wikitech-l] Re: reviewer for extension

2021-08-13 Thread Kunal Mehta
Hi, On 8/13/21 6:21 AM, Andre Klapper wrote: Is this about https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043 as that is the only open changeset listed under https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ? I wonder if it makes sense to change the

[Wikitech-l] Re:  Summary of 1.37.0-wmf.17 train deployment

2021-08-12 Thread Kunal Mehta
On 8/11/21 5:56 PM, Mukunda Modell wrote: Yes I know James is mentioned twice. There really aren't enough thank-yous for all that James does. This, 100%. <3 -- Legoktm ___ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe send

[Wikitech-l] Next datacenter switchover: week of Sept. 13

2021-08-04 Thread Kunal Mehta
Hi, The next datacenter switchover, going from codfw (Texas) to eqiad (Virginia), will be the week of Sept. 13. The schedule is as follows: Services: Monday, Sept 13th 14:00 UTC Traffic: Monday, Sept 13th 15:00 UTC MediaWiki: Tuesday, Sept 14th 14:00 UTC If you're not familiar with this

[Wikitech-l] Use ircservserv to manage your IRC channel

2021-07-23 Thread Kunal Mehta
Hi, As part of the Libera Chat migration, myself and some others worked on developing "ircservserv"[0], which allows you to mostly manage IRC channel ACLs and settings using Git. Basically think GitOps, but for IRC. Instead of having to look up the various ChanServ and /mode commands each

[Wikitech-l] Re: Update on DC switchover

2021-06-29 Thread Kunal Mehta
Hi again, Today we switched MediaWiki from our eqiad datacenter to codfw. In total there was 1 minute 57 seconds of read-only time, which is basically what we were aiming for. We really only had one user-facing issue in that tr.wikivoyage.org was inaccessible for a few minutes because of a

[Wikitech-l] Update on DC switchover

2021-06-28 Thread Kunal Mehta
Hi, Today we switched over most services and traffic caches from the eqiad (Virginia) datacenter to codfw (Texas) as part of improving our reliability. The goal is to have this procedure working and regularly tested in case of an emergency when we actually need it. We're only aware of one

[Wikitech-l] Please autovoice wikibugs in your IRC channel

2021-06-24 Thread Kunal Mehta
Hi, wikibugs needs to be autovoiced in all the IRC channels it speaks in to avoid being killed by antispam bots. If wikibugs speaks in your channel and isn't voiced, please have a channel founder autovoice it: /msg chanserv flags <#channel> wikibugs +Vv

[Wikitech-l] Re: Thank you Tuesday

2021-06-24 Thread Kunal Mehta
On 6/22/21 3:42 PM, Amir Sarabadani wrote: Hi, Lots of people thanked me for deploying mailman3 but I want to mention that it would have not been possible without Wikimedia Cloud Services team giving a lot of resources to me so I could have a test setup and puppetize mailman3 easily which in

[Wikitech-l] Re: Mailman 3 - is there an API available?

2021-06-19 Thread Kunal Mehta
Hi, On 6/19/21 5:32 AM, Martin Urbanec wrote: does Mailman 3 (as-installed by Wikimedia) have an API I could use? Yes it has an API, but it's not available for public access. Everything in Mailman3 is driven by a REST API, however that API has a single user/password and has access to do

[Wikitech-l] Re: Upstream shutdowns

2021-06-05 Thread Kunal Mehta
On 6/5/21 10:56 AM, Amir Sarabadani wrote: I think one part of the problem is that we don't have a comprehensive catalog of our dependencies and their dependencies (and so on). Do you mean something different than ? (which is missing a lot

[Wikitech-l] Re: [Mediawiki-api] [Mediawiki-api-announce] Action API: Removal of deprecated CSRF token parameters

2021-06-02 Thread Kunal Mehta
Hi, On 6/2/21 9:02 AM, Petr Pchelko wrote: TLDR: We will soon remove some parameters that were used to obtain CSRF tokens in the MediaWiki API. This will break bots, gadgets and user scripts that are still using these parameters. Can we get a list of those bots/scripts that are still using

[Wikitech-l] Upstream shutdowns

2021-06-01 Thread Kunal Mehta
On 5/29/21 5:59 PM, Brian Wolff wrote: It sounds like phabricator upstream is going away: https://admin.phacility.com/phame/post/view/11/phacility_is_winding_down_operations/ On the general topic, it's

[Wikitech-l] IRC channels are moving to Libera Chat

2021-05-25 Thread Kunal Mehta
tl;dr: * Wikimedia IRC channels are moving from Freenode to Libera.Chat. * Register an account on Libera.Chat and join us there! There has been a lot of activity over the past week related to staffing changes on the Freenode IRC network [0]. The Wikimedia IRC Group Contacts (GCs) [1] evaluated

[Wikitech-l] Thank you Xqt

2021-05-07 Thread Kunal Mehta
I was looking at Pywikibot's commit stats for something and noticed that as of earlier today, `git shortlog -s` reports that Xqt hit 4,000 commits in the pywikibot/core repository! For comparison, the next human is at 822 commits. In total the repository has a little over 9,800 commits, of

[Wikitech-l] Next datacenter switchover planned for week of June 28th

2021-04-29 Thread Kunal Mehta
Hi, The next datacenter switchover is scheduled for the week of June 28th. If you're not familiar with why we do this, I'd suggest reading [1]. Starting next week I'll be reaching out to service owners/maintainers to finalize the list of services that we will be switching over, checking

[Wikitech-l] Upstream release notifications on Phabricator

2021-04-19 Thread Kunal Mehta
Hi, LibUp can now notify you about new upstream releases in Phabricator. An example: . It'll check daily to see if an upstream project has a new release, and if so, file a Phabricator task. If it already filed a task that's still open, it'll leave

Re: [Wikitech-l] Problems with the CI

2021-04-13 Thread Kunal Mehta
Hi, On 4/13/21 7:47 PM, Zoran Dori wrote: > I would like to know why is this happening. See https://phabricator.wikimedia.org/T280064 and https://phabricator.wikimedia.org/T234020#6989290. Daimona has proposed https://gerrit.wikimedia.org/r/c/integration/config/+/678383/ to hopefully fix

Re: [Wikitech-l] [MediaWiki-l] Security and maintenance release: 1.31.13 / 1.35.2

2021-04-09 Thread Kunal Mehta
Hi, On 4/8/21 12:34 PM, Sam Reed wrote: T279451 also does not apply to MediaWiki 1.31.13, as Parsoid is not bundled. If you use the node.js service, it is recommended to update this. To follow-up on this, 0.11.1[0] of Parsoid/JS has been relesed with a fix. You can get it from the apt

Re: [Wikitech-l] [Wikimedia-l] Test Mailman3 in production

2021-03-26 Thread Kunal Mehta
Hi, On 3/25/21 11:45 PM, Pankaj Jangid wrote: One question. I subscribe to this list via the NNTP bridge hosted at gmane.io. Will the change make any difference at that end? I mean do the administrators of Gmane require any change? My understanding is that Gmane is subscribed to our mailing

Re: [Wikitech-l] Train vs Backport for Wikimedia Deployment

2021-03-23 Thread Kunal Mehta
Hi, On 3/18/21 1:49 PM, Tyler Cipriani wrote: Over time The Train™ has become the default way to deploy changes to Wikimedia's MediaWiki cluster -- for some patches that may not always be the right path. If a developer needs a change deployed *now*, or if there is a desire to deploy a change

Re: [Wikitech-l] Production Excellence #29: February 2021

2021-03-22 Thread Kunal Mehta
On 3/5/21 5:16 PM, Krinkle wrote:  /*Did you know*: Our Incident reports have switched to using the ISO date format in their titles and listings, for improved readability and edit-ability (esp. when publishing on a later date). So long 202010221, and hello 2021-02-21!/ I really appreciate

Re: [Wikitech-l] Performance regression expected with Debian Buster upgrade

2021-02-12 Thread Kunal Mehta
Hi, On 2/3/21 5:35 PM, Kunal Mehta wrote: What now? We're going to continue with the upgrade as planned, but we also need help to try and make some performance improvements to reduce the impact of the regression. A week later I'd like to highlight and recognize some of the performance

[Wikitech-l] Starting the Wikimedia Rust developers user group

2021-02-11 Thread Kunal Mehta
Hi everyone, We are starting a user group for people interested in spreading the adoption of the Rust programming language[1] in the Wikimedia movement. If you're not familiar with it, Rust is a systems programming language that aims to provide the trifecta of safety, concurrency and speed.

Re: [Wikitech-l] GlobalWatchlist enabled on testwiki

2021-02-09 Thread Kunal Mehta
Hi, On 2/9/21 4:44 PM, Danny S wrote: I developed the extension to replace a user script I wrote[5], funded through a grant from the WMF[6], and the deployment to meta follows 8 months of work on the extension, and an additional year of work on the script.[7] This is awesome, thank you so

[Wikitech-l] Performance regression expected with Debian Buster upgrade

2021-02-03 Thread Kunal Mehta
Hi, We're currently in the process of upgrading the MediaWiki servers to Debian Buster and expect a performance regression to come with it. The cause appears to be better Spectre[1] mitigations in the Buster 4.19 kernel, which we can't disable. Most of the effect is seen in code that ends

Re: [Wikitech-l] Technical Decision Making Process Update and Change

2021-01-28 Thread Kunal Mehta
Hi, On 1/25/21 6:19 PM, Kate Chapman wrote: If you currently have an RFC in process with TechCom that is not on Last Call, it may need to be moved into this process. If you have filed an RFC that is no longer relevant please close it. The group setting up the process will be inquiring about the

Re: [Wikitech-l] Making breaking changes without deprecation?

2020-08-31 Thread Kunal Mehta
Hi, On 2020-08-28 02:18, Daniel Kinzler wrote: > tl;dr: the key question is: > > Can we shorten or even entirely skip the deprecation process, > if we have removed all usages of the obsolete code from public > extensions? I think going down this road would be a mistake, mostly

Re: [Wikitech-l] [MediaWiki-l] MediaWiki 1.35.0-rc.0 is ready for testing

2020-08-02 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-07-31 07:05, Sam Reed wrote: > I'm pleased to announce the immediate availability of MediaWiki > 1.35.0-rc.0, the first release candidate for 1.35.x, the next LTS > version to replace 1.31 which is due to go end of life in June > 2021.

[Wikitech-l] Help test the new MediaWiki codesearch UI

2020-07-31 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, tl;dr: Help would be appreciated testing a new MediaWiki codesearch UI: . Sticking "-beta" in existing URLs should just work. The current codesearch interface is a pretty bad hack based on upstream's UI.

Re: [Wikitech-l] Hard deprecation of the Revision class

2020-07-11 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-07-06 13:18, Petr Pchelko wrote: > TLDR: your extension CI might break due to hard deprecation of > Revision class. Unfortunately, this is happening to a significant amount of extensions. The latest libup security run shows failures

[Wikitech-l] Proposed breaking change to Command::restrict()

2020-07-08 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I'm proposing a breaking change to MediaWiki\Shell\Command::restrict(). I made a mistake in my original implementation of this function that I believe we're better off fixing. For background on what shell restrictions are, see

[Wikitech-l] npm and security (was: Re: TechCom Radar 2020-07-01)

2020-07-06 Thread Kunal Mehta
Hi, On 2020-07-02 02:41, Aron Manning wrote: > Recently, I haven't seen the security question of npm being discussed on > https://phabricator.wikimedia.org/T199004 > and thought that question was not on topic. If that's not the case: is > there another discussion I'm not aware of? There's been

Re: [Wikitech-l] Gerrit upgrade on Saturday, 27th of June

2020-06-21 Thread Kunal Mehta
Hi, On 2020-06-20 14:58, Christian Aistleitner via Wikitech-l wrote: > It holds a copy of our Gerrit data as of 15th of June, and it runs > the new Gerrit v3.2.2. We'll keep tuning things there during this > week, so it might get an occasional restart. But look around and > test the new UI, the

Re: [Wikitech-l] CI build of empty patch fails in Vector repo in 'mediawiki/phan-taint-check-plugin'

2020-06-01 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2020-06-01 07:21, Aron Demian wrote: > This has been happening since Saturday. Looking for resolution. See . It's currently being fixed by rolling out a new version of the phan-taint-check plugin. - --

Re: [Wikitech-l] +2 for DannyS712 for mediawiki/*

2020-05-21 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 I just closed the request as successful. Congrats Danny! - -- Legoktm On 2020-05-14 14:28, Danny S wrote: > Dear all, > > Per policy[1], I'd like to inform you that I have been nominated[2] > for +2 rights for mediawiki/*. > > Stay safe,

Re: [Wikitech-l] CodeReview to be removed from mediawiki.org, dumps available

2020-05-19 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-05-18 14:46, Zoran Dori wrote: > Hello, >> We're planning to review the CodeReview extension, which was >> used during the SVN era, from mediawiki.org soon. > > You mean to "remove extension" from mediawiki.org, right? :) Yep, my bad.

[Wikitech-l] CodeReview to be removed from mediawiki.org, dumps available

2020-05-18 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, We're planning to review the CodeReview extension, which was used during the SVN era, from mediawiki.org soon. A static HTML dump of the code review comments is available at and SQL dumps are

Re: [Wikitech-l] List related to repositories which haven't mediawiki/mediawiki-codesniffer

2020-03-16 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-03-05 22:46, Zoran Dori wrote: > Hello, can someone to update list > https://phabricator.wikimedia.org/P10500 which contains > repositories which haven't mediawiki/mediawiki-codesniffer. I added this functionality to the PHPCS tool:

Re: [Wikitech-l] TechCom Radar 2020-01-22

2020-01-29 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-01-28 05:29, Kate Chapman wrote: > * New RFC under discussion: Allow extensions to register handlers > with factories without the use of global variables. > Just to be clear, this is not

[Wikitech-l] Thank you Thursday

2019-07-25 Thread Kunal Mehta
Hi, This week I'd like to thank: * Daimona, bawolff, and sbassett for their work on v2.0 of the phan-taint-check-plugin, which has been instrumental in catching real security issues. * James_F for picking up a lot of CI maintenance * MatmaRex for seeing through a patch to allow skins to have

Re: [Wikitech-l] +2 nomination for Daimona in mediawiki/*

2019-07-24 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > I've nominated Daimona for +2 in mediawiki/* repositories. Please > see . I've closed this as successful. Congrats Daimona! - -- Legoktm -BEGIN PGP SIGNATURE-

Re: [Wikitech-l] Dealing with composer dependencies in early MediaWiki initialization

2019-07-18 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 6/26/19 11:25 PM, Tim Starling wrote: > Interesting that I wrote there: "How about this: let's set > $wgServer in the installer in 1.18, and remove $wgServer > autodetection from DefaultSettings.php a bit later, say in 1.20." > > It was

Re: [Wikitech-l] Help merge patch (Interwiki)

2019-07-18 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 7/8/19 10:04 AM, Isarra Yos wrote: > Basically, uh, can anyone else help us with this? Any of this? > Given the nature of the patch we really do kind of need it merged > so it can get translations. I went ahead and +2'd it. As I was

[Wikitech-l] +2 nomination for Daimona in mediawiki/*

2019-07-17 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I've nominated Daimona for +2 in mediawiki/* repositories. Please see . Thanks! - -- Legoktm -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0u2zMACgkQ8QX4EBsF

Re: [Wikitech-l] New errors with composer update

2019-06-28 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 6/26/19 10:53 PM, James Montalvo wrote: > I'm getting a new error today that was not happening with the > identical config yesterday. Tgr tracked down the root cause and filed to figure out how

[Wikitech-l] Dealing with composer dependencies in early MediaWiki initialization

2019-06-25 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I (with Reedy's help) recently started work on librarizing MediaWiki's IP class into a separate composer package (wikimedia/ip-utils[1]). The main motivation was so that the Parsoid PHP port could use it[2]. However, I ran into an unexpected

Re: [Wikitech-l] Switching to elections for the Code of Conduct Committee?

2019-06-20 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 6/18/19 3:24 PM, Yaron Koren wrote: > That's what I'm writing about: I now think that the committee > should be decided via open elections, instead of having the > committee appoint itself. At the moment, this group has a complete > lack of

[Wikitech-l] MediaWiki-CodeSniffer 25.0.0 released

2019-04-05 Thread Kunal Mehta
PHPDoc comment parsing in UnusedUseStatement sniff (Thiemo Kreuz) * Upgrade PHP_CodeSniffer to 3.4.1 (Kunal Mehta) * Whitelist more phan annotations (Kunal Mehta) [1] https://phabricator.wikimedia.org/T218750 - -- Legoktm -BEGIN PGP SIGNATURE

[Wikitech-l] Thank you Thursday

2019-02-28 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's Thursday :) I wanted to say thank you this week to Zoranzoki21 and Matěj Suchánek for jumping on the phan migration and helping with upgrading extensions to take advantage of newer static analysis tools. - -- Legoktm -BEGIN PGP

[Wikitech-l] Upgrading phan

2019-02-24 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's time to work on upgrading phan, the PHP static analysis tool we use! The version of phan we were using was released over two years ago (0.8.0) - we're moving to 1.2.4 that was released less than a week ago. And the CI infrastructure is now

Re: [Wikitech-l] [Train] 1.33.0-wmf.18 status update

2019-02-19 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 2/19/19 6:36 AM, Tyler Cipriani wrote: > I have not yet started the 1.33.0-wmf.18 train; however, at the end > of last week, I noticed some errors that (AFAICT) are regressions > in 1.33.0-wmf.17. In addition to those, I'm not sure whether

[Wikitech-l] MediaWiki-CodeSniffer 24.0.0 released

2019-02-06 Thread Kunal Mehta
, 19.2.0, which just disabled the problematic Generic.PHP.DeprecatedFunctions sniff. Here's the changelog for 24.0.0: * Whitelist @after and @before phpunit annotations (Umherirrender) * Update PHP_CodeSniffer to 3.4.0 (Kunal Mehta) * Enable new Generic.VersionControl.GitMergeConflict sniff (Kunal

Re: [Wikitech-l] IE 6/7 MIME type sniffing checks on uploads - is it time to retire them?

2019-01-28 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/28/19 3:58 PM, Brion Vibber wrote: > Years ago, we added security checks for IE 5/6/7 to work around > IE's mime type sniffing: if you went to view a .png file directly > in IE (as opposed to in an ) the browser would check the first > few

Re: [Wikitech-l] The mw.ext construct in lua modules

2019-01-25 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/24/19 11:33 PM, Thiemo Kreuz wrote: > Is there a question assigned with this long email? Is this a call > for feedback? I think this is probably related to/coming from . - -- Legoktm

[Wikitech-l] Thank you Tuesday

2019-01-22 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's still Tuesday in my timezone, so here's this week's thread. Noticed something neat or cool that someone did? Or is someone just being awesome in general? Say thanks! * Thanks to Krinkle and Krenair for cleaning up user JavaScript across

Re: [Wikitech-l] UserMerge extension on Wikimedia sites

2019-01-22 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/22/19 12:24 AM, Amir E. Aharoni wrote: > Yes, it's installed, but it doesn't seem to be actually used. The > English Wikivoyage has a bunch of log entries of its usage, the > last in 2015. Other Wikimedia sites have very few entries, or

Re: [Wikitech-l] Gerrit now automatically adds reviewers

2019-01-22 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/18/19 1:11 AM, Jaime Crespo wrote: > One member of my team sadly left. Now he is pinged every time I > upload a change, passively aggressive reminding him he used to work > on this. > > Don't get me wrong, I think this is great to get

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/18/19 6:11 AM, Tyler Cipriani wrote: > In the interim, project-owners are able to opt-in to using the > reviewers-by-blame plugin on a per-project basis on their project > admin page in Gerrit. I'm happy to volunteer any of the projects

[Wikitech-l] Thank you Tuesday

2019-01-15 Thread Kunal Mehta
Hi everyone, Following up on Andre's statistics[1] about the people writing/editing the code, I wanted to share some about the people reviewing the code (gathered by Nemo, thanks!). The top +2'ers in MediaWiki core: 582 Timo Tijhof 475 James D. Forrester 406 Kunal Mehta 189 Aaron Schulz 174

[Wikitech-l] Thank you Thursday

2018-12-20 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Sorry for missing Tuesday, here's this week's thank you thread :) * Thanks to Faidon for packaging different Python 3 versions for Stretch so Wikimedia CI can test against multiple Python versions seamlessly. * Thanks to Jforrester and Paladox

[Wikitech-l] Changes to CI for Python jobs

2018-12-18 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, There are a few changes to the Python `tox` jobs that CI is running: 1. Most importantly, Python 3.5 is now the default version when invoked with `tox`. This can be overridden by using basepython[1]. 2. Multiple Python 3 versions are available:

[Wikitech-l] Feedback requested on proposal for extensions to "reserve" blocks of namespaces

2018-12-10 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I'm forwarding along a request for feedback on a proposal started by Dinoguy1000 related to the "Extension default namespaces"[1] page. They've proposed codifying the general practice of having extensions reserve blocks of ten namespace

Re: [Wikitech-l] Thank you Tuesday

2018-12-05 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 12/4/18 7:55 AM, MA wrote: > It's Tuesday (my timezone at least) and this week I'd like to thank > the following people for their work and assistance: Sorry for being a day late, here's my thanks: * BPirkle and Reedy for moving forwards

[Wikitech-l] Thank you Tuesday

2018-11-20 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's been a while since we had a thank you thread, so since it's Tuesday, I'm starting one for the alliteration. If you haven't participated in one of these before, it's simple - just reply to the list thanking someone for what they've done

[Wikitech-l] MediaWiki-CodeSniffer 23.0.0 released

2018-11-13 Thread Kunal Mehta
in @param (Umherirrender) * Update message to talk about "top level" instead of "file comment" (Thiemo Kreuz) * Upgrade squizlabs/php_codesniffer to 3.3.2 (Kunal Mehta) Thanks, - -- Legoktm -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAlvr0ekACgkQUvyOe

Re: [Wikitech-l] Extension test failures on PHP 7.2

2018-11-13 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 10/14/18 11:39 PM, Kunal Mehta wrote: > I'd like to also make 7.2 voting by the end of the week, but I > realize that might be a little too ambitious with multiple > conferences this week s/week/month/ it seems. As of a few hours

Re: [Wikitech-l] Changes to User Blocking

2018-11-04 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 11/2/18 12:58 PM, Alex Ezell wrote: > *tl:dr;* On a wiki with the new Partial Blocks enabled (currently > only testwiki), if the code is checking User::isBlocked() to > determine edit rights, it should instead check User::isBlockedFrom( >

[Wikitech-l] Extension test failures on PHP 7.2

2018-10-15 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 10/8/18 7:43 AM, Aryeh Gregor wrote: > On Mon, Oct 8, 2018 at 9:04 AM Kunal Mehta > wrote: >> In preparation for Wikimedia production switching to PHP 7.2, we >> need to get CI running using 7.2 (and for the rest of the

[Wikitech-l] Debian & Ubuntu packages of MediaWiki 1.31 now available

2018-10-10 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Debian and Ubuntu packages of MediaWiki 1.31 (LTS) are now available. See for more information on how to get them, and basic instructions for installing (hint: it's as simple as `sudo apt

[Wikitech-l] Extension test failures on PHP 7.1

2018-10-08 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, In preparation for Wikimedia production switching to PHP 7.2, we need to get CI running using 7.2 (and for the rest of the MediaWiki world too!). But before we can do that, we'll need 7.1 to be passing first. The following extensions are

[Wikitech-l] MediaWiki-CodeSniffer 22.0.0 released

2018-09-02 Thread Kunal Mehta
nesting of inline ternary statements without parentheses (Kevin Israel) * Disable 'Generic.PHP.DeprecatedFunctions' sniff (Kunal Mehta) * Enable PSR2.Classes.ClassDeclaration (Umherirrender) * Enable Squiz.Functions.FunctionDeclarationArgumentSpacing (Umherirrender) * Enable

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-12 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 08/11/2018 06:48 PM, Brion Vibber wrote: > Second, probably related to that I'm seeing a failure in the code > coverage calculations -- it's seeing some increased coverage on the > parent process at least but seems to think it's returning a

Re: [Wikitech-l] My Phabricator account has been disabled

2018-08-11 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/09/2018 04:55 AM, Aryeh Gregor wrote: > The main problem here that needs to be solved is communicating > what the problem was in a manner that is clear to the parties whom > the CoC committee seeks to deter. A one-week ban is not going to >

Re: [Wikitech-l] My Phabricator account has been disabled

2018-08-11 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 08/08/2018 03:08 AM, Amir Ladsgroup wrote: > I disabled the account and now I disabled it again. It's part of a > CoC ban. We sent the user an email using the "Email to user" > functionality from mediawiki.org the moment I enforced the ban.

[Wikitech-l] Postgres and SQLite tests are now voting on mediawiki/core patches

2018-08-01 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, MediaWiki core patches will now need to pass tests on postgres and sqlite (in addition to mysql of course) to be merged. For speed, CI won't run postgres/sqlite tests until after the patch has been +2'd (gate-and-submit queue). If you want to

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-31 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I don't have a strong opinion about the specific function in this case, but I did want to discuss a few things about the policy itself. On 07/30/2018 06:28 AM, Stephan Gambke via Wikitech-l wrote: > I know it is annoying as heck to keep

[Wikitech-l] New PHPUnit structure test validating existence of right-* i18n messages

2018-07-28 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, For proper display on pages like Special:ListGroupRights, all userrights are supposed to have a corresponding right-{name} i18n message. MediaWiki core has had a PHPUnit test enforcing this for quite a while now, so I converted[1] it into a

  1   2   >