Re: [Wikitech-l] Dropping PHPUnit 4 support

2019-10-07 Thread Brad Jorsch (Anomie)
On Sun, Oct 6, 2019 at 4:35 AM Daimona wrote: > And in turn, this happens because MediaWikiUnitTestCase validates the > directory structure, but some repos do not comply. That is not the only reason a test might use PHPUnit\Framework\TestCase. Another is that libraries (and proto-libraries in

Re: [Wikitech-l] Dropping PHPUnit 4 support

2019-10-06 Thread Daimona
Thanks, Amir! That's a great idea. My regexps were a bit naive and there's still some space for improvement, so I'll comment about that on the gist. As for removing the PHPUnit4And6Compat trait: I think we should do that regardless of this migration. In fact, I'd like to draw some attention to

Re: [Wikitech-l] Dropping PHPUnit 4 support

2019-10-05 Thread Amir Sarabadani
Thanks Daimona! In the spirit of automating everything including ourselves, I wrote a quick python script using Daimon's regexes to run on codebases and it tries to clean as much as possible for you. https://gist.github.com/Ladsgroup/bfb4f4b66384efb8b8d3efea338b6e6b (After running this, you should