Re: [Wikitech-l] Diff algorithms: the shootout

2016-05-07 Thread Isarra Yos
Cool! It's entirely possible that the shortcuts it takes correspond to what makes a more cohesive thing to present to the user - the same shortcuts in the diff implementation are what we want in the front-end when looking for meaningful changes anyway. I mean, this is just random

Re: [Wikitech-l] Diff algorithms: the shootout

2016-04-21 Thread Max Semenik
All right, votes indicate that wikidiff3 is even better in quality, so here we go: https://gerrit.wikimedia.org/r/#/c/284003/ removes DairikiDiff. After it's merged, I plan to refactor this area further and work on improving diff quality now that we'll have 2 places to make changes instead of 3.

Re: [Wikitech-l] Diff algorithms: the shootout

2016-04-18 Thread Antoine Musso
Le 16/04/2016 04:00, MZMcBride a écrit : > Is there a related Phabricator Maniphest task about this? I'm not sure I > understand the motivation for making a switch. I would think that heavy > diffs are a very small portion of traffic. An intensive would be for MediaWiki core to only have a single

Re: [Wikitech-l] Diff algorithms: the shootout

2016-04-17 Thread Brian Wolff
On Friday, April 15, 2016, MZMcBride wrote: > Max Semenik wrote: >>Right now, MediaWiki has 2 pure-PHP engines to produce diffs (there's also >>a native PHP extension wikidiff2, but we're not discussing it right now): >>* DairikiDiff is what everybody uses, and >>* Wikidiff3,

Re: [Wikitech-l] Diff algorithms: the shootout

2016-04-17 Thread Andre Klapper
On Fri, 2016-04-15 at 21:00 -0500, MZMcBride wrote: > Max Semenik wrote: > > > > Right now, MediaWiki has 2 pure-PHP engines to produce diffs (there's also > > a native PHP extension wikidiff2, but we're not discussing it right now): > > * DairikiDiff is what everybody uses, and > > * Wikidiff3,

Re: [Wikitech-l] Diff algorithms: the shootout

2016-04-15 Thread MZMcBride
Max Semenik wrote: >Right now, MediaWiki has 2 pure-PHP engines to produce diffs (there's also >a native PHP extension wikidiff2, but we're not discussing it right now): >* DairikiDiff is what everybody uses, and >* Wikidiff3, and alternative implementation by Guy Van den Broeck that was >around

[Wikitech-l] Diff algorithms: the shootout

2016-04-15 Thread Max Semenik
Right now, MediaWiki has 2 pure-PHP engines to produce diffs (there's also a native PHP extension wikidiff2, but we're not discussing it right now): * DairikiDiff is what everybody uses, and * Wikidiff3, and alternative implementation by Guy Van den Broeck that was around for 8 years but required