Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-12 Thread Dmitriy Sintsov
Dmitriy Sintsov. 11 Октябрь 2012 г. 16:13:02 пользователь Jeroen De Dauw (jeroended...@gmail.com) написал: Hey, Also, it would be great, if WMF selected some old version of MediaWiki as LTS (Long Time Support) so extensions would be required to work with it. Currently that could be 1.17,

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-11 Thread Jeroen De Dauw
Hey, What is wrong with making extensions work right now both with and without it? +1. I don't see any harm done in adding such conditional checks, and they solve the problem at hand. We probably want to add them in any case, unless breaking compatibility with MediaWiki older then 1.21 is

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-11 Thread Dmitriy Sintsov
11 Октябрь 2012 г. 15:53:42 пользователь Jeroen De Dauw (jeroended...@gmail.com) написал: Hey, What is wrong with making extensions work right now both with and without it? +1. I don't see any harm done in adding such conditional checks, and they solve the problem at hand. We probably

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-11 Thread Jeroen De Dauw
Hey, Also, it would be great, if WMF selected some old version of MediaWiki as LTS (Long Time Support) so extensions would be required to work with it. Currently that could be 1.17, first version which got ResourceLoader. My observation is that most WMF maintained extensions are not maintained

[Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-10 Thread Daniel Kinzler
Hi! I could use some help looking over extensions. Since the ContentHandler stuff has been merged into the core, several much-used functions and hooks have been deprecated. I have tried to find and replace all calls in core, but a lot of extensions are still using the old stuff. They will still

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-10 Thread Niklas Laxström
On 10 October 2012 16:52, Daniel Kinzler dan...@brightbyte.de wrote: Hi! I could use some help looking over extensions. What is the difference between $content instanceof TextContent and $title-getContentModel() === CONTENT_MODEL_WIKITEXT? -Niklas -- Niklas Laxström

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-10 Thread Jeroen De Dauw
Hey, What is the difference between $content instanceof TextContent and $title-getContentModel() === CONTENT_MODEL_WIKITEXT? -Niklas The former will be true for any content deriving from TextContent, which currently includes WikitextContent, JavaScriptContent, CssContent and

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-10 Thread Rob Lanphier
On Wed, Oct 10, 2012 at 6:52 AM, Daniel Kinzler dan...@brightbyte.de wrote: Since the ContentHandler stuff has been merged into the core, several much-used functions and hooks have been deprecated. I have tried to find and replace all calls in core, but a lot of extensions are still using the

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-10 Thread Daniel Friesen
On Wed, 10 Oct 2012 14:37:47 -0700, Rob Lanphier ro...@wikimedia.org wrote: On Wed, Oct 10, 2012 at 6:52 AM, Daniel Kinzler dan...@brightbyte.de wrote: Since the ContentHandler stuff has been merged into the core, several much-used functions and hooks have been deprecated. I have tried to

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-10 Thread Tyler Romeo
This is not a good idea. We should wait until the ContentHandler branch is fully QAd and we are sure it will not be reverted before converting extensions over to using it. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com |

Re: [Wikitech-l] Make Extensions Aware of the ContentHandler

2012-10-10 Thread Daniel Friesen
What is wrong with making extensions work right now both with and without it? -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] On Wed, 10 Oct 2012 22:19:25 -0700, Tyler Romeo tylerro...@gmail.com wrote: This is not a good idea. We should wait until the