Re: [Wikitech-l] Modern module loading needing code review

2016-01-22 Thread Legoktm
Hi,

On 01/21/2016 10:01 AM, Jon Robson wrote:
> As part of the work of the frontend standards group
> https://gerrit.wikimedia.org/r/#/c/260071/ adds require and
> module.exports to MediaWiki ResourceLoader. This will make it easier
> to share code outside MediaWiki and with nodejs systems as well as
> discouraging the overloading of the mediawiki variable.
> 
> I'm looking for code review at the moment. If you are familiar with
> ResourceLoader's internals I'd appreciate your input.
> 
> See https://phabricator.wikimedia.org/T108655 for further background

I'll ask since we just discussed this in the last IRC meeting...why
wasn't/isn't this an RfC?

-- Legoktm

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Modern module loading needing code review

2016-01-21 Thread Jon Robson
As part of the work of the frontend standards group
https://gerrit.wikimedia.org/r/#/c/260071/ adds require and
module.exports to MediaWiki ResourceLoader. This will make it easier
to share code outside MediaWiki and with nodejs systems as well as
discouraging the overloading of the mediawiki variable.

I'm looking for code review at the moment. If you are familiar with
ResourceLoader's internals I'd appreciate your input.

See https://phabricator.wikimedia.org/T108655 for further background

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l