Re: [Wikitech-l] Proposed breaking change to Command::restrict()

2020-07-08 Thread Max Semenik
Maybe introduce a function like removeRestrictions()? On Wed, Jul 8, 2020 at 2:53 PM Kunal Mehta wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hi, > > I'm proposing a breaking change to > MediaWiki\Shell\Command::restrict(). I made a mistake in my original > implementation of th

[Wikitech-l] Proposed breaking change to Command::restrict()

2020-07-08 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I'm proposing a breaking change to MediaWiki\Shell\Command::restrict(). I made a mistake in my original implementation of this function that I believe we're better off fixing. For background on what shell restrictions are, see