[Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Andre Klapper]

Your help is welcome to provide feedback (CR±1/2) and guidance:

== mediawiki/core: ==

since 2016-11-21:
Support Basic Auth on outgoing HTTP
https://gerrit.wikimedia.org/r/#/c/320388/

== mediawiki/extensions/LdapAuthentication: ==

since 2016-09-27 (5th time listed here):
Allow local user creation even if LDAP user creation is disabled
https://gerrit.wikimedia.org/r/#/c/313019/
(Still no CR±1 decision but review comments by Tgr)


Thanks in advance for your reviews!

Of last time's 6 listed patches, 5 got merged. 
Thanks to FlorianSW and VolkerE!

-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Andre Klapper]

Your help is welcome to provide feedback (CR±1/2) and guidance:

== mediawiki/extensions/Favorites: ==

https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Favorites+status:open
4 patches by same author. Extension might be unmaintained, looking
at https://phabricator.wikimedia.org/diffusion/EFAV/ ?

== mediawiki/extensions/LdapAuthentication: ==

since 2016-09-27 (4th time listed here):
Allow local user creation even if LDAP user creation is disabled
https://gerrit.wikimedia.org/r/#/c/313019/
(Still no CR±1 but review comments by Tgr - thanks!)

== mediawiki/extensions/MixedNamespaceSearchSuggestions: ==

since 2016-10-22 (patch has 3 lines):
Fix Namespace Display in resources/ext.mnss.search.less
https://gerrit.wikimedia.org/r/#/c/317325/

== pywikibot/core: ==

https://lists.wikimedia.org/pipermail/wikitech-l/2016-May/085598.html 
might make me exclude Pywikibot from future emails, as its developers
might not have a shared understanding when it comes to the importance
of providing fast reviews quickly to new contributors.

since 2016-09-25 (4th time listed here):
Checks the type of isbn and modifies accordingly
https://gerrit.wikimedia.org/r/#/c/312726/
(Still no CR±1 but a review comment by Whym - thanks!)

since 2016-10-15:
Silence warnings
https://gerrit.wikimedia.org/r/#/c/316060/


Thanks in advance for your reviews!
-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Andre Klapper]

Your help is welcome to provide feedback (CR±1/2) and guidance:

No *new* & unreviewed patches this week but:

== mediawiki/extensions/LdapAuthentication: ==

since 2016-09-27 (3rd time listed here; it's 2 lines):
Allow local user creation even if LDAP user creation is disabled
https://gerrit.wikimedia.org/r/#/c/313019/

== pywikibot/core: ==

since 2016-09-25 (3rd time listed here):
Checks the type of isbn and modifies accordingly
https://gerrit.wikimedia.org/r/#/c/312726/


Thanks in advance for your reviews.

Of last time's 3 listed patches, 1 got merged. 
Thanks to Hashar, Jonas and Thiemo!

-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[K. Peachey]

On 12 October 2016 at 23:21, Andre Klapper  wrote:
> == pywikibot/core: ==
>
> since 2016-09-25 (2nd time listed here):
> Checks the type of isbn and modifies accordingly
> https://gerrit.wikimedia.org/r/#/c/312726/

Might be better to send that one to the pywiki mailing lists.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Andre Klapper]

Your help is welcome to provide feedback (CR±1/2) and guidance:


== mediawiki/extensions/LdapAuthentication: ==

since 2016-09-27 (2nd time listed here):
Allow local user creation even if LDAP user creation is disabled
https://gerrit.wikimedia.org/r/#/c/313019/

== operations/mediawiki-config: ==

since 2016-09-27 (2nd time listed here):
Adding language name configuration for Wikidata
https://gerrit.wikimedia.org/r/#/c/312944/

== pywikibot/core: ==

since 2016-09-25 (2nd time listed here):
Checks the type of isbn and modifies accordingly
https://gerrit.wikimedia.org/r/#/c/312726/


Thanks in advance for your reviews.

Of last time's 5 listed patches, 1 got abandoned, 1 got reviewed. 
Thanks to Krinkle and Reedy!

andre
-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Andre Klapper]

Your help is welcome to provide feedback (CR±1/2) and guidance:


== mediawiki/extensions/DynamicSidebar: ==

since 2016-09-24:
Replace deprecated Article::getContent()
https://gerrit.wikimedia.org/r/#/c/312634/
https://gerrit.wikimedia.org/r/#/c/312637/

== mediawiki/extensions/LdapAuthentication: ==

since 2016-09-27:
Allow local user creation even if LDAP user creation is disabled
https://gerrit.wikimedia.org/r/#/c/313019/

== operations/mediawiki-config: ==

since 2016-09-27:
Adding language name configuration for Wikidata
https://gerrit.wikimedia.org/r/#/c/312944/

== pywikibot/core: ==

since 2016-09-25:
Checks the type of isbn and modifies accordingly
https://gerrit.wikimedia.org/r/#/c/312726/


Thanks in advance for your reviews.


Of last time's 1 listed patch, 1 got reviewed. Thanks to DCausse!

andre
-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review - organization?

[Andre Klapper]

On Sun, 2016-10-02 at 10:30 +, Marcin Cieslak wrote:
> A just checked this one:
> 
> > 
> > http://korma.wmflabs.org/browser/scr-backlog.html
> 
> how does one recognize or define "Organization" affected by the
> backlog? (it's the first time I see this)

The organizations are defined in the underlying database. 
Currently those are
* Hallo Welt!
* Independent
* Wikia, Inc.
* Wikimedia Deutschland
* Wikimedia Foundation
* WikiWorks

Some more technical information is available at
https://www.mediawiki.org/wiki/Community_metrics#korma.wmflabs.org

Cheers,
andre
-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review - organization?

[Marcin Cieslak]

A just checked this one:

> http://korma.wmflabs.org/browser/scr-backlog.html

how does one recognize or define "Organization" affected by the backlog?
(it's the first time I see this)

Saper


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Andre Klapper]

On Thu, 2016-09-22 at 18:27 +, Jon Robson wrote:
> Thanks for these e-mails.

Glad to hear that! :)

> Would you be also open to flagging some of our oldest patches as part of
> this mail (I think you are right to keep the number of patches low - a long
> list can be overwhelming)?
> 
> I just ran a Gerrit query and found these old patches that had no merge
> conflicts. I'd love to get us to a point where at least core's patchsets
> are weeks old rather than months. It seems these e-mails could be a good
> mechanism for reaching the right people.

I do share the sentiment; still "old patches" are a very different beast.
The current email focuses on fresh contributors still "available" (even
if it was a one-time drive-by contribution), in combination with ideas
like https://phabricator.wikimedia.org/T73357 (Gerrit Welcome Bot).

So I'd be open but I currently don't think it's the best use of (my)
time, also as I am not sure how to easily gather that list & which
criteria to apply. Plus it should likely be a separate email.

We currently list "Oldest open Gerrit changesets without code review"
on http://korma.wmflabs.org/browser/scr-backlog.html [1].
But that page does not exclude "Cannot merge / needs rebase" items.

List of open MediaWiki Core patches without any code review:
https://gerrit.wikimedia.org/r/#/q/status:open+project:%5Emediawiki/core+AND+label:Code-Review%3D0,n,z

Cheers,
andre


[1] (that korma.wmflabs.org page is to be replaced by 
https://wikimedia.biterg.io/app/kibana#/dashboard/Gerrit-Backlog 
at some point in the future. All still very beta.)
-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Jon Robson]

Andre,
Thanks for these e-mails. It really helps having an overview of where we
can help. I really appreciate them.

Would you be also open to flagging some of our oldest patches as part of
this mail (I think you are right to keep the number of patches low - a long
list can be overwhelming)?

I just ran a Gerrit query and found these old patches that had no merge
conflicts. I'd love to get us to a point where at least core's patchsets
are weeks old rather than months. It seems these e-mails could be a good
mechanism for reaching the right people.

Some old patches:
Added custom label for links in category pages
https://gerrit.wikimedia.org/r/#/c/104905/

Add category name in ID property for extension row in Special:Version page
https://gerrit.wikimedia.org/r/#/c/275836/2



On Thu, 22 Sep 2016 at 06:49 Andre Klapper  wrote:

> Your help is welcome to provide feedback and guidance:
>
> == in "mediawiki/tools/mwdumper": ==
>
> since 2016-09-08:
> Major refactoring
> https://gerrit.wikimedia.org/r/#/c/309314/
>
> Thanks in advance for your reviews.
>
>
> Of last weeks' 5 listed patches, 4 got merged & 1 got reviewed. Thanks
> to Amire80, Daniel, FlorianSW, Jdlrobson, MatmaRex, Smalyshev, Tjones!
>
> andre
> --
> Andre Klapper | Wikimedia Bugwrangler
> http://blogs.gnome.org/aklapper/
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Andre Klapper]

Your help is welcome to provide feedback and guidance:

== in "mediawiki/tools/mwdumper": ==

since 2016-09-08:
Major refactoring
https://gerrit.wikimedia.org/r/#/c/309314/

Thanks in advance for your reviews.


Of last weeks' 5 listed patches, 4 got merged & 1 got reviewed. Thanks
to Amire80, Daniel, FlorianSW, Jdlrobson, MatmaRex, Smalyshev, Tjones!

andre
-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Recently proposed patchsets by new contributors awaiting code review

[Andre Klapper]

Your help is welcome to provide feedback and guidance:

== All in "mediawiki/core": ==

since 2016-08-01:
Incorrect redirect for titles starting with '/' in special cases
https://gerrit.wikimedia.org/r/#/c/302088/

since 2016-08-02:
Fix to incorrect calls of header () breaking saving some pages and login
https://gerrit.wikimedia.org/r/#/c/302430/

since 2016-08-11:
Change wording, change grammar in lang/en.json
https://gerrit.wikimedia.org/r/#/c/304329/

since 2016-08-11:
Cleaned up some unneeded wording in the english lang file, as well as minor 
wording changes.
https://gerrit.wikimedia.org/r/#/c/302061/

since 2016-08-11:
Add Localisation to the links, add the link to Localisation in 
Languages/Language.php
https://gerrit.wikimedia.org/r/#/c/304153/


Thanks in advance for your reviews.

andre
-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l