Re: [Wikitech-l] Reviewing a couple of TorBlock patches

2014-08-23 Thread Arlo Breault
I can help a bit with review. I maintain the check[0] service for the Tor
project.

[0] https://check.torproject.org/


On Wed, Jul 23, 2014 at 10:16 PM, Legoktm legoktm.wikipe...@gmail.com
wrote:

 On 7/23/14, 4:56 AM, Quim Gil wrote:
  According to our algorithm (*), TorBlock currently has the worse track
  reviewing code contributions -- even after Tim gave a -1 to one of the
  three open patches last week (thanks!). There are two patches from Tyler
  that haven't received any feedback at all since August 2013.
 
 
 https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/TorBlock,n,z

 I left comments on all the patches. The -1's are mainly due to rebasing
 needed.

  Your help reviewing these patches is welcome.
 
  It is not surprising that this extension has no maintaner listed at
  https://www.mediawiki.org/wiki/Developers/Maintainers (someone suggested
  Tim in that table, he disagrees and edited accordingly).
 
  Also, maybe someone is interested in maintaining this extension? Only
  eleven patches submitted in the last 15 months.

 Probably not since I don't really know that much about tor, but I'm
 willing to review Tyler's patches if he's unable to find other people.

 -- Legoktm

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Reviewing a couple of TorBlock patches

2014-07-23 Thread Quim Gil
According to our algorithm (*), TorBlock currently has the worse track
reviewing code contributions -- even after Tim gave a -1 to one of the
three open patches last week (thanks!). There are two patches from Tyler
that haven't received any feedback at all since August 2013.

https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/TorBlock,n,z


Your help reviewing these patches is welcome.

It is not surprising that this extension has no maintaner listed at
https://www.mediawiki.org/wiki/Developers/Maintainers (someone suggested
Tim in that table, he disagrees and edited accordingly).

Also, maybe someone is interested in maintaining this extension? Only
eleven patches submitted in the last 15 months.

(*) http://korma.wmflabs.org/browser/gerrit_review_queue.html -- the
algorithm happens to be buggy these days, but apparently equally buggy for
all repos, which still results in some kind of justice.


-- 
Quim Gil
Engineering Community Manager @ Wikimedia Foundation
http://www.mediawiki.org/wiki/User:Qgil
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Reviewing a couple of TorBlock patches

2014-07-23 Thread Tyler Romeo
FYI, I’d be willing to maintain the extension, but it’d be best it there was 
one other person, since it is WMF-deployed and thus I cannot merge my own 
patches.
-- 
Tyler Romeo
0x405D34A7C86B42DF

From: Quim Gil q...@wikimedia.org
Reply: Wikimedia developers wikitech-l@lists.wikimedia.org
Date: July 23, 2014 at 7:57:07
To: Wikimedia developers wikitech-l@lists.wikimedia.org
Subject:  [Wikitech-l] Reviewing a couple of TorBlock patches  

According to our algorithm (*), TorBlock currently has the worse track
reviewing code contributions -- even after Tim gave a -1 to one of the
three open patches last week (thanks!). There are two patches from Tyler
that haven't received any feedback at all since August 2013.

https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/TorBlock,n,z


Your help reviewing these patches is welcome.

It is not surprising that this extension has no maintaner listed at
https://www.mediawiki.org/wiki/Developers/Maintainers (someone suggested
Tim in that table, he disagrees and edited accordingly).

Also, maybe someone is interested in maintaining this extension? Only
eleven patches submitted in the last 15 months.

(*) http://korma.wmflabs.org/browser/gerrit_review_queue.html -- the
algorithm happens to be buggy these days, but apparently equally buggy for
all repos, which still results in some kind of justice.


--  
Quim Gil
Engineering Community Manager @ Wikimedia Foundation
http://www.mediawiki.org/wiki/User:Qgil
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Reviewing a couple of TorBlock patches

2014-07-23 Thread Legoktm
On 7/23/14, 4:56 AM, Quim Gil wrote:
 According to our algorithm (*), TorBlock currently has the worse track
 reviewing code contributions -- even after Tim gave a -1 to one of the
 three open patches last week (thanks!). There are two patches from Tyler
 that haven't received any feedback at all since August 2013.
 
 https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/TorBlock,n,z

I left comments on all the patches. The -1's are mainly due to rebasing
needed.

 Your help reviewing these patches is welcome.
 
 It is not surprising that this extension has no maintaner listed at
 https://www.mediawiki.org/wiki/Developers/Maintainers (someone suggested
 Tim in that table, he disagrees and edited accordingly).
 
 Also, maybe someone is interested in maintaining this extension? Only
 eleven patches submitted in the last 15 months.

Probably not since I don't really know that much about tor, but I'm
willing to review Tyler's patches if he's unable to find other people.

-- Legoktm

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l